From 14d20933f7dcbf6d4aab3ee2c6444a19c7afdfd6 Mon Sep 17 00:00:00 2001
From: msquare <msquare@notrademark.de>
Date: Mon, 22 Aug 2016 19:23:23 +0200
Subject: [PATCH] improve quality of user atom

---
 includes/pages/user_atom.php | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/includes/pages/user_atom.php b/includes/pages/user_atom.php
index 19abca61..81eb1670 100644
--- a/includes/pages/user_atom.php
+++ b/includes/pages/user_atom.php
@@ -4,11 +4,10 @@
 function user_atom() {
   global $user, $DISPLAY_NEWS;
   
-  if (isset($_REQUEST['key']) && preg_match("/^[0-9a-f]{32}$/", $_REQUEST['key'])) {
-    $key = $_REQUEST['key'];
-  } else {
+  if (! isset($_REQUEST['key']) || ! preg_match("/^[0-9a-f]{32}$/", $_REQUEST['key'])) {
     engelsystem_error("Missing key.");
   }
+  $key = $_REQUEST['key'];
   
   $user = User_by_api_key($key);
   if ($user === false) {
@@ -27,7 +26,7 @@ function user_atom() {
   
   header('Content-Type: application/atom+xml; charset=utf-8');
   header("Content-Length: " . strlen($output));
-  raw_output($html);
+  raw_output($output);
 }
 
 function make_atom_entries_from_news($news_entries) {