From 94753bc3d866071980148a2fd9e1bd5fa72b7a13 Mon Sep 17 00:00:00 2001 From: Igor Scheller Date: Thu, 9 Jan 2020 13:43:10 +0100 Subject: [PATCH] Worklog: Limit worklog comment length to 200 as it is configured in the database --- includes/controller/user_worklog_controller.php | 5 +++++ includes/view/UserWorkLog_view.php | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/includes/controller/user_worklog_controller.php b/includes/controller/user_worklog_controller.php index 6b100338..5bb07f33 100644 --- a/includes/controller/user_worklog_controller.php +++ b/includes/controller/user_worklog_controller.php @@ -93,6 +93,11 @@ function user_worklog_from_request($userWorkLog) error(__('Please enter a comment.')); } + if (mb_strlen($userWorkLog['comment']) > 200) { + $valid = false; + error(__('Comment too long.')); + } + return [ $valid, $userWorkLog diff --git a/includes/view/UserWorkLog_view.php b/includes/view/UserWorkLog_view.php index 0d5e7797..879979ba 100644 --- a/includes/view/UserWorkLog_view.php +++ b/includes/view/UserWorkLog_view.php @@ -45,7 +45,7 @@ function UserWorkLog_edit_form($user_source, $userWorkLog) form_info(__('User'), User_Nick_render($user_source)), form_date('work_timestamp', __('Work date'), $userWorkLog['work_timestamp'], null, time()), form_text('work_hours', __('Work hours'), $userWorkLog['work_hours']), - form_text('comment', __('Comment'), $userWorkLog['comment']), + form_text('comment', __('Comment'), $userWorkLog['comment'], false, 200), form_submit('submit', __('Save')) ]); }