From 8c1f6d2c9c36d84bff629e4bd1e1fdbbe4b83d76 Mon Sep 17 00:00:00 2001
From: Felix Favre <felix.favre@protonet.info>
Date: Wed, 26 Aug 2015 13:33:38 +0200
Subject: [PATCH 1/2] removed sessionhelper. we should let this handle the
 server administrator within the PHP config

---
 includes/engelsystem_provider.php  |  5 +----
 includes/helper/session_helper.php | 30 ------------------------------
 2 files changed, 1 insertion(+), 34 deletions(-)
 delete mode 100644 includes/helper/session_helper.php

diff --git a/includes/engelsystem_provider.php b/includes/engelsystem_provider.php
index 2dc425a2..fc5553bc 100644
--- a/includes/engelsystem_provider.php
+++ b/includes/engelsystem_provider.php
@@ -76,9 +76,6 @@ require_once realpath(__DIR__ . '/../includes/pages/user_shifts.php');
 
 require_once realpath(__DIR__ . '/../vendor/parsedown/Parsedown.php');
 
-if (! defined('PHPUNIT_TESTSUITE')) {
-  session_lifetime(24 * 60, preg_replace("/[^a-z0-9-]/", '', md5(__DIR__)));
-}
 session_start();
 
 gettext_init();
@@ -87,4 +84,4 @@ sql_connect($config['host'], $config['user'], $config['pw'], $config['db']);
 
 load_auth();
 
-?>
\ No newline at end of file
+?>
diff --git a/includes/helper/session_helper.php b/includes/helper/session_helper.php
deleted file mode 100644
index 443701ee..00000000
--- a/includes/helper/session_helper.php
+++ /dev/null
@@ -1,30 +0,0 @@
-<?php
-/**
- * Set lifetime of php session.
- *
- * @param int $lifetime
- *          Lifetime in minutes
- * @param string $application_name
- *          Name of the application
- */
-function session_lifetime($lifetime, $application_name) {
-  // Set session save path and name
-  $session_save_path = '/tmp/' . $application_name;
-  if (! file_exists($session_save_path))
-    mkdir($session_save_path);
-  if (file_exists($session_save_path))
-    session_save_path($session_save_path);
-  session_name($application_name);
-  
-  // Set session lifetime
-  ini_set('session.gc_maxlifetime', $lifetime * 60);
-  ini_set('session.gc_probability', 1);
-  ini_set('session.gc_divisor', 100);
-  
-  // Cookie settings (lifetime)
-  ini_set('session.cookie_secure', ! (isset($_SERVER['HTTP_HOST']) && preg_match("/^localhost/", $_SERVER["HTTP_HOST"]) || isset($_GET['debug'])));
-  ini_set('session.use_only_cookies', true);
-  ini_set('session.cookie_lifetime', $lifetime * 60);
-}
-
-?>
\ No newline at end of file

From 0ae5d85c601ba69d45a0df7420ce0baeeaf59c44 Mon Sep 17 00:00:00 2001
From: Felix Favre <felix.favre@protonet.info>
Date: Wed, 26 Aug 2015 14:11:08 +0200
Subject: [PATCH 2/2] added hint about session settings to readme

---
 README.md | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/README.md b/README.md
index 389fe07b..27144219 100644
--- a/README.md
+++ b/README.md
@@ -18,4 +18,8 @@
 
 Das Engelsystem ist jetzt einsatzbereit.
 
+## Session Einstellungen:
+ * Einstellungen für Cookies und Sessions bitte in der PHP Config des Servers vornehmen.
+ * Sowohl Apache als auch nginx bieten Möglichkeiten für verschiedene Konfigurationen pro VirtualHost an
+
 Fehler bitte auf Github melden: https://github.com/engelsystem/engelsystem/issues