From f46e921b710b02d5a1f17f0dd076a5bf085ae735 Mon Sep 17 00:00:00 2001 From: Igor Scheller Date: Sun, 12 Aug 2018 13:41:33 +0200 Subject: [PATCH] Use domain for links to '/' to fix assets URLs on subdirectories --- src/Routing/LegacyUrlGenerator.php | 3 ++- templates/layout.html | 4 ++-- tests/Unit/Routing/LegacyUrlGeneratorTest.php | 4 ++-- tests/Unit/Routing/UrlGeneratorTest.php | 1 + 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/Routing/LegacyUrlGenerator.php b/src/Routing/LegacyUrlGenerator.php index 4c1e736b..fdac4f96 100644 --- a/src/Routing/LegacyUrlGenerator.php +++ b/src/Routing/LegacyUrlGenerator.php @@ -4,7 +4,7 @@ namespace Engelsystem\Routing; /** * Provides urls when webserver rewriting is disabled. - * + * * The urls have the form /index.php?p=& */ class LegacyUrlGenerator extends UrlGenerator @@ -24,6 +24,7 @@ class LegacyUrlGenerator extends UrlGenerator $uri = parent::linkTo('index.php', $parameters); $uri = preg_replace('~(/index\.php)+~', '/index.php', $uri); + $uri = preg_replace('~(/index\.php)$~', '/', $uri); return $uri; } diff --git a/templates/layout.html b/templates/layout.html index c87ff3d4..832bdcf3 100644 --- a/templates/layout.html +++ b/templates/layout.html @@ -4,8 +4,8 @@ %title% - Engelsystem - - + + %atom_link% diff --git a/tests/Unit/Routing/LegacyUrlGeneratorTest.php b/tests/Unit/Routing/LegacyUrlGeneratorTest.php index 55b3d721..3d42afbd 100644 --- a/tests/Unit/Routing/LegacyUrlGeneratorTest.php +++ b/tests/Unit/Routing/LegacyUrlGeneratorTest.php @@ -14,9 +14,9 @@ class LegacyUrlGeneratorTest extends TestCase public function provideLinksTo() { return [ - ['/', 'http://foo.bar/index.php', [], 'http://foo.bar/index.php'], + ['/', 'http://foo.bar/index.php', [], 'http://foo.bar/'], ['/foo-path', 'http://foo.bar/index.php/index.php', [], 'http://foo.bar/index.php?p=foo_path'], - ['/foo', 'http://foo.bar/index.php/index.php', [], 'http://foo.bar/index.php?p=foo'], + ['/foo', 'http://foo.bar/index.php/index.php', [], 'http://foo.bar/index.php?p=foo'], ['foo', 'http://foo.bar/index.php', ['test' => 'abc'], 'http://foo.bar/index.php?p=foo&test=abc'], ]; } diff --git a/tests/Unit/Routing/UrlGeneratorTest.php b/tests/Unit/Routing/UrlGeneratorTest.php index 2d2efd31..e128bfe7 100644 --- a/tests/Unit/Routing/UrlGeneratorTest.php +++ b/tests/Unit/Routing/UrlGeneratorTest.php @@ -14,6 +14,7 @@ class UrlGeneratorTest extends TestCase public function provideLinksTo() { return [ + ['/', '/', 'http://foo.bar/', [], 'http://foo.bar/'], ['/foo/path', '/foo/path', 'http://foo.bar/foo/path', [], 'http://foo.bar/foo/path'], ['foo', '/foo', 'https://foo.bar/foo', [], 'https://foo.bar/foo'], ['foo', '/foo', 'http://f.b/foo', ['test' => 'abc', 'bla' => 'foo'], 'http://f.b/foo?test=abc&bla=foo'],