redo fix shift view bug

includes/controller/shifts_controller.php

@@ -269,12 +269,11 @@ function shift_controller()
 
     $shifttype = ShiftType($shift['shifttype_id']);
     $room = Room($shift['RID']);
-    $angeltypes_source = AngelTypes();
-    $angeltypes = [];
+    $angeltypes = AngelTypes();
     $user_shifts = Shifts_by_user($user->id);
 
     $shift_signup_state = new ShiftSignupState(ShiftSignupState::OCCUPIED, 0);
-    foreach ($angeltypes_source as &$angeltype) {
+    foreach ($angeltypes as &$angeltype) {
         $needed_angeltype = NeededAngeltype_by_Shift_and_Angeltype($shift, $angeltype);
         if (empty($needed_angeltype)) {
             continue;
@@ -293,7 +292,6 @@ function shift_controller()
         );
         $shift_signup_state->combineWith($angeltype_signup_state);
         $angeltype['shift_signup_state'] = $angeltype_signup_state;
-        $angeltypes[] = $angeltype;
     }
 
     return [