Show normal login page after registration, added msg() template function

includes/pages/guest_login.php

@@ -242,9 +242,9 @@ function guest_register()
                 redirect(page_link_to('register'));
             }
 
-            // If a welcome message is present, display registration success page.
+            // If a welcome message is present, display it on the next page
             if ($message = $config->get('welcome_msg')) {
-                return User_registration_success_view($message);
+                info((new Parsedown())->text($message));
             }
 
             redirect(page_link_to('/'));

includes/view/User_view.php

@@ -107,46 +107,6 @@ function User_settings_view(
     ]);
 }
 
-/**
- * Displays the welcome message to the user and shows a login form.
- *
- * @param string $event_welcome_message
- * @return string
- */
-function User_registration_success_view($event_welcome_message)
-{
-    $parsedown = new Parsedown();
-    $event_welcome_message = $parsedown->text($event_welcome_message);
-
-    return page_with_title(__('Registration successful'), [
-        msg(),
-        div('row', [
-            div('col-md-4', [
-                $event_welcome_message
-            ]),
-            div('col-md-4', [
-                '<h2>' . __('Login') . '</h2>',
-                form([
-                    form_text('login', __('Nick'), ''),
-                    form_password('password', __('Password')),
-                    form_submit('submit', __('Login')),
-                    buttons([
-                        button(page_link_to('user_password_recovery'), __('I forgot my password'))
-                    ]),
-                    info(__('Please note: You have to activate cookies!'), true)
-                ], page_link_to('login'))
-            ]),
-            div('col-md-4', [
-                '<h2>' . __('What can I do?') . '</h2>',
-                '<p>' . __('Please read about the jobs you can do to help us.') . '</p>',
-                buttons([
-                    button(page_link_to('angeltypes', ['action' => 'about']), __('Teams/Job description') . ' &raquo;')
-                ])
-            ])
-        ])
-    ]);
-}
-
 /**
  * Gui for deleting user with password field.
  *
@@ -271,8 +231,16 @@ function Users_view(
     $user_table_headers['force_active'] = Users_table_header_link('force_active', __('Forced'), $order_by);
     $user_table_headers['got_shirt'] = Users_table_header_link('got_shirt', __('T-Shirt'), $order_by);
     $user_table_headers['shirt_size'] = Users_table_header_link('shirt_size', __('Size'), $order_by);
-    $user_table_headers['arrival_date'] = Users_table_header_link('planned_arrival_date', __('Planned arrival'), $order_by);
+    $user_table_headers['arrival_date'] = Users_table_header_link(
-    $user_table_headers['departure_date'] = Users_table_header_link('planned_departure_date', __('Planned departure'), $order_by);
+        'planned_arrival_date',
+        __('Planned arrival'),
+        $order_by
+    );
+    $user_table_headers['departure_date'] = Users_table_header_link(
+        'planned_departure_date',
+        __('Planned departure'),
+        $order_by
+    );
     $user_table_headers['last_login_at'] = Users_table_header_link('last_login_at', __('Last login'), $order_by);
     $user_table_headers['actions'] = '';
 

resources/views/pages/login.twig

@@ -32,6 +32,7 @@
             <div class="col-sm-6 col-sm-offset-3 col-md-4 col-md-offset-4">
                 <div class="panel panel-primary first">
                     <div class="panel-body">
+                        {{ msg() }}
                         {% for message in errors|default([]) %}
                             {{ m.alert(__(message), 'danger') }}
                         {% endfor %}

src/Renderer/Twig/Extensions/Legacy.php

@@ -32,6 +32,7 @@ class Legacy extends TwigExtension
             new TwigFunction('menuUserHints', 'header_render_hints', $isSafeHtml),
             new TwigFunction('menuUserSubmenu', 'make_user_submenu', $isSafeHtml),
             new TwigFunction('page', [$this, 'getPage']),
+            new TwigFunction('msg', 'msg', $isSafeHtml),
         ];
     }
 

tests/Unit/Renderer/Twig/Extensions/LegacyTest.php

@@ -26,6 +26,7 @@ class LegacyTest extends ExtensionTest
         $this->assertExtensionExists('menuUserHints', 'header_render_hints', $functions, $isSafeHtml);
         $this->assertExtensionExists('menuUserSubmenu', 'make_user_submenu', $functions, $isSafeHtml);
         $this->assertExtensionExists('page', [$extension, 'getPage'], $functions);
+        $this->assertExtensionExists('msg', 'msg', $functions, $isSafeHtml);
     }
 
     /**