Formatting

config/config.default.php

@@ -49,7 +49,7 @@ $shift_sum_formula = "SUM(
 
 // voucher calculation
 $voucher_settings = [
-    "initial_vouchers" => 2,
+    "initial_vouchers"   => 2,
     "shifts_per_voucher" => 1
 ];
 
@@ -63,6 +63,6 @@ $api_key = "";
 $config = [
     'host' => "localhost",
     'user' => "root",
-    'pw' => "",
+    'pw'   => "",
-    'db' => "engelsystem"
+    'db'   => "engelsystem"
 ];

includes/controller/angeltypes_controller.php

@@ -16,18 +16,18 @@ function angeltypes_controller()
     $action = strip_request_item('action', 'list');
 
     switch ($action) {
-    default:
+        default:
-    case 'list':
+        case 'list':
-      return angeltypes_list_controller();
+            return angeltypes_list_controller();
-    case 'view':
+        case 'view':
-      return angeltype_controller();
+            return angeltype_controller();
-    case 'edit':
+        case 'edit':
-      return angeltype_edit_controller();
+            return angeltype_edit_controller();
-    case 'delete':
+        case 'delete':
-      return angeltype_delete_controller();
+            return angeltype_delete_controller();
-    case 'about':
+        case 'about':
-      return angeltypes_about_controller();
+            return angeltypes_about_controller();
-  }
+    }
 }
 
 /**
@@ -54,9 +54,9 @@ function angeltypes_about_controller()
     }
 
     return [
-      _("Teams/Job description"),
+        _("Teams/Job description"),
-      AngelTypes_about_view($angeltypes, isset($user))
+        AngelTypes_about_view($angeltypes, isset($user))
-  ];
+    ];
 }
 
 /**
@@ -66,7 +66,7 @@ function angeltype_delete_controller()
 {
     global $privileges;
 
-    if (! in_array('admin_angel_types', $privileges)) {
+    if (!in_array('admin_angel_types', $privileges)) {
         redirect(page_link_to('angeltypes'));
     }
 
@@ -79,9 +79,9 @@ function angeltype_delete_controller()
     }
 
     return [
-      sprintf(_("Delete angeltype %s"), $angeltype['name']),
+        sprintf(_("Delete angeltype %s"), $angeltype['name']),
-      AngelType_delete_view($angeltype)
+        AngelType_delete_view($angeltype)
-  ];
+    ];
 }
 
 /**
@@ -91,33 +91,33 @@ function angeltype_edit_controller()
 {
     global $privileges, $user;
 
-  // In supporter mode only allow to modify description
+    // In supporter mode only allow to modify description
-  $supporter_mode = ! in_array('admin_angel_types', $privileges);
+    $supporter_mode = !in_array('admin_angel_types', $privileges);
 
     if (isset($_REQUEST['angeltype_id'])) {
         // Edit existing angeltype
-    $angeltype = load_angeltype();
+        $angeltype = load_angeltype();
 
-        if (! User_is_AngelType_supporter($user, $angeltype)) {
+        if (!User_is_AngelType_supporter($user, $angeltype)) {
             redirect(page_link_to('angeltypes'));
         }
     } else {
         // New angeltype
-    if ($supporter_mode) {
+        if ($supporter_mode) {
-        // Supporters aren't allowed to create new angeltypes.
+            // Supporters aren't allowed to create new angeltypes.
-      redirect(page_link_to('angeltypes'));
+            redirect(page_link_to('angeltypes'));
-    }
+        }
         $angeltype = AngelType_new();
     }
 
     if (isset($_REQUEST['submit'])) {
         $valid = true;
 
-        if (! $supporter_mode) {
+        if (!$supporter_mode) {
             if (isset($_REQUEST['name'])) {
                 $result = AngelType_validate_name($_REQUEST['name'], $angeltype);
                 $angeltype['name'] = $result->getValue();
-                if (! $result->isValid()) {
+                if (!$result->isValid()) {
                     $valid = false;
                     error(_("Please check the name. Maybe it already exists."));
                 }
@@ -144,9 +144,9 @@ function angeltype_edit_controller()
     }
 
     return [
-      sprintf(_("Edit %s"), $angeltype['name']),
+        sprintf(_("Edit %s"), $angeltype['name']),
-      AngelType_edit_view($angeltype, $supporter_mode)
+        AngelType_edit_view($angeltype, $supporter_mode)
-  ];
+    ];
 }
 
 /**
@@ -156,7 +156,7 @@ function angeltype_controller()
 {
     global $privileges, $user;
 
-    if (! in_array('angeltypes', $privileges)) {
+    if (!in_array('angeltypes', $privileges)) {
         redirect('?');
     }
 
@@ -166,9 +166,18 @@ function angeltype_controller()
     $members = Users_by_angeltype($angeltype);
 
     return [
-      sprintf(_("Team %s"), $angeltype['name']),
+        sprintf(_("Team %s"), $angeltype['name']),
-      AngelType_view($angeltype, $members, $user_angeltype, in_array('admin_user_angeltypes', $privileges) || $user_angeltype['supporter'], in_array('admin_angel_types', $privileges), $user_angeltype['supporter'], $user_driver_license, $user)
+        AngelType_view(
-  ];
+            $angeltype,
+            $members,
+            $user_angeltype,
+            in_array('admin_user_angeltypes', $privileges) || $user_angeltype['supporter'],
+            in_array('admin_angel_types', $privileges),
+            $user_angeltype['supporter'],
+            $user_driver_license,
+            $user
+        )
+    ];
 }
 
 /**
@@ -178,7 +187,7 @@ function angeltypes_list_controller()
 {
     global $privileges, $user;
 
-    if (! in_array('angeltypes', $privileges)) {
+    if (!in_array('angeltypes', $privileges)) {
         redirect('?');
     }
 
@@ -186,19 +195,35 @@ function angeltypes_list_controller()
 
     foreach ($angeltypes as &$angeltype) {
         $actions = [
-        button(page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id'], _("view"), "btn-xs")
+            button(page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id'], _("view"), "btn-xs")
-    ];
+        ];
 
         if (in_array('admin_angel_types', $privileges)) {
-            $actions[] = button(page_link_to('angeltypes') . '&action=edit&angeltype_id=' . $angeltype['id'], _("edit"), "btn-xs");
+            $actions[] = button(
-            $actions[] = button(page_link_to('angeltypes') . '&action=delete&angeltype_id=' . $angeltype['id'], _("delete"), "btn-xs");
+                page_link_to('angeltypes') . '&action=edit&angeltype_id=' . $angeltype['id'],
+                _("edit"),
+                "btn-xs"
+            );
+            $actions[] = button(
+                page_link_to('angeltypes') . '&action=delete&angeltype_id=' . $angeltype['id'],
+                _("delete"),
+                "btn-xs"
+            );
         }
 
         $angeltype['membership'] = AngelType_render_membership($angeltype);
         if ($angeltype['user_angeltype_id'] != null) {
-            $actions[] = button(page_link_to('user_angeltypes') . '&action=delete&user_angeltype_id=' . $angeltype['user_angeltype_id'], _("leave"), "btn-xs");
+            $actions[] = button(
+                page_link_to('user_angeltypes') . '&action=delete&user_angeltype_id=' . $angeltype['user_angeltype_id'],
+                _("leave"),
+                "btn-xs"
+            );
         } else {
-            $actions[] = button(page_link_to('user_angeltypes') . '&action=add&angeltype_id=' . $angeltype['id'], _("join"), "btn-xs");
+            $actions[] = button(
+                page_link_to('user_angeltypes') . '&action=add&angeltype_id=' . $angeltype['id'],
+                _("join"),
+                "btn-xs"
+            );
         }
 
         $angeltype['restricted'] = $angeltype['restricted'] ? glyph('lock') : '';
@@ -210,9 +235,9 @@ function angeltypes_list_controller()
     }
 
     return [
-      angeltypes_title(),
+        angeltypes_title(),
-      AngelTypes_list_view($angeltypes, in_array('admin_angel_types', $privileges))
+        AngelTypes_list_view($angeltypes, in_array('admin_angel_types', $privileges))
-  ];
+    ];
 }
 
 /**
@@ -220,7 +245,7 @@ function angeltypes_list_controller()
  */
 function load_angeltype()
 {
-    if (! isset($_REQUEST['angeltype_id'])) {
+    if (!isset($_REQUEST['angeltype_id'])) {
         redirect(page_link_to('angeltypes'));
     }
 

includes/controller/event_config_controller.php

@@ -9,7 +9,7 @@ function event_config_edit_controller()
 {
     global $privileges;
 
-    if (! in_array('admin_event_config', $privileges)) {
+    if (!in_array('admin_event_config', $privileges)) {
         redirect('?');
     }
 
@@ -84,20 +84,38 @@ function event_config_edit_controller()
         }
 
         if ($valid) {
-            $result = EventConfig_update($event_name, $buildup_start_date, $event_start_date, $event_end_date, $teardown_end_date, $event_welcome_msg);
+            $result = EventConfig_update(
+                $event_name,
+                $buildup_start_date,
+                $event_start_date,
+                $event_end_date,
+                $teardown_end_date,
+                $event_welcome_msg
+            );
 
             if ($result === false) {
                 engelsystem_error("Unable to update event config.");
             }
 
-            engelsystem_log("Changed event config: $event_name, $event_welcome_msg, " . date("Y-m-d", $buildup_start_date) . ", " . date("Y-m-d", $event_start_date) . ", " . date("Y-m-d", $event_end_date) . ", " . date("Y-m-d", $teardown_end_date));
+            engelsystem_log(
+                "Changed event config: $event_name, $event_welcome_msg, "
+                . date("Y-m-d", $buildup_start_date) . ", " . date("Y-m-d", $event_start_date) . ", "
+                . date("Y-m-d", $event_end_date) . ", " . date("Y-m-d", $teardown_end_date)
+            );
             success(_("Settings saved."));
             redirect(page_link_to('admin_event_config'));
         }
     }
 
     return [
-      event_config_title(),
+        event_config_title(),
-      EventConfig_edit_view($event_name, $event_welcome_msg, $buildup_start_date, $event_start_date, $event_end_date, $teardown_end_date)
+        EventConfig_edit_view(
-  ];
+            $event_name,
+            $event_welcome_msg,
+            $buildup_start_date,
+            $event_start_date,
+            $event_end_date,
+            $teardown_end_date
+        )
+    ];
 }

includes/controller/rooms_controller.php

@@ -1,7 +1,6 @@
 <?php
-use Engelsystem\ShiftsFilterRenderer;
 use Engelsystem\ShiftsFilter;
-use Engelsystem\ShiftCalendarRenderer;
+use Engelsystem\ShiftsFilterRenderer;
 
 /**
  * Room controllers for managing everything room related.
@@ -14,7 +13,7 @@ function room_controller()
 {
     global $privileges;
 
-    if (! in_array('view_rooms', $privileges)) {
+    if (!in_array('view_rooms', $privileges)) {
         redirect(page_link_to());
     }
 
@@ -23,16 +22,18 @@ function room_controller()
     $days = [];
     foreach ($all_shifts as $shift) {
         $day = date("Y-m-d", $shift['start']);
-        if (! in_array($day, $days)) {
+        if (!in_array($day, $days)) {
             $days[] = $day;
         }
     }
 
-    $shiftsFilter = new ShiftsFilter(true, [
+    $shiftsFilter = new ShiftsFilter(
-      $room['RID']
+        true,
-  ], AngelType_ids());
+        [$room['RID']],
+        AngelType_ids()
+    );
     $selected_day = date("Y-m-d");
-    if (! empty($days)) {
+    if (!empty($days)) {
         $selected_day = $days[0];
     }
     if (isset($_REQUEST['shifts_filter_day'])) {
@@ -47,9 +48,9 @@ function room_controller()
     $shiftCalendarRenderer = shiftCalendarRendererByShiftFilter($shiftsFilter);
 
     return [
-      $room['Name'],
+        $room['Name'],
-      Room_view($room, $shiftsFilterRenderer, $shiftCalendarRenderer)
+        Room_view($room, $shiftsFilterRenderer, $shiftCalendarRenderer)
-  ];
+    ];
 }
 
 /**
@@ -57,17 +58,17 @@ function room_controller()
  */
 function rooms_controller()
 {
-    if (! isset($_REQUEST['action'])) {
+    if (!isset($_REQUEST['action'])) {
         $_REQUEST['action'] = 'list';
     }
 
     switch ($_REQUEST['action']) {
-    default:
+        default:
-    case 'list':
+        case 'list':
-      redirect(page_link_to('admin_rooms'));
+            redirect(page_link_to('admin_rooms'));
-    case 'view':
+        case 'view':
-      return room_controller();
+            return room_controller();
-  }
+    }
 }
 
 function room_link($room)
@@ -85,7 +86,7 @@ function room_edit_link($room)
  */
 function load_room()
 {
-    if (! test_request_int('room_id')) {
+    if (!test_request_int('room_id')) {
         redirect(page_link_to());
     }
 

includes/controller/shift_entries_controller.php

@@ -13,8 +13,8 @@ function shift_entry_add_controller()
         redirect(page_link_to('user_shifts'));
     }
 
-  // Locations laden
+    // Locations laden
-  $rooms = sql_select("SELECT * FROM `Room` WHERE `show`='Y' ORDER BY `Name`");
+    $rooms = sql_select("SELECT * FROM `Room` WHERE `show`='Y' ORDER BY `Name`");
     $room_array = [];
     foreach ($rooms as $room) {
         $room_array[$room['RID']] = $room['Name'];
@@ -35,7 +35,18 @@ function shift_entry_add_controller()
     if (in_array('user_shifts_admin', $privileges) || in_array('shiftentry_edit_angeltype_supporter', $privileges)) {
         $type = AngelType($type_id);
     } else {
-        $type = sql_select("SELECT * FROM `UserAngelTypes` JOIN `AngelTypes` ON (`UserAngelTypes`.`angeltype_id` = `AngelTypes`.`id`) WHERE `AngelTypes`.`id` = '" . sql_escape($type_id) . "' AND (`AngelTypes`.`restricted` = 0 OR (`UserAngelTypes`.`user_id` = '" . sql_escape($user['UID']) . "' AND NOT `UserAngelTypes`.`confirm_user_id` IS NULL))");
+        $type = sql_select("
+            SELECT * FROM `UserAngelTypes`
+            JOIN `AngelTypes` ON (`UserAngelTypes`.`angeltype_id` = `AngelTypes`.`id`)
+            WHERE `AngelTypes`.`id` = '" . sql_escape($type_id) . "'
+            AND (
+                `AngelTypes`.`restricted` = 0
+                OR (
+                    `UserAngelTypes`.`user_id` = '" . sql_escape($user['UID']) . "'
+                    AND NOT `UserAngelTypes`.`confirm_user_id` IS NULL
+                )
+            )
+        ");
         $type = $type[0];
     }
 
@@ -43,7 +54,14 @@ function shift_entry_add_controller()
         redirect(page_link_to('user_shifts'));
     }
 
-    if (isset($_REQUEST['user_id']) && preg_match("/^[0-9]*$/", $_REQUEST['user_id']) && (in_array('user_shifts_admin', $privileges) || in_array('shiftentry_edit_angeltype_supporter', $privileges))) {
+    if (
+        isset($_REQUEST['user_id'])
+        && preg_match("/^[0-9]*$/", $_REQUEST['user_id'])
+        && (
+            in_array('user_shifts_admin', $privileges)
+            || in_array('shiftentry_edit_angeltype_supporter', $privileges)
+        )
+    ) {
         $user_id = $_REQUEST['user_id'];
     } else {
         $user_id = $user['UID'];
@@ -52,20 +70,34 @@ function shift_entry_add_controller()
     $needed_angeltype = NeededAngeltype_by_Shift_and_Angeltype($shift, $type);
     $shift_entries = ShiftEntries_by_shift_and_angeltype($shift['SID'], $type['id']);
 
-    $shift_signup_allowed = Shift_signup_allowed(User($user_id), $shift, $type, null, null, $needed_angeltype, $shift_entries);
+    $shift_signup_allowed = Shift_signup_allowed(
-    if (! $shift_signup_allowed->isSignupAllowed()) {
+        User($user_id),
+        $shift,
+        $type,
+        null,
+        null,
+        $needed_angeltype,
+        $shift_entries
+    );
+    if (!$shift_signup_allowed->isSignupAllowed()) {
         error(_("You are not allowed to sign up for this shift. Maybe shift is full or already running."));
         redirect(shift_link($shift));
     }
 
     if (isset($_REQUEST['submit'])) {
         $selected_type_id = $type_id;
-        if (in_array('user_shifts_admin', $privileges) || in_array('shiftentry_edit_angeltype_supporter', $privileges)) {
+        if (in_array('user_shifts_admin', $privileges) || in_array('shiftentry_edit_angeltype_supporter',
+                $privileges)
+        ) {
             if (sql_num_query("SELECT * FROM `User` WHERE `UID`='" . sql_escape($user_id) . "' LIMIT 1") == 0) {
                 redirect(page_link_to('user_shifts'));
             }
 
-            if (isset($_REQUEST['angeltype_id']) && test_request_int('angeltype_id') && sql_num_query("SELECT * FROM `AngelTypes` WHERE `id`='" . sql_escape($_REQUEST['angeltype_id']) . "' LIMIT 1") > 0) {
+            if (
+                isset($_REQUEST['angeltype_id'])
+                && test_request_int('angeltype_id')
+                && sql_num_query("SELECT * FROM `AngelTypes` WHERE `id`='" . sql_escape($_REQUEST['angeltype_id']) . "' LIMIT 1") > 0
+            ) {
                 $selected_type_id = $_REQUEST['angeltype_id'];
             }
         }
@@ -83,29 +115,42 @@ function shift_entry_add_controller()
 
         $comment = strip_request_item_nl('comment');
         $result = ShiftEntry_create([
-        'SID' => $shift_id,
+            'SID'              => $shift_id,
-        'TID' => $selected_type_id,
+            'TID'              => $selected_type_id,
-        'UID' => $user_id,
+            'UID'              => $user_id,
-        'Comment' => $comment,
+            'Comment'          => $comment,
-        'freeloaded' => $freeloaded,
+            'freeloaded'       => $freeloaded,
-        'freeload_comment' => $freeload_comment
+            'freeload_comment' => $freeload_comment
-    ]);
+        ]);
         if ($result === false) {
             engelsystem_error('Unable to create shift entry.');
         }
 
-        if ($type['restricted'] == 0 && sql_num_query("SELECT * FROM `UserAngelTypes` INNER JOIN `AngelTypes` ON `AngelTypes`.`id` = `UserAngelTypes`.`angeltype_id` WHERE `angeltype_id` = '" . sql_escape($selected_type_id) . "' AND `user_id` = '" . sql_escape($user_id) . "'") == 0) {
+        if (
+            $type['restricted'] == 0
+            && sql_num_query("
+              SELECT * FROM `UserAngelTypes`
+              INNER JOIN `AngelTypes` ON `AngelTypes`.`id` = `UserAngelTypes`.`angeltype_id`
+              WHERE `angeltype_id` = '" . sql_escape($selected_type_id) . "' 
+              AND `user_id` = '" . sql_escape($user_id) . "'
+            ") == 0
+        ) {
             sql_query("INSERT INTO `UserAngelTypes` (`user_id`, `angeltype_id`) VALUES ('" . sql_escape($user_id) . "', '" . sql_escape($selected_type_id) . "')");
         }
 
         $user_source = User($user_id);
-        engelsystem_log("User " . User_Nick_render($user_source) . " signed up for shift " . $shift['name'] . " from " . date("Y-m-d H:i", $shift['start']) . " to " . date("Y-m-d H:i", $shift['end']));
+        engelsystem_log("User " . User_Nick_render($user_source) . " signed up for shift " . $shift['name'] . " from " . date("Y-m-d H:i",
+                $shift['start']) . " to " . date("Y-m-d H:i", $shift['end']));
         success(_("You are subscribed. Thank you!") . ' <a href="' . page_link_to('user_myshifts') . '">' . _("My shifts") . ' &raquo;</a>');
         redirect(shift_link($shift));
     }
 
     if (in_array('user_shifts_admin', $privileges)) {
-        $users = sql_select("SELECT *, (SELECT count(*) FROM `ShiftEntry` WHERE `freeloaded`=1 AND `ShiftEntry`.`UID`=`User`.`UID`) AS `freeloaded` FROM `User` ORDER BY `Nick`");
+        $users = sql_select("
+            SELECT *, (SELECT count(*) FROM `ShiftEntry` WHERE `freeloaded`=1 AND `ShiftEntry`.`UID`=`User`.`UID`) AS `freeloaded`
+            FROM `User`
+            ORDER BY `Nick`
+        ");
         $users_select = [];
         foreach ($users as $usr) {
             $users_select[$usr['UID']] = $usr['Nick'] . ($usr['freeloaded'] == 0 ? "" : " (" . _("Freeloader") . ")");
@@ -122,7 +167,7 @@ function shift_entry_add_controller()
         $users = Users_by_angeltype($type);
         $users_select = [];
         foreach ($users as $usr) {
-            if (! $type['restricted'] || $usr['confirm_user_id'] != null) {
+            if (!$type['restricted'] || $usr['confirm_user_id'] != null) {
                 $users_select[$usr['UID']] = $usr['Nick'];
             }
         }
@@ -141,7 +186,9 @@ function shift_entry_add_controller()
         $angeltype_select = $type['name'];
     }
 
-    return ShiftEntry_edit_view($user_text, date("Y-m-d H:i", $shift['start']) . ' &ndash; ' . date('Y-m-d H:i', $shift['end']) . ' (' . shift_length($shift) . ')', $shift['Name'], $shift['name'], $angeltype_select, "", false, null, in_array('user_shifts_admin', $privileges));
+    return ShiftEntry_edit_view($user_text, date("Y-m-d H:i", $shift['start']) . ' &ndash; ' . date('Y-m-d H:i',
+            $shift['end']) . ' (' . shift_length($shift) . ')', $shift['Name'], $shift['name'], $angeltype_select, "",
+        false, null, in_array('user_shifts_admin', $privileges));
 }
 
 /**
@@ -151,13 +198,21 @@ function shift_entry_delete_controller()
 {
     global $privileges, $user;
 
-    if (! isset($_REQUEST['entry_id']) || ! test_request_int('entry_id')) {
+    if (!isset($_REQUEST['entry_id']) || !test_request_int('entry_id')) {
         redirect(page_link_to('user_shifts'));
     }
     $entry_id = $_REQUEST['entry_id'];
 
     $shift_entry_source = sql_select("
-        SELECT `User`.`Nick`, `ShiftEntry`.`Comment`, `ShiftEntry`.`UID`, `ShiftTypes`.`name`, `Shifts`.*, `Room`.`Name`, `AngelTypes`.`name` as `angel_type`, `AngelTypes`.`id` as `angeltype_id`
+        SELECT
+            `User`.`Nick`,
+            `ShiftEntry`.`Comment`,
+            `ShiftEntry`.`UID`,
+            `ShiftTypes`.`name`,
+            `Shifts`.*,
+            `Room`.`Name`,
+            `AngelTypes`.`name` AS `angel_type`,
+            `AngelTypes`.`id` AS `angeltype_id`
         FROM `ShiftEntry`
         JOIN `User` ON (`User`.`UID`=`ShiftEntry`.`UID`)
         JOIN `AngelTypes` ON (`ShiftEntry`.`TID` = `AngelTypes`.`id`)
@@ -168,7 +223,9 @@ function shift_entry_delete_controller()
     if (count($shift_entry_source) > 0) {
         $shift_entry_source = $shift_entry_source[0];
 
-        if (!in_array('user_shifts_admin', $privileges) && (!in_array('shiftentry_edit_angeltype_supporter', $privileges) || !User_is_AngelType_supporter($user, AngelType($shift_entry_source['angeltype_id'])))) {
+        if (!in_array('user_shifts_admin', $privileges) && (!in_array('shiftentry_edit_angeltype_supporter',
+                    $privileges) || !User_is_AngelType_supporter($user, AngelType($shift_entry_source['angeltype_id'])))
+        ) {
             redirect(page_link_to('user_shifts'));
         }
 
@@ -177,7 +234,13 @@ function shift_entry_delete_controller()
             engelsystem_error('Unable to delete shift entry.');
         }
 
-        engelsystem_log("Deleted " . User_Nick_render($shift_entry_source) . "'s shift: " . $shift_entry_source['name'] . " at " . $shift_entry_source['Name'] . " from " . date("Y-m-d H:i", $shift_entry_source['start']) . " to " . date("Y-m-d H:i", $shift_entry_source['end']) . " as " . $shift_entry_source['angel_type']);
+        engelsystem_log(
+            "Deleted " . User_Nick_render($shift_entry_source) . "'s shift: " . $shift_entry_source['name']
+            . " at " . $shift_entry_source['Name']
+            . " from " . date("Y-m-d H:i", $shift_entry_source['start'])
+            . " to " . date("Y-m-d H:i", $shift_entry_source['end'])
+            . " as " . $shift_entry_source['angel_type']
+        );
         success(_("Shift entry deleted."));
     } else {
         error(_("Entry not found."));

includes/controller/shifts_controller.php

@@ -23,15 +23,15 @@ function shift_edit_controller()
 {
     global $privileges;
 
-  // Schicht bearbeiten
+    // Schicht bearbeiten
-  $msg = "";
+    $msg = "";
     $valid = true;
 
-    if (! in_array('admin_shifts', $privileges)) {
+    if (!in_array('admin_shifts', $privileges)) {
         redirect(page_link_to('user_shifts'));
     }
 
-    if (! isset($_REQUEST['edit_shift']) || ! test_request_int('edit_shift')) {
+    if (!isset($_REQUEST['edit_shift']) || !test_request_int('edit_shift')) {
         redirect(page_link_to('user_shifts'));
     }
     $shift_id = $_REQUEST['edit_shift'];
@@ -44,7 +44,7 @@ function shift_edit_controller()
 
     $needed_angel_types = select_array(NeededAngelTypes_by_shift($shift_id), 'id', 'count');
     foreach (array_keys($angeltypes) as $angeltype_id) {
-        if (! isset($needed_angel_types[$angeltype_id])) {
+        if (!isset($needed_angel_types[$angeltype_id])) {
             $needed_angel_types[$angeltype_id] = 0;
         }
     }
@@ -57,15 +57,15 @@ function shift_edit_controller()
 
     if (isset($_REQUEST['submit'])) {
         // Name/Bezeichnung der Schicht, darf leer sein
-    $title = strip_request_item('title');
+        $title = strip_request_item('title');
-    
+
-    // Auswahl der sichtbaren Locations für die Schichten
+        // Auswahl der sichtbaren Locations für die Schichten
-    if (isset($_REQUEST['rid']) && preg_match("/^[0-9]+$/", $_REQUEST['rid']) && isset($room[$_REQUEST['rid']])) {
+        if (isset($_REQUEST['rid']) && preg_match("/^[0-9]+$/", $_REQUEST['rid']) && isset($room[$_REQUEST['rid']])) {
-        $rid = $_REQUEST['rid'];
+            $rid = $_REQUEST['rid'];
-    } else {
+        } else {
-        $valid = false;
+            $valid = false;
-        $msg .= error(_("Please select a room."), true);
+            $msg .= error(_("Please select a room."), true);
-    }
+        }
 
         if (isset($_REQUEST['shifttype_id']) && isset($shifttypes[$_REQUEST['shifttype_id']])) {
             $shifttype_id = $_REQUEST['shifttype_id'];
@@ -98,7 +98,10 @@ function shift_edit_controller()
                 $needed_angel_types[$needed_angeltype_id] = trim($_REQUEST['type_' . $needed_angeltype_id]);
             } else {
                 $valid = false;
-                $msg .= error(sprintf(_("Please check your input for needed angels of type %s."), $needed_angeltype_name), true);
+                $msg .= error(sprintf(
+                    _("Please check your input for needed angels of type %s."),
+                    $needed_angeltype_name
+                ), true);
             }
         }
 
@@ -120,48 +123,57 @@ function shift_edit_controller()
                 $needed_angel_types_info[] = $angeltypes[$type_id] . ": " . $count;
             }
 
-            engelsystem_log("Updated shift '" . $shifttypes[$shifttype_id] . ", " . $title . "' from " . date("Y-m-d H:i", $start) . " to " . date("Y-m-d H:i", $end) . " with angel types " . join(", ", $needed_angel_types_info));
+            engelsystem_log(
+                "Updated shift '" . $shifttypes[$shifttype_id] . ", " . $title
+                . "' from " . date("Y-m-d H:i", $start)
+                . " to " . date("Y-m-d H:i", $end)
+                . " with angel types " . join(", ", $needed_angel_types_info)
+            );
             success(_("Shift updated."));
 
             redirect(shift_link([
-          'SID' => $shift_id
+                'SID' => $shift_id
-      ]));
+            ]));
         }
     }
 
     $angel_types_spinner = "";
     foreach ($angeltypes as $angeltype_id => $angeltype_name) {
-        $angel_types_spinner .= form_spinner('type_' . $angeltype_id, $angeltype_name, $needed_angel_types[$angeltype_id]);
+        $angel_types_spinner .= form_spinner('type_' . $angeltype_id, $angeltype_name,
+            $needed_angel_types[$angeltype_id]);
     }
 
-    return page_with_title(shifts_title(), [
+    return page_with_title(
-      msg(),
+        shifts_title(),
-      '<noscript>' . info(_("This page is much more comfortable with javascript."), true) . '</noscript>',
+        [
-      form([
+            msg(),
-          form_select('shifttype_id', _('Shifttype'), $shifttypes, $shifttype_id),
+            '<noscript>' . info(_("This page is much more comfortable with javascript."), true) . '</noscript>',
-          form_text('title', _("Title"), $title),
+            form([
-          form_select('rid', _("Room:"), $room, $rid),
+                form_select('shifttype_id', _('Shifttype'), $shifttypes, $shifttype_id),
-          form_text('start', _("Start:"), date("Y-m-d H:i", $start)),
+                form_text('title', _("Title"), $title),
-          form_text('end', _("End:"), date("Y-m-d H:i", $end)),
+                form_select('rid', _("Room:"), $room, $rid),
-          '<h2>' . _("Needed angels") . '</h2>',
+                form_text('start', _("Start:"), date("Y-m-d H:i", $start)),
-          $angel_types_spinner,
+                form_text('end', _("End:"), date("Y-m-d H:i", $end)),
-          form_submit('submit', _("Save"))
+                '<h2>' . _("Needed angels") . '</h2>',
-      ])
+                $angel_types_spinner,
-  ]);
+                form_submit('submit', _("Save"))
+            ])
+        ]
+    );
 }
 
 function shift_delete_controller()
 {
     global $privileges;
 
-    if (! in_array('user_shifts_admin', $privileges)) {
+    if (!in_array('user_shifts_admin', $privileges)) {
         redirect(page_link_to('user_shifts'));
     }
 
-  // Schicht komplett löschen (nur für admins/user mit user_shifts_admin privileg)
+    // Schicht komplett löschen (nur für admins/user mit user_shifts_admin privileg)
-  if (! isset($_REQUEST['delete_shift']) || ! preg_match("/^[0-9]*$/", $_REQUEST['delete_shift'])) {
+    if (!isset($_REQUEST['delete_shift']) || !preg_match("/^[0-9]*$/", $_REQUEST['delete_shift'])) {
-      redirect(page_link_to('user_shifts'));
+        redirect(page_link_to('user_shifts'));
-  }
+    }
     $shift_id = $_REQUEST['delete_shift'];
 
     $shift = Shift($shift_id);
@@ -169,30 +181,39 @@ function shift_delete_controller()
         redirect(page_link_to('user_shifts'));
     }
 
-  // Schicht löschen bestätigt
+    // Schicht löschen bestätigt
-  if (isset($_REQUEST['delete'])) {
+    if (isset($_REQUEST['delete'])) {
-      Shift_delete($shift_id);
+        Shift_delete($shift_id);
 
-      engelsystem_log("Deleted shift " . $shift['name'] . " from " . date("Y-m-d H:i", $shift['start']) . " to " . date("Y-m-d H:i", $shift['end']));
+        engelsystem_log(
-      success(_("Shift deleted."));
+            "Deleted shift " . $shift['name']
-      redirect(page_link_to('user_shifts'));
+            . " from " . date("Y-m-d H:i", $shift['start'])
-  }
+            . " to " . date("Y-m-d H:i", $shift['end'])
+        );
+        success(_("Shift deleted."));
+        redirect(page_link_to('user_shifts'));
+    }
 
     return page_with_title(shifts_title(), [
-      error(sprintf(_("Do you want to delete the shift %s from %s to %s?"), $shift['name'], date("Y-m-d H:i", $shift['start']), date("H:i", $shift['end'])), true),
+        error(sprintf(
-      '<a class="button" href="?p=user_shifts&delete_shift=' . $shift_id . '&delete">' . _("delete") . '</a>'
+            _("Do you want to delete the shift %s from %s to %s?"),
-  ]);
+            $shift['name'],
+            date("Y-m-d H:i", $shift['start']),
+            date("H:i", $shift['end'])
+        ), true),
+        '<a class="button" href="?p=user_shifts&delete_shift=' . $shift_id . '&delete">' . _("delete") . '</a>'
+    ]);
 }
 
 function shift_controller()
 {
     global $user, $privileges;
 
-    if (! in_array('user_shifts', $privileges)) {
+    if (!in_array('user_shifts', $privileges)) {
         redirect(page_link_to('?'));
     }
 
-    if (! isset($_REQUEST['shift_id'])) {
+    if (!isset($_REQUEST['shift_id'])) {
         redirect(page_link_to('user_shifts'));
     }
 
@@ -212,7 +233,8 @@ function shift_controller()
         $needed_angeltype = NeededAngeltype_by_Shift_and_Angeltype($shift, $angeltype);
         $shift_entries = ShiftEntries_by_shift_and_angeltype($shift['SID'], $angeltype['id']);
 
-        $angeltype_signup_state = Shift_signup_allowed($user, $shift, $angeltype, null, $user_shifts, $needed_angeltype, $shift_entries);
+        $angeltype_signup_state = Shift_signup_allowed($user, $shift, $angeltype, null, $user_shifts, $needed_angeltype,
+            $shift_entries);
         if ($shift_signup_state == null) {
             $shift_signup_state = $angeltype_signup_state;
         } else {
@@ -222,25 +244,25 @@ function shift_controller()
     }
 
     return [
-      $shift['name'],
+        $shift['name'],
-      Shift_view($shift, $shifttype, $room, $angeltypes, $shift_signup_state)
+        Shift_view($shift, $shifttype, $room, $angeltypes, $shift_signup_state)
-  ];
+    ];
 }
 
 function shifts_controller()
 {
-    if (! isset($_REQUEST['action'])) {
+    if (!isset($_REQUEST['action'])) {
         redirect(page_link_to('user_shifts'));
     }
 
     switch ($_REQUEST['action']) {
-    default:
+        default:
-      redirect(page_link_to('?'));
+            redirect(page_link_to('?'));
-    case 'view':
+        case 'view':
-      return shift_controller();
+            return shift_controller();
-    case 'next':
+        case 'next':
-      return shift_next_controller();
+            return shift_next_controller();
-  }
+    }
 }
 
 /**
@@ -250,7 +272,7 @@ function shift_next_controller()
 {
     global $user, $privileges;
 
-    if (! in_array('user_shifts', $privileges)) {
+    if (!in_array('user_shifts', $privileges)) {
         redirect(page_link_to('?'));
     }
 
@@ -277,7 +299,7 @@ function shifts_json_export_all_controller()
         engelsystem_error("Config contains empty apikey.");
     }
 
-    if (! isset($_REQUEST['api_key'])) {
+    if (!isset($_REQUEST['api_key'])) {
         engelsystem_error("Missing parameter api_key.");
     }
 
@@ -302,7 +324,7 @@ function shifts_json_export_controller()
 {
     global $user;
 
-    if (! isset($_REQUEST['key']) || ! preg_match("/^[0-9a-f]{32}$/", $_REQUEST['key'])) {
+    if (!isset($_REQUEST['key']) || !preg_match("/^[0-9a-f]{32}$/", $_REQUEST['key'])) {
         engelsystem_error("Missing key.");
     }
 
@@ -312,7 +334,7 @@ function shifts_json_export_controller()
     if ($user == null) {
         engelsystem_error("Key invalid.");
     }
-    if (! in_array('shifts_json_export', privileges_for_user($user['UID']))) {
+    if (!in_array('shifts_json_export', privileges_for_user($user['UID']))) {
         engelsystem_error("No privilege for shifts_json_export.");
     }
 

includes/controller/shifttypes_controller.php

@@ -10,7 +10,7 @@ function shifttype_link($shifttype)
  */
 function shifttype_delete_controller()
 {
-    if (! isset($_REQUEST['shifttype_id'])) {
+    if (!isset($_REQUEST['shifttype_id'])) {
         redirect(page_link_to('shifttypes'));
     }
 
@@ -35,9 +35,9 @@ function shifttype_delete_controller()
     }
 
     return [
-      sprintf(_("Delete shifttype %s"), $shifttype['name']),
+        sprintf(_("Delete shifttype %s"), $shifttype['name']),
-      ShiftType_delete_view($shifttype)
+        ShiftType_delete_view($shifttype)
-  ];
+    ];
 }
 
 /**
@@ -108,14 +108,14 @@ function shifttype_edit_controller()
     }
 
     return [
-      shifttypes_title(),
+        shifttypes_title(),
-      ShiftType_edit_view($name, $angeltype_id, $angeltypes, $description, $shifttype_id)
+        ShiftType_edit_view($name, $angeltype_id, $angeltypes, $description, $shifttype_id)
-  ];
+    ];
 }
 
 function shifttype_controller()
 {
-    if (! isset($_REQUEST['shifttype_id'])) {
+    if (!isset($_REQUEST['shifttype_id'])) {
         redirect(page_link_to('shifttypes'));
     }
     $shifttype = ShiftType($_REQUEST['shifttype_id']);
@@ -132,9 +132,9 @@ function shifttype_controller()
     }
 
     return [
-      $shifttype['name'],
+        $shifttype['name'],
-      ShiftType_view($shifttype, $angeltype)
+        ShiftType_view($shifttype, $angeltype)
-  ];
+    ];
 }
 
 /**
@@ -148,9 +148,9 @@ function shifttypes_list_controller()
     }
 
     return [
-      shifttypes_title(),
+        shifttypes_title(),
-      ShiftTypes_list_view($shifttypes)
+        ShiftTypes_list_view($shifttypes)
-  ];
+    ];
 }
 
 /**
@@ -166,19 +166,19 @@ function shifttypes_title()
  */
 function shifttypes_controller()
 {
-    if (! isset($_REQUEST['action'])) {
+    if (!isset($_REQUEST['action'])) {
         $_REQUEST['action'] = 'list';
     }
 
     switch ($_REQUEST['action']) {
-    default:
+        default:
-    case 'list':
+        case 'list':
-      return shifttypes_list_controller();
+            return shifttypes_list_controller();
-    case 'view':
+        case 'view':
-      return shifttype_controller();
+            return shifttype_controller();
-    case 'edit':
+        case 'edit':
-      return shifttype_edit_controller();
+            return shifttype_edit_controller();
-    case 'delete':
+        case 'delete':
-      return shifttype_delete_controller();
+            return shifttype_delete_controller();
-  }
+    }
 }

includes/controller/user_angeltypes_controller.php

@@ -17,7 +17,10 @@ function user_angeltypes_unconfirmed_hint()
         $unconfirmed_links[] = '<a href="' . page_link_to('angeltypes') . '&action=view&angeltype_id=' . $user_angeltype['angeltype_id'] . '">' . $user_angeltype['name'] . ' (+' . $user_angeltype['count'] . ')' . '</a>';
     }
 
-    return sprintf(ngettext("There is %d unconfirmed angeltype.", "There are %d unconfirmed angeltypes.", count($unconfirmed_user_angeltypes)), count($unconfirmed_user_angeltypes)) . " " . _('Angel types which need approvals:') . ' ' . join(', ', $unconfirmed_links);
+    return sprintf(ngettext("There is %d unconfirmed angeltype.", "There are %d unconfirmed angeltypes.",
+            count($unconfirmed_user_angeltypes)),
+            count($unconfirmed_user_angeltypes)) . " " . _('Angel types which need approvals:') . ' ' . join(', ',
+            $unconfirmed_links);
 }
 
 /**
@@ -27,7 +30,7 @@ function user_angeltypes_delete_all_controller()
 {
     global $user;
 
-    if (! isset($_REQUEST['angeltype_id'])) {
+    if (!isset($_REQUEST['angeltype_id'])) {
         error(_("Angeltype doesn't exist."));
         redirect(page_link_to('angeltypes'));
     }
@@ -38,7 +41,7 @@ function user_angeltypes_delete_all_controller()
         redirect(page_link_to('angeltypes'));
     }
 
-    if (! User_is_AngelType_supporter($user, $angeltype)) {
+    if (!User_is_AngelType_supporter($user, $angeltype)) {
         error(_("You are not allowed to delete all users for this angeltype."));
         redirect(page_link_to('angeltypes'));
     }
@@ -52,9 +55,9 @@ function user_angeltypes_delete_all_controller()
     }
 
     return [
-      _("Deny all users"),
+        _("Deny all users"),
-      UserAngelTypes_delete_all_view($angeltype)
+        UserAngelTypes_delete_all_view($angeltype)
-  ];
+    ];
 }
 
 /**
@@ -64,7 +67,7 @@ function user_angeltypes_confirm_all_controller()
 {
     global $user, $privileges;
 
-    if (! isset($_REQUEST['angeltype_id'])) {
+    if (!isset($_REQUEST['angeltype_id'])) {
         error(_("Angeltype doesn't exist."));
         redirect(page_link_to('angeltypes'));
     }
@@ -81,7 +84,7 @@ function user_angeltypes_confirm_all_controller()
         redirect(page_link_to('angeltypes'));
     }
 
-    if (! in_array('admin_user_angeltypes', $privileges) && ! $user_angeltype['supporter']) {
+    if (!in_array('admin_user_angeltypes', $privileges) && !$user_angeltype['supporter']) {
         error(_("You are not allowed to confirm all users for this angeltype."));
         redirect(page_link_to('angeltypes'));
     }
@@ -95,9 +98,9 @@ function user_angeltypes_confirm_all_controller()
     }
 
     return [
-      _("Confirm all users"),
+        _("Confirm all users"),
-      UserAngelTypes_confirm_all_view($angeltype)
+        UserAngelTypes_confirm_all_view($angeltype)
-  ];
+    ];
 }
 
 /**
@@ -107,7 +110,7 @@ function user_angeltype_confirm_controller()
 {
     global $user;
 
-    if (! isset($_REQUEST['user_angeltype_id'])) {
+    if (!isset($_REQUEST['user_angeltype_id'])) {
         error(_("User angeltype doesn't exist."));
         redirect(page_link_to('angeltypes'));
     }
@@ -124,7 +127,7 @@ function user_angeltype_confirm_controller()
         redirect(page_link_to('angeltypes'));
     }
 
-    if (! User_is_AngelType_supporter($user, $angeltype)) {
+    if (!User_is_AngelType_supporter($user, $angeltype)) {
         error(_("You are not allowed to confirm this users angeltype."));
         redirect(page_link_to('angeltypes'));
     }
@@ -141,15 +144,23 @@ function user_angeltype_confirm_controller()
             engelsystem_error("Unable to confirm user angeltype.");
         }
 
-        engelsystem_log(sprintf("%s confirmed for angeltype %s", User_Nick_render($user_source), AngelType_name_render($angeltype)));
+        engelsystem_log(sprintf(
-        success(sprintf(_("%s confirmed for angeltype %s."), User_Nick_render($user_source), AngelType_name_render($angeltype)));
+            "%s confirmed for angeltype %s",
+            User_Nick_render($user_source),
+            AngelType_name_render($angeltype)
+        ));
+        success(sprintf(
+            _("%s confirmed for angeltype %s."),
+            User_Nick_render($user_source),
+            AngelType_name_render($angeltype)
+        ));
         redirect(page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id']);
     }
 
     return [
-      _("Confirm angeltype for user"),
+        _("Confirm angeltype for user"),
-      UserAngelType_confirm_view($user_angeltype, $user_source, $angeltype)
+        UserAngelType_confirm_view($user_angeltype, $user_source, $angeltype)
-  ];
+    ];
 }
 
 /**
@@ -159,7 +170,7 @@ function user_angeltype_delete_controller()
 {
     global $user;
 
-    if (! isset($_REQUEST['user_angeltype_id'])) {
+    if (!isset($_REQUEST['user_angeltype_id'])) {
         error(_("User angeltype doesn't exist."));
         redirect(page_link_to('angeltypes'));
     }
@@ -182,7 +193,7 @@ function user_angeltype_delete_controller()
         redirect(page_link_to('angeltypes'));
     }
 
-    if ($user['UID'] != $user_angeltype['user_id'] && ! User_is_AngelType_supporter($user, $angeltype)) {
+    if ($user['UID'] != $user_angeltype['user_id'] && !User_is_AngelType_supporter($user, $angeltype)) {
         error(_("You are not allowed to delete this users angeltype."));
         redirect(page_link_to('angeltypes'));
     }
@@ -201,9 +212,9 @@ function user_angeltype_delete_controller()
     }
 
     return [
-      _("Remove angeltype"),
+        _("Remove angeltype"),
-      UserAngelType_delete_view($user_angeltype, $user_source, $angeltype)
+        UserAngelType_delete_view($user_angeltype, $user_source, $angeltype)
-  ];
+    ];
 }
 
 /**
@@ -213,12 +224,12 @@ function user_angeltype_update_controller()
 {
     global $privileges;
 
-    if (! in_array('admin_angel_types', $privileges)) {
+    if (!in_array('admin_angel_types', $privileges)) {
         error(_("You are not allowed to set supporter rights."));
         redirect(page_link_to('angeltypes'));
     }
 
-    if (! isset($_REQUEST['user_angeltype_id'])) {
+    if (!isset($_REQUEST['user_angeltype_id'])) {
         error(_("User angeltype doesn't exist."));
         redirect(page_link_to('angeltypes'));
     }
@@ -251,7 +262,11 @@ function user_angeltype_update_controller()
     if (isset($_REQUEST['confirmed'])) {
         UserAngelType_update($user_angeltype['id'], $supporter);
 
-        $success_message = sprintf($supporter ? _("Added supporter rights for %s to %s.") : _("Removed supporter rights for %s from %s."), AngelType_name_render($angeltype), User_Nick_render($user_source));
+        $success_message = sprintf(
+            $supporter ? _("Added supporter rights for %s to %s.") : _("Removed supporter rights for %s from %s."),
+            AngelType_name_render($angeltype),
+            User_Nick_render($user_source)
+        );
         engelsystem_log($success_message);
         success($success_message);
 
@@ -259,9 +274,9 @@ function user_angeltype_update_controller()
     }
 
     return [
-      $supporter ? _("Add supporter rights") : _("Remove supporter rights"),
+        $supporter ? _("Add supporter rights") : _("Remove supporter rights"),
-      UserAngelType_update_view($user_angeltype, $user_source, $angeltype, $supporter)
+        UserAngelType_update_view($user_angeltype, $user_source, $angeltype, $supporter)
-  ];
+    ];
 }
 
 /**
@@ -273,39 +288,51 @@ function user_angeltype_add_controller()
 
     $angeltype = load_angeltype();
 
-  // User is joining by itself
+    // User is joining by itself
-  if (! User_is_AngelType_supporter($user, $angeltype)) {
+    if (!User_is_AngelType_supporter($user, $angeltype)) {
-      return user_angeltype_join_controller($angeltype);
+        return user_angeltype_join_controller($angeltype);
-  }
+    }
 
-  // Allow to add any user
+    // Allow to add any user
 
-  // Default selection
+    // Default selection
-  $user_source = $user;
+    $user_source = $user;
 
-  // Load possible users, that are not in the angeltype already
+    // Load possible users, that are not in the angeltype already
-  $users_source = Users_by_angeltype_inverted($angeltype);
+    $users_source = Users_by_angeltype_inverted($angeltype);
 
     if (isset($_REQUEST['submit'])) {
         $user_source = load_user();
 
-        if (! UserAngelType_exists($user_source, $angeltype)) {
+        if (!UserAngelType_exists($user_source, $angeltype)) {
             $user_angeltype_id = UserAngelType_create($user_source, $angeltype);
 
-            engelsystem_log(sprintf("User %s added to %s.", User_Nick_render($user_source), AngelType_name_render($angeltype)));
+            engelsystem_log(sprintf(
-            success(sprintf(_("User %s added to %s."), User_Nick_render($user_source), AngelType_name_render($angeltype)));
+                "User %s added to %s.",
+                User_Nick_render($user_source),
+                AngelType_name_render($angeltype)
+            ));
+            success(sprintf(
+                _("User %s added to %s."),
+                User_Nick_render($user_source),
+                AngelType_name_render($angeltype)
+            ));
 
             UserAngelType_confirm($user_angeltype_id, $user_source);
-            engelsystem_log(sprintf("User %s confirmed as %s.", User_Nick_render($user), AngelType_name_render($angeltype)));
+            engelsystem_log(sprintf(
+                "User %s confirmed as %s.",
+                User_Nick_render($user),
+                AngelType_name_render($angeltype)
+            ));
 
             redirect(page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id']);
         }
     }
 
     return [
-      _("Add user to angeltype"),
+        _("Add user to angeltype"),
-      UserAngelType_add_view($angeltype, $users_source, $user_source['UID'])
+        UserAngelType_add_view($angeltype, $users_source, $user_source['UID'])
-  ];
+    ];
 }
 
 /**
@@ -330,16 +357,20 @@ function user_angeltype_join_controller($angeltype)
 
         if (in_array('admin_user_angeltypes', $privileges)) {
             UserAngelType_confirm($user_angeltype_id, $user);
-            engelsystem_log(sprintf("User %s confirmed as %s.", User_Nick_render($user), AngelType_name_render($angeltype)));
+            engelsystem_log(sprintf(
+                "User %s confirmed as %s.",
+                User_Nick_render($user),
+                AngelType_name_render($angeltype)
+            ));
         }
 
         redirect(page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id']);
     }
 
     return [
-      sprintf(_("Become a %s"), $angeltype['name']),
+        sprintf(_("Become a %s"), $angeltype['name']),
-      UserAngelType_join_view($user, $angeltype)
+        UserAngelType_join_view($user, $angeltype)
-  ];
+    ];
 }
 
 /**
@@ -347,24 +378,24 @@ function user_angeltype_join_controller($angeltype)
  */
 function user_angeltypes_controller()
 {
-    if (! isset($_REQUEST['action'])) {
+    if (!isset($_REQUEST['action'])) {
         redirect(page_link_to('angeltypes'));
     }
 
     switch ($_REQUEST['action']) {
-    case 'delete_all':
+        case 'delete_all':
-      return user_angeltypes_delete_all_controller();
+            return user_angeltypes_delete_all_controller();
-    case 'confirm_all':
+        case 'confirm_all':
-      return user_angeltypes_confirm_all_controller();
+            return user_angeltypes_confirm_all_controller();
-    case 'confirm':
+        case 'confirm':
-      return user_angeltype_confirm_controller();
+            return user_angeltype_confirm_controller();
-    case 'delete':
+        case 'delete':
-      return user_angeltype_delete_controller();
+            return user_angeltype_delete_controller();
-    case 'update':
+        case 'update':
-      return user_angeltype_update_controller();
+            return user_angeltype_update_controller();
-    case 'add':
+        case 'add':
-      return user_angeltype_add_controller();
+            return user_angeltype_add_controller();
-    default:
+        default:
-      redirect(page_link_to('angeltypes'));
+            redirect(page_link_to('angeltypes'));
-  }
+    }
 }

includes/controller/user_driver_licenses_controller.php

@@ -1,7 +1,8 @@
 <?php
 
 /**
- * Generates a hint, if user joined angeltypes that require a driving license and the user has no driver license information provided.
+ * Generates a hint, if user joined angeltypes that require a driving license and the user has no driver license
+ * information provided.
  */
 function user_driver_license_required_hint()
 {
@@ -10,14 +11,17 @@ function user_driver_license_required_hint()
     $angeltypes = User_angeltypes($user);
     $user_driver_license = UserDriverLicense($user['UID']);
 
-  // User has already entered data, no hint needed.
+    // User has already entered data, no hint needed.
-  if ($user_driver_license != null) {
+    if ($user_driver_license != null) {
-      return null;
+        return null;
-  }
+    }
 
     foreach ($angeltypes as $angeltype) {
         if ($angeltype['requires_driver_license']) {
-            return sprintf(_("You joined an angeltype which requires a driving license. Please edit your driving license information here: %s."), '<a href="' . user_driver_license_edit_link() . '">' . _("driving license information") . '</a>');
+            return sprintf(
+                _("You joined an angeltype which requires a driving license. Please edit your driving license information here: %s."),
+                '<a href="' . user_driver_license_edit_link() . '">' . _("driving license information") . '</a>'
+            );
         }
     }
 
@@ -31,17 +35,17 @@ function user_driver_licenses_controller()
 {
     global $user;
 
-    if (! isset($user)) {
+    if (!isset($user)) {
         redirect(page_link_to(''));
     }
 
     $action = strip_request_item('action', 'edit');
 
     switch ($action) {
-    default:
+        default:
-    case 'edit':
+        case 'edit':
-      return user_driver_license_edit_controller();
+            return user_driver_license_edit_controller();
-  }
+    }
 }
 
 /**
@@ -85,10 +89,10 @@ function user_driver_license_edit_controller()
 
     $user_source = user_driver_license_load_user();
 
-  // only privilege admin_user can edit other users driver license information
+    // only privilege admin_user can edit other users driver license information
-  if ($user['UID'] != $user_source['UID'] && ! in_array('admin_user', $privileges)) {
+    if ($user['UID'] != $user_source['UID'] && !in_array('admin_user', $privileges)) {
-      redirect(user_driver_license_edit_link());
+        redirect(user_driver_license_edit_link());
-  }
+    }
 
     $user_driver_license = UserDriverLicense($user_source['UID']);
     if ($user_driver_license == null) {
@@ -129,7 +133,7 @@ function user_driver_license_edit_controller()
     }
 
     return [
-      sprintf(_("Edit %s driving license information"), $user_source['Nick']),
+        sprintf(_("Edit %s driving license information"), $user_source['Nick']),
-      UserDriverLicense_edit_view($user_source, $wants_to_drive, $user_driver_license)
+        UserDriverLicense_edit_view($user_source, $wants_to_drive, $user_driver_license)
-  ];
+    ];
 }

includes/controller/users_controller.php

@@ -1,6 +1,6 @@
 <?php
-use Engelsystem\ShiftsFilter;
 use Engelsystem\ShiftCalendarRenderer;
+use Engelsystem\ShiftsFilter;
 
 /**
  * Route user actions.
@@ -9,27 +9,27 @@ function users_controller()
 {
     global $user;
 
-    if (! isset($user)) {
+    if (!isset($user)) {
         redirect(page_link_to(''));
     }
 
-    if (! isset($_REQUEST['action'])) {
+    if (!isset($_REQUEST['action'])) {
         $_REQUEST['action'] = 'list';
     }
 
     switch ($_REQUEST['action']) {
-    default:
+        default:
-    case 'list':
+        case 'list':
-      return users_list_controller();
+            return users_list_controller();
-    case 'view':
+        case 'view':
-      return user_controller();
+            return user_controller();
-    case 'edit':
+        case 'edit':
-      return user_edit_controller();
+            return user_edit_controller();
-    case 'delete':
+        case 'delete':
-      return user_delete_controller();
+            return user_delete_controller();
-    case 'edit_vouchers':
+        case 'edit_vouchers':
-      return user_edit_vouchers_controller();
+            return user_edit_vouchers_controller();
-  }
+    }
 }
 
 /**
@@ -45,20 +45,22 @@ function user_delete_controller()
         $user_source = $user;
     }
 
-    if (! in_array('admin_user', $privileges)) {
+    if (!in_array('admin_user', $privileges)) {
         redirect(page_link_to(''));
     }
 
-  // You cannot delete yourself
+    // You cannot delete yourself
-  if ($user['UID'] == $user_source['UID']) {
+    if ($user['UID'] == $user_source['UID']) {
-      error(_("You cannot delete yourself."));
+        error(_("You cannot delete yourself."));
-      redirect(user_link($user));
+        redirect(user_link($user));
-  }
+    }
 
     if (isset($_REQUEST['submit'])) {
         $valid = true;
 
-        if (! (isset($_REQUEST['password']) && verify_password($_REQUEST['password'], $user['Passwort'], $user['UID']))) {
+        if (!(isset($_REQUEST['password']) && verify_password($_REQUEST['password'], $user['Passwort'],
+                $user['UID']))
+        ) {
             $valid = false;
             error(_("Your password is incorrect.  Please try it again."));
         }
@@ -78,9 +80,9 @@ function user_delete_controller()
     }
 
     return [
-      sprintf(_("Delete %s"), $user_source['Nick']),
+        sprintf(_("Delete %s"), $user_source['Nick']),
-      User_delete_view($user_source)
+        User_delete_view($user_source)
-  ];
+    ];
 }
 
 function users_link()
@@ -113,7 +115,7 @@ function user_edit_vouchers_controller()
         $user_source = $user;
     }
 
-    if (! in_array('admin_user', $privileges)) {
+    if (!in_array('admin_user', $privileges)) {
         redirect(page_link_to(''));
     }
 
@@ -136,16 +138,17 @@ function user_edit_vouchers_controller()
             }
 
             success(_("Saved the number of vouchers."));
-            engelsystem_log(User_Nick_render($user_source) . ': ' . sprintf("Got %s vouchers", $user_source['got_voucher']));
+            engelsystem_log(User_Nick_render($user_source) . ': ' . sprintf("Got %s vouchers",
+                    $user_source['got_voucher']));
 
             redirect(user_link($user_source));
         }
     }
 
     return [
-      sprintf(_("%s's vouchers"), $user_source['Nick']),
+        sprintf(_("%s's vouchers"), $user_source['Nick']),
-      User_edit_vouchers_view($user_source)
+        User_edit_vouchers_view($user_source)
-  ];
+    ];
 }
 
 function user_controller()
@@ -164,7 +167,7 @@ function user_controller()
     $shifts = Shifts_by_user($user_source, in_array("user_shifts_admin", $privileges));
     foreach ($shifts as &$shift) {
         // TODO: Move queries to model
-    $shift['needed_angeltypes'] = sql_select("SELECT DISTINCT `AngelTypes`.* FROM `ShiftEntry` JOIN `AngelTypes` ON `ShiftEntry`.`TID`=`AngelTypes`.`id` WHERE `ShiftEntry`.`SID`='" . sql_escape($shift['SID']) . "'  ORDER BY `AngelTypes`.`name`");
+        $shift['needed_angeltypes'] = sql_select("SELECT DISTINCT `AngelTypes`.* FROM `ShiftEntry` JOIN `AngelTypes` ON `ShiftEntry`.`TID`=`AngelTypes`.`id` WHERE `ShiftEntry`.`SID`='" . sql_escape($shift['SID']) . "'  ORDER BY `AngelTypes`.`name`");
         foreach ($shift['needed_angeltypes'] as &$needed_angeltype) {
             $needed_angeltype['users'] = sql_select("
           SELECT `ShiftEntry`.`freeloaded`, `User`.*
@@ -180,9 +183,17 @@ function user_controller()
     }
 
     return [
-      $user_source['Nick'],
+        $user_source['Nick'],
-      User_view($user_source, in_array('admin_user', $privileges), User_is_freeloader($user_source), User_angeltypes($user_source), User_groups($user_source), $shifts, $user['UID'] == $user_source['UID'])
+        User_view(
-  ];
+            $user_source,
+            in_array('admin_user', $privileges),
+            User_is_freeloader($user_source),
+            User_angeltypes($user_source),
+            User_groups($user_source),
+            $shifts,
+            $user['UID'] == $user_source['UID']
+        )
+    ];
 }
 
 /**
@@ -192,7 +203,7 @@ function users_list_controller()
 {
     global $privileges;
 
-    if (! in_array('admin_user', $privileges)) {
+    if (!in_array('admin_user', $privileges)) {
         redirect(page_link_to(''));
     }
 
@@ -211,9 +222,18 @@ function users_list_controller()
     }
 
     return [
-      _('All users'),
+        _('All users'),
-      Users_view($users, $order_by, User_arrived_count(), User_active_count(), User_force_active_count(), ShiftEntries_freeleaded_count(), User_tshirts_count(), User_got_voucher_count())
+        Users_view(
-  ];
+            $users,
+            $order_by,
+            User_arrived_count(),
+            User_active_count(),
+            User_force_active_count(),
+            ShiftEntries_freeleaded_count(),
+            User_tshirts_count(),
+            User_got_voucher_count()
+        )
+    ];
 }
 
 /**
@@ -278,7 +298,14 @@ function user_password_recovery_start_controller()
 
         if ($valid) {
             $token = User_generate_password_recovery_token($user_source);
-            engelsystem_email_to_user($user_source, _("Password recovery"), sprintf(_("Please visit %s to recover your password."), page_link_to_absolute('user_password_recovery') . '&token=' . $token));
+            engelsystem_email_to_user(
+                $user_source,
+                _("Password recovery"),
+                sprintf(
+                    _("Please visit %s to recover your password."),
+                    page_link_to_absolute('user_password_recovery') . '&token=' . $token
+                )
+            );
             success(_("We sent an email containing your password recovery link."));
             redirect(page_link_to('login'));
         }
@@ -313,7 +340,7 @@ function user_password_recovery_title()
  */
 function load_user()
 {
-    if (! isset($_REQUEST['user_id'])) {
+    if (!isset($_REQUEST['user_id'])) {
         redirect(page_link_to());
     }
 
@@ -355,7 +382,10 @@ function shiftCalendarRendererByShiftFilter(ShiftsFilter $shiftsFilter)
     unset($needed_angeltypes_source);
     unset($shift_entries_source);
 
-    if (in_array(ShiftsFilter::FILLED_FREE, $shiftsFilter->getFilled()) && in_array(ShiftsFilter::FILLED_FILLED, $shiftsFilter->getFilled())) {
+    if (
+        in_array(ShiftsFilter::FILLED_FREE, $shiftsFilter->getFilled())
+        && in_array(ShiftsFilter::FILLED_FILLED, $shiftsFilter->getFilled())
+    ) {
         return new ShiftCalendarRenderer($shifts, $needed_angeltypes, $shift_entries, $shiftsFilter);
     }
 
@@ -366,7 +396,7 @@ function shiftCalendarRendererByShiftFilter(ShiftsFilter $shiftsFilter)
             $taken = 0;
             foreach ($shift_entries[$shift['SID']] as $shift_entry) {
                 if ($needed_angeltype['angel_type_id'] == $shift_entry['TID'] && $shift_entry['freeloaded'] == 0) {
-                    $taken ++;
+                    $taken++;
                 }
             }
 

includes/helper/email_helper.php

@@ -10,7 +10,10 @@ function engelsystem_email_to_user($recipient_user, $title, $message, $not_if_it
 
     gettext_locale($recipient_user['Sprache']);
 
-    $message = sprintf(_("Hi %s,"), $recipient_user['Nick']) . "\n\n" . _("here is a message for you from the engelsystem:") . "\n\n" . $message . "\n\n" . _("This email is autogenerated and has not to be signed. You got this email because you are registered in the engelsystem.");
+    $message = sprintf(_("Hi %s,"), $recipient_user['Nick']) . "\n\n"
+        . _("here is a message for you from the engelsystem:") . "\n\n"
+        . $message . "\n\n"
+        . _("This email is autogenerated and has not to be signed. You got this email because you are registered in the engelsystem.");
 
     gettext_locale();
     return engelsystem_email($recipient_user['email'], $title, $message);
@@ -18,7 +21,8 @@ function engelsystem_email_to_user($recipient_user, $title, $message, $not_if_it
 
 function engelsystem_email($address, $title, $message)
 {
-    $result = mail($address, $title, $message, "Content-Type: text/plain; charset=UTF-8\r\nFrom: Engelsystem <noreply@engelsystem.de>");
+    $result = mail($address, $title, $message,
+        "Content-Type: text/plain; charset=UTF-8\r\nFrom: Engelsystem <noreply@engelsystem.de>");
     if ($result === false) {
         engelsystem_error('Unable to send email.');
     }

includes/helper/graph_helper.php

@@ -2,10 +2,11 @@
 
 /**
  * Renders a bargraph
- * @param string $key keyname of the x-axis
+ *
- * @param array $row_names keynames for the data rows
+ * @param string  $key       keyname of the x-axis
- * @param unknown $colors colors for the data rows
+ * @param array   $row_names keynames for the data rows
- * @param unknown $data the data
+ * @param unknown $colors    colors for the data rows
+ * @param unknown $data      the data
  */
 function bargraph($dom_id, $key, $row_names, $colors, $data)
 {
@@ -21,10 +22,10 @@ function bargraph($dom_id, $key, $row_names, $colors, $data)
             $values[] = $dataset[$row_key];
         }
         $datasets[] = [
-        'label' => $name,
+            'label'     => $name,
-        'fillColor' => $colors[$row_key],
+            'fillColor' => $colors[$row_key],
-        'data' => $values
+            'data'      => $values
-    ];
+        ];
     }
 
     return '<canvas id="' . $dom_id . '" style="width: 100%; height: 300px;"></canvas>
@@ -32,9 +33,9 @@ function bargraph($dom_id, $key, $row_names, $colors, $data)
       $(function(){
         var ctx = $("#' . $dom_id . '").get(0).getContext("2d");
         var chart = new Chart(ctx).Bar(' . json_encode([
-      'labels' => $labels,
+            'labels'   => $labels,
-      'datasets' => $datasets
+            'datasets' => $datasets
-  ]) . ');
+        ]) . ');
       });
       </script>';
 }

includes/helper/internationalization_helper.php

@@ -31,7 +31,7 @@ function gettext_init()
 
     if (isset($_REQUEST['set_locale']) && isset($locales[$_REQUEST['set_locale']])) {
         $_SESSION['locale'] = $_REQUEST['set_locale'];
-    } elseif (! isset($_SESSION['locale'])) {
+    } elseif (!isset($_SESSION['locale'])) {
         $_SESSION['locale'] = $default_locale;
     }
 
@@ -68,7 +68,11 @@ function make_langselect()
 
     $items = [];
     foreach ($locales as $locale => $name) {
-        $items[] = toolbar_item_link(htmlspecialchars($URL) . $locale, '', '<img src="pic/flag/' . $locale . '.png" alt="' . $name . '" title="' . $name . '"> ' . $name);
+        $items[] = toolbar_item_link(
+            htmlspecialchars($URL) . $locale,
+            '',
+            '<img src="pic/flag/' . $locale . '.png" alt="' . $name . '" title="' . $name . '"> ' . $name
+        );
     }
     return $items;
 }

includes/helper/message_helper.php

@@ -5,7 +5,7 @@
  */
 function msg()
 {
-    if (! isset($_SESSION['msg'])) {
+    if (!isset($_SESSION['msg'])) {
         return "";
     }
     $msg = $_SESSION['msg'];
@@ -49,7 +49,7 @@ function alert($class, $msg, $immediatly = false)
         return '<div class="alert alert-' . $class . '">' . $msg . '</div>';
     }
 
-    if (! isset($_SESSION['msg'])) {
+    if (!isset($_SESSION['msg'])) {
         $_SESSION['msg'] = "";
     }
     $_SESSION['msg'] .= alert($class, $msg, true);

includes/mailer/shifts_mailer.php

@@ -22,12 +22,20 @@ function mail_shift_change($old_shift, $new_shift)
     }
 
     if ($old_shift["start"] != $new_shift["start"]) {
-        $message .= sprintf(_("* Shift Start changed from %s to %s"), date("Y-m-d H:i", $old_shift["start"]), date("Y-m-d H:i", $new_shift["start"])) . "\n";
+        $message .= sprintf(
+                _("* Shift Start changed from %s to %s"),
+                date("Y-m-d H:i", $old_shift["start"]),
+                date("Y-m-d H:i", $new_shift["start"])
+            ) . "\n";
         $noticable_changes = true;
     }
 
     if ($old_shift["end"] != $new_shift["end"]) {
-        $message .= sprintf(_("* Shift End changed from %s to %s"), date("Y-m-d H:i", $old_shift["end"]), date("Y-m-d H:i", $new_shift["end"])) . "\n";
+        $message .= sprintf(
+                _("* Shift End changed from %s to %s"),
+                date("Y-m-d H:i", $old_shift["end"]),
+                date("Y-m-d H:i", $new_shift["end"])
+            ) . "\n";
         $noticable_changes = true;
     }
 
@@ -36,9 +44,9 @@ function mail_shift_change($old_shift, $new_shift)
         $noticable_changes = true;
     }
 
-    if (! $noticable_changes) {
+    if (!$noticable_changes) {
         // There are no changes worth sending an E-Mail
-    return;
+        return;
     }
 
     $message .= "\n";

includes/mailer/users_mailer.php

@@ -5,5 +5,9 @@
  */
 function mail_user_delete($user)
 {
-    engelsystem_email_to_user($user, '[engelsystem] ' . _("Your account has been deleted"), _("Your angelsystem account has been deleted. If you have any questions regarding your account deletion, please contact heaven."));
+    engelsystem_email_to_user(
+        $user,
+        '[engelsystem] ' . _("Your account has been deleted"),
+        _("Your angelsystem account has been deleted. If you have any questions regarding your account deletion, please contact heaven.")
+    );
 }

includes/model/AngelType_model.php

@@ -8,17 +8,17 @@ use Engelsystem\ValidationResult;
 function AngelType_new()
 {
     return [
-      'id' => null,
+        'id'                      => null,
-      'name' => "",
+        'name'                    => "",
-      'restricted' => false,
+        'restricted'              => false,
-      'no_self_signup' => false,
+        'no_self_signup'          => false,
-      'description' => '',
+        'description'             => '',
-      'requires_driver_license' => false,
+        'requires_driver_license' => false,
-      'contact_user_id' => null,
+        'contact_user_id'         => null,
-      'contact_name' => null,
+        'contact_name'            => null,
-      'contact_dect' => null,
+        'contact_dect'            => null,
-      'contact_email' => null
+        'contact_email'           => null
-  ];
+    ];
 }
 
 /**
@@ -30,7 +30,7 @@ function AngelType_new()
  */
 function AngelType_validate_contact_user_id($angeltype)
 {
-    if (! isset($angeltype['contact_user_id'])) {
+    if (!isset($angeltype['contact_user_id'])) {
         return new ValidationResult(true, null);
     }
     if (isset($angeltype['contact_name']) || isset($angeltype['contact_dect']) || isset($angeltype['contact_email'])) {
@@ -53,9 +53,9 @@ function AngelType_contact_info($angeltype)
     if (isset($angeltype['contact_user_id'])) {
         $contact_user = User($angeltype['contact_user_id']);
         $contact_data = [
-        'contact_name' => $contact_user['Nick'],
+            'contact_name' => $contact_user['Nick'],
-        'contact_dect' => $contact_user['DECT']
+            'contact_dect' => $contact_user['DECT']
-    ];
+        ];
         if ($contact_user['email_by_human_allowed']) {
             $contact_data['contact_email'] = $contact_user['email'];
         }
@@ -63,10 +63,10 @@ function AngelType_contact_info($angeltype)
     }
     if (isset($angeltype['contact_name'])) {
         return [
-        'contact_name' => $angeltype['contact_name'],
+            'contact_name'  => $angeltype['contact_name'],
-        'contact_dect' => $angeltype['contact_dect'],
+            'contact_dect'  => $angeltype['contact_dect'],
-        'contact_email' => $angeltype['contact_email']
+            'contact_email' => $angeltype['contact_email']
-    ];
+        ];
     }
     return null;
 }
@@ -148,7 +148,7 @@ function AngelType_create($angeltype)
  * Validates a name for angeltypes.
  * Returns ValidationResult containing validation success and validated name.
  *
- * @param string $name
+ * @param string    $name
  *          Wanted name for the angeltype
  * @param AngelType $angeltype
  *          The angeltype the name is for
@@ -186,7 +186,7 @@ function AngelTypes_with_user($user)
 {
     $result = sql_select("
       SELECT `AngelTypes`.*, 
-      `UserAngelTypes`.`id` as `user_angeltype_id`,
+      `UserAngelTypes`.`id` AS `user_angeltype_id`,
       `UserAngelTypes`.`confirm_user_id`,
       `UserAngelTypes`.`supporter`
       FROM `AngelTypes` 
@@ -230,7 +230,7 @@ function AngelType_ids()
  * Returns angelType by id.
  *
  * @param $angeltype_id angelType
- *          ID
+ *                      ID
  */
 function AngelType($angeltype_id)
 {

includes/model/EventConfig_model.php

@@ -20,14 +20,20 @@ function EventConfig()
  * Update event config.
  *
  * @param string $event_name
- * @param int $buildup_start_date
+ * @param int    $buildup_start_date
- * @param int $event_start_date
+ * @param int    $event_start_date
- * @param int $event_end_date
+ * @param int    $event_end_date
- * @param int $teardown_end_date
+ * @param int    $teardown_end_date
  * @param string $event_welcome_msg
  */
-function EventConfig_update($event_name, $buildup_start_date, $event_start_date, $event_end_date, $teardown_end_date, $event_welcome_msg)
+function EventConfig_update(
-{
+    $event_name,
+    $buildup_start_date,
+    $event_start_date,
+    $event_end_date,
+    $teardown_end_date,
+    $event_welcome_msg
+) {
     if (EventConfig() == null) {
         return sql_query("INSERT INTO `EventConfig` SET
       `event_name`=" . sql_null($event_name) . ",

includes/model/LogEntries_model.php

@@ -3,9 +3,9 @@
 /**
  * Creates a log entry.
  *
- * @param $nick Username
+ * @param $nick    Username
  * @param $message Log
- *          Message
+ *                 Message
  */
 function LogEntry_create($nick, $message)
 {

includes/model/Message_model.php

@@ -12,7 +12,7 @@ function Message_ids()
  * Returns message by id.
  *
  * @param $message_id message
- *          ID
+ *                    ID
  */
 function Message($message_id)
 {
@@ -32,9 +32,9 @@ function Message($message_id)
  * send message
  *
  * @param $receiver_user_id User
- *          ID of Reciever
+ *                          ID of Reciever
- * @param $text Text
+ * @param $text             Text
- *          of Message
+ *                          of Message
  */
 function Message_send($receiver_user_id, $text)
 {
@@ -43,8 +43,23 @@ function Message_send($receiver_user_id, $text)
     $text = preg_replace("/([^\p{L}\p{P}\p{Z}\p{N}\n]{1,})/ui", '', strip_tags($text));
     $receiver_user_id = preg_replace("/([^0-9]{1,})/ui", '', strip_tags($receiver_user_id));
 
-    if (($text != "" && is_numeric($receiver_user_id)) && (sql_num_query("SELECT * FROM `User` WHERE `UID`='" . sql_escape($receiver_user_id) . "' AND NOT `UID`='" . sql_escape($user['UID']) . "' LIMIT 1") > 0)) {
+    if (
-        sql_query("INSERT INTO `Messages` SET `Datum`='" . sql_escape(time()) . "', `SUID`='" . sql_escape($user['UID']) . "', `RUID`='" . sql_escape($receiver_user_id) . "', `Text`='" . sql_escape($text) . "'");
+        ($text != "" && is_numeric($receiver_user_id))
+        && (sql_num_query("
+            SELECT *
+            FROM `User`
+            WHERE `UID`='" . sql_escape($receiver_user_id) . "'
+            AND NOT `UID`='" . sql_escape($user['UID']) . "'
+            LIMIT 1
+        ") > 0)
+    ) {
+        sql_query("
+            INSERT INTO `Messages`
+            SET `Datum`='" . sql_escape(time()) . "',
+                `SUID`='" . sql_escape($user['UID']) . "',
+                `RUID`='" . sql_escape($receiver_user_id) . "',
+                `Text`='" . sql_escape($text) . "'
+        ");
         return true;
     }
 

includes/model/NeededAngelTypes_model.php

@@ -72,9 +72,9 @@ function NeededAngelTypes_by_shift($shiftId)
         engelsystem_error("Unable to load needed angeltypes.");
     }
 
-  // Use settings from room
+    // Use settings from room
-  if (count($needed_angeltypes_source) == 0) {
+    if (count($needed_angeltypes_source) == 0) {
-      $needed_angeltypes_source = sql_select("
+        $needed_angeltypes_source = sql_select("
         SELECT `NeededAngelTypes`.*, `AngelTypes`.`name`, `AngelTypes`.`restricted`
         FROM `NeededAngelTypes`
         JOIN `AngelTypes` ON `AngelTypes`.`id` = `NeededAngelTypes`.`angel_type_id`
@@ -83,10 +83,10 @@ function NeededAngelTypes_by_shift($shiftId)
         AND `count` > 0
         ORDER BY `room_id` DESC
         ");
-      if ($needed_angeltypes_source === false) {
+        if ($needed_angeltypes_source === false) {
-          engelsystem_error("Unable to load needed angeltypes.");
+            engelsystem_error("Unable to load needed angeltypes.");
-      }
+        }
-  }
+    }
 
     $shift_entries = ShiftEntries_by_shift($shiftId);
     $needed_angeltypes = [];
@@ -95,7 +95,7 @@ function NeededAngelTypes_by_shift($shiftId)
         $angeltype['taken'] = 0;
         foreach ($shift_entries as $shift_entry) {
             if ($shift_entry['TID'] == $angeltype['angel_type_id'] && $shift_entry['freeloaded'] == 0) {
-                $angeltype['taken'] ++;
+                $angeltype['taken']++;
                 $angeltype['shift_entries'][] = $shift_entry;
             }
         }

includes/model/Room_model.php

@@ -2,6 +2,7 @@
 
 /**
  * returns a list of rooms.
+ *
  * @param boolean $show_all returns also hidden rooms when true
  */
 function Rooms($show_all = false)
@@ -22,7 +23,7 @@ function Room_delete($room_id)
 /**
  * Create a new room
  *
- * @param string $name
+ * @param string  $name
  *          Name of the room
  * @param boolean $from_frab
  *          Is this a frab imported room?

includes/model/ShiftEntry_model.php

@@ -7,14 +7,14 @@
 function ShiftEntry_new()
 {
     return [
-      'id' => null,
+        'id'                 => null,
-      'SID' => null,
+        'SID'                => null,
-      'TID' => null,
+        'TID'                => null,
-      'UID' => null,
+        'UID'                => null,
-      'Comment' => null,
+        'Comment'            => null,
-      'freeloaded_comment' => null,
+        'freeloaded_comment' => null,
-      'freeloaded' => false
+        'freeloaded'         => false
-  ];
+    ];
 }
 
 /**
@@ -31,7 +31,18 @@ function ShiftEntries_freeleaded_count()
 function ShiftEntries_by_shift($shift_id)
 {
     return sql_select("
-      SELECT `User`.`Nick`, `User`.`email`, `User`.`email_shiftinfo`, `User`.`Sprache`, `User`.`Gekommen`, `ShiftEntry`.`UID`, `ShiftEntry`.`TID`, `ShiftEntry`.`SID`, `AngelTypes`.`name` as `angel_type_name`, `ShiftEntry`.`Comment`, `ShiftEntry`.`freeloaded`
+      SELECT
+          `User`.`Nick`,
+          `User`.`email`,
+          `User`.`email_shiftinfo`,
+          `User`.`Sprache`,
+          `User`.`Gekommen`,
+          `ShiftEntry`.`UID`,
+          `ShiftEntry`.`TID`,
+          `ShiftEntry`.`SID`,
+          `AngelTypes`.`name` AS `angel_type_name`,
+          `ShiftEntry`.`Comment`,
+          `ShiftEntry`.`freeloaded`
       FROM `ShiftEntry`
       JOIN `User` ON `ShiftEntry`.`UID`=`User`.`UID`
       JOIN `AngelTypes` ON `ShiftEntry`.`TID`=`AngelTypes`.`id`

includes/model/ShiftSignupState.php

@@ -9,40 +9,40 @@ namespace Engelsystem;
 class ShiftSignupState
 {
 
-  /**
+    /**
-   * Shift has free places
+     * Shift has free places
-   */
+     */
-  const FREE = 'FREE';
+    const FREE = 'FREE';
-
+
-  /**
+    /**
-   * Shift collides with users shifts
+     * Shift collides with users shifts
-   */
+     */
-  const COLLIDES = 'COLLIDES';
+    const COLLIDES = 'COLLIDES';
-
+
-  /**
+    /**
-   * User cannot join because of a restricted angeltype or user is not in the angeltype
+     * User cannot join because of a restricted angeltype or user is not in the angeltype
-   */
+     */
-  const ANGELTYPE = 'ANGELTYPE';
+    const ANGELTYPE = 'ANGELTYPE';
-
+
-  /**
+    /**
-   * Shift is full
+     * Shift is full
-   */
+     */
-  const OCCUPIED = 'OCCUPIED';
+    const OCCUPIED = 'OCCUPIED';
-
+
-  /**
+    /**
-   * User is admin and can do what he wants.
+     * User is admin and can do what he wants.
-   */
+     */
-  const ADMIN = 'ADMIN';
+    const ADMIN = 'ADMIN';
-
+
-  /**
+    /**
-   * Shift has already ended, no signup
+     * Shift has already ended, no signup
-   */
+     */
-  const SHIFT_ENDED = 'SHIFT_ENDED';
+    const SHIFT_ENDED = 'SHIFT_ENDED';
-
+
-  /**
+    /**
-   * User is already signed up
+     * User is already signed up
-   */
+     */
-  const SIGNED_UP = 'SIGNED_UP';
+    const SIGNED_UP = 'SIGNED_UP';
 
     private $state;
 
@@ -54,69 +54,69 @@ class ShiftSignupState
         $this->freeEntries = $free_entries;
     }
 
-  /**
+    /**
-   * Combine this state with another state from the same shift.
+     * Combine this state with another state from the same shift.
-   *
+     *
-   * @param ShiftSignupState $shiftSignupState
+     * @param ShiftSignupState $shiftSignupState
-   *          The other state to combine
+     *          The other state to combine
-   */
+     */
-  public function combineWith(ShiftSignupState $shiftSignupState)
+    public function combineWith(ShiftSignupState $shiftSignupState)
-  {
+    {
-      $this->freeEntries += $shiftSignupState->getFreeEntries();
+        $this->freeEntries += $shiftSignupState->getFreeEntries();
-    
+
-      if ($this->valueForState($shiftSignupState->state) > $this->valueForState($this->state)) {
+        if ($this->valueForState($shiftSignupState->state) > $this->valueForState($this->state)) {
-          $this->state = $shiftSignupState->state;
+            $this->state = $shiftSignupState->state;
-      }
+        }
-  }
+    }
 
     private function valueForState($state)
     {
         switch ($state) {
-      case ShiftSignupState::SHIFT_ENDED:
+            case ShiftSignupState::SHIFT_ENDED:
-        return 100;
+                return 100;
 
-      case ShiftSignupState::SIGNED_UP:
+            case ShiftSignupState::SIGNED_UP:
-        return 90;
+                return 90;
 
-      case ShiftSignupState::FREE:
+            case ShiftSignupState::FREE:
-        return 80;
+                return 80;
 
-      case ShiftSignupState::ANGELTYPE:
+            case ShiftSignupState::ANGELTYPE:
-      case ShiftSignupState::COLLIDES:
+            case ShiftSignupState::COLLIDES:
-        return 70;
+                return 70;
 
-      case ShiftSignupState::OCCUPIED:
+            case ShiftSignupState::OCCUPIED:
-      case ShiftSignupState::ADMIN:
+            case ShiftSignupState::ADMIN:
-        return 60;
+                return 60;
+        }
     }
+
+    /**
+     * Returns true, if signup is allowed
+     */
+    public function isSignupAllowed()
+    {
+        switch ($this->state) {
+            case ShiftSignupState::FREE:
+            case ShiftSignupState::ADMIN:
+                return true;
+        }
+        return false;
     }
 
-  /**
+    /**
-   * Returns true, if signup is allowed
+     * Return the shift signup state
-   */
+     */
-  public function isSignupAllowed()
+    public function getState()
-  {
+    {
-      switch ($this->state) {
+        return $this->state;
-      case ShiftSignupState::FREE:
+    }
-      case ShiftSignupState::ADMIN:
+
-        return true;
+    /**
+     * How many places are free in this shift for the angeltype?
+     */
+    public function getFreeEntries()
+    {
+        return $this->freeEntries;
     }
-      return false;
-  }
-
-  /**
-   * Return the shift signup state
-   */
-  public function getState()
-  {
-      return $this->state;
-  }
-
-  /**
-   * How many places are free in this shift for the angeltype?
-   */
-  public function getFreeEntries()
-  {
-      return $this->freeEntries;
-  }
 }

includes/model/ShiftTypes_model.php

@@ -2,6 +2,7 @@
 
 /**
  * Delete a shift type.
+ *
  * @param int $shifttype_id
  */
 function ShiftType_delete($shifttype_id)
@@ -12,34 +13,38 @@ function ShiftType_delete($shifttype_id)
 /**
  * Update a shift type.
  *
- * @param int $shifttype_id
+ * @param int    $shifttype_id
  * @param string $name
- * @param int $angeltype_id
+ * @param int    $angeltype_id
  * @param string $description
  */
 function ShiftType_update($shifttype_id, $name, $angeltype_id, $description)
 {
-    return sql_query("UPDATE `ShiftTypes` SET
+    return sql_query("
+      UPDATE `ShiftTypes` SET
       `name`='" . sql_escape($name) . "', 
       `angeltype_id`=" . sql_null($angeltype_id) . ",
       `description`='" . sql_escape($description) . "'
-      WHERE `id`='" . sql_escape($shifttype_id) . "'");
+      WHERE `id`='" . sql_escape($shifttype_id) . "'
+    ");
 }
 
 /**
  * Create a shift type.
  *
  * @param string $name
- * @param int $angeltype_id
+ * @param int    $angeltype_id
  * @param string $description
  * @return new shifttype id
  */
 function ShiftType_create($name, $angeltype_id, $description)
 {
-    $result = sql_query("INSERT INTO `ShiftTypes` SET
+    $result = sql_query("
+      INSERT INTO `ShiftTypes` SET
       `name`='" . sql_escape($name) . "', 
       `angeltype_id`=" . sql_null($angeltype_id) . ",
-      `description`='" . sql_escape($description) . "'");
+      `description`='" . sql_escape($description) . "'
+    ");
     if ($result === false) {
         return false;
     }

includes/model/ShiftsFilter.php

@@ -10,28 +10,28 @@ namespace Engelsystem;
 class ShiftsFilter
 {
 
-  /**
+    /**
-   * How long can the time interval be?
+     * How long can the time interval be?
-   */
+     */
-  const MAX_DURATION = 86400;
+    const MAX_DURATION = 86400;
- // one day
+    // one day
-  
+
-  /**
+    /**
-   * Shift is completely full.
+     * Shift is completely full.
-   */
+     */
-  const FILLED_FILLED = 1;
+    const FILLED_FILLED = 1;
-
+
-  /**
+    /**
-   * Shift has some free slots.
+     * Shift has some free slots.
-   */
+     */
-  const FILLED_FREE = 0;
+    const FILLED_FREE = 0;
-
+
-  /**
+    /**
-   * Has the user "user shifts admin" privilege?
+     * Has the user "user shifts admin" privilege?
-   *
+     *
-   * @var boolean
+     * @var boolean
-   */
+     */
-  private $userShiftsAdmin;
+    private $userShiftsAdmin;
 
     private $filled = [];
 
@@ -50,8 +50,8 @@ class ShiftsFilter
         $this->types = $types;
 
         $this->filled = [
-        ShiftsFilter::FILLED_FREE
+            ShiftsFilter::FILLED_FREE
-    ];
+        ];
 
         if ($user_shifts_admin) {
             $this->filled[] = ShiftsFilter::FILLED_FILLED;
@@ -84,9 +84,7 @@ class ShiftsFilter
     public function getTypes()
     {
         if (count($this->types) == 0) {
-            return [
+            return [0];
-          0
-      ];
         }
         return $this->types;
     }
@@ -99,9 +97,7 @@ class ShiftsFilter
     public function getRooms()
     {
         if (count($this->rooms) == 0) {
-            return [
+            return [0];
-          0
-      ];
         }
         return $this->rooms;
     }

includes/model/Shifts_model.php

@@ -14,7 +14,7 @@ function Shifts_by_room($room)
 function Shifts_by_ShiftsFilter(ShiftsFilter $shiftsFilter)
 {
     $SQL = "SELECT * FROM (
-      SELECT DISTINCT `Shifts`.*, `ShiftTypes`.`name`, `Room`.`Name` as `room_name`
+      SELECT DISTINCT `Shifts`.*, `ShiftTypes`.`name`, `Room`.`Name` AS `room_name`
       FROM `Shifts`
       JOIN `Room` USING (`RID`)
       JOIN `ShiftTypes` ON `ShiftTypes`.`id` = `Shifts`.`shifttype_id`
@@ -27,7 +27,7 @@ function Shifts_by_ShiftsFilter(ShiftsFilter $shiftsFilter)
       
       UNION
       
-      SELECT DISTINCT `Shifts`.*, `ShiftTypes`.`name`, `Room`.`Name` as `room_name`
+      SELECT DISTINCT `Shifts`.*, `ShiftTypes`.`name`, `Room`.`Name` AS `room_name`
       FROM `Shifts`
       JOIN `Room` USING (`RID`)
       JOIN `ShiftTypes` ON `ShiftTypes`.`id` = `Shifts`.`shifttype_id`
@@ -36,7 +36,7 @@ function Shifts_by_ShiftsFilter(ShiftsFilter $shiftsFilter)
       AND `start` BETWEEN " . $shiftsFilter->getStartTime() . " AND " . $shiftsFilter->getEndTime() . "
       AND `NeededAngelTypes`.`angel_type_id` IN (" . implode(',', $shiftsFilter->getTypes()) . ")
       AND `NeededAngelTypes`.`count` > 0
-      AND NOT `Shifts`.`PSID` IS NULL) as tmp_shifts
+      AND NOT `Shifts`.`PSID` IS NULL) AS tmp_shifts
           
       ORDER BY `start`";
     $result = sql_select($SQL);
@@ -48,7 +48,14 @@ function Shifts_by_ShiftsFilter(ShiftsFilter $shiftsFilter)
 
 function NeededAngeltypes_by_ShiftsFilter(ShiftsFilter $shiftsFilter)
 {
-    $SQL = "SELECT `NeededAngelTypes`.*, `Shifts`.`SID`, `AngelTypes`.`id`, `AngelTypes`.`name`, `AngelTypes`.`restricted`, `AngelTypes`.`no_self_signup`
+    $SQL = "
+      SELECT
+          `NeededAngelTypes`.*,
+          `Shifts`.`SID`,
+          `AngelTypes`.`id`,
+          `AngelTypes`.`name`,
+          `AngelTypes`.`restricted`,
+          `AngelTypes`.`no_self_signup`
       FROM `Shifts`
       JOIN `NeededAngelTypes` ON `NeededAngelTypes`.`shift_id`=`Shifts`.`SID`
       JOIN `AngelTypes` ON `AngelTypes`.`id`= `NeededAngelTypes`.`angel_type_id`
@@ -58,7 +65,13 @@ function NeededAngeltypes_by_ShiftsFilter(ShiftsFilter $shiftsFilter)
 
       UNION
 
-      SELECT `NeededAngelTypes`.*, `Shifts`.`SID`, `AngelTypes`.`id`, `AngelTypes`.`name`, `AngelTypes`.`restricted`, `AngelTypes`.`no_self_signup`
+      SELECT
+            `NeededAngelTypes`.*,
+            `Shifts`.`SID`,
+            `AngelTypes`.`id`,
+            `AngelTypes`.`name`,
+            `AngelTypes`.`restricted`,
+            `AngelTypes`.`no_self_signup`
       FROM `Shifts`
       JOIN `NeededAngelTypes` ON `NeededAngelTypes`.`room_id`=`Shifts`.`RID`
       JOIN `AngelTypes` ON `AngelTypes`.`id`= `NeededAngelTypes`.`angel_type_id`
@@ -74,7 +87,14 @@ function NeededAngeltypes_by_ShiftsFilter(ShiftsFilter $shiftsFilter)
 
 function NeededAngeltype_by_Shift_and_Angeltype($shift, $angeltype)
 {
-    $result = sql_select("SELECT `NeededAngelTypes`.*, `Shifts`.`SID`, `AngelTypes`.`id`, `AngelTypes`.`name`, `AngelTypes`.`restricted`, `AngelTypes`.`no_self_signup`
+    $result = sql_select("
+      SELECT
+          `NeededAngelTypes`.*,
+          `Shifts`.`SID`,
+          `AngelTypes`.`id`,
+          `AngelTypes`.`name`,
+          `AngelTypes`.`restricted`,
+          `AngelTypes`.`no_self_signup`
       FROM `Shifts`
       JOIN `NeededAngelTypes` ON `NeededAngelTypes`.`shift_id`=`Shifts`.`SID`
       JOIN `AngelTypes` ON `AngelTypes`.`id`= `NeededAngelTypes`.`angel_type_id`
@@ -84,7 +104,13 @@ function NeededAngeltype_by_Shift_and_Angeltype($shift, $angeltype)
           
       UNION
           
-      SELECT `NeededAngelTypes`.*, `Shifts`.`SID`, `AngelTypes`.`id`, `AngelTypes`.`name`, `AngelTypes`.`restricted`, `AngelTypes`.`no_self_signup`
+      SELECT
+            `NeededAngelTypes`.*,
+            `Shifts`.`SID`,
+            `AngelTypes`.`id`,
+            `AngelTypes`.`name`,
+            `AngelTypes`.`restricted`,
+            `AngelTypes`.`no_self_signup`
       FROM `Shifts`
       JOIN `NeededAngelTypes` ON `NeededAngelTypes`.`room_id`=`Shifts`.`RID`
       JOIN `AngelTypes` ON `AngelTypes`.`id`= `NeededAngelTypes`.`angel_type_id`
@@ -102,7 +128,18 @@ function NeededAngeltype_by_Shift_and_Angeltype($shift, $angeltype)
 
 function ShiftEntries_by_ShiftsFilter(ShiftsFilter $shiftsFilter)
 {
-    $SQL = "SELECT `User`.`Nick`, `User`.`email`, `User`.`email_shiftinfo`, `User`.`Sprache`, `User`.`Gekommen`, `ShiftEntry`.`UID`, `ShiftEntry`.`TID`, `ShiftEntry`.`SID`, `ShiftEntry`.`Comment`, `ShiftEntry`.`freeloaded`
+    $SQL = "
+      SELECT
+          `User`.`Nick`,
+          `User`.`email`,
+          `User`.`email_shiftinfo`,
+          `User`.`Sprache`,
+          `User`.`Gekommen`,
+          `ShiftEntry`.`UID`,
+          `ShiftEntry`.`TID`,
+          `ShiftEntry`.`SID`,
+          `ShiftEntry`.`Comment`,
+          `ShiftEntry`.`freeloaded`
       FROM `Shifts`
       JOIN `ShiftEntry` ON `ShiftEntry`.`SID`=`Shifts`.`SID`
       JOIN `User` ON `ShiftEntry`.`UID`=`User`.`UID`
@@ -120,13 +157,13 @@ function ShiftEntries_by_ShiftsFilter(ShiftsFilter $shiftsFilter)
  * Check if a shift collides with other shifts (in time).
  *
  * @param Shift $shift
- * @param array<Shift> $shifts
+ * @param       array <Shift> $shifts
  */
 function Shift_collides($shift, $shifts)
 {
     foreach ($shifts as $other_shift) {
         if ($shift['SID'] != $other_shift['SID']) {
-            if (! ($shift['start'] >= $other_shift['end'] || $shift['end'] <= $other_shift['start'])) {
+            if (!($shift['start'] >= $other_shift['end'] || $shift['end'] <= $other_shift['start'])) {
                 return true;
             }
         }
@@ -142,7 +179,7 @@ function Shift_free_entries($needed_angeltype, $shift_entries)
     $taken = 0;
     foreach ($shift_entries as $shift_entry) {
         if ($shift_entry['freeloaded'] == 0) {
-            $taken ++;
+            $taken++;
         }
     }
     return max(0, $needed_angeltype['count'] - $taken);
@@ -151,17 +188,25 @@ function Shift_free_entries($needed_angeltype, $shift_entries)
 /**
  * Check if shift signup is allowed from the end users point of view (no admin like privileges)
  *
- * @param Shift $shift
+ * @param Shift     $shift
- *          The shift
+ *                        The shift
  * @param AngelType $angeltype
- *          The angeltype to which the user wants to sign up
+ *                        The angeltype to which the user wants to sign up
- * @param array<Shift> $user_shifts
+ * @param           array <Shift> $user_shifts
- *          List of the users shifts
+ *                        List of the users shifts
- * @param boolean $angeltype_supporter
+ * @param boolean   $angeltype_supporter
- *          True, if the user has angeltype supporter rights for the angeltype, which enables him to sign somebody up for the shift.
+ *                        True, if the user has angeltype supporter rights for the angeltype, which enables him to sign
+ *                        somebody up for the shift.
  */
-function Shift_signup_allowed_angel($user, $shift, $angeltype, $user_angeltype, $user_shifts, $needed_angeltype, $shift_entries)
+function Shift_signup_allowed_angel(
-{
+    $user,
+    $shift,
+    $angeltype,
+    $user_angeltype,
+    $user_shifts,
+    $needed_angeltype,
+    $shift_entries
+) {
     $free_entries = Shift_free_entries($needed_angeltype, $shift_entries);
 
     if ($user['Gekommen'] == 0) {
@@ -182,37 +227,41 @@ function Shift_signup_allowed_angel($user, $shift, $angeltype, $user_angeltype,
 
     if ($signed_up) {
         // you cannot join if you already singed up for this shift
-    return new ShiftSignupState(ShiftSignupState::SIGNED_UP, $free_entries);
+        return new ShiftSignupState(ShiftSignupState::SIGNED_UP, $free_entries);
     }
 
     if (time() > $shift['start']) {
         // you can only join if the shift is in future
-    return new ShiftSignupState(ShiftSignupState::SHIFT_ENDED, $free_entries);
+        return new ShiftSignupState(ShiftSignupState::SHIFT_ENDED, $free_entries);
     }
     if ($free_entries == 0) {
         // you cannot join if shift is full
-    return new ShiftSignupState(ShiftSignupState::OCCUPIED, $free_entries);
+        return new ShiftSignupState(ShiftSignupState::OCCUPIED, $free_entries);
     }
 
     if ($user_angeltype == null) {
         $user_angeltype = UserAngelType_by_User_and_AngelType($user, $angeltype);
     }
 
-    if ($user_angeltype == null || ($angeltype['no_self_signup'] == 1 && $user_angeltype != null) || ($angeltype['restricted'] == 1 && $user_angeltype != null && ! isset($user_angeltype['confirm_user_id']))) {
+    if (
+        $user_angeltype == null
+        || ($angeltype['no_self_signup'] == 1 && $user_angeltype != null)
+        || ($angeltype['restricted'] == 1 && $user_angeltype != null && !isset($user_angeltype['confirm_user_id']))
+    ) {
         // you cannot join if user is not of this angel type
-    // you cannot join if you are not confirmed
+        // you cannot join if you are not confirmed
-    // you cannot join if angeltype has no self signup
+        // you cannot join if angeltype has no self signup
 
-    return new ShiftSignupState(ShiftSignupState::ANGELTYPE, $free_entries);
+        return new ShiftSignupState(ShiftSignupState::ANGELTYPE, $free_entries);
     }
 
     if (Shift_collides($shift, $user_shifts)) {
         // you cannot join if user alread joined a parallel or this shift
-    return new ShiftSignupState(ShiftSignupState::COLLIDES, $free_entries);
+        return new ShiftSignupState(ShiftSignupState::COLLIDES, $free_entries);
     }
 
-  // Hooray, shift is free for you!
+    // Hooray, shift is free for you!
-  return new ShiftSignupState(ShiftSignupState::FREE, $free_entries);
+    return new ShiftSignupState(ShiftSignupState::FREE, $free_entries);
 }
 
 /**
@@ -231,7 +280,7 @@ function Shift_signup_allowed_angeltype_supporter($angeltype, $needed_angeltype,
 /**
  * Check if an admin can sign up a user to a shift.
  *
- * @param Shift $shift
+ * @param Shift     $shift
  *          The shift
  * @param AngelType $angeltype
  *          The angeltype to which the user wants to sign up
@@ -242,7 +291,7 @@ function Shift_signup_allowed_admin($angeltype, $needed_angeltype, $shift_entrie
 
     if ($free_entries == 0) {
         // User shift admins may join anybody in every shift
-    return new ShiftSignupState(ShiftSignupState::ADMIN, $free_entries);
+        return new ShiftSignupState(ShiftSignupState::ADMIN, $free_entries);
     }
 
     return new ShiftSignupState(ShiftSignupState::FREE, $free_entries);
@@ -251,26 +300,44 @@ function Shift_signup_allowed_admin($angeltype, $needed_angeltype, $shift_entrie
 /**
  * Check if an angel can sign up for given shift.
  *
- * @param Shift $shift
+ * @param Shift     $shift
- *          The shift
+ *                        The shift
  * @param AngelType $angeltype
- *          The angeltype to which the user wants to sign up
+ *                        The angeltype to which the user wants to sign up
- * @param array<Shift> $user_shifts
+ * @param           array <Shift> $user_shifts
- *          List of the users shifts
+ *                        List of the users shifts
  */
-function Shift_signup_allowed($signup_user, $shift, $angeltype, $user_angeltype = null, $user_shifts = null, $needed_angeltype, $shift_entries)
+function Shift_signup_allowed(
-{
+    $signup_user,
+    $shift,
+    $angeltype,
+    $user_angeltype = null,
+    $user_shifts = null,
+    $needed_angeltype,
+    $shift_entries
+) {
     global $user, $privileges;
 
     if (in_array('user_shifts_admin', $privileges)) {
         return Shift_signup_allowed_admin($angeltype, $needed_angeltype, $shift_entries);
     }
 
-    if (in_array('shiftentry_edit_angeltype_supporter', $privileges) && User_is_AngelType_supporter($user, $angeltype)) {
+    if (
+        in_array('shiftentry_edit_angeltype_supporter', $privileges)
+        && User_is_AngelType_supporter($user, $angeltype)
+    ) {
         return Shift_signup_allowed_angeltype_supporter($angeltype, $needed_angeltype, $shift_entries);
     }
 
-    return Shift_signup_allowed_angel($signup_user, $shift, $angeltype, $user_angeltype, $user_shifts, $needed_angeltype, $shift_entries);
+    return Shift_signup_allowed_angel(
+        $signup_user,
+        $shift,
+        $angeltype,
+        $user_angeltype,
+        $user_shifts,
+        $needed_angeltype,
+        $shift_entries
+    );
 }
 
 /**
@@ -304,7 +371,8 @@ function Shift_update($shift)
     $shift['name'] = ShiftType($shift['shifttype_id'])['name'];
     mail_shift_change(Shift($shift['SID']), $shift);
 
-    return sql_query("UPDATE `Shifts` SET
+    return sql_query("
+      UPDATE `Shifts` SET
       `shifttype_id`='" . sql_escape($shift['shifttype_id']) . "',
       `start`='" . sql_escape($shift['start']) . "',
       `end`='" . sql_escape($shift['end']) . "',
@@ -314,7 +382,8 @@ function Shift_update($shift)
       `PSID`=" . sql_null($shift['PSID']) . ",
       `edited_by_user_id`='" . sql_escape($user['UID']) . "',
       `edited_at_timestamp`=" . time() . "
-      WHERE `SID`='" . sql_escape($shift['SID']) . "'");
+      WHERE `SID`='" . sql_escape($shift['SID']) . "'
+    ");
 }
 
 /**
@@ -341,7 +410,8 @@ function Shift_update_by_psid($shift)
 function Shift_create($shift)
 {
     global $user;
-    $result = sql_query("INSERT INTO `Shifts` SET
+    $result = sql_query("
+      INSERT INTO `Shifts` SET
       `shifttype_id`='" . sql_escape($shift['shifttype_id']) . "',
       `start`='" . sql_escape($shift['start']) . "',
       `end`='" . sql_escape($shift['end']) . "',
@@ -350,7 +420,8 @@ function Shift_create($shift)
       `URL`=" . sql_null($shift['URL']) . ",
       `PSID`=" . sql_null($shift['PSID']) . ",
       `created_by_user_id`='" . sql_escape($user['UID']) . "',
-      `created_at_timestamp`=" . time());
+      `created_at_timestamp`=" . time()
+    );
     if ($result === false) {
         return false;
     }
@@ -384,7 +455,7 @@ function Shifts_by_user($user, $include_freeload_comments = false)
  * Returns Shift by id.
  *
  * @param $shift_id Shift
- *          ID
+ *                  ID
  */
 function Shift($shift_id)
 {
@@ -411,11 +482,11 @@ function Shift($shift_id)
     $temp = NeededAngelTypes_by_shift($shift_id);
     foreach ($temp as $e) {
         $result['NeedAngels'][] = [
-        'TID' => $e['angel_type_id'],
+            'TID'        => $e['angel_type_id'],
-        'count' => $e['count'],
+            'count'      => $e['count'],
-        'restricted' => $e['restricted'],
+            'restricted' => $e['restricted'],
-        'taken' => $e['taken']
+            'taken'      => $e['taken']
-    ];
+        ];
     }
 
     return $result;
@@ -427,7 +498,7 @@ function Shift($shift_id)
 function Shifts()
 {
     $shifts_source = sql_select("
-    SELECT `ShiftTypes`.`name`, `Shifts`.*, `Room`.`RID`, `Room`.`Name` as `room_name` 
+    SELECT `ShiftTypes`.`name`, `Shifts`.*, `Room`.`RID`, `Room`.`Name` AS `room_name` 
     FROM `Shifts`
     JOIN `ShiftTypes` ON (`ShiftTypes`.`id` = `Shifts`.`shifttype_id`)
     JOIN `Room` ON `Room`.`RID` = `Shifts`.`RID`

includes/model/UserAngelTypes_model.php

@@ -7,7 +7,7 @@
 /**
  * Checks if a user joined an angeltype.
  *
- * @param User $user
+ * @param User      $user
  *          The user to be checked
  * @param Angeltype $angeltype
  *          The angeltype to be checked
@@ -51,19 +51,20 @@ function User_angeltypes($user)
 function User_unconfirmed_AngelTypes($user)
 {
     $result = sql_select("
-    SELECT 
+        SELECT 
-      `UserAngelTypes`.*, 
+          `UserAngelTypes`.*, 
-      `AngelTypes`.`name`, 
+          `AngelTypes`.`name`, 
-      count(`UnconfirmedMembers`.`user_id`) as `count` 
+          count(`UnconfirmedMembers`.`user_id`) AS `count` 
-    FROM `UserAngelTypes`
+        FROM `UserAngelTypes`
-    JOIN `AngelTypes` ON `UserAngelTypes`.`angeltype_id`=`AngelTypes`.`id`
+        JOIN `AngelTypes` ON `UserAngelTypes`.`angeltype_id`=`AngelTypes`.`id`
-    JOIN `UserAngelTypes` as `UnconfirmedMembers` ON `UserAngelTypes`.`angeltype_id`=`UnconfirmedMembers`.`angeltype_id`
+        JOIN `UserAngelTypes` AS `UnconfirmedMembers` ON `UserAngelTypes`.`angeltype_id`=`UnconfirmedMembers`.`angeltype_id`
-    WHERE `UserAngelTypes`.`user_id`='" . sql_escape($user['UID']) . "'
+        WHERE `UserAngelTypes`.`user_id`='" . sql_escape($user['UID']) . "'
-      AND `UserAngelTypes`.`supporter`=TRUE
+          AND `UserAngelTypes`.`supporter`=TRUE
-      AND `AngelTypes`.`restricted`=TRUE
+          AND `AngelTypes`.`restricted`=TRUE
-      AND `UnconfirmedMembers`.`confirm_user_id` IS NULL
+          AND `UnconfirmedMembers`.`confirm_user_id` IS NULL
-    GROUP BY `UserAngelTypes`.`angeltype_id`
+        GROUP BY `UserAngelTypes`.`angeltype_id`
-    ORDER BY `AngelTypes`.`name`");
+        ORDER BY `AngelTypes`.`name`
+    ");
     if ($result === false) {
         engelsystem_error("Unable to load user angeltypes.");
     }
@@ -73,7 +74,7 @@ function User_unconfirmed_AngelTypes($user)
 /**
  * Returns true if user is angeltype supporter or has privilege admin_user_angeltypes.
  *
- * @param User $user
+ * @param User      $user
  * @param AngelType $angeltype
  */
 function User_is_AngelType_supporter(&$user, $angeltype)
@@ -87,13 +88,14 @@ function User_is_AngelType_supporter(&$user, $angeltype)
       WHERE `user_id`='" . sql_escape($user['UID']) . "'
       AND `angeltype_id`='" . sql_escape($angeltype['id']) . "'
       AND `supporter`=TRUE
-      LIMIT 1") > 0) || in_array('admin_user_angeltypes', $user['privileges']);
+      LIMIT 1
+    ") > 0) || in_array('admin_user_angeltypes', $user['privileges']);
 }
 
 /**
  * Add or remove supporter rights.
  *
- * @param int $user_angeltype_id
+ * @param int  $user_angeltype_id
  * @param bool $supporter
  */
 function UserAngelType_update($user_angeltype_id, $supporter)
@@ -102,7 +104,8 @@ function UserAngelType_update($user_angeltype_id, $supporter)
       UPDATE `UserAngelTypes`
       SET `supporter`=" . sql_bool($supporter) . "
       WHERE `id`='" . sql_escape($user_angeltype_id) . "'
-      LIMIT 1");
+      LIMIT 1
+    ");
     if ($result === false) {
         engelsystem_error("Unable to update supporter rights.");
     }
@@ -119,7 +122,8 @@ function UserAngelTypes_delete_all($angeltype_id)
     $result = sql_query("
       DELETE FROM `UserAngelTypes`
       WHERE `angeltype_id`='" . sql_escape($angeltype_id) . "'
-      AND `confirm_user_id` IS NULL");
+      AND `confirm_user_id` IS NULL
+    ");
     if ($result === false) {
         engelsystem_error("Unable to delete all unconfirmed users.");
     }
@@ -129,7 +133,7 @@ function UserAngelTypes_delete_all($angeltype_id)
 /**
  * Confirm all unconfirmed UserAngelTypes for given Angeltype.
  *
- * @param int $angeltype_id
+ * @param int  $angeltype_id
  * @param User $confirm_user
  */
 function UserAngelTypes_confirm_all($angeltype_id, $confirm_user)
@@ -138,7 +142,8 @@ function UserAngelTypes_confirm_all($angeltype_id, $confirm_user)
       UPDATE `UserAngelTypes`
       SET `confirm_user_id`='" . sql_escape($confirm_user['UID']) . "'
       WHERE `angeltype_id`='" . sql_escape($angeltype_id) . "'
-      AND `confirm_user_id` IS NULL");
+      AND `confirm_user_id` IS NULL
+    ");
     if ($result === false) {
         engelsystem_error("Unable to confirm all users.");
     }
@@ -148,7 +153,7 @@ function UserAngelTypes_confirm_all($angeltype_id, $confirm_user)
 /**
  * Confirm an UserAngelType with confirming user.
  *
- * @param int $user_angeltype_id
+ * @param int  $user_angeltype_id
  * @param User $confirm_user
  */
 function UserAngelType_confirm($user_angeltype_id, $confirm_user)
@@ -180,7 +185,7 @@ function UserAngelType_delete($user_angeltype)
 /**
  * Create an UserAngelType.
  *
- * @param User $user
+ * @param User      $user
  * @param Angeltype $angeltype
  */
 function UserAngelType_create($user, $angeltype)
@@ -219,7 +224,7 @@ function UserAngelType($user_angeltype_id)
 /**
  * Get an UserAngelType by user and angeltype.
  *
- * @param User $user
+ * @param User      $user
  * @param Angeltype $angeltype
  */
 function UserAngelType_by_User_and_AngelType($user, $angeltype)

includes/model/UserDriverLicenses_model.php

@@ -7,14 +7,14 @@
 function UserDriverLicense_new()
 {
     return [
-      'user_id' => null,
+        'user_id'                      => null,
-      'has_car' => false,
+        'has_car'                      => false,
-      'has_license_car' => false,
+        'has_license_car'              => false,
-      'has_license_3_5t_transporter' => false,
+        'has_license_3_5t_transporter' => false,
-      'has_license_7_5t_truck' => false,
+        'has_license_7_5t_truck'       => false,
-      'has_license_12_5t_truck' => false,
+        'has_license_12_5t_truck'      => false,
-      'has_license_forklift' => false
+        'has_license_forklift'         => false
-  ];
+    ];
 }
 
 /**
@@ -26,7 +26,12 @@ function UserDriverLicense_new()
  */
 function UserDriverLicense_valid($user_driver_license)
 {
-    return $user_driver_license['has_car'] || $user_driver_license['has_license_car'] || $user_driver_license['has_license_3_5t_transporter'] || $user_driver_license['has_license_7_5t_truck'] || $user_driver_license['has_license_12_5t_truck'] || $user_driver_license['has_license_forklift'];
+    return $user_driver_license['has_car']
+        || $user_driver_license['has_license_car']
+        || $user_driver_license['has_license_3_5t_transporter']
+        || $user_driver_license['has_license_7_5t_truck']
+        || $user_driver_license['has_license_12_5t_truck']
+        || $user_driver_license['has_license_forklift'];
 }
 
 /**

includes/model/UserGroups_model.php

@@ -2,6 +2,7 @@
 
 /**
  * Returns users groups
+ *
  * @param User $user
  */
 function User_groups($user)

includes/model/User_model.php

@@ -22,7 +22,8 @@ function User_delete($user_id)
  */
 function User_update($user)
 {
-    return sql_query("UPDATE `User` SET
+    return sql_query("
+      UPDATE `User` SET
       `Nick`='" . sql_escape($user['Nick']) . "',
       `Name`='" . sql_escape($user['Name']) . "',
       `Vorname`='" . sql_escape($user['Vorname']) . "',
@@ -46,7 +47,8 @@ function User_update($user)
       `arrival_date`='" . sql_escape($user['arrival_date']) . "',
       `planned_arrival_date`='" . sql_escape($user['planned_arrival_date']) . "',
       `planned_departure_date`=" . sql_null($user['planned_departure_date']) . "
-      WHERE `UID`='" . sql_escape($user['UID']) . "'");
+      WHERE `UID`='" . sql_escape($user['UID']) . "'
+    ");
 }
 
 /**
@@ -83,19 +85,19 @@ function User_tshirts_count()
 function User_sortable_columns()
 {
     return [
-      'Nick',
+        'Nick',
-      'Name',
+        'Name',
-      'Vorname',
+        'Vorname',
-      'Alter',
+        'Alter',
-      'DECT',
+        'DECT',
-      'email',
+        'email',
-      'Size',
+        'Size',
-      'Gekommen',
+        'Gekommen',
-      'Aktiv',
+        'Aktiv',
-      'force_active',
+        'force_active',
-      'Tshirt',
+        'Tshirt',
-      'lastLogIn'
+        'lastLogIn'
-  ];
+    ];
 }
 
 /**
@@ -130,7 +132,8 @@ function Users_by_angeltype_inverted($angeltype)
     $result = sql_select("
       SELECT `User`.*
       FROM `User`
-      LEFT JOIN `UserAngelTypes` ON (`User`.`UID`=`UserAngelTypes`.`user_id` AND `angeltype_id`='" . sql_escape($angeltype['id']) . "')
+      LEFT JOIN `UserAngelTypes`
+        ON (`User`.`UID`=`UserAngelTypes`.`user_id` AND `angeltype_id`='" . sql_escape($angeltype['id']) . "')
       WHERE `UserAngelTypes`.`id` IS NULL
       ORDER BY `Nick`");
     if ($result === false) {
@@ -149,7 +152,7 @@ function Users_by_angeltype($angeltype)
     $result = sql_select("
       SELECT
       `User`.*,
-      `UserAngelTypes`.`id` as `user_angeltype_id`,
+      `UserAngelTypes`.`id` AS `user_angeltype_id`,
       `UserAngelTypes`.`confirm_user_id`,
       `UserAngelTypes`.`supporter`,
       `UserDriverLicenses`.*
@@ -207,7 +210,7 @@ function User_validate_jabber($jabber)
     $jabber = strip_item($jabber);
     if ($jabber == '') {
         // Empty is ok
-    return new ValidationResult(true, '');
+        return new ValidationResult(true, '');
     }
     return new ValidationResult(check_email($jabber), $jabber);
 }
@@ -223,20 +226,20 @@ function User_validate_planned_arrival_date($planned_arrival_date)
 {
     if ($planned_arrival_date == null) {
         // null is not okay
-    return new ValidationResult(false, time());
+        return new ValidationResult(false, time());
     }
     $event_config = EventConfig();
     if ($event_config == null) {
         // Nothing to validate against
-    return new ValidationResult(true, $planned_arrival_date);
+        return new ValidationResult(true, $planned_arrival_date);
     }
     if (isset($event_config['buildup_start_date']) && $planned_arrival_date < $event_config['buildup_start_date']) {
         // Planned arrival can not be before buildup start date
-    return new ValidationResult(false, $event_config['buildup_start_date']);
+        return new ValidationResult(false, $event_config['buildup_start_date']);
     }
     if (isset($event_config['teardown_end_date']) && $planned_arrival_date > $event_config['teardown_end_date']) {
         // Planned arrival can not be after teardown end date
-    return new ValidationResult(false, $event_config['teardown_end_date']);
+        return new ValidationResult(false, $event_config['teardown_end_date']);
     }
     return new ValidationResult(true, $planned_arrival_date);
 }
@@ -254,24 +257,24 @@ function User_validate_planned_departure_date($planned_arrival_date, $planned_de
 {
     if ($planned_departure_date == null) {
         // null is okay
-    return new ValidationResult(true, null);
+        return new ValidationResult(true, null);
     }
     if ($planned_arrival_date > $planned_departure_date) {
         // departure cannot be before arrival
-    return new ValidationResult(false, $planned_arrival_date);
+        return new ValidationResult(false, $planned_arrival_date);
     }
     $event_config = EventConfig();
     if ($event_config == null) {
         // Nothing to validate against
-    return new ValidationResult(true, $planned_departure_date);
+        return new ValidationResult(true, $planned_departure_date);
     }
     if (isset($event_config['buildup_start_date']) && $planned_departure_date < $event_config['buildup_start_date']) {
         // Planned arrival can not be before buildup start date
-    return new ValidationResult(false, $event_config['buildup_start_date']);
+        return new ValidationResult(false, $event_config['buildup_start_date']);
     }
     if (isset($event_config['teardown_end_date']) && $planned_departure_date > $event_config['teardown_end_date']) {
         // Planned arrival can not be after teardown end date
-    return new ValidationResult(false, $event_config['teardown_end_date']);
+        return new ValidationResult(false, $event_config['teardown_end_date']);
     }
     return new ValidationResult(true, $planned_departure_date);
 }

includes/model/ValidationResult.php

@@ -12,33 +12,33 @@ class ValidationResult
 
     private $value;
 
-  /**
+    /**
-   * Constructor.
+     * Constructor.
-   *
+     *
-   * @param boolean $valid
+     * @param boolean $valid
-   *          Is the value valid?
+     *          Is the value valid?
-   * @param * $value
+     * @param * $value
-   *          The validated value
+     *          The validated value
-   */
+     */
-  public function __construct($valid, $value)
+    public function __construct($valid, $value)
-  {
+    {
-      $this->valid = $valid;
+        $this->valid = $valid;
-      $this->value = $value;
+        $this->value = $value;
-  }
+    }
 
-  /**
+    /**
-   * Is the value valid?
+     * Is the value valid?
-   */
+     */
-  public function isValid()
+    public function isValid()
-  {
+    {
-      return $this->valid;
+        return $this->valid;
-  }
+    }
 
-  /**
+    /**
-   * The parsed/validated value.
+     * The parsed/validated value.
-   */
+     */
-  public function getValue()
+    public function getValue()
-  {
+    {
-      return $this->value;
+        return $this->value;
-  }
+    }
 }

includes/mysqli_provider.php

@@ -25,7 +25,7 @@ function sql_transaction_start()
 {
     global $sql_nested_transaction_level;
 
-    if ($sql_nested_transaction_level ++ == 0) {
+    if ($sql_nested_transaction_level++ == 0) {
         return sql_query("BEGIN");
     }
 
@@ -39,7 +39,7 @@ function sql_transaction_commit()
 {
     global $sql_nested_transaction_level;
 
-    if (-- $sql_nested_transaction_level == 0) {
+    if (--$sql_nested_transaction_level == 0) {
         return sql_query("COMMIT");
     }
 
@@ -53,7 +53,7 @@ function sql_transaction_rollback()
 {
     global $sql_nested_transaction_level;
 
-    if (-- $sql_nested_transaction_level == 0) {
+    if (--$sql_nested_transaction_level == 0) {
         return sql_query("ROLLBACK");
     }
 
@@ -102,12 +102,12 @@ function sql_connect($host, $user, $pass, $db_name)
     }
 
     $result = $sql_connection->query("SET CHARACTER SET utf8;");
-    if (! $result) {
+    if (!$result) {
         return sql_error("Unable to set utf8 character set (" . $sql_connection->errno . ") " . $sql_connection->error);
     }
 
     $result = $sql_connection->set_charset('utf8');
-    if (! $result) {
+    if (!$result) {
         return sql_error("Unable to set utf8 names (" . $sql_connection->errno . ") " . $sql_connection->error);
     }
 
@@ -124,7 +124,7 @@ function sql_connect($host, $user, $pass, $db_name)
 function sql_select_db($db_name)
 {
     global $sql_connection;
-    if (! $sql_connection->select_db($db_name)) {
+    if (!$sql_connection->select_db($db_name)) {
         return sql_error("No database selected.");
     }
     return true;
@@ -143,7 +143,7 @@ function sql_select($query)
 //   echo $query . ";\n";
 //   echo debug_string_backtrace() . "\n";
 
-  $result = $sql_connection->query($query);
+    $result = $sql_connection->query($query);
     if ($result) {
         $data = [];
         while ($line = $result->fetch_assoc()) {

includes/pages/admin_active.php

@@ -28,7 +28,10 @@ function admin_active()
         if (isset($_REQUEST['count']) && preg_match("/^[0-9]+$/", $_REQUEST['count'])) {
             $count = strip_request_item('count');
             if ($count < $forced_count) {
-                error(sprintf(_("At least %s angels are forced to be active. The number has to be greater."), $forced_count));
+                error(sprintf(
+                    _("At least %s angels are forced to be active. The number has to be greater."),
+                    $forced_count
+                ));
                 redirect(page_link_to('admin_active'));
             }
         } else {
@@ -112,7 +115,8 @@ function admin_active()
       LEFT JOIN `Shifts` ON `ShiftEntry`.`SID` = `Shifts`.`SID` " . ($show_all_shifts ? "" : "AND (`Shifts`.`end` < " . time() . " OR `Shifts`.`end` IS NULL)") . "
       WHERE `User`.`Gekommen` = 1
       GROUP BY `User`.`UID` 
-      ORDER BY `force_active` DESC, `shift_length` DESC" . $limit);
+      ORDER BY `force_active` DESC, `shift_length` DESC" . $limit
+    );
     $matched_users = [];
     if ($search == "") {
         $tokens = [];
@@ -128,7 +132,7 @@ function admin_active()
                     break;
                 }
             }
-            if (! $match) {
+            if (!$match) {
                 continue;
             }
         }
@@ -160,44 +164,44 @@ function admin_active()
     foreach (array_keys($tshirt_sizes) as $size) {
         if ($size != '') {
             $shirt_statistics[] = [
-          'size' => $size,
+                'size'   => $size,
-          'needed' => sql_select_single_cell("SELECT count(*) FROM `User` WHERE `Size`='" . sql_escape($size) . "' AND `Gekommen`=1"),
+                'needed' => sql_select_single_cell("SELECT count(*) FROM `User` WHERE `Size`='" . sql_escape($size) . "' AND `Gekommen`=1"),
-          'given' => sql_select_single_cell("SELECT count(*) FROM `User` WHERE `Size`='" . sql_escape($size) . "' AND `Tshirt`=1")
+                'given'  => sql_select_single_cell("SELECT count(*) FROM `User` WHERE `Size`='" . sql_escape($size) . "' AND `Tshirt`=1")
-      ];
+            ];
         }
     }
     $shirt_statistics[] = [
-      'size' => '<b>' . _("Sum") . '</b>',
+        'size'   => '<b>' . _("Sum") . '</b>',
-      'needed' => '<b>' . User_arrived_count() . '</b>',
+        'needed' => '<b>' . User_arrived_count() . '</b>',
-      'given' => '<b>' . sql_select_single_cell("SELECT count(*) FROM `User` WHERE `Tshirt`=1") . '</b>'
+        'given'  => '<b>' . sql_select_single_cell("SELECT count(*) FROM `User` WHERE `Tshirt`=1") . '</b>'
-  ];
+    ];
 
     return page_with_title(admin_active_title(), [
-      form([
+        form([
-          form_text('search', _("Search angel:"), $search),
+            form_text('search', _("Search angel:"), $search),
-          form_checkbox('show_all_shifts', _("Show all shifts"), $show_all_shifts),
+            form_checkbox('show_all_shifts', _("Show all shifts"), $show_all_shifts),
-          form_submit('submit', _("Search"))
+            form_submit('submit', _("Search"))
-      ], page_link_to('admin_active')),
+        ], page_link_to('admin_active')),
-      $set_active == "" ? form([
+        $set_active == "" ? form([
-          form_text('count', _("How much angels should be active?"), $count),
+            form_text('count', _("How much angels should be active?"), $count),
-          form_submit('set_active', _("Preview"))
+            form_submit('set_active', _("Preview"))
-      ]) : $set_active,
+        ]) : $set_active,
-      msg(),
+        msg(),
-      table([
+        table([
-          'nick' => _("Nickname"),
+            'nick'         => _("Nickname"),
-          'shirt_size' => _("Size"),
+            'shirt_size'   => _("Size"),
-          'shift_count' => _("Shifts"),
+            'shift_count'  => _("Shifts"),
-          'work_time' => _("Length"),
+            'work_time'    => _("Length"),
-          'active' => _("Active?"),
+            'active'       => _("Active?"),
-          'force_active' => _("Forced"),
+            'force_active' => _("Forced"),
-          'tshirt' => _("T-shirt?"),
+            'tshirt'       => _("T-shirt?"),
-          'actions' => ""
+            'actions'      => ""
-      ], $matched_users),
+        ], $matched_users),
-      '<h2>' . _("Shirt statistics") . '</h2>',
+        '<h2>' . _("Shirt statistics") . '</h2>',
-      table([
+        table([
-          'size' => _("Size"),
+            'size'   => _("Size"),
-          'needed' => _("Needed shirts"),
+            'needed' => _("Needed shirts"),
-          'given' => _("Given shirts")
+            'given'  => _("Given shirts")
-      ], $shirt_statistics)
+        ], $shirt_statistics)
-  ]);
+    ]);
 }

includes/pages/admin_arrive.php

@@ -57,7 +57,7 @@ function admin_arrive()
                     break;
                 }
             }
-            if (! $match) {
+            if (!$match) {
                 continue;
             }
         }
@@ -75,26 +75,26 @@ function admin_arrive()
 
         if ($usr['arrival_date'] > 0) {
             $day = date('Y-m-d', $usr['arrival_date']);
-            if (! isset($arrival_count_at_day[$day])) {
+            if (!isset($arrival_count_at_day[$day])) {
                 $arrival_count_at_day[$day] = 0;
             }
-            $arrival_count_at_day[$day] ++;
+            $arrival_count_at_day[$day]++;
         }
 
         if ($usr['planned_arrival_date'] != null) {
             $day = date('Y-m-d', $usr['planned_arrival_date']);
-            if (! isset($planned_arrival_count_at_day[$day])) {
+            if (!isset($planned_arrival_count_at_day[$day])) {
                 $planned_arrival_count_at_day[$day] = 0;
             }
-            $planned_arrival_count_at_day[$day] ++;
+            $planned_arrival_count_at_day[$day]++;
         }
 
         if ($usr['planned_departure_date'] != null && $usr['Gekommen'] == 1) {
             $day = date('Y-m-d', $usr['planned_departure_date']);
-            if (! isset($planned_departure_count_at_day[$day])) {
+            if (!isset($planned_departure_count_at_day[$day])) {
                 $planned_departure_count_at_day[$day] = 0;
             }
-            $planned_departure_count_at_day[$day] ++;
+            $planned_departure_count_at_day[$day]++;
         }
 
         $users_matched[] = $usr;
@@ -109,10 +109,10 @@ function admin_arrive()
     foreach ($arrival_count_at_day as $day => $count) {
         $arrival_sum += $count;
         $arrival_at_day[$day] = [
-        'day' => $day,
+            'day'   => $day,
-        'count' => $count,
+            'count' => $count,
-        'sum' => $arrival_sum
+            'sum'   => $arrival_sum
-    ];
+        ];
     }
 
     $planned_arrival_at_day = [];
@@ -120,10 +120,10 @@ function admin_arrive()
     foreach ($planned_arrival_count_at_day as $day => $count) {
         $planned_arrival_sum += $count;
         $planned_arrival_at_day[$day] = [
-        'day' => $day,
+            'day'   => $day,
-        'count' => $count,
+            'count' => $count,
-        'sum' => $planned_arrival_sum
+            'sum'   => $planned_arrival_sum
-    ];
+        ];
     }
 
     $planned_departure_at_day = [];
@@ -131,72 +131,72 @@ function admin_arrive()
     foreach ($planned_departure_count_at_day as $day => $count) {
         $planned_departure_sum += $count;
         $planned_departure_at_day[$day] = [
-        'day' => $day,
+            'day'   => $day,
-        'count' => $count,
+            'count' => $count,
-        'sum' => $planned_departure_sum
+            'sum'   => $planned_departure_sum
-    ];
+        ];
     }
 
     return page_with_title(admin_arrive_title(), [
-      msg(),
+        msg(),
-      form([
+        form([
-          form_text('search', _("Search"), $search),
+            form_text('search', _("Search"), $search),
-          form_submit('submit', _("Search"))
+            form_submit('submit', _("Search"))
-      ]),
+        ]),
-      table([
+        table([
-          'nick' => _("Nickname"),
+            'nick'                            => _("Nickname"),
-          'rendered_planned_arrival_date' => _("Planned arrival"),
+            'rendered_planned_arrival_date'   => _("Planned arrival"),
-          'arrived' => _("Arrived?"),
+            'arrived'                         => _("Arrived?"),
-          'rendered_arrival_date' => _("Arrival date"),
+            'rendered_arrival_date'           => _("Arrival date"),
-          'rendered_planned_departure_date' => _("Planned departure"),
+            'rendered_planned_departure_date' => _("Planned departure"),
-          'actions' => ""
+            'actions'                         => ""
-      ], $users_matched),
+        ], $users_matched),
-      div('row', [
+        div('row', [
-          div('col-md-4', [
+            div('col-md-4', [
-              heading(_("Planned arrival statistics"), 2),
+                heading(_("Planned arrival statistics"), 2),
-              bargraph('planned_arrives', 'day', [
+                bargraph('planned_arrives', 'day', [
-                  'count' => _("arrived"),
+                    'count' => _("arrived"),
-                  'sum' => _("arrived sum")
+                    'sum'   => _("arrived sum")
-              ], [
+                ], [
-                  'count' => '#090',
+                    'count' => '#090',
-                  'sum' => '#888'
+                    'sum'   => '#888'
-              ], $planned_arrival_at_day),
+                ], $planned_arrival_at_day),
-              table([
+                table([
-                  'day' => _("Date"),
+                    'day'   => _("Date"),
-                  'count' => _("Count"),
+                    'count' => _("Count"),
-                  'sum' => _("Sum")
+                    'sum'   => _("Sum")
-              ], $planned_arrival_at_day)
+                ], $planned_arrival_at_day)
-          ]),
+            ]),
-          div('col-md-4', [
+            div('col-md-4', [
-              heading(_("Arrival statistics"), 2),
+                heading(_("Arrival statistics"), 2),
-              bargraph('arrives', 'day', [
+                bargraph('arrives', 'day', [
-                  'count' => _("arrived"),
+                    'count' => _("arrived"),
-                  'sum' => _("arrived sum")
+                    'sum'   => _("arrived sum")
-              ], [
+                ], [
-                  'count' => '#090',
+                    'count' => '#090',
-                  'sum' => '#888'
+                    'sum'   => '#888'
-              ], $arrival_at_day),
+                ], $arrival_at_day),
-              table([
+                table([
-                  'day' => _("Date"),
+                    'day'   => _("Date"),
-                  'count' => _("Count"),
+                    'count' => _("Count"),
-                  'sum' => _("Sum")
+                    'sum'   => _("Sum")
-              ], $arrival_at_day)
+                ], $arrival_at_day)
-          ]),
+            ]),
-          div('col-md-4', [
+            div('col-md-4', [
-              heading(_("Planned departure statistics"), 2),
+                heading(_("Planned departure statistics"), 2),
-              bargraph('planned_departures', 'day', [
+                bargraph('planned_departures', 'day', [
-                  'count' => _("arrived"),
+                    'count' => _("arrived"),
-                  'sum' => _("arrived sum")
+                    'sum'   => _("arrived sum")
-              ], [
+                ], [
-                  'count' => '#090',
+                    'count' => '#090',
-                  'sum' => '#888'
+                    'sum'   => '#888'
-              ], $planned_departure_at_day),
+                ], $planned_departure_at_day),
-              table([
+                table([
-                  'day' => _("Date"),
+                    'day'   => _("Date"),
-                  'count' => _("Count"),
+                    'count' => _("Count"),
-                  'sum' => _("Sum")
+                    'sum'   => _("Sum")
-              ], $planned_departure_at_day)
+                ], $planned_departure_at_day)
-          ])
+            ])
-      ])
+        ])
-  ]);
+    ]);
 }

includes/pages/admin_free.php

@@ -27,8 +27,8 @@ function admin_free()
 
     $angel_types_source = sql_select("SELECT `id`, `name` FROM `AngelTypes` ORDER BY `name`");
     $angel_types = [
-      '' => 'alle Typen'
+        '' => 'alle Typen'
-  ];
+    ];
     foreach ($angel_types_source as $angel_type) {
         $angel_types[$angel_type['id']] = $angel_type['name'];
     }
@@ -59,44 +59,47 @@ function admin_free()
                     break;
                 }
             }
-            if (! $match) {
+            if (!$match) {
                 continue;
             }
         }
 
         $free_users_table[] = [
-        'name' => User_Nick_render($usr),
+            'name'        => User_Nick_render($usr),
-        'shift_state' => User_shift_state_render($usr),
+            'shift_state' => User_shift_state_render($usr),
-        'dect' => $usr['DECT'],
+            'dect'        => $usr['DECT'],
-        'jabber' => $usr['jabber'],
+            'jabber'      => $usr['jabber'],
-        'email' => $usr['email_by_human_allowed'] ? $usr['email'] : glyph('eye-close'),
+            'email'       => $usr['email_by_human_allowed'] ? $usr['email'] : glyph('eye-close'),
-        'actions' => in_array('admin_user', $privileges) ? button(page_link_to('admin_user') . '&id=' . $usr['UID'], _("edit"), 'btn-xs') : ''
+            'actions'     =>
-    ];
+                in_array('admin_user', $privileges)
+                    ? button(page_link_to('admin_user') . '&id=' . $usr['UID'], _("edit"), 'btn-xs')
+                    : ''
+        ];
     }
     return page_with_title(admin_free_title(), [
-      form([
+        form([
-          div('row', [
+            div('row', [
-              div('col-md-4', [
+                div('col-md-4', [
-                  form_text('search', _("Search"), $search)
+                    form_text('search', _("Search"), $search)
-              ]),
+                ]),
-              div('col-md-4', [
+                div('col-md-4', [
-                  form_select('angeltype', _("Angeltype"), $angel_types, $_REQUEST['angeltype'])
+                    form_select('angeltype', _("Angeltype"), $angel_types, $_REQUEST['angeltype'])
-              ]),
+                ]),
-              div('col-md-2', [
+                div('col-md-2', [
-                  form_checkbox('confirmed_only', _("Only confirmed"), isset($_REQUEST['confirmed_only']))
+                    form_checkbox('confirmed_only', _("Only confirmed"), isset($_REQUEST['confirmed_only']))
-              ]),
+                ]),
-              div('col-md-2', [
+                div('col-md-2', [
-                  form_submit('submit', _("Search"))
+                    form_submit('submit', _("Search"))
-              ])
+                ])
-          ])
+            ])
-      ]),
+        ]),
-      table([
+        table([
-          'name' => _("Nick"),
+            'name'        => _("Nick"),
-          'shift_state' => '',
+            'shift_state' => '',
-          'dect' => _("DECT"),
+            'dect'        => _("DECT"),
-          'jabber' => _("Jabber"),
+            'jabber'      => _("Jabber"),
-          'email' => _("E-Mail"),
+            'email'       => _("E-Mail"),
-          'actions' => ''
+            'actions'     => ''
-      ], $free_users_table)
+        ], $free_users_table)
-  ]);
+    ]);
 }

includes/pages/admin_groups.php

@@ -9,10 +9,15 @@ function admin_groups()
 {
     $html = "";
     $groups = sql_select("SELECT * FROM `Groups` ORDER BY `Name`");
-    if (! isset($_REQUEST["action"])) {
+    if (!isset($_REQUEST["action"])) {
         $groups_table = [];
         foreach ($groups as $group) {
-            $privileges = sql_select("SELECT * FROM `GroupPrivileges` JOIN `Privileges` ON (`GroupPrivileges`.`privilege_id` = `Privileges`.`id`) WHERE `group_id`='" . sql_escape($group['UID']) . "'");
+            $privileges = sql_select("
+                SELECT *
+                FROM `GroupPrivileges`
+                JOIN `Privileges` ON (`GroupPrivileges`.`privilege_id` = `Privileges`.`id`)
+                WHERE `group_id`='" . sql_escape($group['UID']) . "'
+            ");
             $privileges_html = [];
 
             foreach ($privileges as $priv) {
@@ -20,79 +25,106 @@ function admin_groups()
             }
 
             $groups_table[] = [
-          'name' => $group['Name'],
+                'name'       => $group['Name'],
-          'privileges' => join(', ', $privileges_html),
+                'privileges' => join(', ', $privileges_html),
-          'actions' => button(page_link_to('admin_groups') . '&action=edit&id=' . $group['UID'], _("edit"), 'btn-xs')
+                'actions'    => button(
-      ];
+                    page_link_to('admin_groups') . '&action=edit&id=' . $group['UID'],
+                    _("edit"),
+                    'btn-xs'
+                )
+            ];
         }
 
         return page_with_title(admin_groups_title(), [
-        table([
+            table([
-            'name' => _("Name"),
+                'name'       => _("Name"),
-            'privileges' => _("Privileges"),
+                'privileges' => _("Privileges"),
-            'actions' => ''
+                'actions'    => ''
-        ], $groups_table)
+            ], $groups_table)
-    ]);
+        ]);
     } else {
         switch ($_REQUEST["action"]) {
-      case 'edit':
+            case 'edit':
-        if (isset($_REQUEST['id']) && preg_match("/^-[0-9]{1,11}$/", $_REQUEST['id'])) {
+                if (isset($_REQUEST['id']) && preg_match("/^-[0-9]{1,11}$/", $_REQUEST['id'])) {
-            $group_id = $_REQUEST['id'];
+                    $group_id = $_REQUEST['id'];
-        } else {
+                } else {
-            return error("Incomplete call, missing Groups ID.", true);
+                    return error("Incomplete call, missing Groups ID.", true);
-        }
+                }
 
-        $group = sql_select("SELECT * FROM `Groups` WHERE `UID`='" . sql_escape($group_id) . "' LIMIT 1");
+                $group = sql_select("SELECT * FROM `Groups` WHERE `UID`='" . sql_escape($group_id) . "' LIMIT 1");
-        if (count($group) > 0) {
+                if (count($group) > 0) {
-            list($group) = $group;
+                    list($group) = $group;
-            $privileges = sql_select("SELECT `Privileges`.*, `GroupPrivileges`.`group_id` FROM `Privileges` LEFT OUTER JOIN `GroupPrivileges` ON (`Privileges`.`id` = `GroupPrivileges`.`privilege_id` AND `GroupPrivileges`.`group_id`='" . sql_escape($group_id) . "') ORDER BY `Privileges`.`name`");
+                    $privileges = sql_select("
-            $privileges_html = "";
+                        SELECT `Privileges`.*, `GroupPrivileges`.`group_id`
-            $privileges_form = [];
+                        FROM `Privileges`
-            foreach ($privileges as $priv) {
+                        LEFT OUTER JOIN `GroupPrivileges`
-                $privileges_form[] = form_checkbox('privileges[]', $priv['desc'] . ' (' . $priv['name'] . ')', $priv['group_id'] != "", $priv['id']);
+                            ON (
-                $privileges_html .= sprintf('<tr><td><input type="checkbox" ' . 'name="privileges[]" value="%s" %s />' . '</td> <td>%s</td> <td>%s</td></tr>', $priv['id'], ($priv['group_id'] != "" ? 'checked="checked"' : ''), $priv['name'], $priv['desc']);
+                                `Privileges`.`id` = `GroupPrivileges`.`privilege_id`
-            }
+                                AND `GroupPrivileges`.`group_id`='" . sql_escape($group_id) . "'
+                            )
+                        ORDER BY `Privileges`.`name`
+                    ");
+                    $privileges_html = "";
+                    $privileges_form = [];
+                    foreach ($privileges as $priv) {
+                        $privileges_form[] = form_checkbox(
+                            'privileges[]',
+                            $priv['desc'] . ' (' . $priv['name'] . ')',
+                            $priv['group_id'] != "",
+                            $priv['id']
+                        );
+                        $privileges_html .= sprintf(
+                            '<tr><td><input type="checkbox" name="privileges[]" value="%s" %s /></td> <td>%s</td> <td>%s</td></tr>',
+                            $priv['id'],
+                            ($priv['group_id'] != "" ? 'checked="checked"' : ''),
+                            $priv['name'],
+                            $priv['desc']
+                        );
+                    }
 
-            $privileges_form[] = form_submit('submit', _("Save"));
+                    $privileges_form[] = form_submit('submit', _("Save"));
-            $html .= page_with_title(_("Edit group"), [
+                    $html .= page_with_title(_("Edit group"), [
-              form($privileges_form, page_link_to('admin_groups') . '&action=save&id=' . $group_id)
+                        form($privileges_form, page_link_to('admin_groups') . '&action=save&id=' . $group_id)
-          ]);
+                    ]);
-        } else {
+                } else {
-            return error("No Group found.", true);
+                    return error("No Group found.", true);
-        }
+                }
-        break;
+                break;
 
-      case 'save':
+            case 'save':
-        if (isset($_REQUEST['id']) && preg_match("/^-[0-9]{1,11}$/", $_REQUEST['id'])) {
+                if (isset($_REQUEST['id']) && preg_match("/^-[0-9]{1,11}$/", $_REQUEST['id'])) {
-            $group_id = $_REQUEST['id'];
+                    $group_id = $_REQUEST['id'];
-        } else {
+                } else {
-            return error("Incomplete call, missing Groups ID.", true);
+                    return error("Incomplete call, missing Groups ID.", true);
-        }
+                }
 
-        $group = sql_select("SELECT * FROM `Groups` WHERE `UID`='" . sql_escape($group_id) . "' LIMIT 1");
+                $group = sql_select("SELECT * FROM `Groups` WHERE `UID`='" . sql_escape($group_id) . "' LIMIT 1");
-        if (! is_array($_REQUEST['privileges'])) {
+                if (!is_array($_REQUEST['privileges'])) {
-            $_REQUEST['privileges'] = [];
+                    $_REQUEST['privileges'] = [];
-        }
+                }
-        if (count($group) > 0) {
+                if (count($group) > 0) {
-            list($group) = $group;
+                    list($group) = $group;
-            sql_query("DELETE FROM `GroupPrivileges` WHERE `group_id`='" . sql_escape($group_id) . "'");
+                    sql_query("DELETE FROM `GroupPrivileges` WHERE `group_id`='" . sql_escape($group_id) . "'");
-            $privilege_names = [];
+                    $privilege_names = [];
-            foreach ($_REQUEST['privileges'] as $priv) {
+                    foreach ($_REQUEST['privileges'] as $priv) {
-                if (preg_match("/^[0-9]{1,}$/", $priv)) {
+                        if (preg_match("/^[0-9]{1,}$/", $priv)) {
-                    $group_privileges_source = sql_select("SELECT * FROM `Privileges` WHERE `id`='" . sql_escape($priv) . "' LIMIT 1");
+                            $group_privileges_source = sql_select("SELECT * FROM `Privileges` WHERE `id`='" . sql_escape($priv) . "' LIMIT 1");
-                    if (count($group_privileges_source) > 0) {
+                            if (count($group_privileges_source) > 0) {
-                        sql_query("INSERT INTO `GroupPrivileges` SET `group_id`='" . sql_escape($group_id) . "', `privilege_id`='" . sql_escape($priv) . "'");
+                                sql_query("INSERT INTO `GroupPrivileges` SET `group_id`='" . sql_escape($group_id) . "', `privilege_id`='" . sql_escape($priv) . "'");
-                        $privilege_names[] = $group_privileges_source[0]['name'];
+                                $privilege_names[] = $group_privileges_source[0]['name'];
+                            }
+                        }
                     }
+                    engelsystem_log(
+                        "Group privileges of group " . $group['Name']
+                        . " edited: " . join(", ", $privilege_names)
+                    );
+                    redirect(page_link_to("admin_groups"));
+                } else {
+                    return error("No Group found.", true);
                 }
-            }
+                break;
-            engelsystem_log("Group privileges of group " . $group['Name'] . " edited: " . join(", ", $privilege_names));
-            redirect(page_link_to("admin_groups"));
-        } else {
-            return error("No Group found.", true);
         }
-        break;
-    }
     }
     return $html;
 }

includes/pages/admin_import.php

@@ -13,11 +13,14 @@ function admin_import()
     $import_dir = __DIR__ . '/../../import';
 
     $step = "input";
-    if (isset($_REQUEST['step']) && in_array($step, [
+    if (
-      'input',
+        isset($_REQUEST['step'])
-      'check',
+        && in_array($step, [
-      'import'
+            'input',
-  ])) {
+            'check',
+            'import'
+        ])
+    ) {
         $step = $_REQUEST['step'];
     }
 
@@ -43,226 +46,248 @@ function admin_import()
     }
 
     switch ($step) {
-    case 'input':
+        case 'input':
-      $valid = false;
+            $valid = false;
-      
+
-      if (isset($_REQUEST['submit'])) {
+            if (isset($_REQUEST['submit'])) {
-          $valid = true;
+                $valid = true;
-        
+
-          if (isset($_REQUEST['shifttype_id']) && isset($shifttypes[$_REQUEST['shifttype_id']])) {
+                if (isset($_REQUEST['shifttype_id']) && isset($shifttypes[$_REQUEST['shifttype_id']])) {
-              $shifttype_id = $_REQUEST['shifttype_id'];
+                    $shifttype_id = $_REQUEST['shifttype_id'];
-          } else {
+                } else {
-              $valid = false;
+                    $valid = false;
-              error(_('Please select a shift type.'));
+                    error(_('Please select a shift type.'));
-          }
+                }
-        
+
-          if (isset($_REQUEST['add_minutes_start']) && is_numeric(trim($_REQUEST['add_minutes_start']))) {
+                if (isset($_REQUEST['add_minutes_start']) && is_numeric(trim($_REQUEST['add_minutes_start']))) {
-              $add_minutes_start = trim($_REQUEST['add_minutes_start']);
+                    $add_minutes_start = trim($_REQUEST['add_minutes_start']);
-          } else {
+                } else {
-              $valid = false;
+                    $valid = false;
-              error(_("Please enter an amount of minutes to add to a talk's begin."));
+                    error(_("Please enter an amount of minutes to add to a talk's begin."));
-          }
+                }
-        
+
-          if (isset($_REQUEST['add_minutes_end']) && is_numeric(trim($_REQUEST['add_minutes_end']))) {
+                if (isset($_REQUEST['add_minutes_end']) && is_numeric(trim($_REQUEST['add_minutes_end']))) {
-              $add_minutes_end = trim($_REQUEST['add_minutes_end']);
+                    $add_minutes_end = trim($_REQUEST['add_minutes_end']);
-          } else {
+                } else {
-              $valid = false;
+                    $valid = false;
-              error(_("Please enter an amount of minutes to add to a talk's end."));
+                    error(_("Please enter an amount of minutes to add to a talk's end."));
-          }
+                }
-        
+
-          if (isset($_FILES['xcal_file']) && ($_FILES['xcal_file']['error'] == 0)) {
+                if (isset($_FILES['xcal_file']) && ($_FILES['xcal_file']['error'] == 0)) {
-              if (move_uploaded_file($_FILES['xcal_file']['tmp_name'], $import_file)) {
+                    if (move_uploaded_file($_FILES['xcal_file']['tmp_name'], $import_file)) {
-                  libxml_use_internal_errors(true);
+                        libxml_use_internal_errors(true);
-                  if (simplexml_load_file($import_file) === false) {
+                        if (simplexml_load_file($import_file) === false) {
-                      $valid = false;
+                            $valid = false;
-                      error(_('No valid xml/xcal file provided.'));
+                            error(_('No valid xml/xcal file provided.'));
-                      unlink($import_file);
+                            unlink($import_file);
-                  }
+                        }
-              } else {
+                    } else {
-                  $valid = false;
+                        $valid = false;
-                  error(_('File upload went wrong.'));
+                        error(_('File upload went wrong.'));
-              }
+                    }
-          } else {
+                } else {
-              $valid = false;
+                    $valid = false;
-              error(_('Please provide some data.'));
+                    error(_('Please provide some data.'));
-          }
+                }
-      }
+            }
-      
+
-      if ($valid) {
+            if ($valid) {
-          redirect(page_link_to('admin_import') . "&step=check&shifttype_id=" . $shifttype_id . "&add_minutes_end=" . $add_minutes_end . "&add_minutes_start=" . $add_minutes_start);
+                redirect(page_link_to('admin_import') . "&step=check&shifttype_id=" . $shifttype_id . "&add_minutes_end=" . $add_minutes_end . "&add_minutes_start=" . $add_minutes_start);
-      } else {
+            } else {
-          $html .= div('well well-sm text-center', [
+                $html .= div('well well-sm text-center', [
-            _('File Upload') . mute(glyph('arrow-right')) . mute(_('Validation')) . mute(glyph('arrow-right')) . mute(_('Import'))
+                        _('File Upload') . mute(glyph('arrow-right')) . mute(_('Validation')) . mute(glyph('arrow-right')) . mute(_('Import'))
-        ]) . div('row', [
+                    ]) . div('row', [
-            div('col-md-offset-3 col-md-6', [
+                        div('col-md-offset-3 col-md-6', [
-                form([
+                            form([
-                    form_info('', _("This import will create/update/delete rooms and shifts by given FRAB-export file. The needed file format is xcal.")),
+                                form_info(
-                    form_select('shifttype_id', _('Shifttype'), $shifttypes, $shifttype_id),
+                                    '',
-                    form_spinner('add_minutes_start', _("Add minutes to start"), $add_minutes_start),
+                                    _("This import will create/update/delete rooms and shifts by given FRAB-export file. The needed file format is xcal.")
-                    form_spinner('add_minutes_end', _("Add minutes to end"), $add_minutes_end),
+                                ),
-                    form_file('xcal_file', _("xcal-File (.xcal)")),
+                                form_select('shifttype_id', _('Shifttype'), $shifttypes, $shifttype_id),
-                    form_submit('submit', _("Import"))
+                                form_spinner('add_minutes_start', _("Add minutes to start"), $add_minutes_start),
-                ])
+                                form_spinner('add_minutes_end', _("Add minutes to end"), $add_minutes_end),
-            ])
+                                form_file('xcal_file', _("xcal-File (.xcal)")),
-        ]);
+                                form_submit('submit', _("Import"))
-      }
+                            ])
-      break;
+                        ])
-    
+                    ]);
-    case 'check':
+            }
-      if (! file_exists($import_file)) {
+            break;
-          error(_('Missing import file.'));
+
-          redirect(page_link_to('admin_import'));
+        case 'check':
-      }
+            if (!file_exists($import_file)) {
-      
+                error(_('Missing import file.'));
-      if (isset($_REQUEST['shifttype_id']) && isset($shifttypes[$_REQUEST['shifttype_id']])) {
+                redirect(page_link_to('admin_import'));
-          $shifttype_id = $_REQUEST['shifttype_id'];
+            }
-      } else {
+
-          error(_('Please select a shift type.'));
+            if (isset($_REQUEST['shifttype_id']) && isset($shifttypes[$_REQUEST['shifttype_id']])) {
-          redirect(page_link_to('admin_import'));
+                $shifttype_id = $_REQUEST['shifttype_id'];
-      }
+            } else {
-      
+                error(_('Please select a shift type.'));
-      if (isset($_REQUEST['add_minutes_start']) && is_numeric(trim($_REQUEST['add_minutes_start']))) {
+                redirect(page_link_to('admin_import'));
-          $add_minutes_start = trim($_REQUEST['add_minutes_start']);
+            }
-      } else {
+
-          error(_("Please enter an amount of minutes to add to a talk's begin."));
+            if (isset($_REQUEST['add_minutes_start']) && is_numeric(trim($_REQUEST['add_minutes_start']))) {
-          redirect(page_link_to('admin_import'));
+                $add_minutes_start = trim($_REQUEST['add_minutes_start']);
-      }
+            } else {
-      
+                error(_("Please enter an amount of minutes to add to a talk's begin."));
-      if (isset($_REQUEST['add_minutes_end']) && is_numeric(trim($_REQUEST['add_minutes_end']))) {
+                redirect(page_link_to('admin_import'));
-          $add_minutes_end = trim($_REQUEST['add_minutes_end']);
+            }
-      } else {
+
-          error(_("Please enter an amount of minutes to add to a talk's end."));
+            if (isset($_REQUEST['add_minutes_end']) && is_numeric(trim($_REQUEST['add_minutes_end']))) {
-          redirect(page_link_to('admin_import'));
+                $add_minutes_end = trim($_REQUEST['add_minutes_end']);
-      }
+            } else {
-      
+                error(_("Please enter an amount of minutes to add to a talk's end."));
-      list($rooms_new, $rooms_deleted) = prepare_rooms($import_file);
+                redirect(page_link_to('admin_import'));
-      list($events_new, $events_updated, $events_deleted) = prepare_events($import_file, $shifttype_id, $add_minutes_start, $add_minutes_end);
+            }
-      
+
-      $html .= div('well well-sm text-center', [
+            list($rooms_new, $rooms_deleted) = prepare_rooms($import_file);
-          '<span class="text-success">' . _('File Upload') . glyph('ok-circle') . '</span>' . mute(glyph('arrow-right')) . _('Validation') . mute(glyph('arrow-right')) . mute(_('Import'))
+            list($events_new, $events_updated, $events_deleted) = prepare_events(
-      ]) . form([
+                $import_file,
-          div('row', [
+                $shifttype_id,
-              div('col-sm-6', [
+                $add_minutes_start,
-                  '<h3>' . _("Rooms to create") . '</h3>',
+                $add_minutes_end
-                  table(_("Name"), $rooms_new)
+            );
-              ]),
+
-              div('col-sm-6', [
+            $html .= div(
-                  '<h3>' . _("Rooms to delete") . '</h3>',
+                    'well well-sm text-center',
-                  table(_("Name"), $rooms_deleted)
+                    [
-              ])
+                        '<span class="text-success">' . _('File Upload') . glyph('ok-circle') . '</span>' . mute(glyph('arrow-right')) . _('Validation') . mute(glyph('arrow-right')) . mute(_('Import'))
-          ]),
+                    ])
-          '<h3>' . _("Shifts to create") . '</h3>',
+                . form(
-          table([
+                    [
-              'day' => _("Day"),
+                        div('row', [
-              'start' => _("Start"),
+                            div('col-sm-6', [
-              'end' => _("End"),
+                                '<h3>' . _("Rooms to create") . '</h3>',
-              'shifttype' => _('Shift type'),
+                                table(_("Name"), $rooms_new)
-              'title' => _("Title"),
+                            ]),
-              'room' => _("Room")
+                            div('col-sm-6', [
-          ], shifts_printable($events_new, $shifttypes)),
+                                '<h3>' . _("Rooms to delete") . '</h3>',
-          '<h3>' . _("Shifts to update") . '</h3>',
+                                table(_("Name"), $rooms_deleted)
-          table([
+                            ])
-              'day' => _("Day"),
+                        ]),
-              'start' => _("Start"),
+                        '<h3>' . _("Shifts to create") . '</h3>',
-              'end' => _("End"),
+                        table([
-              'shifttype' => _('Shift type'),
+                            'day'       => _("Day"),
-              'title' => _("Title"),
+                            'start'     => _("Start"),
-              'room' => _("Room")
+                            'end'       => _("End"),
-          ], shifts_printable($events_updated, $shifttypes)),
+                            'shifttype' => _('Shift type'),
-          '<h3>' . _("Shifts to delete") . '</h3>',
+                            'title'     => _("Title"),
-          table([
+                            'room'      => _("Room")
-              'day' => _("Day"),
+                        ], shifts_printable($events_new, $shifttypes)),
-              'start' => _("Start"),
+                        '<h3>' . _("Shifts to update") . '</h3>',
-              'end' => _("End"),
+                        table([
-              'shifttype' => _('Shift type'),
+                            'day'       => _("Day"),
-              'title' => _("Title"),
+                            'start'     => _("Start"),
-              'room' => _("Room")
+                            'end'       => _("End"),
-          ], shifts_printable($events_deleted, $shifttypes)),
+                            'shifttype' => _('Shift type'),
-          form_submit('submit', _("Import"))
+                            'title'     => _("Title"),
-      ], page_link_to('admin_import') . '&step=import&shifttype_id=' . $shifttype_id . "&add_minutes_end=" . $add_minutes_end . "&add_minutes_start=" . $add_minutes_start);
+                            'room'      => _("Room")
-      break;
+                        ], shifts_printable($events_updated, $shifttypes)),
-    
+                        '<h3>' . _("Shifts to delete") . '</h3>',
-    case 'import':
+                        table([
-      if (! file_exists($import_file)) {
+                            'day'       => _("Day"),
-          error(_('Missing import file.'));
+                            'start'     => _("Start"),
-          redirect(page_link_to('admin_import'));
+                            'end'       => _("End"),
-      }
+                            'shifttype' => _('Shift type'),
-      
+                            'title'     => _("Title"),
-      if (! file_exists($import_file)) {
+                            'room'      => _("Room")
-          redirect(page_link_to('admin_import'));
+                        ], shifts_printable($events_deleted, $shifttypes)),
-      }
+                        form_submit('submit', _("Import"))
-      
+                    ],
-      if (isset($_REQUEST['shifttype_id']) && isset($shifttypes[$_REQUEST['shifttype_id']])) {
+                    page_link_to('admin_import')
-          $shifttype_id = $_REQUEST['shifttype_id'];
+                    . '&step=import&shifttype_id=' . $shifttype_id
-      } else {
+                    . "&add_minutes_end=" . $add_minutes_end
-          error(_('Please select a shift type.'));
+                    . "&add_minutes_start=" . $add_minutes_start
-          redirect(page_link_to('admin_import'));
+                );
-      }
+            break;
-      
+
-      if (isset($_REQUEST['add_minutes_start']) && is_numeric(trim($_REQUEST['add_minutes_start']))) {
+        case 'import':
-          $add_minutes_start = trim($_REQUEST['add_minutes_start']);
+            if (!file_exists($import_file)) {
-      } else {
+                error(_('Missing import file.'));
-          error(_("Please enter an amount of minutes to add to a talk's begin."));
+                redirect(page_link_to('admin_import'));
-          redirect(page_link_to('admin_import'));
+            }
-      }
+
-      
+            if (!file_exists($import_file)) {
-      if (isset($_REQUEST['add_minutes_end']) && is_numeric(trim($_REQUEST['add_minutes_end']))) {
+                redirect(page_link_to('admin_import'));
-          $add_minutes_end = trim($_REQUEST['add_minutes_end']);
+            }
-      } else {
+
-          error(_("Please enter an amount of minutes to add to a talk's end."));
+            if (isset($_REQUEST['shifttype_id']) && isset($shifttypes[$_REQUEST['shifttype_id']])) {
-          redirect(page_link_to('admin_import'));
+                $shifttype_id = $_REQUEST['shifttype_id'];
-      }
+            } else {
-      
+                error(_('Please select a shift type.'));
-      list($rooms_new, $rooms_deleted) = prepare_rooms($import_file);
+                redirect(page_link_to('admin_import'));
-      foreach ($rooms_new as $room) {
+            }
-          $result = Room_create($room, true, true);
+
-          if ($result === false) {
+            if (isset($_REQUEST['add_minutes_start']) && is_numeric(trim($_REQUEST['add_minutes_start']))) {
-              engelsystem_error('Unable to create room.');
+                $add_minutes_start = trim($_REQUEST['add_minutes_start']);
-          }
+            } else {
-          $rooms_import[trim($room)] = sql_id();
+                error(_("Please enter an amount of minutes to add to a talk's begin."));
-      }
+                redirect(page_link_to('admin_import'));
-      foreach ($rooms_deleted as $room) {
+            }
-          sql_query("DELETE FROM `Room` WHERE `Name`='" . sql_escape($room) . "' LIMIT 1");
+
-      }
+            if (isset($_REQUEST['add_minutes_end']) && is_numeric(trim($_REQUEST['add_minutes_end']))) {
-      
+                $add_minutes_end = trim($_REQUEST['add_minutes_end']);
-      list($events_new, $events_updated, $events_deleted) = prepare_events($import_file, $shifttype_id, $add_minutes_start, $add_minutes_end);
+            } else {
-      foreach ($events_new as $event) {
+                error(_("Please enter an amount of minutes to add to a talk's end."));
-          $result = Shift_create($event);
+                redirect(page_link_to('admin_import'));
-          if ($result === false) {
+            }
-              engelsystem_error('Unable to create shift.');
+
-          }
+            list($rooms_new, $rooms_deleted) = prepare_rooms($import_file);
-      }
+            foreach ($rooms_new as $room) {
-      
+                $result = Room_create($room, true, true);
-      foreach ($events_updated as $event) {
+                if ($result === false) {
-          $result = Shift_update_by_psid($event);
+                    engelsystem_error('Unable to create room.');
-          if ($result === false) {
+                }
-              engelsystem_error('Unable to update shift.');
+                $rooms_import[trim($room)] = sql_id();
-          }
+            }
-      }
+            foreach ($rooms_deleted as $room) {
-      
+                sql_query("DELETE FROM `Room` WHERE `Name`='" . sql_escape($room) . "' LIMIT 1");
-      foreach ($events_deleted as $event) {
+            }
-          $result = Shift_delete_by_psid($event['PSID']);
+
-          if ($result === false) {
+            list($events_new, $events_updated, $events_deleted) = prepare_events(
-              engelsystem_error('Unable to delete shift.');
+                $import_file,
-          }
+                $shifttype_id,
-      }
+                $add_minutes_start,
-      
+                $add_minutes_end
-      engelsystem_log("Frab import done");
+            );
-      
+            foreach ($events_new as $event) {
-      unlink($import_file);
+                $result = Shift_create($event);
-      
+                if ($result === false) {
-      $html .= div('well well-sm text-center', [
+                    engelsystem_error('Unable to create shift.');
-          '<span class="text-success">' . _('File Upload') . glyph('ok-circle') . '</span>' . mute(glyph('arrow-right')) . '<span class="text-success">' . _('Validation') . glyph('ok-circle') . '</span>' . mute(glyph('arrow-right')) . '<span class="text-success">' . _('Import') . glyph('ok-circle') . '</span>'
+                }
-      ]) . success(_("It's done!"), true);
+            }
-      break;
+
-    default:
+            foreach ($events_updated as $event) {
-      redirect(page_link_to('admin_import'));
+                $result = Shift_update_by_psid($event);
-  }
+                if ($result === false) {
+                    engelsystem_error('Unable to update shift.');
+                }
+            }
+
+            foreach ($events_deleted as $event) {
+                $result = Shift_delete_by_psid($event['PSID']);
+                if ($result === false) {
+                    engelsystem_error('Unable to delete shift.');
+                }
+            }
+
+            engelsystem_log("Frab import done");
+
+            unlink($import_file);
+
+            $html .= div('well well-sm text-center', [
+                    '<span class="text-success">' . _('File Upload') . glyph('ok-circle') . '</span>' . mute(glyph('arrow-right')) . '<span class="text-success">' . _('Validation') . glyph('ok-circle') . '</span>' . mute(glyph('arrow-right')) . '<span class="text-success">' . _('Import') . glyph('ok-circle') . '</span>'
+                ]) . success(_("It's done!"), true);
+            break;
+        default:
+            redirect(page_link_to('admin_import'));
+    }
 
     return page_with_title(admin_import_title(), [
-      msg(),
+        msg(),
-      $html
+        $html
-  ]);
+    ]);
 }
 
 function prepare_rooms($file)
@@ -270,20 +295,20 @@ function prepare_rooms($file)
     global $rooms_import;
     $data = read_xml($file);
 
-  // Load rooms from db for compare with input
+    // Load rooms from db for compare with input
-  $rooms = sql_select("SELECT * FROM `Room` WHERE `FromPentabarf`='Y'");
+    $rooms = sql_select("SELECT * FROM `Room` WHERE `FromPentabarf`='Y'");
     $rooms_db = [];
     $rooms_import = [];
     foreach ($rooms as $room) {
-        $rooms_db[] = (string) $room['Name'];
+        $rooms_db[] = (string)$room['Name'];
         $rooms_import[$room['Name']] = $room['RID'];
     }
 
     $events = $data->vcalendar->vevent;
     $rooms_pb = [];
     foreach ($events as $event) {
-        $rooms_pb[] = (string) $event->location;
+        $rooms_pb[] = (string)$event->location;
-        if (! isset($rooms_import[trim($event->location)])) {
+        if (!isset($rooms_import[trim($event->location)])) {
             $rooms_import[trim($event->location)] = trim($event->location);
         }
     }
@@ -293,9 +318,9 @@ function prepare_rooms($file)
     $rooms_deleted = array_diff($rooms_db, $rooms_pb);
 
     return [
-      $rooms_new,
+        $rooms_new,
-      $rooms_deleted
+        $rooms_deleted
-  ];
+    ];
 }
 
 function prepare_events($file, $shifttype_id, $add_minutes_start, $add_minutes_end)
@@ -314,16 +339,16 @@ function prepare_events($file, $shifttype_id, $add_minutes_start, $add_minutes_e
     foreach ($events as $event) {
         $event_pb = $event->children("http://pentabarf.org");
         $event_id = trim($event_pb->{
-      'event-id' });
+        'event-id'});
         $shifts_pb[$event_id] = [
-        'shifttype_id' => $shifttype_id,
+            'shifttype_id' => $shifttype_id,
-        'start' => parse_date("Ymd\THis", $event->dtstart) - $add_minutes_start * 60,
+            'start'        => parse_date("Ymd\THis", $event->dtstart) - $add_minutes_start * 60,
-        'end' => parse_date("Ymd\THis", $event->dtend) + $add_minutes_end * 60,
+            'end'          => parse_date("Ymd\THis", $event->dtend) + $add_minutes_end * 60,
-        'RID' => $rooms_import[trim($event->location)],
+            'RID'          => $rooms_import[trim($event->location)],
-        'title' => trim($event->summary),
+            'title'        => trim($event->summary),
-        'URL' => trim($event->url),
+            'URL'          => trim($event->url),
-        'PSID' => $event_id
+            'PSID'         => $event_id
-    ];
+        ];
     }
 
     $shifts = sql_select("SELECT * FROM `Shifts` WHERE `PSID` IS NOT NULL ORDER BY `start`");
@@ -335,7 +360,7 @@ function prepare_events($file, $shifttype_id, $add_minutes_start, $add_minutes_e
     $shifts_new = [];
     $shifts_updated = [];
     foreach ($shifts_pb as $shift) {
-        if (! isset($shifts_db[$shift['PSID']])) {
+        if (!isset($shifts_db[$shift['PSID']])) {
             $shifts_new[] = $shift;
         } else {
             $tmp = $shifts_db[$shift['PSID']];
@@ -347,22 +372,22 @@ function prepare_events($file, $shifttype_id, $add_minutes_start, $add_minutes_e
 
     $shifts_deleted = [];
     foreach ($shifts_db as $shift) {
-        if (! isset($shifts_pb[$shift['PSID']])) {
+        if (!isset($shifts_pb[$shift['PSID']])) {
             $shifts_deleted[] = $shift;
         }
     }
 
     return [
-      $shifts_new,
+        $shifts_new,
-      $shifts_updated,
+        $shifts_updated,
-      $shifts_deleted
+        $shifts_deleted
-  ];
+    ];
 }
 
 function read_xml($file)
 {
     global $xml_import;
-    if (! isset($xml_import)) {
+    if (!isset($xml_import)) {
         $xml_import = simplexml_load_file($file);
     }
     return $xml_import;
@@ -378,21 +403,21 @@ function shifts_printable($shifts, $shifttypes)
     $shifts_printable = [];
     foreach ($shifts as $shift) {
         $shifts_printable[] = [
-        'day' => date("l, Y-m-d", $shift['start']),
+            'day'       => date("l, Y-m-d", $shift['start']),
-        'start' => date("H:i", $shift['start']),
+            'start'     => date("H:i", $shift['start']),
-        'shifttype' => ShiftType_name_render([
+            'shifttype' => ShiftType_name_render([
-            'id' => $shift['shifttype_id'],
+                'id'   => $shift['shifttype_id'],
-            'name' => $shifttypes[$shift['shifttype_id']]
+                'name' => $shifttypes[$shift['shifttype_id']]
-        ]),
+            ]),
-        'title' => shorten($shift['title']),
+            'title'     => shorten($shift['title']),
-        'end' => date("H:i", $shift['end']),
+            'end'       => date("H:i", $shift['end']),
-        'room' => $rooms[$shift['RID']]
+            'room'      => $rooms[$shift['RID']]
-    ];
+        ];
     }
     return $shifts_printable;
 }
 
 function shift_sort($shift_a, $shift_b)
 {
-    return ($shift_a['start'] < $shift_b['start']) ? - 1 : 1;
+    return ($shift_a['start'] < $shift_b['start']) ? -1 : 1;
 }

includes/pages/admin_log.php

@@ -20,15 +20,15 @@ function admin_log()
     }
 
     return page_with_title(admin_log_title(), [
-      msg(),
+        msg(),
-      form([
+        form([
-          form_text('keyword', _("Search"), $filter),
+            form_text('keyword', _("Search"), $filter),
-          form_submit(_("Search"), "Go")
+            form_submit(_("Search"), "Go")
-      ]),
+        ]),
-      table([
+        table([
-          'date' => "Time",
+            'date'    => "Time",
-          'nick' => "Angel",
+            'nick'    => "Angel",
-          'message' => "Log Entry"
+            'message' => "Log Entry"
-      ], $log_entries)
+        ], $log_entries)
-  ]);
+    ]);
 }

includes/pages/admin_news.php

@@ -4,7 +4,7 @@ function admin_news()
 {
     global $user;
 
-    if (! isset($_GET["action"])) {
+    if (!isset($_GET["action"])) {
         redirect(page_link_to("news"));
     }
 
@@ -20,48 +20,50 @@ function admin_news()
         return error("No News found.", true);
     }
     switch ($_REQUEST["action"]) {
-    default:
+        default:
-      redirect(page_link_to('news'));
+            redirect(page_link_to('news'));
-    case 'edit':
+        case 'edit':
-      list($news) = $news;
+            list($news) = $news;
 
-      $user_source = User($news['UID']);
+            $user_source = User($news['UID']);
 
-      $html .= form([
+            $html .= form([
-          form_info(_("Date"), date("Y-m-d H:i", $news['Datum'])),
+                form_info(_("Date"), date("Y-m-d H:i", $news['Datum'])),
-          form_info(_("Author"), User_Nick_render($user_source)),
+                form_info(_("Author"), User_Nick_render($user_source)),
-          form_text('eBetreff', _("Subject"), $news['Betreff']),
+                form_text('eBetreff', _("Subject"), $news['Betreff']),
-          form_textarea('eText', _("Message"), $news['Text']),
+                form_textarea('eText', _("Message"), $news['Text']),
-          form_checkbox('eTreffen', _("Meeting"), $news['Treffen'] == 1, 1),
+                form_checkbox('eTreffen', _("Meeting"), $news['Treffen'] == 1, 1),
-          form_submit('submit', _("Save"))
+                form_submit('submit', _("Save"))
-      ], page_link_to('admin_news&action=save&id=' . $news_id));
+            ], page_link_to('admin_news&action=save&id=' . $news_id));
 
-      $html .= '<a class="btn btn-danger" href="' . page_link_to('admin_news&action=delete&id=' . $news_id) . '"><span class="glyphicon glyphicon-trash"></span> ' . _("Delete") . '</a>';
+            $html .= '<a class="btn btn-danger" href="' . page_link_to('admin_news&action=delete&id=' . $news_id) . '">'
-      break;
+                . '<span class="glyphicon glyphicon-trash"></span> ' . _("Delete")
+                . '</a>';
+            break;
 
-    case 'save':
+        case 'save':
-      list($news) = $news;
+            list($news) = $news;
 
-      sql_query("UPDATE `News` SET 
+            sql_query("UPDATE `News` SET 
               `Datum`='" . sql_escape(time()) . "', 
               `Betreff`='" . sql_escape($_POST["eBetreff"]) . "', 
               `Text`='" . sql_escape($_POST["eText"]) . "', 
               `UID`='" . sql_escape($user['UID']) . "', 
               `Treffen`='" . sql_escape($_POST["eTreffen"]) . "' 
               WHERE `ID`='" . sql_escape($news_id) . "'");
-      engelsystem_log("News updated: " . $_POST["eBetreff"]);
+            engelsystem_log("News updated: " . $_POST["eBetreff"]);
-      success(_("News entry updated."));
+            success(_("News entry updated."));
-      redirect(page_link_to("news"));
+            redirect(page_link_to("news"));
-      break;
+            break;
 
-    case 'delete':
+        case 'delete':
-      list($news) = $news;
+            list($news) = $news;
 
-      sql_query("DELETE FROM `News` WHERE `ID`='" . sql_escape($news_id) . "' LIMIT 1");
+            sql_query("DELETE FROM `News` WHERE `ID`='" . sql_escape($news_id) . "' LIMIT 1");
-      engelsystem_log("News deleted: " . $news['Betreff']);
+            engelsystem_log("News deleted: " . $news['Betreff']);
-      success(_("News entry deleted."));
+            success(_("News entry deleted."));
-      redirect(page_link_to("news"));
+            redirect(page_link_to("news"));
-      break;
+            break;
-  }
+    }
     return $html . '</div>';
 }

includes/pages/admin_questions.php

@@ -29,21 +29,25 @@ function admin_questions()
 {
     global $user;
 
-    if (! isset($_REQUEST['action'])) {
+    if (!isset($_REQUEST['action'])) {
         $unanswered_questions_table = [];
         $questions = sql_select("SELECT * FROM `Questions` WHERE `AID` IS NULL");
         foreach ($questions as $question) {
             $user_source = User($question['UID']);
 
             $unanswered_questions_table[] = [
-          'from' => User_Nick_render($user_source),
+                'from'     => User_Nick_render($user_source),
-          'question' => str_replace("\n", "<br />", $question['Question']),
+                'question' => str_replace("\n", "<br />", $question['Question']),
-          'answer' => form([
+                'answer'   => form([
-              form_textarea('answer', '', ''),
+                    form_textarea('answer', '', ''),
-              form_submit('submit', _("Save"))
+                    form_submit('submit', _("Save"))
-          ], page_link_to('admin_questions') . '&action=answer&id=' . $question['QID']),
+                ], page_link_to('admin_questions') . '&action=answer&id=' . $question['QID']),
-          'actions' => button(page_link_to("admin_questions") . '&action=delete&id=' . $question['QID'], _("delete"), 'btn-xs')
+                'actions'  => button(
-      ];
+                    page_link_to("admin_questions") . '&action=delete&id=' . $question['QID'],
+                    _("delete"),
+                    'btn-xs'
+                )
+            ];
         }
 
         $answered_questions_table = [];
@@ -52,71 +56,84 @@ function admin_questions()
             $user_source = User($question['UID']);
             $answer_user_source = User($question['AID']);
             $answered_questions_table[] = [
-          'from' => User_Nick_render($user_source),
+                'from'        => User_Nick_render($user_source),
-          'question' => str_replace("\n", "<br />", $question['Question']),
+                'question'    => str_replace("\n", "<br />", $question['Question']),
-          'answered_by' => User_Nick_render($answer_user_source),
+                'answered_by' => User_Nick_render($answer_user_source),
-          'answer' => str_replace("\n", "<br />", $question['Answer']),
+                'answer'      => str_replace("\n", "<br />", $question['Answer']),
-          'actions' => button(page_link_to("admin_questions") . '&action=delete&id=' . $question['QID'], _("delete"), 'btn-xs')
+                'actions'     => button(
-      ];
+                    page_link_to("admin_questions") . '&action=delete&id=' . $question['QID'],
+                    _("delete"),
+                    'btn-xs'
+                )
+            ];
         }
 
         return page_with_title(admin_questions_title(), [
-        '<h2>' . _("Unanswered questions") . '</h2>',
+            '<h2>' . _("Unanswered questions") . '</h2>',
-        table([
+            table([
-            'from' => _("From"),
+                'from'     => _("From"),
-            'question' => _("Question"),
+                'question' => _("Question"),
-            'answer' => _("Answer"),
+                'answer'   => _("Answer"),
-            'actions' => ''
+                'actions'  => ''
-        ], $unanswered_questions_table),
+            ], $unanswered_questions_table),
-        '<h2>' . _("Answered questions") . '</h2>',
+            '<h2>' . _("Answered questions") . '</h2>',
-        table([
+            table([
-            'from' => _("From"),
+                'from'        => _("From"),
-            'question' => _("Question"),
+                'question'    => _("Question"),
-            'answered_by' => _("Answered by"),
+                'answered_by' => _("Answered by"),
-            'answer' => _("Answer"),
+                'answer'      => _("Answer"),
-            'actions' => ''
+                'actions'     => ''
-        ], $answered_questions_table)
+            ], $answered_questions_table)
-    ]);
+        ]);
     } else {
         switch ($_REQUEST['action']) {
-      case 'answer':
+            case 'answer':
-        if (isset($_REQUEST['id']) && preg_match("/^[0-9]{1,11}$/", $_REQUEST['id'])) {
+                if (isset($_REQUEST['id']) && preg_match("/^[0-9]{1,11}$/", $_REQUEST['id'])) {
-            $question_id = $_REQUEST['id'];
+                    $question_id = $_REQUEST['id'];
-        } else {
+                } else {
-            return error("Incomplete call, missing Question ID.", true);
+                    return error("Incomplete call, missing Question ID.", true);
-        }
+                }
 
-        $question = sql_select("SELECT * FROM `Questions` WHERE `QID`='" . sql_escape($question_id) . "' LIMIT 1");
+                $question = sql_select("SELECT * FROM `Questions` WHERE `QID`='" . sql_escape($question_id) . "' LIMIT 1");
-        if (count($question) > 0 && $question[0]['AID'] == null) {
+                if (count($question) > 0 && $question[0]['AID'] == null) {
-            $answer = trim(preg_replace("/([^\p{L}\p{P}\p{Z}\p{N}\n]{1,})/ui", '', strip_tags($_REQUEST['answer'])));
+                    $answer = trim(
+                        preg_replace("/([^\p{L}\p{P}\p{Z}\p{N}\n]{1,})/ui",
+                            '',
+                            strip_tags($_REQUEST['answer'])
+                        ));
 
-            if ($answer != "") {
+                    if ($answer != "") {
-                sql_query("UPDATE `Questions` SET `AID`='" . sql_escape($user['UID']) . "', `Answer`='" . sql_escape($answer) . "' WHERE `QID`='" . sql_escape($question_id) . "' LIMIT 1");
+                        sql_query("
-                engelsystem_log("Question " . $question[0]['Question'] . " answered: " . $answer);
+                            UPDATE `Questions`
-                redirect(page_link_to("admin_questions"));
+                            SET `AID`='" . sql_escape($user['UID']) . "', `Answer`='" . sql_escape($answer) . "'
-            } else {
+                            WHERE `QID`='" . sql_escape($question_id) . "'
-                return error("Enter an answer!", true);
+                            LIMIT 1
-            }
+                        ");
-        } else {
+                        engelsystem_log("Question " . $question[0]['Question'] . " answered: " . $answer);
-            return error("No question found.", true);
+                        redirect(page_link_to("admin_questions"));
-        }
+                    } else {
-        break;
+                        return error("Enter an answer!", true);
-      case 'delete':
+                    }
-        if (isset($_REQUEST['id']) && preg_match("/^[0-9]{1,11}$/", $_REQUEST['id'])) {
+                } else {
-            $question_id = $_REQUEST['id'];
+                    return error("No question found.", true);
-        } else {
+                }
-            return error("Incomplete call, missing Question ID.", true);
+                break;
-        }
+            case 'delete':
+                if (isset($_REQUEST['id']) && preg_match("/^[0-9]{1,11}$/", $_REQUEST['id'])) {
+                    $question_id = $_REQUEST['id'];
+                } else {
+                    return error("Incomplete call, missing Question ID.", true);
+                }
 
-        $question = sql_select("SELECT * FROM `Questions` WHERE `QID`='" . sql_escape($question_id) . "' LIMIT 1");
+                $question = sql_select("SELECT * FROM `Questions` WHERE `QID`='" . sql_escape($question_id) . "' LIMIT 1");
-        if (count($question) > 0) {
+                if (count($question) > 0) {
-            sql_query("DELETE FROM `Questions` WHERE `QID`='" . sql_escape($question_id) . "' LIMIT 1");
+                    sql_query("DELETE FROM `Questions` WHERE `QID`='" . sql_escape($question_id) . "' LIMIT 1");
-            engelsystem_log("Question deleted: " . $question[0]['Question']);
+                    engelsystem_log("Question deleted: " . $question[0]['Question']);
-            redirect(page_link_to("admin_questions"));
+                    redirect(page_link_to("admin_questions"));
-        } else {
+                } else {
-            return error("No question found.", true);
+                    return error("No question found.", true);
+                }
+                break;
         }
-        break;
-    }
     }
 }

includes/pages/admin_rooms.php

@@ -11,14 +11,14 @@ function admin_rooms()
     $rooms = [];
     foreach ($rooms_source as $room) {
         $rooms[] = [
-        'name' => Room_name_render($room),
+            'name'           => Room_name_render($room),
-        'from_pentabarf' => $room['FromPentabarf'] == 'Y' ? '✓' : '',
+            'from_pentabarf' => $room['FromPentabarf'] == 'Y' ? '✓' : '',
-        'public' => $room['show'] == 'Y' ? '✓' : '',
+            'public'         => $room['show'] == 'Y' ? '✓' : '',
-        'actions' => table_buttons([
+            'actions'        => table_buttons([
-            button(page_link_to('admin_rooms') . '&show=edit&id=' . $room['RID'], _("edit"), 'btn-xs'),
+                button(page_link_to('admin_rooms') . '&show=edit&id=' . $room['RID'], _("edit"), 'btn-xs'),
-            button(page_link_to('admin_rooms') . '&show=delete&id=' . $room['RID'], _("delete"), 'btn-xs')
+                button(page_link_to('admin_rooms') . '&show=delete&id=' . $room['RID'], _("delete"), 'btn-xs')
-        ])
+            ])
-    ];
+        ];
     }
     $room = null;
 
@@ -92,7 +92,10 @@ function admin_rooms()
                 }
 
                 foreach ($angeltypes as $angeltype_id => $angeltype) {
-                    if (isset($_REQUEST['angeltype_count_' . $angeltype_id]) && preg_match("/^[0-9]{1,4}$/", $_REQUEST['angeltype_count_' . $angeltype_id])) {
+                    if (
+                        isset($_REQUEST['angeltype_count_' . $angeltype_id])
+                        && preg_match("/^[0-9]{1,4}$/", $_REQUEST['angeltype_count_' . $angeltype_id])
+                    ) {
                         $angeltypes_count[$angeltype_id] = $_REQUEST['angeltype_count_' . $angeltype_id];
                     } else {
                         $valid = false;
@@ -122,7 +125,10 @@ function admin_rooms()
                         }
                     }
 
-                    engelsystem_log("Set needed angeltypes of room " . $name . " to: " . join(", ", $needed_angeltype_info));
+                    engelsystem_log(
+                        "Set needed angeltypes of room " . $name
+                        . " to: " . join(", ", $needed_angeltype_info)
+                    );
                     success(_("Room saved."));
                     redirect(page_link_to("admin_rooms"));
                 }
@@ -130,38 +136,38 @@ function admin_rooms()
             $angeltypes_count_form = [];
             foreach ($angeltypes as $angeltype_id => $angeltype) {
                 $angeltypes_count_form[] = div('col-lg-4 col-md-6 col-xs-6', [
-            form_spinner('angeltype_count_' . $angeltype_id, $angeltype, $angeltypes_count[$angeltype_id])
+                    form_spinner('angeltype_count_' . $angeltype_id, $angeltype, $angeltypes_count[$angeltype_id])
-        ]);
+                ]);
             }
 
             return page_with_title(admin_rooms_title(), [
-          buttons([
+                buttons([
-              button(page_link_to('admin_rooms'), _("back"), 'back')
+                    button(page_link_to('admin_rooms'), _("back"), 'back')
-          ]),
+                ]),
-          $msg,
+                $msg,
-          form([
+                form([
-              div('row', [
+                    div('row', [
-                  div('col-md-6', [
+                        div('col-md-6', [
-                      form_text('name', _("Name"), $name),
+                            form_text('name', _("Name"), $name),
-                      form_checkbox('from_pentabarf', _("Frab import"), $from_pentabarf),
+                            form_checkbox('from_pentabarf', _("Frab import"), $from_pentabarf),
-                      form_checkbox('public', _("Public"), $public),
+                            form_checkbox('public', _("Public"), $public),
-                      form_text('number', _("Room number"), $number)
+                            form_text('number', _("Room number"), $number)
-                  ]),
+                        ]),
-                  div('col-md-6', [
+                        div('col-md-6', [
-                      div('row', [
+                            div('row', [
-                          div('col-md-12', [
+                                div('col-md-12', [
-                              form_info(_("Needed angels:"))
+                                    form_info(_("Needed angels:"))
-                          ]),
+                                ]),
-                          join($angeltypes_count_form)
+                                join($angeltypes_count_form)
-                      ])
+                            ])
-                  ])
+                        ])
-              ]),
+                    ]),
-              form_submit('submit', _("Save"))
+                    form_submit('submit', _("Save"))
-          ])
+                ])
-      ]);
+            ]);
         } elseif ($_REQUEST['show'] == 'delete') {
             if (isset($_REQUEST['ack'])) {
-                if (! Room_delete($room_id)) {
+                if (!Room_delete($room_id)) {
                     engelsystem_error("Unable to delete room.");
                 }
 
@@ -171,27 +177,27 @@ function admin_rooms()
             }
 
             return page_with_title(admin_rooms_title(), [
-          buttons([
+                buttons([
-              button(page_link_to('admin_rooms'), _("back"), 'back')
+                    button(page_link_to('admin_rooms'), _("back"), 'back')
-          ]),
+                ]),
-          sprintf(_("Do you want to delete room %s?"), $name),
+                sprintf(_("Do you want to delete room %s?"), $name),
-          buttons([
+                buttons([
-              button(page_link_to('admin_rooms') . '&show=delete&id=' . $room_id . '&ack', _("Delete"), 'delete')
+                    button(page_link_to('admin_rooms') . '&show=delete&id=' . $room_id . '&ack', _("Delete"), 'delete')
-          ])
+                ])
-      ]);
+            ]);
         }
     }
 
     return page_with_title(admin_rooms_title(), [
-      buttons([
+        buttons([
-          button(page_link_to('admin_rooms') . '&show=edit', _("add"))
+            button(page_link_to('admin_rooms') . '&show=edit', _("add"))
-      ]),
+        ]),
-      msg(),
+        msg(),
-      table([
+        table([
-          'name' => _("Name"),
+            'name'           => _("Name"),
-          'from_pentabarf' => _("Frab import"),
+            'from_pentabarf' => _("Frab import"),
-          'public' => _("Public"),
+            'public'         => _("Public"),
-          'actions' => ""
+            'actions'        => ""
-      ], $rooms)
+        ], $rooms)
-  ]);
+    ]);
 }

includes/pages/admin_shifts.php

@@ -20,22 +20,22 @@ function admin_shifts()
     $title = "";
     $shifttype_id = null;
 
-  // Locations laden (auch unsichtbare - fuer Erzengel ist das ok)
+    // Locations laden (auch unsichtbare - fuer Erzengel ist das ok)
-  $rooms = sql_select("SELECT * FROM `Room` ORDER BY `Name`");
+    $rooms = sql_select("SELECT * FROM `Room` ORDER BY `Name`");
     $room_array = [];
     foreach ($rooms as $room) {
         $room_array[$room['RID']] = $room['Name'];
     }
 
-  // Engeltypen laden
+    // Engeltypen laden
-  $types = sql_select("SELECT * FROM `AngelTypes` ORDER BY `name`");
+    $types = sql_select("SELECT * FROM `AngelTypes` ORDER BY `name`");
     $needed_angel_types = [];
     foreach ($types as $type) {
         $needed_angel_types[$type['id']] = 0;
     }
 
-  // Load shift types
+    // Load shift types
-  $shifttypes_source = ShiftTypes();
+    $shifttypes_source = ShiftTypes();
     if ($shifttypes_source === false) {
         engelsystem_error('Unable to load shift types.');
     }
@@ -61,17 +61,21 @@ function admin_shifts()
             error(_('Please select a shift type.'));
         }
 
-    // Name/Bezeichnung der Schicht, darf leer sein
+        // Name/Bezeichnung der Schicht, darf leer sein
-    $title = strip_request_item('title');
+        $title = strip_request_item('title');
 
-    // Auswahl der sichtbaren Locations für die Schichten
+        // Auswahl der sichtbaren Locations für die Schichten
-    if (isset($_REQUEST['rid']) && preg_match("/^[0-9]+$/", $_REQUEST['rid']) && isset($room_array[$_REQUEST['rid']])) {
+        if (
-        $rid = $_REQUEST['rid'];
+            isset($_REQUEST['rid'])
-    } else {
+            && preg_match("/^[0-9]+$/", $_REQUEST['rid'])
-        $valid = false;
+            && isset($room_array[$_REQUEST['rid']])
-        $rid = $rooms[0]['RID'];
+        ) {
-        error(_('Please select a location.'));
+            $rid = $_REQUEST['rid'];
-    }
+        } else {
+            $valid = false;
+            $rid = $rooms[0]['RID'];
+            error(_('Please select a location.'));
+        }
 
         if (isset($_REQUEST['start']) && $tmp = parse_date("Y-m-d H:i", $_REQUEST['start'])) {
             $start = $tmp;
@@ -104,7 +108,10 @@ function admin_shifts()
                     error(_('Please enter a shift duration in minutes.'));
                 }
             } elseif ($_REQUEST['mode'] == 'variable') {
-                if (isset($_REQUEST['change_hours']) && preg_match("/^([0-9]{2}(,|$))/", trim(str_replace(" ", "", $_REQUEST['change_hours'])))) {
+                if (
+                    isset($_REQUEST['change_hours'])
+                    && preg_match("/^([0-9]{2}(,|$))/", trim(str_replace(" ", "", $_REQUEST['change_hours'])))
+                ) {
                     $mode = 'variable';
                     $change_hours = array_map('trim', explode(",", $_REQUEST['change_hours']));
                 } else {
@@ -123,7 +130,10 @@ function admin_shifts()
             } elseif ($_REQUEST['angelmode'] == 'manually') {
                 $angelmode = 'manually';
                 foreach ($types as $type) {
-                    if (isset($_REQUEST['type_' . $type['id']]) && preg_match("/^[0-9]+$/", trim($_REQUEST['type_' . $type['id']]))) {
+                    if (
+                        isset($_REQUEST['type_' . $type['id']])
+                        && preg_match("/^[0-9]+$/", trim($_REQUEST['type_' . $type['id']]))
+                    ) {
                         $needed_angel_types[$type['id']] = trim($_REQUEST['type_' . $type['id']]);
                     } else {
                         $valid = false;
@@ -143,140 +153,148 @@ function admin_shifts()
             error(_('Please select needed angels.'));
         }
 
-    // Beim Zurück-Knopf das Formular zeigen
+        // Beim Zurück-Knopf das Formular zeigen
-    if (isset($_REQUEST['back'])) {
+        if (isset($_REQUEST['back'])) {
-        $valid = false;
+            $valid = false;
-    }
-    
-    // Alle Eingaben in Ordnung
-    if ($valid) {
-        if ($angelmode == 'location') {
-            $needed_angel_types = [];
-            $needed_angel_types_location = sql_select("SELECT * FROM `NeededAngelTypes` WHERE `room_id`='" . sql_escape($rid) . "'");
-            foreach ($needed_angel_types_location as $type) {
-                $needed_angel_types[$type['angel_type_id']] = $type['count'];
-            }
         }
-        $shifts = [];
-        if ($mode == 'single') {
-            $shifts[] = [
-            'start' => $start,
-            'end' => $end,
-            'RID' => $rid,
-            'title' => $title,
-            'shifttype_id' => $shifttype_id
-        ];
-        } elseif ($mode == 'multi') {
-            $shift_start = $start;
-            do {
-                $shift_end = $shift_start + $length * 60;
 
-                if ($shift_end > $end) {
+        // Alle Eingaben in Ordnung
-                    $shift_end = $end;
+        if ($valid) {
-                }
+            if ($angelmode == 'location') {
-                if ($shift_start >= $shift_end) {
+                $needed_angel_types = [];
-                    break;
+                $needed_angel_types_location = sql_select("SELECT * FROM `NeededAngelTypes` WHERE `room_id`='" . sql_escape($rid) . "'");
+                foreach ($needed_angel_types_location as $type) {
+                    $needed_angel_types[$type['angel_type_id']] = $type['count'];
                 }
-          
+            }
+            $shifts = [];
+            if ($mode == 'single') {
                 $shifts[] = [
-              'start' => $shift_start,
+                    'start'        => $start,
-              'end' => $shift_end,
+                    'end'          => $end,
-              'RID' => $rid,
+                    'RID'          => $rid,
-              'title' => $title,
+                    'title'        => $title,
-              'shifttype_id' => $shifttype_id
+                    'shifttype_id' => $shifttype_id
-          ];
+                ];
+            } elseif ($mode == 'multi') {
+                $shift_start = $start;
+                do {
+                    $shift_end = $shift_start + $length * 60;
 
-                $shift_start = $shift_end;
+                    if ($shift_end > $end) {
-            } while ($shift_end < $end);
+                        $shift_end = $end;
-        } elseif ($mode == 'variable') {
+                    }
-            rsort($change_hours);
+                    if ($shift_start >= $shift_end) {
-            $day = parse_date("Y-m-d H:i", date("Y-m-d", $start) . " 00:00");
+                        break;
-            $change_index = 0;
+                    }
-        // Ersten/nächsten passenden Schichtwechsel suchen
-        foreach ($change_hours as $i => $change_hour) {
-            if ($start < $day + $change_hour * 60 * 60) {
-                $change_index = $i;
-            } elseif ($start == $day + $change_hour * 60 * 60) {
-                // Start trifft Schichtwechsel
-            $change_index = ($i + count($change_hours) - 1) % count($change_hours);
-                break;
-            } else {
-                break;
-            }
-        }
 
-            $shift_start = $start;
+                    $shifts[] = [
-            do {
+                        'start'        => $shift_start,
-                $day = parse_date("Y-m-d H:i", date("Y-m-d", $shift_start) . " 00:00");
+                        'end'          => $shift_end,
-                $shift_end = $day + $change_hours[$change_index] * 60 * 60;
+                        'RID'          => $rid,
+                        'title'        => $title,
+                        'shifttype_id' => $shifttype_id
+                    ];
 
-                if ($shift_end > $end) {
+                    $shift_start = $shift_end;
-                    $shift_end = $end;
+                } while ($shift_end < $end);
-                }
+            } elseif ($mode == 'variable') {
-                if ($shift_start >= $shift_end) {
+                rsort($change_hours);
-                    $shift_end += 24 * 60 * 60;
+                $day = parse_date("Y-m-d H:i", date("Y-m-d", $start) . " 00:00");
+                $change_index = 0;
+                // Ersten/nächsten passenden Schichtwechsel suchen
+                foreach ($change_hours as $i => $change_hour) {
+                    if ($start < $day + $change_hour * 60 * 60) {
+                        $change_index = $i;
+                    } elseif ($start == $day + $change_hour * 60 * 60) {
+                        // Start trifft Schichtwechsel
+                        $change_index = ($i + count($change_hours) - 1) % count($change_hours);
+                        break;
+                    } else {
+                        break;
+                    }
                 }
 
-                $shifts[] = [
+                $shift_start = $start;
-              'start' => $shift_start,
+                do {
-              'end' => $shift_end,
+                    $day = parse_date("Y-m-d H:i", date("Y-m-d", $shift_start) . " 00:00");
-              'RID' => $rid,
+                    $shift_end = $day + $change_hours[$change_index] * 60 * 60;
-              'title' => $title,
-              'shifttype_id' => $shifttype_id
-          ];
 
-                $shift_start = $shift_end;
+                    if ($shift_end > $end) {
-                $change_index = ($change_index + count($change_hours) - 1) % count($change_hours);
+                        $shift_end = $end;
-            } while ($shift_end < $end);
+                    }
-        }
+                    if ($shift_start >= $shift_end) {
+                        $shift_end += 24 * 60 * 60;
+                    }
 
-        $shifts_table = [];
+                    $shifts[] = [
-        foreach ($shifts as $shift) {
+                        'start'        => $shift_start,
-            $shifts_table_entry = [
+                        'end'          => $shift_end,
-            'timeslot' => '<span class="glyphicon glyphicon-time"></span> ' . date("Y-m-d H:i", $shift['start']) . ' - ' . date("H:i", $shift['end']) . '<br />' . Room_name_render(Room($shift['RID'])),
+                        'RID'          => $rid,
-            'title' => ShiftType_name_render(ShiftType($shifttype_id)) . ($shift['title'] ? '<br />' . $shift['title'] : ''),
+                        'title'        => $title,
-            'needed_angels' => ''
+                        'shifttype_id' => $shifttype_id
-        ];
+                    ];
-            foreach ($types as $type) {
+
-                if (isset($needed_angel_types[$type['id']]) && $needed_angel_types[$type['id']] > 0) {
+                    $shift_start = $shift_end;
-                    $shifts_table_entry['needed_angels'] .= '<b>' . AngelType_name_render($type) . ':</b> ' . $needed_angel_types[$type['id']] . '<br />';
+                    $change_index = ($change_index + count($change_hours) - 1) % count($change_hours);
+                } while ($shift_end < $end);
+            }
+
+            $shifts_table = [];
+            foreach ($shifts as $shift) {
+                $shifts_table_entry = [
+                    'timeslot'      =>
+                        '<span class="glyphicon glyphicon-time"></span> '
+                        . date("Y-m-d H:i", $shift['start'])
+                        . ' - '
+                        . date("H:i", $shift['end'])
+                        . '<br />'
+                        . Room_name_render(Room($shift['RID'])),
+                    'title'         =>
+                        ShiftType_name_render(ShiftType($shifttype_id))
+                        . ($shift['title'] ? '<br />' . $shift['title'] : ''),
+                    'needed_angels' => ''
+                ];
+                foreach ($types as $type) {
+                    if (isset($needed_angel_types[$type['id']]) && $needed_angel_types[$type['id']] > 0) {
+                        $shifts_table_entry['needed_angels'] .= '<b>' . AngelType_name_render($type) . ':</b> ' . $needed_angel_types[$type['id']] . '<br />';
+                    }
                 }
+                $shifts_table[] = $shifts_table_entry;
             }
-            $shifts_table[] = $shifts_table_entry;
-        }
 
-      // Fürs Anlegen zwischenspeichern:
+            // Fürs Anlegen zwischenspeichern:
-      $_SESSION['admin_shifts_shifts'] = $shifts;
+            $_SESSION['admin_shifts_shifts'] = $shifts;
-        $_SESSION['admin_shifts_types'] = $needed_angel_types;
+            $_SESSION['admin_shifts_types'] = $needed_angel_types;
 
-        $hidden_types = "";
+            $hidden_types = "";
-        foreach ($needed_angel_types as $type_id => $count) {
+            foreach ($needed_angel_types as $type_id => $count) {
-            $hidden_types .= form_hidden('type_' . $type_id, $count);
+                $hidden_types .= form_hidden('type_' . $type_id, $count);
+            }
+            return page_with_title(_("Preview"), [
+                form([
+                    $hidden_types,
+                    form_hidden('shifttype_id', $shifttype_id),
+                    form_hidden('title', $title),
+                    form_hidden('rid', $rid),
+                    form_hidden('start', date("Y-m-d H:i", $start)),
+                    form_hidden('end', date("Y-m-d H:i", $end)),
+                    form_hidden('mode', $mode),
+                    form_hidden('length', $length),
+                    form_hidden('change_hours', implode(', ', $change_hours)),
+                    form_hidden('angelmode', $angelmode),
+                    form_submit('back', _("back")),
+                    table([
+                        'timeslot'      => _('Time and location'),
+                        'title'         => _('Type and title'),
+                        'needed_angels' => _('Needed angels')
+                    ], $shifts_table),
+                    form_submit('submit', _("Save"))
+                ])
+            ]);
         }
-        return page_with_title(_("Preview"), [
-          form([
-              $hidden_types,
-              form_hidden('shifttype_id', $shifttype_id),
-              form_hidden('title', $title),
-              form_hidden('rid', $rid),
-              form_hidden('start', date("Y-m-d H:i", $start)),
-              form_hidden('end', date("Y-m-d H:i", $end)),
-              form_hidden('mode', $mode),
-              form_hidden('length', $length),
-              form_hidden('change_hours', implode(', ', $change_hours)),
-              form_hidden('angelmode', $angelmode),
-              form_submit('back', _("back")),
-              table([
-                  'timeslot' => _('Time and location'),
-                  'title' => _('Type and title'),
-                  'needed_angels' => _('Needed angels')
-              ], $shifts_table),
-              form_submit('submit', _("Save"))
-          ])
-      ]);
-    }
     } elseif (isset($_REQUEST['submit'])) {
-        if (! is_array($_SESSION['admin_shifts_shifts']) || ! is_array($_SESSION['admin_shifts_types'])) {
+        if (!is_array($_SESSION['admin_shifts_shifts']) || !is_array($_SESSION['admin_shifts_types'])) {
             redirect(page_link_to('admin_shifts'));
         }
 
@@ -288,7 +306,12 @@ function admin_shifts()
                 engelsystem_error('Unable to create shift.');
             }
 
-            engelsystem_log("Shift created: " . $shifttypes[$shift['shifttype_id']] . " with title " . $shift['title'] . " from " . date("Y-m-d H:i", $shift['start']) . " to " . date("Y-m-d H:i", $shift['end']));
+            engelsystem_log(
+                "Shift created: " . $shifttypes[$shift['shifttype_id']]
+                . " with title " . $shift['title']
+                . " from " . date("Y-m-d H:i", $shift['start'])
+                . " to " . date("Y-m-d H:i", $shift['end'])
+            );
             $needed_angel_types_info = [];
             foreach ($_SESSION['admin_shifts_types'] as $type_id => $count) {
                 $angel_type_source = sql_select("SELECT * FROM `AngelTypes` WHERE `id`='" . sql_escape($type_id) . "' LIMIT 1");
@@ -307,41 +330,60 @@ function admin_shifts()
         unset($_SESSION['admin_shifts_types']);
     }
 
-    if (! isset($_REQUEST['rid'])) {
+    if (!isset($_REQUEST['rid'])) {
         $_REQUEST['rid'] = null;
     }
     $angel_types = "";
     foreach ($types as $type) {
-        $angel_types .= '<div class="col-md-4">' . form_spinner('type_' . $type['id'], $type['name'], $needed_angel_types[$type['id']]) . '</div>';
+        $angel_types .= '<div class="col-md-4">' . form_spinner(
+                'type_' . $type['id'],
+                $type['name'],
+                $needed_angel_types[$type['id']]
+            )
+            . '</div>';
     }
 
     return page_with_title(admin_shifts_title(), [
-      msg(),
+        msg(),
-      form([
+        form([
-          form_select('shifttype_id', _('Shifttype'), $shifttypes, $shifttype_id),
+            form_select('shifttype_id', _('Shifttype'), $shifttypes, $shifttype_id),
-          form_text('title', _("Title"), $title),
+            form_text('title', _("Title"), $title),
-          form_select('rid', _("Room"), $room_array, $_REQUEST['rid']),
+            form_select('rid', _("Room"), $room_array, $_REQUEST['rid']),
-          div('row', [
+            div('row', [
-              div('col-md-6', [
+                div('col-md-6', [
-                  form_text('start', _("Start"), date("Y-m-d H:i", $start)),
+                    form_text('start', _("Start"), date("Y-m-d H:i", $start)),
-                  form_text('end', _("End"), date("Y-m-d H:i", $end)),
+                    form_text('end', _("End"), date("Y-m-d H:i", $end)),
-                  form_info(_("Mode"), ''),
+                    form_info(_("Mode"), ''),
-                  form_radio('mode', _("Create one shift"), $mode == 'single', 'single'),
+                    form_radio('mode', _("Create one shift"), $mode == 'single', 'single'),
-                  form_radio('mode', _("Create multiple shifts"), $mode == 'multi', 'multi'),
+                    form_radio('mode', _("Create multiple shifts"), $mode == 'multi', 'multi'),
-                  form_text('length', _("Length"), ! empty($_REQUEST['length']) ? $_REQUEST['length'] : '120'),
+                    form_text('length', _("Length"), !empty($_REQUEST['length']) ? $_REQUEST['length'] : '120'),
-                  form_radio('mode', _("Create multiple shifts with variable length"), $mode == 'variable', 'variable'),
+                    form_radio(
-                  form_text('change_hours', _("Shift change hours"), ! empty($_REQUEST['change_hours']) ? $_REQUEST['change_hours'] : '00, 04, 08, 10, 12, 14, 16, 18, 20, 22')
+                        'mode',
-              ]),
+                        _("Create multiple shifts with variable length"),
-              div('col-md-6', [
+                        $mode == 'variable',
-                  form_info(_("Needed angels"), ''),
+                        'variable'
-                  form_radio('angelmode', _("Take needed angels from room settings"), $angelmode == 'location', 'location'),
+                    ),
-                  form_radio('angelmode', _("The following angels are needed"), $angelmode == 'manually', 'manually'),
+                    form_text(
-                  div('row', [
+                        'change_hours',
-                      $angel_types
+                        _("Shift change hours"),
-                  ])
+                        !empty($_REQUEST['change_hours']) ? $_REQUEST['change_hours'] : '00, 04, 08, 10, 12, 14, 16, 18, 20, 22'
-              ])
+                    )
-          ]),
+                ]),
-          form_submit('preview', _("Preview"))
+                div('col-md-6', [
-      ])
+                    form_info(_("Needed angels"), ''),
-  ]);
+                    form_radio(
+                        'angelmode',
+                        _("Take needed angels from room settings"),
+                        $angelmode == 'location',
+                        'location'
+                    ),
+                    form_radio('angelmode', _("The following angels are needed"), $angelmode == 'manually', 'manually'),
+                    div('row', [
+                        $angel_types
+                    ])
+                ])
+            ]),
+            form_submit('preview', _("Preview"))
+        ])
+    ]);
 }

includes/pages/admin_user.php

@@ -11,12 +11,12 @@ function admin_user()
 
     $html = '';
 
-    if (! isset($_REQUEST['id'])) {
+    if (!isset($_REQUEST['id'])) {
         redirect(users_link());
     }
 
     $user_id = $_REQUEST['id'];
-    if (! isset($_REQUEST['action'])) {
+    if (!isset($_REQUEST['action'])) {
         $user_source = User($user_id);
         if ($user_source == null) {
             error(_('This user does not exist.'));
@@ -42,29 +42,31 @@ function admin_user()
             $html .= "  <tr><td>email</td><td>" . "<input type=\"text\" size=\"40\" name=\"eemail\" value=\"" . $user_source['email'] . "\"></td></tr>\n";
         }
         $html .= "  <tr><td>jabber</td><td>" . "<input type=\"text\" size=\"40\" name=\"ejabber\" value=\"" . $user_source['jabber'] . "\"></td></tr>\n";
-        $html .= "  <tr><td>Size</td><td>" . html_select_key('size', 'eSize', $tshirt_sizes, $user_source['Size']) . "</td></tr>\n";
+        $html .= "  <tr><td>Size</td><td>"
+            . html_select_key('size', 'eSize', $tshirt_sizes, $user_source['Size'])
+            . "</td></tr>\n";
 
         $options = [
-        '1' => _("Yes"),
+            '1' => _("Yes"),
-        '0' => _("No")
+            '0' => _("No")
-    ];
+        ];
 
-    // Gekommen?
+        // Gekommen?
-    $html .= "  <tr><td>Gekommen</td><td>\n";
+        $html .= "  <tr><td>Gekommen</td><td>\n";
         $html .= html_options('eGekommen', $options, $user_source['Gekommen']) . "</td></tr>\n";
 
-    // Aktiv?
+        // Aktiv?
-    $html .= "  <tr><td>Aktiv</td><td>\n";
+        $html .= "  <tr><td>Aktiv</td><td>\n";
         $html .= html_options('eAktiv', $options, $user_source['Aktiv']) . "</td></tr>\n";
 
-    // Aktiv erzwingen
+        // Aktiv erzwingen
-    if (in_array('admin_active', $privileges)) {
+        if (in_array('admin_active', $privileges)) {
-        $html .= "  <tr><td>" . _("Force active") . "</td><td>\n";
+            $html .= "  <tr><td>" . _("Force active") . "</td><td>\n";
-        $html .= html_options('force_active', $options, $user_source['force_active']) . "</td></tr>\n";
+            $html .= html_options('force_active', $options, $user_source['force_active']) . "</td></tr>\n";
-    }
+        }
 
-    // T-Shirt bekommen?
+        // T-Shirt bekommen?
-    $html .= "  <tr><td>T-Shirt</td><td>\n";
+        $html .= "  <tr><td>T-Shirt</td><td>\n";
         $html .= html_options('eTshirt', $options, $user_source['Tshirt']) . "</td></tr>\n";
 
         $html .= "  <tr><td>Hometown</td><td>" . "<input type=\"text\" size=\"40\" name=\"Hometown\" value=\"" . $user_source['Hometown'] . "\"></td></tr>\n";
@@ -119,55 +121,56 @@ function admin_user()
         }
 
         $html .= buttons([
-        button(user_delete_link($user_source), glyph('lock') . _("delete"), 'btn-danger')
+            button(user_delete_link($user_source), glyph('lock') . _("delete"), 'btn-danger')
-    ]);
+        ]);
 
         $html .= "<hr />";
     } else {
         switch ($_REQUEST['action']) {
-      case 'save_groups':
+            case 'save_groups':
-        if ($user_id != $user['UID']) {
+                if ($user_id != $user['UID']) {
-            $my_highest_group = sql_select("SELECT * FROM `UserGroups` WHERE `uid`='" . sql_escape($user['UID']) . "' ORDER BY `group_id`");
+                    $my_highest_group = sql_select("SELECT * FROM `UserGroups` WHERE `uid`='" . sql_escape($user['UID']) . "' ORDER BY `group_id`");
-            $his_highest_group = sql_select("SELECT * FROM `UserGroups` WHERE `uid`='" . sql_escape($user_id) . "' ORDER BY `group_id`");
+                    $his_highest_group = sql_select("SELECT * FROM `UserGroups` WHERE `uid`='" . sql_escape($user_id) . "' ORDER BY `group_id`");
-          
+
-            if (count($my_highest_group) > 0 && (count($his_highest_group) == 0 || ($my_highest_group[0]['group_id'] <= $his_highest_group[0]['group_id']))) {
+                    if (count($my_highest_group) > 0 && (count($his_highest_group) == 0 || ($my_highest_group[0]['group_id'] <= $his_highest_group[0]['group_id']))) {
-                $groups_source = sql_select("SELECT * FROM `Groups` LEFT OUTER JOIN `UserGroups` ON (`UserGroups`.`group_id` = `Groups`.`UID` AND `UserGroups`.`uid` = '" . sql_escape($user_id) . "') WHERE `Groups`.`UID` >= '" . sql_escape($my_highest_group[0]['group_id']) . "' ORDER BY `Groups`.`Name`");
+                        $groups_source = sql_select("SELECT * FROM `Groups` LEFT OUTER JOIN `UserGroups` ON (`UserGroups`.`group_id` = `Groups`.`UID` AND `UserGroups`.`uid` = '" . sql_escape($user_id) . "') WHERE `Groups`.`UID` >= '" . sql_escape($my_highest_group[0]['group_id']) . "' ORDER BY `Groups`.`Name`");
-                $groups = [];
+                        $groups = [];
-                $grouplist = [];
+                        $grouplist = [];
-                foreach ($groups_source as $group) {
+                        foreach ($groups_source as $group) {
-                    $groups[$group['UID']] = $group;
+                            $groups[$group['UID']] = $group;
-                    $grouplist[] = $group['UID'];
+                            $grouplist[] = $group['UID'];
-                }
+                        }
-            
+
-                if (! is_array($_REQUEST['groups'])) {
+                        if (!is_array($_REQUEST['groups'])) {
-                    $_REQUEST['groups'] = [];
+                            $_REQUEST['groups'] = [];
-                }
+                        }
-            
+
-                sql_query("DELETE FROM `UserGroups` WHERE `uid`='" . sql_escape($user_id) . "'");
+                        sql_query("DELETE FROM `UserGroups` WHERE `uid`='" . sql_escape($user_id) . "'");
-                $user_groups_info = [];
+                        $user_groups_info = [];
-                foreach ($_REQUEST['groups'] as $group) {
+                        foreach ($_REQUEST['groups'] as $group) {
-                    if (in_array($group, $grouplist)) {
+                            if (in_array($group, $grouplist)) {
-                        sql_query("INSERT INTO `UserGroups` SET `uid`='" . sql_escape($user_id) . "', `group_id`='" . sql_escape($group) . "'");
+                                sql_query("INSERT INTO `UserGroups` SET `uid`='" . sql_escape($user_id) . "', `group_id`='" . sql_escape($group) . "'");
-                        $user_groups_info[] = $groups[$group]['Name'];
+                                $user_groups_info[] = $groups[$group]['Name'];
+                            }
+                        }
+                        $user_source = User($user_id);
+                        engelsystem_log("Set groups of " . User_Nick_render($user_source) . " to: " . join(", ",
+                                $user_groups_info));
+                        $html .= success("Benutzergruppen gespeichert.", true);
+                    } else {
+                        $html .= error("Du kannst keine Engel mit mehr Rechten bearbeiten.", true);
                     }
+                } else {
+                    $html .= error("Du kannst Deine eigenen Rechte nicht bearbeiten.", true);
                 }
-                $user_source = User($user_id);
+                break;
-                engelsystem_log("Set groups of " . User_Nick_render($user_source) . " to: " . join(", ", $user_groups_info));
-                $html .= success("Benutzergruppen gespeichert.", true);
-            } else {
-                $html .= error("Du kannst keine Engel mit mehr Rechten bearbeiten.", true);
-            }
-        } else {
-            $html .= error("Du kannst Deine eigenen Rechte nicht bearbeiten.", true);
-        }
-        break;
 
-      case 'save':
+            case 'save':
-        $force_active = $user['force_active'];
+                $force_active = $user['force_active'];
-        if (in_array('admin_active', $privileges)) {
+                if (in_array('admin_active', $privileges)) {
-            $force_active = $_REQUEST['force_active'];
+                    $force_active = $_REQUEST['force_active'];
-        }
+                }
-        $SQL = "UPDATE `User` SET 
+                $SQL = "UPDATE `User` SET 
               `Nick` = '" . sql_escape($_POST["eNick"]) . "', 
               `Name` = '" . sql_escape($_POST["eName"]) . "', 
               `Vorname` = '" . sql_escape($_POST["eVorname"]) . "', 
@@ -185,25 +188,25 @@ function admin_user()
               `Hometown` = '" . sql_escape($_POST["Hometown"]) . "' 
               WHERE `UID` = '" . sql_escape($user_id) . "' 
               LIMIT 1";
-        sql_query($SQL);
+                sql_query($SQL);
-        engelsystem_log("Updated user: " . $_POST["eNick"] . ", " . $_POST["eSize"] . ", arrived: " . $_POST["eGekommen"] . ", active: " . $_POST["eAktiv"] . ", tshirt: " . $_POST["eTshirt"]);
+                engelsystem_log("Updated user: " . $_POST["eNick"] . ", " . $_POST["eSize"] . ", arrived: " . $_POST["eGekommen"] . ", active: " . $_POST["eAktiv"] . ", tshirt: " . $_POST["eTshirt"]);
-        $html .= success("Änderung wurde gespeichert...\n", true);
+                $html .= success("Änderung wurde gespeichert...\n", true);
-        break;
+                break;
-      
+
-      case 'change_pw':
+            case 'change_pw':
-        if ($_REQUEST['new_pw'] != "" && $_REQUEST['new_pw'] == $_REQUEST['new_pw2']) {
+                if ($_REQUEST['new_pw'] != "" && $_REQUEST['new_pw'] == $_REQUEST['new_pw2']) {
-            set_password($user_id, $_REQUEST['new_pw']);
+                    set_password($user_id, $_REQUEST['new_pw']);
-            $user_source = User($user_id);
+                    $user_source = User($user_id);
-            engelsystem_log("Set new password for " . User_Nick_render($user_source));
+                    engelsystem_log("Set new password for " . User_Nick_render($user_source));
-            $html .= success("Passwort neu gesetzt.", true);
+                    $html .= success("Passwort neu gesetzt.", true);
-        } else {
+                } else {
-            $html .= error("Die Eingaben müssen übereinstimmen und dürfen nicht leer sein!", true);
+                    $html .= error("Die Eingaben müssen übereinstimmen und dürfen nicht leer sein!", true);
+                }
+                break;
         }
-        break;
-    }
     }
 
     return page_with_title(_("Edit user"), [
-      $html
+        $html
-  ]);
+    ]);
 }

includes/pages/guest_login.php

@@ -45,7 +45,7 @@ function guest_register()
     $angel_types = [];
     foreach ($angel_types_source as $angel_type) {
         $angel_types[$angel_type['id']] = $angel_type['name'] . ($angel_type['restricted'] ? " (restricted)" : "");
-        if (! $angel_type['restricted']) {
+        if (!$angel_type['restricted']) {
             $selected_angel_types[] = $angel_type['id'];
         }
     }
@@ -61,12 +61,15 @@ function guest_register()
             }
         } else {
             $valid = false;
-            $msg .= error(sprintf(_("Your nick "%s" is too short (min. 2 characters)."), User_validate_Nick($_REQUEST['nick'])), true);
+            $msg .= error(sprintf(
+                _("Your nick "%s" is too short (min. 2 characters)."),
+                User_validate_Nick($_REQUEST['nick'])
+            ), true);
         }
 
         if (isset($_REQUEST['mail']) && strlen(strip_request_item('mail')) > 0) {
             $mail = strip_request_item('mail');
-            if (! check_email($mail)) {
+            if (!check_email($mail)) {
                 $valid = false;
                 $msg .= error(_("E-mail address is not correct."), true);
             }
@@ -85,7 +88,7 @@ function guest_register()
 
         if (isset($_REQUEST['jabber']) && strlen(strip_request_item('jabber')) > 0) {
             $jabber = strip_request_item('jabber');
-            if (! check_email($jabber)) {
+            if (!check_email($jabber)) {
                 $valid = false;
                 $msg .= error(_("Please check your jabber account information."), true);
             }
@@ -107,14 +110,17 @@ function guest_register()
             }
         } else {
             $valid = false;
-            $msg .= error(sprintf(_("Your password is too short (please use at least %s characters)."), $min_password_length), true);
+            $msg .= error(sprintf(
+                _("Your password is too short (please use at least %s characters)."),
+                $min_password_length
+            ), true);
         }
 
         if (isset($_REQUEST['planned_arrival_date'])) {
             $tmp = parse_date("Y-m-d H:i", $_REQUEST['planned_arrival_date'] . " 00:00");
             $result = User_validate_planned_arrival_date($tmp);
             $planned_arrival_date = $result->getValue();
-            if (! $result->isValid()) {
+            if (!$result->isValid()) {
                 $valid = false;
                 error(_("Please enter your planned date of arrival. It should be after the buildup start date and before teardown end date."));
             }
@@ -127,10 +133,10 @@ function guest_register()
             }
         }
 
-    // Trivia
+        // Trivia
-    if (isset($_REQUEST['lastname'])) {
+        if (isset($_REQUEST['lastname'])) {
-        $lastname = strip_request_item('lastname');
+            $lastname = strip_request_item('lastname');
-    }
+        }
         if (isset($_REQUEST['prename'])) {
             $prename = strip_request_item('prename');
         }
@@ -177,30 +183,33 @@ function guest_register()
           `arrival_date`=NULL,
           `planned_arrival_date`='" . sql_escape($planned_arrival_date) . "'");
 
-      // Assign user-group and set password
+            // Assign user-group and set password
-      $user_id = sql_id();
+            $user_id = sql_id();
             sql_query("INSERT INTO `UserGroups` SET `uid`='" . sql_escape($user_id) . "', `group_id`=-2");
             set_password($user_id, $_REQUEST['password']);
 
-      // Assign angel-types
+            // Assign angel-types
-      $user_angel_types_info = [];
+            $user_angel_types_info = [];
             foreach ($selected_angel_types as $selected_angel_type_id) {
                 sql_query("INSERT INTO `UserAngelTypes` SET `user_id`='" . sql_escape($user_id) . "', `angeltype_id`='" . sql_escape($selected_angel_type_id) . "'");
                 $user_angel_types_info[] = $angel_types[$selected_angel_type_id];
             }
 
-            engelsystem_log("User " . User_Nick_render(User($user_id)) . " signed up as: " . join(", ", $user_angel_types_info));
+            engelsystem_log(
+                "User " . User_Nick_render(User($user_id))
+                . " signed up as: " . join(", ", $user_angel_types_info)
+            );
             success(_("Angel registration successful!"));
 
-      // User is already logged in - that means a supporter has registered an angel. Return to register page.
+            // User is already logged in - that means a supporter has registered an angel. Return to register page.
-      if (isset($user)) {
+            if (isset($user)) {
-          redirect(page_link_to('register'));
+                redirect(page_link_to('register'));
-      }
+            }
 
-      // If a welcome message is present, display registration success page.
+            // If a welcome message is present, display registration success page.
-      if ($event_config != null && $event_config['event_welcome_msg'] != null) {
+            if ($event_config != null && $event_config['event_welcome_msg'] != null) {
-          return User_registration_success_view($event_config['event_welcome_msg']);
+                return User_registration_success_view($event_config['event_welcome_msg']);
-      }
+            }
 
             redirect('?');
         }
@@ -218,77 +227,103 @@ function guest_register()
     }
 
     return page_with_title(register_title(), [
-      _("By completing this form you're registering as a Chaos-Angel. This script will create you an account in the angel task scheduler."),
+        _("By completing this form you're registering as a Chaos-Angel. This script will create you an account in the angel task scheduler."),
-      $msg,
+        $msg,
-      msg(),
+        msg(),
-      form([
+        form([
-          div('row', [
+            div('row', [
-              div('col-md-6', [
+                div('col-md-6', [
-                  div('row', [
+                    div('row', [
-                      div('col-sm-4', [
+                        div('col-sm-4', [
-                          form_text('nick', _("Nick") . ' ' . entry_required(), $nick)
+                            form_text('nick', _("Nick") . ' ' . entry_required(), $nick)
-                      ]),
+                        ]),
-                      div('col-sm-8', [
+                        div('col-sm-8', [
-                          form_email('mail', _("E-Mail") . ' ' . entry_required(), $mail),
+                            form_email('mail', _("E-Mail") . ' ' . entry_required(), $mail),
-                          form_checkbox('email_shiftinfo', _("The engelsystem is allowed to send me an email (e.g. when my shifts change)"), $email_shiftinfo),
+                            form_checkbox(
-                          form_checkbox('email_by_human_allowed', _("Humans are allowed to send me an email (e.g. for ticket vouchers)"), $email_by_human_allowed)
+                                'email_shiftinfo',
-                      ])
+                                _("The engelsystem is allowed to send me an email (e.g. when my shifts change)"),
-                  ]),
+                                $email_shiftinfo
-                  div('row', [
+                            ),
-                      div('col-sm-6', [
+                            form_checkbox(
-                          form_date('planned_arrival_date', _("Planned date of arrival") . ' ' . entry_required(), $planned_arrival_date, $buildup_start_date, $teardown_end_date)
+                                'email_by_human_allowed',
-                      ]),
+                                _("Humans are allowed to send me an email (e.g. for ticket vouchers)"),
-                      div('col-sm-6', [
+                                $email_by_human_allowed
-                          $enable_tshirt_size ? form_select('tshirt_size', _("Shirt size") . ' ' . entry_required(), $tshirt_sizes, $tshirt_size) : ''
+                            )
-                      ])
+                        ])
-                  ]),
+                    ]),
-                  div('row', [
+                    div('row', [
-                      div('col-sm-6', [
+                        div('col-sm-6', [
-                          form_password('password', _("Password") . ' ' . entry_required())
+                            form_date(
-                      ]),
+                                'planned_arrival_date',
-                      div('col-sm-6', [
+                                _("Planned date of arrival") . ' ' . entry_required(),
-                          form_password('password2', _("Confirm password") . ' ' . entry_required())
+                                $planned_arrival_date, $buildup_start_date, $teardown_end_date
-                      ])
+                            )
-                  ]),
+                        ]),
-                  form_checkboxes('angel_types', _("What do you want to do?") . sprintf(" (<a href=\"%s\">%s</a>)", page_link_to('angeltypes') . '&action=about', _("Description of job types")), $angel_types, $selected_angel_types),
+                        div('col-sm-6', [
-                  form_info("", _("Restricted angel types need will be confirmed later by a supporter. You can change your selection in the options section."))
+                            $enable_tshirt_size ? form_select('tshirt_size',
-              ]),
+                                _("Shirt size") . ' ' . entry_required(),
-              div('col-md-6', [
+                                $tshirt_sizes, $tshirt_size) : ''
-                  div('row', [
+                        ])
-                      div('col-sm-4', [
+                    ]),
-                          form_text('dect', _("DECT"), $dect)
+                    div('row', [
-                      ]),
+                        div('col-sm-6', [
-                      div('col-sm-4', [
+                            form_password('password', _("Password") . ' ' . entry_required())
-                          form_text('mobile', _("Mobile"), $mobile)
+                        ]),
-                      ]),
+                        div('col-sm-6', [
-                      div('col-sm-4', [
+                            form_password('password2', _("Confirm password") . ' ' . entry_required())
-                          form_text('tel', _("Phone"), $tel)
+                        ])
-                      ])
+                    ]),
-                  ]),
+                    form_checkboxes(
-                  form_text('jabber', _("Jabber"), $jabber),
+                        'angel_types',
-                  div('row', [
+                        _("What do you want to do?") . sprintf(
-                      div('col-sm-6', [
+                            " (<a href=\"%s\">%s</a>)",
-                          form_text('prename', _("First name"), $prename)
+                            page_link_to('angeltypes') . '&action=about',
-                      ]),
+                            _("Description of job types")
-                      div('col-sm-6', [
+                        ),
-                          form_text('lastname', _("Last name"), $lastname)
+                        $angel_types,
-                      ])
+                        $selected_angel_types
-                  ]),
+                    ),
-                  div('row', [
+                    form_info(
-                      div('col-sm-3', [
+                        "",
-                          form_text('age', _("Age"), $age)
+                        _("Restricted angel types need will be confirmed later by a supporter. You can change your selection in the options section.")
-                      ]),
+                    )
-                      div('col-sm-9', [
+                ]),
-                          form_text('hometown', _("Hometown"), $hometown)
+                div('col-md-6', [
-                      ])
+                    div('row', [
-                  ]),
+                        div('col-sm-4', [
-                  form_info(entry_required() . ' = ' . _("Entry required!"))
+                            form_text('dect', _("DECT"), $dect)
-              ])
+                        ]),
-          ]),
+                        div('col-sm-4', [
-          // form_textarea('comment', _("Did you help at former CCC events and which tasks have you performed then?"), $comment),
+                            form_text('mobile', _("Mobile"), $mobile)
-          form_submit('submit', _("Register"))
+                        ]),
-      ])
+                        div('col-sm-4', [
-  ]);
+                            form_text('tel', _("Phone"), $tel)
+                        ])
+                    ]),
+                    form_text('jabber', _("Jabber"), $jabber),
+                    div('row', [
+                        div('col-sm-6', [
+                            form_text('prename', _("First name"), $prename)
+                        ]),
+                        div('col-sm-6', [
+                            form_text('lastname', _("Last name"), $lastname)
+                        ])
+                    ]),
+                    div('row', [
+                        div('col-sm-3', [
+                            form_text('age', _("Age"), $age)
+                        ]),
+                        div('col-sm-9', [
+                            form_text('hometown', _("Hometown"), $hometown)
+                        ])
+                    ]),
+                    form_info(entry_required() . ' = ' . _("Entry required!"))
+                ])
+            ]),
+            // form_textarea('comment', _("Did you help at former CCC events and which tasks have you performed then?"), $comment),
+            form_submit('submit', _("Register"))
+        ])
+    ]);
 }
 
 function entry_required()
@@ -316,7 +351,7 @@ function guest_login()
             if (count($login_user) > 0) {
                 $login_user = $login_user[0];
                 if (isset($_REQUEST['password'])) {
-                    if (! verify_password($_REQUEST['password'], $login_user['Passwort'], $login_user['UID'])) {
+                    if (!verify_password($_REQUEST['password'], $login_user['Passwort'], $login_user['UID'])) {
                         $valid = false;
                         error(_("Your password is incorrect.  Please try it again."));
                     }
@@ -344,48 +379,48 @@ function guest_login()
     $event_config = EventConfig();
 
     return page([
-      div('col-md-12', [
+        div('col-md-12', [
-          div('row', [
+            div('row', [
-              EventConfig_countdown_page($event_config)
+                EventConfig_countdown_page($event_config)
-          ]),
+            ]),
-          div('row', [
+            div('row', [
-              div('col-sm-6 col-sm-offset-3 col-md-4 col-md-offset-4', [
+                div('col-sm-6 col-sm-offset-3 col-md-4 col-md-offset-4', [
-                  div('panel panel-primary first', [
+                    div('panel panel-primary first', [
-                      div('panel-heading', [
+                        div('panel-heading', [
-                          '<span class="icon-icon_angel"></span> ' . _("Login")
+                            '<span class="icon-icon_angel"></span> ' . _("Login")
-                      ]),
+                        ]),
-                      div('panel-body', [
+                        div('panel-body', [
-                          msg(),
+                            msg(),
-                          form([
+                            form([
-                              form_text_placeholder('nick', _("Nick"), $nick),
+                                form_text_placeholder('nick', _("Nick"), $nick),
-                              form_password_placeholder('password', _("Password")),
+                                form_password_placeholder('password', _("Password")),
-                              form_submit('submit', _("Login")),
+                                form_submit('submit', _("Login")),
-                              ! $valid ? buttons([
+                                !$valid ? buttons([
-                                  button(page_link_to('user_password_recovery'), _("I forgot my password"))
+                                    button(page_link_to('user_password_recovery'), _("I forgot my password"))
-                              ]) : ''
+                                ]) : ''
-                          ])
+                            ])
-                      ]),
+                        ]),
-                      div('panel-footer', [
+                        div('panel-footer', [
-                          glyph('info-sign') . _("Please note: You have to activate cookies!")
+                            glyph('info-sign') . _("Please note: You have to activate cookies!")
-                      ])
+                        ])
-                  ])
+                    ])
-              ])
+                ])
-          ]),
+            ]),
-          div('row', [
+            div('row', [
-              div('col-sm-6 text-center', [
+                div('col-sm-6 text-center', [
-                  heading(register_title(), 2),
+                    heading(register_title(), 2),
-                  get_register_hint()
+                    get_register_hint()
-              ]),
+                ]),
-              div('col-sm-6 text-center', [
+                div('col-sm-6 text-center', [
-                  heading(_("What can I do?"), 2),
+                    heading(_("What can I do?"), 2),
-                  '<p>' . _("Please read about the jobs you can do to help us.") . '</p>',
+                    '<p>' . _("Please read about the jobs you can do to help us.") . '</p>',
-                  buttons([
+                    buttons([
-                      button(page_link_to('angeltypes') . '&action=about', _("Teams/Job description") . ' &raquo;')
+                        button(page_link_to('angeltypes') . '&action=about', _("Teams/Job description") . ' &raquo;')
-                  ])
+                    ])
-              ])
+                ])
-          ])
+            ])
-      ])
+        ])
-  ]);
+    ]);
 }
 
 function get_register_hint()
@@ -394,13 +429,13 @@ function get_register_hint()
 
     if (in_array('register', $privileges)) {
         return join('', [
-        '<p>' . _("Please sign up, if you want to help us!") . '</p>',
+            '<p>' . _("Please sign up, if you want to help us!") . '</p>',
-        buttons([
+            buttons([
-            button(page_link_to('register'), register_title() . ' &raquo;')
+                button(page_link_to('register'), register_title() . ' &raquo;')
-        ])
+            ])
-    ]);
+        ]);
     }
 
-  //FIXME: return error(_("Registration is disabled."), true);
+    //FIXME: return error(_("Registration is disabled."), true);
-  return error("Registration is <a href='https://engelsystem.de/33c3/overwhelmed.html'>disabled</a>.", true);
+    return error("Registration is <a href='https://engelsystem.de/33c3/overwhelmed.html'>disabled</a>.", true);
 }

includes/pages/guest_stats.php

@@ -8,10 +8,10 @@ function guest_stats()
         if ($_REQUEST['api_key'] == $api_key) {
             $stats = [];
 
-            list($user_count) = sql_select("SELECT count(*) as `user_count` FROM `User`");
+            list($user_count) = sql_select("SELECT count(*) AS `user_count` FROM `User`");
             $stats['user_count'] = $user_count['user_count'];
 
-            list($arrived_user_count) = sql_select("SELECT count(*) as `user_count` FROM `User` WHERE `Gekommen`=1");
+            list($arrived_user_count) = sql_select("SELECT count(*) AS `user_count` FROM `User` WHERE `Gekommen`=1");
             $stats['arrived_user_count'] = $arrived_user_count['user_count'];
 
             $done_shifts_seconds = sql_select_single_cell("SELECT SUM(`Shifts`.`end` - `Shifts`.`start`) FROM `ShiftEntry` JOIN `Shifts` USING (`SID`) WHERE `Shifts`.`end` < UNIX_TIMESTAMP()");
@@ -25,10 +25,10 @@ function guest_stats()
             return;
         }
         raw_output(json_encode([
-        'error' => "Wrong api_key."
+            'error' => "Wrong api_key."
-    ]));
+        ]));
     }
     raw_output(json_encode([
-      'error' => "Missing parameter api_key."
+        'error' => "Missing parameter api_key."
-  ]));
+    ]));
 }

includes/pages/user_atom.php

@@ -5,7 +5,7 @@ function user_atom()
 {
     global $user, $DISPLAY_NEWS;
 
-    if (! isset($_REQUEST['key']) || ! preg_match("/^[0-9a-f]{32}$/", $_REQUEST['key'])) {
+    if (!isset($_REQUEST['key']) || !preg_match("/^[0-9a-f]{32}$/", $_REQUEST['key'])) {
         engelsystem_error("Missing key.");
     }
     $key = $_REQUEST['key'];
@@ -14,7 +14,7 @@ function user_atom()
     if ($user == null) {
         engelsystem_error("Key invalid.");
     }
-    if (! in_array('atom', privileges_for_user($user['UID']))) {
+    if (!in_array('atom', privileges_for_user($user['UID']))) {
         engelsystem_error("No privilege for atom.");
     }
 
@@ -32,7 +32,13 @@ function make_atom_entries_from_news($news_entries)
     $html = '<?xml version="1.0" encoding="utf-8"?>
   <feed xmlns="http://www.w3.org/2005/Atom">
   <title>Engelsystem</title>
-  <id>' . $_SERVER['HTTP_HOST'] . htmlspecialchars(preg_replace('#[&?]key=[a-f0-9]{32}#', '', $_SERVER['REQUEST_URI'])) . '</id>
+  <id>' . $_SERVER['HTTP_HOST']
+        . htmlspecialchars(preg_replace(
+            '#[&?]key=[a-f0-9]{32}#',
+            '',
+            $_SERVER['REQUEST_URI']
+        ))
+        . '</id>
   <updated>' . date('Y-m-d\TH:i:sP', $news_entries[0]['Datum']) . "</updated>\n";
     foreach ($news_entries as $news_entry) {
         $html .= make_atom_entry_from_news($news_entry);

includes/pages/user_ical.php

@@ -7,7 +7,7 @@ function user_ical()
 {
     global $user;
 
-    if (! isset($_REQUEST['key']) || ! preg_match("/^[0-9a-f]{32}$/", $_REQUEST['key'])) {
+    if (!isset($_REQUEST['key']) || !preg_match("/^[0-9a-f]{32}$/", $_REQUEST['key'])) {
         engelsystem_error("Missing key.");
     }
     $key = $_REQUEST['key'];
@@ -17,7 +17,7 @@ function user_ical()
         engelsystem_error("Key invalid.");
     }
 
-    if (! in_array('ical', privileges_for_user($user['UID']))) {
+    if (!in_array('ical', privileges_for_user($user['UID']))) {
         engelsystem_error("No privilege for ical.");
     }
 
@@ -29,7 +29,7 @@ function user_ical()
 /**
  * Renders an ical calender from given shifts array.
  *
- * @param array<Shift> $shifts
+ * @param array <Shift> $shifts
  */
 function send_ical_from_shifts($shifts)
 {
@@ -53,7 +53,8 @@ function make_ical_entry_from_shift($shift)
 {
     $output = "BEGIN:VEVENT\r\n";
     $output .= "UID:" . md5($shift['start'] . $shift['end'] . $shift['name']) . "\r\n";
-    $output .= "SUMMARY:" . str_replace("\n", "\\n", $shift['name']) . " (" . str_replace("\n", "\\n", $shift['title']) . ")\r\n";
+    $output .= "SUMMARY:" . str_replace("\n", "\\n", $shift['name'])
+        . " (" . str_replace("\n", "\\n", $shift['title']) . ")\r\n";
     if (isset($shift['Comment'])) {
         $output .= "DESCRIPTION:" . str_replace("\n", "\\n", $shift['Comment']) . "\r\n";
     }

includes/pages/user_messages.php

@@ -22,12 +22,12 @@ function user_messages()
 {
     global $user;
 
-    if (! isset($_REQUEST['action'])) {
+    if (!isset($_REQUEST['action'])) {
         $users = sql_select("SELECT * FROM `User` WHERE NOT `UID`='" . sql_escape($user['UID']) . "' ORDER BY `Nick`");
 
         $to_select_data = [
-        "" => _("Select recipient...")
+            "" => _("Select recipient...")
-    ];
+        ];
 
         foreach ($users as $u) {
             $to_select_data[$u['UID']] = $u['Nick'];
@@ -38,96 +38,104 @@ function user_messages()
         $messages = sql_select("SELECT * FROM `Messages` WHERE `SUID`='" . sql_escape($user['UID']) . "' OR `RUID`='" . sql_escape($user['UID']) . "' ORDER BY `isRead`,`Datum` DESC");
 
         $messages_table = [
-        [
+            [
-            'news' => '',
+                'news'      => '',
-            'timestamp' => date("Y-m-d H:i"),
+                'timestamp' => date("Y-m-d H:i"),
-            'from' => User_Nick_render($user),
+                'from'      => User_Nick_render($user),
-            'to' => $to_select,
+                'to'        => $to_select,
-            'text' => form_textarea('text', '', ''),
+                'text'      => form_textarea('text', '', ''),
-            'actions' => form_submit('submit', _("Save"))
+                'actions'   => form_submit('submit', _("Save"))
-        ]
+            ]
-    ];
+        ];
 
         foreach ($messages as $message) {
             $sender_user_source = User($message['SUID']);
             $receiver_user_source = User($message['RUID']);
 
             $messages_table_entry = [
-          'new' => $message['isRead'] == 'N' ? '<span class="glyphicon glyphicon-envelope"></span>' : '',
+                'new'       => $message['isRead'] == 'N' ? '<span class="glyphicon glyphicon-envelope"></span>' : '',
-          'timestamp' => date("Y-m-d H:i", $message['Datum']),
+                'timestamp' => date("Y-m-d H:i", $message['Datum']),
-          'from' => User_Nick_render($sender_user_source),
+                'from'      => User_Nick_render($sender_user_source),
-          'to' => User_Nick_render($receiver_user_source),
+                'to'        => User_Nick_render($receiver_user_source),
-          'text' => str_replace("\n", '<br />', $message['Text'])
+                'text'      => str_replace("\n", '<br />', $message['Text'])
-      ];
+            ];
 
             if ($message['RUID'] == $user['UID']) {
                 if ($message['isRead'] == 'N') {
-                    $messages_table_entry['actions'] = button(page_link_to("user_messages") . '&action=read&id=' . $message['id'], _("mark as read"), 'btn-xs');
+                    $messages_table_entry['actions'] = button(
+                        page_link_to("user_messages") . '&action=read&id=' . $message['id'],
+                        _("mark as read"),
+                        'btn-xs'
+                    );
                 }
             } else {
-                $messages_table_entry['actions'] = button(page_link_to("user_messages") . '&action=delete&id=' . $message['id'], _("delete message"), 'btn-xs');
+                $messages_table_entry['actions'] = button(
+                    page_link_to("user_messages") . '&action=delete&id=' . $message['id'],
+                    _("delete message"),
+                    'btn-xs'
+                );
             }
             $messages_table[] = $messages_table_entry;
         }
 
         return page_with_title(messages_title(), [
-        msg(),
+            msg(),
-        sprintf(_("Hello %s, here can you leave messages for other angels"), User_Nick_render($user)),
+            sprintf(_("Hello %s, here can you leave messages for other angels"), User_Nick_render($user)),
-        form([
+            form([
-            table([
+                table([
-                'new' => _("New"),
+                    'new'       => _("New"),
-                'timestamp' => _("Date"),
+                    'timestamp' => _("Date"),
-                'from' => _("Transmitted"),
+                    'from'      => _("Transmitted"),
-                'to' => _("Recipient"),
+                    'to'        => _("Recipient"),
-                'text' => _("Message"),
+                    'text'      => _("Message"),
-                'actions' => ''
+                    'actions'   => ''
-            ], $messages_table)
+                ], $messages_table)
-        ], page_link_to('user_messages') . '&action=send')
+            ], page_link_to('user_messages') . '&action=send')
-    ]);
+        ]);
     } else {
         switch ($_REQUEST['action']) {
-      case "read":
+            case "read":
-        if (isset($_REQUEST['id']) && preg_match("/^[0-9]{1,11}$/", $_REQUEST['id'])) {
+                if (isset($_REQUEST['id']) && preg_match("/^[0-9]{1,11}$/", $_REQUEST['id'])) {
-            $message_id = $_REQUEST['id'];
+                    $message_id = $_REQUEST['id'];
-        } else {
+                } else {
-            return error(_("Incomplete call, missing Message ID."), true);
+                    return error(_("Incomplete call, missing Message ID."), true);
-        }
+                }
 
-        $message = sql_select("SELECT * FROM `Messages` WHERE `id`='" . sql_escape($message_id) . "' LIMIT 1");
+                $message = sql_select("SELECT * FROM `Messages` WHERE `id`='" . sql_escape($message_id) . "' LIMIT 1");
-        if (count($message) > 0 && $message[0]['RUID'] == $user['UID']) {
+                if (count($message) > 0 && $message[0]['RUID'] == $user['UID']) {
-            sql_query("UPDATE `Messages` SET `isRead`='Y' WHERE `id`='" . sql_escape($message_id) . "' LIMIT 1");
+                    sql_query("UPDATE `Messages` SET `isRead`='Y' WHERE `id`='" . sql_escape($message_id) . "' LIMIT 1");
-            redirect(page_link_to("user_messages"));
+                    redirect(page_link_to("user_messages"));
-        } else {
+                } else {
-            return error(_("No Message found."), true);
+                    return error(_("No Message found."), true);
-        }
+                }
-        break;
+                break;
 
-      case "delete":
+            case "delete":
-        if (isset($_REQUEST['id']) && preg_match("/^[0-9]{1,11}$/", $_REQUEST['id'])) {
+                if (isset($_REQUEST['id']) && preg_match("/^[0-9]{1,11}$/", $_REQUEST['id'])) {
-            $message_id = $_REQUEST['id'];
+                    $message_id = $_REQUEST['id'];
-        } else {
+                } else {
-            return error(_("Incomplete call, missing Message ID."), true);
+                    return error(_("Incomplete call, missing Message ID."), true);
-        }
+                }
 
-        $message = sql_select("SELECT * FROM `Messages` WHERE `id`='" . sql_escape($message_id) . "' LIMIT 1");
+                $message = sql_select("SELECT * FROM `Messages` WHERE `id`='" . sql_escape($message_id) . "' LIMIT 1");
-        if (count($message) > 0 && $message[0]['SUID'] == $user['UID']) {
+                if (count($message) > 0 && $message[0]['SUID'] == $user['UID']) {
-            sql_query("DELETE FROM `Messages` WHERE `id`='" . sql_escape($message_id) . "' LIMIT 1");
+                    sql_query("DELETE FROM `Messages` WHERE `id`='" . sql_escape($message_id) . "' LIMIT 1");
-            redirect(page_link_to("user_messages"));
+                    redirect(page_link_to("user_messages"));
-        } else {
+                } else {
-            return error(_("No Message found."), true);
+                    return error(_("No Message found."), true);
-        }
+                }
-        break;
+                break;
 
-      case "send":
+            case "send":
-        if (Message_send($_REQUEST['to'], $_REQUEST['text']) === true) {
+                if (Message_send($_REQUEST['to'], $_REQUEST['text']) === true) {
-            redirect(page_link_to("user_messages"));
+                    redirect(page_link_to("user_messages"));
-        } else {
+                } else {
-            return error(_("Transmitting was terminated with an Error."), true);
+                    return error(_("Transmitting was terminated with an Error."), true);
-        }
+                }
-        break;
+                break;
 
-      default:
+            default:
-        return error(_("Wrong action."), true);
+                return error(_("Wrong action."), true);
-    }
+        }
     }
 }

includes/pages/user_myshifts.php

@@ -11,7 +11,12 @@ function user_myshifts()
     global $LETZTES_AUSTRAGEN;
     global $user, $privileges;
 
-    if (isset($_REQUEST['id']) && in_array("user_shifts_admin", $privileges) && preg_match("/^[0-9]{1,}$/", $_REQUEST['id']) && sql_num_query("SELECT * FROM `User` WHERE `UID`='" . sql_escape($_REQUEST['id']) . "'") > 0) {
+    if (
+        isset($_REQUEST['id'])
+        && in_array("user_shifts_admin", $privileges)
+        && preg_match("/^[0-9]{1,}$/", $_REQUEST['id'])
+        && sql_num_query("SELECT * FROM `User` WHERE `UID`='" . sql_escape($_REQUEST['id']) . "'") > 0
+    ) {
         $user_id = $_REQUEST['id'];
     } else {
         $user_id = $user['UID'];
@@ -26,9 +31,12 @@ function user_myshifts()
             redirect(page_link_to('users') . '&action=view&user_id=' . $shifts_user['UID']);
         }
         return page_with_title(_("Reset API key"), [
-        error(_("If you reset the key, the url to your iCal- and JSON-export and your atom feed changes! You have to update it in every application using one of these exports."), true),
+            error(
-        button(page_link_to('user_myshifts') . '&reset=ack', _("Continue"), 'btn-danger')
+                _("If you reset the key, the url to your iCal- and JSON-export and your atom feed changes! You have to update it in every application using one of these exports."),
-    ]);
+                true
+            ),
+            button(page_link_to('user_myshifts') . '&reset=ack', _("Continue"), 'btn-danger')
+        ]);
     } elseif (isset($_REQUEST['edit']) && preg_match("/^[0-9]*$/", $_REQUEST['edit'])) {
         $user_id = $_REQUEST['edit'];
         $shift = sql_select("SELECT
@@ -39,7 +47,7 @@ function user_myshifts()
         `ShiftTypes`.`name`,
         `Shifts`.*,
         `Room`.`Name`,
-        `AngelTypes`.`name` as `angel_type`
+        `AngelTypes`.`name` AS `angel_type`
         FROM `ShiftEntry`
         JOIN `AngelTypes` ON (`ShiftEntry`.`TID` = `AngelTypes`.`id`)
         JOIN `Shifts` ON (`ShiftEntry`.`SID` = `Shifts`.`SID`)
@@ -68,22 +76,38 @@ function user_myshifts()
 
                 if ($valid) {
                     $result = ShiftEntry_update([
-              'id' => $user_id,
+                        'id'               => $user_id,
-              'Comment' => $comment,
+                        'Comment'          => $comment,
-              'freeloaded' => $freeloaded,
+                        'freeloaded'       => $freeloaded,
-              'freeload_comment' => $freeload_comment
+                        'freeload_comment' => $freeload_comment
-          ]);
+                    ]);
                     if ($result === false) {
                         engelsystem_error('Unable to update shift entry.');
                     }
 
-                    engelsystem_log("Updated " . User_Nick_render($user_source) . "'s shift " . $shift['name'] . " from " . date("Y-m-d H:i", $shift['start']) . " to " . date("Y-m-d H:i", $shift['end']) . " with comment " . $comment . ". Freeloaded: " . ($freeloaded ? "YES Comment: " . $freeload_comment : "NO"));
+                    engelsystem_log(
+                        "Updated " . User_Nick_render($user_source) . "'s shift " . $shift['name']
+                        . " from " . date("Y-m-d H:i", $shift['start'])
+                        . " to " . date("Y-m-d H:i", $shift['end'])
+                        . " with comment " . $comment
+                        . ". Freeloaded: " . ($freeloaded ? "YES Comment: " . $freeload_comment : "NO")
+                    );
                     success(_("Shift saved."));
                     redirect(page_link_to('users') . '&action=view&user_id=' . $shifts_user['UID']);
                 }
             }
 
-            return ShiftEntry_edit_view(User_Nick_render($shifts_user), date("Y-m-d H:i", $shift['start']) . ', ' . shift_length($shift), $shift['Name'], $shift['name'], $shift['angel_type'], $shift['Comment'], $shift['freeloaded'], $shift['freeload_comment'], in_array("user_shifts_admin", $privileges));
+            return ShiftEntry_edit_view(
+                User_Nick_render($shifts_user),
+                date("Y-m-d H:i", $shift['start']) . ', ' . shift_length($shift),
+                $shift['Name'],
+                $shift['name'],
+                $shift['angel_type'],
+                $shift['Comment'],
+                $shift['freeloaded'],
+                $shift['freeload_comment'],
+                in_array("user_shifts_admin", $privileges)
+            );
         } else {
             redirect(page_link_to('user_myshifts'));
         }
@@ -105,7 +129,13 @@ function user_myshifts()
                 $angeltype = AngelType($shift['TID']);
                 $shifttype = ShiftType($shift['shifttype_id']);
 
-                engelsystem_log("Deleted own shift: " . $shifttype['name'] . " at " . $room['Name'] . " from " . date("Y-m-d H:i", $shift['start']) . " to " . date("Y-m-d H:i", $shift['end']) . " as " . $angeltype['name']);
+                engelsystem_log(
+                    "Deleted own shift: " . $shifttype['name']
+                    . " at " . $room['Name']
+                    . " from " . date("Y-m-d H:i", $shift['start'])
+                    . " to " . date("Y-m-d H:i", $shift['end'])
+                    . " as " . $angeltype['name']
+                );
                 success(_("Shift canceled."));
             } else {
                 error(_("It's too late to sign yourself off the shift. If neccessary, ask the dispatcher to do so."));

includes/pages/user_news.php

@@ -34,10 +34,10 @@ function user_meetings()
 
     $dis_rows = ceil(sql_num_query("SELECT * FROM `News`") / $DISPLAY_NEWS);
     $html .= '<div class="text-center">' . '<ul class="pagination">';
-    for ($i = 0; $i < $dis_rows; $i ++) {
+    for ($i = 0; $i < $dis_rows; $i++) {
         if (isset($_REQUEST['page']) && $i == $_REQUEST['page']) {
             $html .= '<li class="active">';
-        } elseif (! isset($_REQUEST['page']) && $i == 0) {
+        } elseif (!isset($_REQUEST['page']) && $i == 0) {
             $html .= '<li class="active">';
         } else {
             $html .= '<li>';
@@ -62,7 +62,9 @@ function display_news($news)
 
     $html .= '<div class="panel-footer text-muted">';
     if (in_array("admin_news", $privileges)) {
-        $html .= '<div class="pull-right">' . button_glyph(page_link_to("admin_news") . '&action=edit&id=' . $news['ID'], 'edit', 'btn-xs') . '</div>';
+        $html .= '<div class="pull-right">'
+            . button_glyph(page_link_to("admin_news") . '&action=edit&id=' . $news['ID'], 'edit', 'btn-xs')
+            . '</div>';
     }
     $html .= '<span class="glyphicon glyphicon-time"></span> ' . date("Y-m-d H:i", $news['Datum']) . '&emsp;';
 
@@ -82,7 +84,11 @@ function user_news_comments()
     global $user;
 
     $html = '<div class="col-md-12"><h1>' . user_news_comments_title() . '</h1>';
-    if (isset($_REQUEST["nid"]) && preg_match("/^[0-9]{1,}$/", $_REQUEST['nid']) && sql_num_query("SELECT * FROM `News` WHERE `ID`='" . sql_escape($_REQUEST['nid']) . "' LIMIT 1") > 0) {
+    if (
+        isset($_REQUEST["nid"])
+        && preg_match("/^[0-9]{1,}$/", $_REQUEST['nid'])
+        && sql_num_query("SELECT * FROM `News` WHERE `ID`='" . sql_escape($_REQUEST['nid']) . "' LIMIT 1") > 0
+    ) {
         $nid = $_REQUEST["nid"];
         list($news) = sql_select("SELECT * FROM `News` WHERE `ID`='" . sql_escape($nid) . "' LIMIT 1");
         if (isset($_REQUEST["text"])) {
@@ -109,9 +115,9 @@ function user_news_comments()
 
         $html .= '<hr /><h2>' . _("New Comment:") . '</h2>';
         $html .= form([
-        form_textarea('text', _("Message"), ''),
+            form_textarea('text', _("Message"), ''),
-        form_submit('submit', _("Save"))
+            form_submit('submit', _("Save"))
-    ], page_link_to('news_comments') . '&nid=' . $news['ID']);
+        ], page_link_to('news_comments') . '&nid=' . $news['ID']);
     } else {
         $html .= _("Invalid request.");
     }
@@ -126,7 +132,7 @@ function user_news()
     $html = '<div class="col-md-12"><h1>' . news_title() . '</h1>' . msg();
 
     if (isset($_POST["text"]) && isset($_POST["betreff"]) && in_array("admin_news", $privileges)) {
-        if (! isset($_POST["treffen"]) || ! in_array("admin_news", $privileges)) {
+        if (!isset($_POST["treffen"]) || !in_array("admin_news", $privileges)) {
             $_POST["treffen"] = 0;
         }
         sql_query("INSERT INTO `News` (`Datum`, `Betreff`, `Text`, `UID`, `Treffen`) " . "VALUES ('" . sql_escape(time()) . "', '" . sql_escape($_POST["betreff"]) . "', '" . sql_escape($_POST["text"]) . "', '" . sql_escape($user['UID']) . "', '" . sql_escape($_POST["treffen"]) . "');");
@@ -148,10 +154,10 @@ function user_news()
 
     $dis_rows = ceil(sql_num_query("SELECT * FROM `News`") / $DISPLAY_NEWS);
     $html .= '<div class="text-center">' . '<ul class="pagination">';
-    for ($i = 0; $i < $dis_rows; $i ++) {
+    for ($i = 0; $i < $dis_rows; $i++) {
         if (isset($_REQUEST['page']) && $i == $_REQUEST['page']) {
             $html .= '<li class="active">';
-        } elseif (! isset($_REQUEST['page']) && $i == 0) {
+        } elseif (!isset($_REQUEST['page']) && $i == 0) {
             $html .= '<li class="active">';
         } else {
             $html .= '<li>';
@@ -165,11 +171,11 @@ function user_news()
         $html .= '<h2>' . _("Create news:") . '</h2>';
 
         $html .= form([
-        form_text('betreff', _("Subject"), ''),
+            form_text('betreff', _("Subject"), ''),
-        form_textarea('text', _("Message"), ''),
+            form_textarea('text', _("Message"), ''),
-        form_checkbox('treffen', _("Meeting"), false, 1),
+            form_checkbox('treffen', _("Meeting"), false, 1),
-        form_submit('submit', _("Save"))
+            form_submit('submit', _("Save"))
-    ]);
+        ]);
     }
     return $html . '</div>';
 }

includes/pages/user_questions.php

@@ -9,10 +9,14 @@ function user_questions()
 {
     global $user;
 
-    if (! isset($_REQUEST['action'])) {
+    if (!isset($_REQUEST['action'])) {
-        $open_questions = sql_select("SELECT * FROM `Questions` WHERE `AID` IS NULL AND `UID`='" . sql_escape($user['UID']) . "'");
+        $open_questions = sql_select(
+            "SELECT * FROM `Questions` WHERE `AID` IS NULL AND `UID`='" . sql_escape($user['UID']) . "'"
+        );
 
-        $answered_questions = sql_select("SELECT * FROM `Questions` WHERE NOT `AID` IS NULL AND `UID`='" . sql_escape($user['UID']) . "'");
+        $answered_questions = sql_select(
+            "SELECT * FROM `Questions` WHERE NOT `AID` IS NULL AND `UID`='" . sql_escape($user['UID']) . "'"
+        );
         foreach ($answered_questions as &$question) {
             $answer_user_source = User($question['AID']);
             $question['answer_user'] = User_Nick_render($answer_user_source);
@@ -21,38 +25,41 @@ function user_questions()
         return Questions_view($open_questions, $answered_questions, page_link_to("user_questions") . '&action=ask');
     } else {
         switch ($_REQUEST['action']) {
-      case 'ask':
+            case 'ask':
-        $question = strip_request_item_nl('question');
+                $question = strip_request_item_nl('question');
-        if ($question != "") {
+                if ($question != "") {
-            $result = sql_query("INSERT INTO `Questions` SET `UID`='" . sql_escape($user['UID']) . "', `Question`='" . sql_escape($question) . "'");
+                    $result = sql_query("
-            if ($result === false) {
+                        INSERT INTO `Questions`
-                engelsystem_error(_("Unable to save question."));
+                        SET `UID`='" . sql_escape($user['UID']) . "', `Question`='" . sql_escape($question) . "'
-            }
+                    ");
-            success(_("You question was saved."));
+                    if ($result === false) {
-            redirect(page_link_to("user_questions"));
+                        engelsystem_error(_("Unable to save question."));
-        } else {
+                    }
-            return page_with_title(questions_title(), [
+                    success(_("You question was saved."));
-              error(_("Please enter a question!"), true)
+                    redirect(page_link_to("user_questions"));
-          ]);
+                } else {
-        }
+                    return page_with_title(questions_title(), [
-        break;
+                        error(_("Please enter a question!"), true)
-      case 'delete':
+                    ]);
-        if (isset($_REQUEST['id']) && preg_match("/^[0-9]{1,11}$/", $_REQUEST['id'])) {
+                }
-            $question_id = $_REQUEST['id'];
+                break;
-        } else {
+            case 'delete':
-            return error(_("Incomplete call, missing Question ID."), true);
+                if (isset($_REQUEST['id']) && preg_match("/^[0-9]{1,11}$/", $_REQUEST['id'])) {
-        }
+                    $question_id = $_REQUEST['id'];
+                } else {
+                    return error(_("Incomplete call, missing Question ID."), true);
+                }
 
-        $question = sql_select("SELECT * FROM `Questions` WHERE `QID`='" . sql_escape($question_id) . "' LIMIT 1");
+                $question = sql_select("SELECT * FROM `Questions` WHERE `QID`='" . sql_escape($question_id) . "' LIMIT 1");
-        if (count($question) > 0 && $question[0]['UID'] == $user['UID']) {
+                if (count($question) > 0 && $question[0]['UID'] == $user['UID']) {
-            sql_query("DELETE FROM `Questions` WHERE `QID`='" . sql_escape($question_id) . "' LIMIT 1");
+                    sql_query("DELETE FROM `Questions` WHERE `QID`='" . sql_escape($question_id) . "' LIMIT 1");
-            redirect(page_link_to("user_questions"));
+                    redirect(page_link_to("user_questions"));
-        } else {
+                } else {
-            return page_with_title(questions_title(), [
+                    return page_with_title(questions_title(), [
-              error(_("No question found."), true)
+                        error(_("No question found."), true)
-          ]);
+                    ]);
+                }
+                break;
         }
-        break;
-    }
     }
 }

includes/pages/user_settings.php

@@ -18,7 +18,7 @@ function user_settings_main($user_source, $enable_tshirt_size, $tshirt_sizes)
     if (isset($_REQUEST['mail'])) {
         $result = User_validate_mail($_REQUEST['mail']);
         $user_source['email'] = $result->getValue();
-        if (! $result->isValid()) {
+        if (!$result->isValid()) {
             $valid = false;
             error(_("E-mail address is not correct."));
         }
@@ -33,7 +33,7 @@ function user_settings_main($user_source, $enable_tshirt_size, $tshirt_sizes)
     if (isset($_REQUEST['jabber'])) {
         $result = User_validate_jabber($_REQUEST['jabber']);
         $user_source['jabber'] = $result->getValue();
-        if (! $result->isValid()) {
+        if (!$result->isValid()) {
             $valid = false;
             error(_("Please check your jabber account information."));
         }
@@ -49,7 +49,7 @@ function user_settings_main($user_source, $enable_tshirt_size, $tshirt_sizes)
         $tmp = parse_date("Y-m-d H:i", $_REQUEST['planned_arrival_date'] . " 00:00");
         $result = User_validate_planned_arrival_date($tmp);
         $user_source['planned_arrival_date'] = $result->getValue();
-        if (! $result->isValid()) {
+        if (!$result->isValid()) {
             $valid = false;
             error(_("Please enter your planned date of arrival. It should be after the buildup start date and before teardown end date."));
         }
@@ -59,14 +59,14 @@ function user_settings_main($user_source, $enable_tshirt_size, $tshirt_sizes)
         $tmp = parse_date("Y-m-d H:i", $_REQUEST['planned_departure_date'] . " 00:00");
         $result = User_validate_planned_departure_date($user_source['planned_arrival_date'], $tmp);
         $user_source['planned_departure_date'] = $result->getValue();
-        if (! $result->isValid()) {
+        if (!$result->isValid()) {
             $valid = false;
             error(_("Please enter your planned date of departure. It should be after your planned arrival date and after buildup start date and before teardown end date."));
         }
     }
 
-  // Trivia
+    // Trivia
-  $user_source['Name'] = strip_request_item('lastname', $user_source['Name']);
+    $user_source['Name'] = strip_request_item('lastname', $user_source['Name']);
     $user_source['Vorname'] = strip_request_item('prename', $user_source['Vorname']);
     $user_source['Alter'] = strip_request_item('age', $user_source['Alter']);
     $user_source['Telefon'] = strip_request_item('tel', $user_source['Telefon']);
@@ -92,7 +92,10 @@ function user_settings_main($user_source, $enable_tshirt_size, $tshirt_sizes)
 function user_settings_password($user_source)
 {
     global $min_password_length;
-    if (! isset($_REQUEST['password']) || ! verify_password($_REQUEST['password'], $user_source['Passwort'], $user_source['UID'])) {
+    if (
+        !isset($_REQUEST['password'])
+        || !verify_password($_REQUEST['password'], $user_source['Passwort'], $user_source['UID'])
+    ) {
         error(_("-> not OK. Please try again."));
     } elseif (strlen($_REQUEST['new_password']) < $min_password_length) {
         error(_("Your password is to short (please use at least 6 characters)."));
@@ -110,9 +113,9 @@ function user_settings_password($user_source)
  * Change user theme
  *
  * @param User $user_sources
- *          The user
+ *                   The user
- * @param array<String> $themes
+ * @param      array <String> $themes
- *          List of available themes
+ *                   List of available themes
  */
 function user_settings_theme($user_source, $themes)
 {
@@ -138,9 +141,9 @@ function user_settings_theme($user_source, $themes)
  * Change use locale
  *
  * @param User $user_source
- *          The user
+ *                   The user
- * @param array<String> $locales
+ * @param      array <String> $locales
- *          List of available locales
+ *                   List of available locales
  */
 function user_settings_locale($user_source, $locales)
 {
@@ -195,5 +198,6 @@ function user_settings()
         $user_source = user_settings_locale($user_source, $locales);
     }
 
-    return User_settings_view($user_source, $locales, $themes, $buildup_start_date, $teardown_end_date, $enable_tshirt_size, $tshirt_sizes);
+    return User_settings_view($user_source, $locales, $themes, $buildup_start_date, $teardown_end_date,
+        $enable_tshirt_size, $tshirt_sizes);
 }

includes/pages/user_shifts.php

@@ -21,16 +21,16 @@ function user_shifts()
         redirect(page_link_to('user_myshifts'));
     }
 
-  // Löschen einzelner Schicht-Einträge (Also Belegung einer Schicht von Engeln) durch Admins
+    // Löschen einzelner Schicht-Einträge (Also Belegung einer Schicht von Engeln) durch Admins
-  if (isset($_REQUEST['entry_id'])) {
+    if (isset($_REQUEST['entry_id'])) {
-      return shift_entry_delete_controller();
+        return shift_entry_delete_controller();
-  } elseif (isset($_REQUEST['edit_shift'])) {
+    } elseif (isset($_REQUEST['edit_shift'])) {
-      return shift_edit_controller();
+        return shift_edit_controller();
-  } elseif (isset($_REQUEST['delete_shift'])) {
+    } elseif (isset($_REQUEST['delete_shift'])) {
-      return shift_delete_controller();
+        return shift_delete_controller();
-  } elseif (isset($_REQUEST['shift_id'])) {
+    } elseif (isset($_REQUEST['shift_id'])) {
-      return shift_entry_add_controller();
+        return shift_entry_add_controller();
-  }
+    }
     return view_user_shifts();
 }
 
@@ -66,9 +66,9 @@ function update_ShiftsFilter_timerange(ShiftsFilter $shiftsFilter, $days)
  *
  * @param ShiftsFilter $shiftsFilter
  *          The shifts filter to update from request data
- * @param boolean $user_shifts_admin
+ * @param boolean      $user_shifts_admin
  *          Has the user user_shift_admin privilege?
- * @param string[] $days
+ * @param string[]     $days
  *          An array of available filter days
  */
 function update_ShiftsFilter(ShiftsFilter $shiftsFilter, $user_shifts_admin, $days)
@@ -111,7 +111,25 @@ function load_types()
         error(_("The administration has not configured any angeltypes yet - or you are not subscribed to any angeltype."));
         redirect('?');
     }
-    $types = sql_select("SELECT `AngelTypes`.`id`, `AngelTypes`.`name`, (`AngelTypes`.`restricted`=0 OR (NOT `UserAngelTypes`.`confirm_user_id` IS NULL OR `UserAngelTypes`.`id` IS NULL)) as `enabled` FROM `AngelTypes` LEFT JOIN `UserAngelTypes` ON (`UserAngelTypes`.`angeltype_id`=`AngelTypes`.`id` AND `UserAngelTypes`.`user_id`='" . sql_escape($user['UID']) . "') ORDER BY `AngelTypes`.`name`");
+    $types = sql_select("
+        SELECT
+            `AngelTypes`.`id`,
+            `AngelTypes`.`name`,
+            (
+                `AngelTypes`.`restricted`=0
+                OR (
+                    NOT `UserAngelTypes`.`confirm_user_id` IS NULL
+                    OR `UserAngelTypes`.`id` IS NULL
+                )
+            ) AS `enabled`
+        FROM `AngelTypes`
+        LEFT JOIN `UserAngelTypes`
+            ON (
+                `UserAngelTypes`.`angeltype_id`=`AngelTypes`.`id`
+                AND `UserAngelTypes`.`user_id`='" . sql_escape($user['UID']) . "'
+            )
+        ORDER BY `AngelTypes`.`name`
+    ");
     if (empty($types)) {
         return sql_select("SELECT `id`, `name` FROM `AngelTypes` WHERE `restricted` = 0");
     }
@@ -128,10 +146,10 @@ function view_user_shifts()
     $rooms = load_rooms();
     $types = load_types();
 
-    if (! isset($_SESSION['ShiftsFilter'])) {
+    if (!isset($_SESSION['ShiftsFilter'])) {
         $room_ids = [
-        $rooms[0]['id']
+            $rooms[0]['id']
-    ];
+        ];
         $type_ids = array_map('get_ids_from_array', $types);
         $_SESSION['ShiftsFilter'] = new ShiftsFilter(in_array('user_shifts_admin', $privileges), $room_ids, $type_ids);
     }
@@ -145,39 +163,54 @@ function view_user_shifts()
     }
 
     $filled = [
-      [
+        [
-          'id' => '1',
+            'id'   => '1',
-          'name' => _("occupied")
+            'name' => _("occupied")
-      ],
+        ],
-      [
+        [
-          'id' => '0',
+            'id'   => '0',
-          'name' => _("free")
+            'name' => _("free")
-      ]
+        ]
-  ];
+    ];
     $start_day = date("Y-m-d", $shiftsFilter->getStartTime());
     $start_time = date("H:i", $shiftsFilter->getStartTime());
     $end_day = date("Y-m-d", $shiftsFilter->getEndTime());
     $end_time = date("H:i", $shiftsFilter->getEndTime());
 
     return page([
-      div('col-md-12', [
+        div('col-md-12', [
-          msg(),
+            msg(),
-          template_render(__DIR__ . '/../../templates/user_shifts.html', [
+            template_render(__DIR__ . '/../../templates/user_shifts.html', [
-              'title' => shifts_title(),
+                'title'         => shifts_title(),
-              'room_select' => make_select($rooms, $shiftsFilter->getRooms(), "rooms", _("Rooms")),
+                'room_select'   => make_select($rooms, $shiftsFilter->getRooms(), "rooms", _("Rooms")),
-              'start_select' => html_select_key("start_day", "start_day", array_combine($days, $days), $start_day),
+                'start_select'  => html_select_key("start_day", "start_day", array_combine($days, $days), $start_day),
-              'start_time' => $start_time,
+                'start_time'    => $start_time,
-              'end_select' => html_select_key("end_day", "end_day", array_combine($days, $days), $end_day),
+                'end_select'    => html_select_key("end_day", "end_day", array_combine($days, $days), $end_day),
-              'end_time' => $end_time,
+                'end_time'      => $end_time,
-              'type_select' => make_select($types, $shiftsFilter->getTypes(), "types", _("Angeltypes") . '<sup>1</sup>'),
+                'type_select'   => make_select(
-              'filled_select' => make_select($filled, $shiftsFilter->getFilled(), "filled", _("Occupancy")),
+                    $types,
-              'task_notice' => '<sup>1</sup>' . _("The tasks shown here are influenced by the angeltypes you joined already!") . " <a href=\"" . page_link_to('angeltypes') . '&action=about' . "\">" . _("Description of the jobs.") . "</a>",
+                    $shiftsFilter->getTypes(),
-              'shifts_table' => msg() . $shiftCalendarRenderer->render(),
+                    "types",
-              'ical_text' => '<h2>' . _("iCal export") . '</h2><p>' . sprintf(_("Export of shown shifts. <a href=\"%s\">iCal format</a> or <a href=\"%s\">JSON format</a> available (please keep secret, otherwise <a href=\"%s\">reset the api key</a>)."), page_link_to_absolute('ical') . '&key=' . $user['api_key'], page_link_to_absolute('shifts_json_export') . '&key=' . $user['api_key'], page_link_to('user_myshifts') . '&reset') . '</p>',
+                    _("Angeltypes") . '<sup>1</sup>'
-              'filter' => _("Filter")
+                ),
-          ])
+                'filled_select' => make_select($filled, $shiftsFilter->getFilled(), "filled", _("Occupancy")),
-      ])
+                'task_notice'   =>
-  ]);
+                    '<sup>1</sup>'
+                    . _("The tasks shown here are influenced by the angeltypes you joined already!")
+                    . " <a href=\"" . page_link_to('angeltypes') . '&action=about' . "\">"
+                    . _("Description of the jobs.")
+                    . "</a>",
+                'shifts_table'  => msg() . $shiftCalendarRenderer->render(),
+                'ical_text'     => '<h2>' . _("iCal export") . '</h2><p>' . sprintf(
+                        _("Export of shown shifts. <a href=\"%s\">iCal format</a> or <a href=\"%s\">JSON format</a> available (please keep secret, otherwise <a href=\"%s\">reset the api key</a>)."),
+                        page_link_to_absolute('ical') . '&key=' . $user['api_key'],
+                        page_link_to_absolute('shifts_json_export') . '&key=' . $user['api_key'],
+                        page_link_to('user_myshifts') . '&reset'
+                    ) . '</p>',
+                'filter'        => _("Filter")
+            ])
+        ])
+    ]);
 }
 
 function get_ids_from_array($array)
@@ -193,14 +226,19 @@ function make_select($items, $selected, $name, $title = null)
     }
 
     foreach ($items as $i) {
-        $html_items[] = '<div class="checkbox"><label><input type="checkbox" name="' . $name . '[]" value="' . $i['id'] . '"' . (in_array($i['id'], $selected) ? ' checked="checked"' : '') . '> ' . $i['name'] . '</label>' . (! isset($i['enabled']) || $i['enabled'] ? '' : glyph("lock")) . '</div><br />';
+        $html_items[] = '<div class="checkbox">'
+            . '<label><input type="checkbox" name="' . $name . '[]" value="' . $i['id'] . '"'
+            . (in_array($i['id'], $selected) ? ' checked="checked"' : '')
+            . '> ' . $i['name'] . '</label>'
+            . (!isset($i['enabled']) || $i['enabled'] ? '' : glyph("lock"))
+            . '</div><br />';
     }
     $html = '<div id="selection_' . $name . '" class="selection ' . $name . '">' . "\n";
     $html .= implode("\n", $html_items);
     $html .= buttons([
-      button("javascript: checkAll('selection_" . $name . "', true)", _("All"), ""),
+        button("javascript: checkAll('selection_" . $name . "', true)", _("All"), ""),
-      button("javascript: checkAll('selection_" . $name . "', false)", _("None"), "")
+        button("javascript: checkAll('selection_" . $name . "', false)", _("None"), "")
-  ]);
+    ]);
     $html .= '</div>' . "\n";
     return $html;
 }

includes/sys_auth.php

@@ -12,16 +12,21 @@ function load_auth()
         $user = sql_select("SELECT * FROM `User` WHERE `UID`='" . sql_escape($_SESSION['uid']) . "' LIMIT 1");
         if (count($user) > 0) {
             // User ist eingeloggt, Datensatz zur Verfügung stellen und Timestamp updaten
-      list($user) = $user;
+            list($user) = $user;
-            sql_query("UPDATE `User` SET " . "`lastLogIn` = '" . time() . "'" . " WHERE `UID` = '" . sql_escape($_SESSION['uid']) . "' LIMIT 1;");
+            sql_query("
+                UPDATE `User`
+                SET " . "`lastLogIn` = '" . time() . "'" . "
+                WHERE `UID` = '" . sql_escape($_SESSION['uid']) . "'
+                LIMIT 1
+            ");
             $privileges = privileges_for_user($user['UID']);
             return;
         }
         unset($_SESSION['uid']);
     }
 
-  // guest privileges
+    // guest privileges
-  $privileges = privileges_for_group(- 1);
+    $privileges = privileges_for_group(-1);
 }
 
 /**
@@ -31,7 +36,7 @@ function generate_salt($length = 16)
 {
     $alphabet = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/";
     $salt = "";
-    for ($i = 0; $i < $length; $i ++) {
+    for ($i = 0; $i < $length; $i++) {
         $salt .= $alphabet[rand(0, strlen($alphabet) - 1)];
     }
     return $salt;
@@ -43,7 +48,13 @@ function generate_salt($length = 16)
 function set_password($uid, $password)
 {
     global $crypt_alg;
-    $result = sql_query("UPDATE `User` SET `Passwort` = '" . sql_escape(crypt($password, $crypt_alg . '$' . generate_salt(16) . '$')) . "', `password_recovery_token`=NULL WHERE `UID` = " . intval($uid) . " LIMIT 1");
+    $result = sql_query("
+        UPDATE `User`
+        SET `Passwort` = '" . sql_escape(crypt($password, $crypt_alg . '$' . generate_salt(16) . '$')) . "',
+        `password_recovery_token`=NULL
+        WHERE `UID` = " . intval($uid) . "
+        LIMIT 1
+    ");
     if ($result === false) {
         engelsystem_error('Unable to update password.');
     }
@@ -59,18 +70,24 @@ function verify_password($password, $salt, $uid = false)
     global $crypt_alg;
     $correct = false;
     if (substr($salt, 0, 1) == '$') { // new-style crypt()
-    $correct = crypt($password, $salt) == $salt;
+        $correct = crypt($password, $salt) == $salt;
     } elseif (substr($salt, 0, 7) == '{crypt}') { // old-style crypt() with DES and static salt - not used anymore
-    $correct = crypt($password, '77') == $salt;
+        $correct = crypt($password, '77') == $salt;
     } elseif (strlen($salt) == 32) { // old-style md5 without salt - not used anymore
-    $correct = md5($password) == $salt;
+        $correct = md5($password) == $salt;
     }
 
     if ($correct && substr($salt, 0, strlen($crypt_alg)) != $crypt_alg && $uid) {
         // this password is stored in another format than we want it to be.
-    // let's update it!
+        // let's update it!
-    // we duplicate the query from the above set_password() function to have the extra safety of checking the old hash
+        // we duplicate the query from the above set_password() function to have the extra safety of checking the old hash
-    sql_query("UPDATE `User` SET `Passwort` = '" . sql_escape(crypt($password, $crypt_alg . '$' . generate_salt() . '$')) . "' WHERE `UID` = " . intval($uid) . " AND `Passwort` = '" . sql_escape($salt) . "' LIMIT 1");
+        sql_query("
+            UPDATE `User`
+            SET `Passwort` = '" . sql_escape(crypt($password, $crypt_alg . '$' . generate_salt() . '$')) . "' 
+            WHERE `UID` = " . intval($uid) . " 
+            AND `Passwort` = '" . sql_escape($salt) . "' 
+            LIMIT 1
+        ");
     }
     return $correct;
 }
@@ -78,7 +95,14 @@ function verify_password($password, $salt, $uid = false)
 function privileges_for_user($user_id)
 {
     $privileges = [];
-    $user_privs = sql_select("SELECT `Privileges`.`name` FROM `User` JOIN `UserGroups` ON (`User`.`UID` = `UserGroups`.`uid`) JOIN `GroupPrivileges` ON (`UserGroups`.`group_id` = `GroupPrivileges`.`group_id`) JOIN `Privileges` ON (`GroupPrivileges`.`privilege_id` = `Privileges`.`id`) WHERE `User`.`UID`='" . sql_escape($user_id) . "'");
+    $user_privs = sql_select("
+        SELECT `Privileges`.`name`
+        FROM `User`
+        JOIN `UserGroups` ON (`User`.`UID` = `UserGroups`.`uid`)
+        JOIN `GroupPrivileges` ON (`UserGroups`.`group_id` = `GroupPrivileges`.`group_id`)
+        JOIN `Privileges` ON (`GroupPrivileges`.`privilege_id` = `Privileges`.`id`)
+        WHERE `User`.`UID`='" . sql_escape($user_id) . "'
+    ");
     foreach ($user_privs as $user_priv) {
         $privileges[] = $user_priv['name'];
     }
@@ -88,7 +112,12 @@ function privileges_for_user($user_id)
 function privileges_for_group($group_id)
 {
     $privileges = [];
-    $groups_privs = sql_select("SELECT * FROM `GroupPrivileges` JOIN `Privileges` ON (`GroupPrivileges`.`privilege_id` = `Privileges`.`id`) WHERE `group_id`='" . sql_escape($group_id) . "'");
+    $groups_privs = sql_select("
+        SELECT *
+        FROM `GroupPrivileges`
+        JOIN `Privileges` ON (`GroupPrivileges`.`privilege_id` = `Privileges`.`id`)
+        WHERE `group_id`='" . sql_escape($group_id) . "'
+    ");
     foreach ($groups_privs as $guest_priv) {
         $privileges[] = $guest_priv['name'];
     }

includes/sys_form.php

@@ -50,9 +50,9 @@ function form_spinner($name, $label, $value)
  *          Name of the parameter
  * @param string $label
  *          Label
- * @param int $value
+ * @param int    $value
  *          Unix Timestamp
- * @param int $min_date
+ * @param int    $min_date
  *          Earliest possible date
  * @return HTML
  */
@@ -111,7 +111,8 @@ function form_checkboxes($name, $label, $items, $selected)
  * @param
  *          items Array mit den Beschriftungen der Zeilen
  * @param
- *          selected Mehrdimensionales Array, wobei $selected[foo] ein Array der in der Datenreihe foo markierten Checkboxen ist
+ *          selected Mehrdimensionales Array, wobei $selected[foo] ein Array der in der Datenreihe foo markierten
+ *          Checkboxen ist
  * @param
  *          disabled Wie selected, nur dass die entsprechenden Checkboxen deaktiviert statt markiert sind
  */
@@ -127,7 +128,7 @@ function form_multi_checkboxes($names, $label, $items, $selected, $disabled = []
         foreach ($names as $name => $title) {
             $dom_id = $name . '_' . $key;
             $sel = array_search($key, $selected[$name]) !== false ? ' checked="checked"' : "";
-            if (! empty($disabled) && ! empty($disabled[$name]) && array_search($key, $disabled[$name]) !== false) {
+            if (!empty($disabled) && !empty($disabled[$name]) && array_search($key, $disabled[$name]) !== false) {
                 $sel .= ' disabled="disabled"';
             }
             $html .= '<td style="text-align: center;"><input type="checkbox" id="' . $dom_id . '" name="' . $name . '[]" value="' . $key . '"' . $sel . ' /></td>';
@@ -173,7 +174,10 @@ function form_info($label, $text = "")
  */
 function form_submit($name, $label)
 {
-    return form_element('<input class="btn btn-primary" type="submit" name="' . $name . '" value="' . $label . '" />', "");
+    return form_element(
+        '<input class="btn btn-primary" type="submit" name="' . $name . '" value="' . $label . '" />',
+        ""
+    );
 }
 
 /**
@@ -182,17 +186,21 @@ function form_submit($name, $label)
 function form_text($name, $label, $value, $disabled = false)
 {
     $disabled = $disabled ? ' disabled="disabled"' : '';
-    return form_element($label, '<input class="form-control" id="form_' . $name . '" type="text" name="' . $name . '" value="' . htmlspecialchars($value) . '" ' . $disabled . '/>', 'form_' . $name);
+    return form_element(
+        $label,
+        '<input class="form-control" id="form_' . $name . '" type="text" name="' . $name . '" value="' . htmlspecialchars($value) . '" ' . $disabled . '/>',
+        'form_' . $name
+    );
 }
 
 /**
  * Renders a text input with placeholder instead of label.
  *
- * @param String $name
+ * @param String  $name
  *          Input name
- * @param String $placeholder
+ * @param String  $placeholder
  *          Placeholder
- * @param String $value
+ * @param String  $value
  *          The value
  * @param Boolean $disabled
  *          Is the field enabled?
@@ -200,7 +208,8 @@ function form_text($name, $label, $value, $disabled = false)
 function form_text_placeholder($name, $placeholder, $value, $disabled = false)
 {
     $disabled = $disabled ? ' disabled="disabled"' : '';
-    return form_element('', '<input class="form-control" id="form_' . $name . '" type="text" name="' . $name . '" value="' . htmlspecialchars($value) . '" placeholder="' . $placeholder . '" ' . $disabled . '/>');
+    return form_element('',
+        '<input class="form-control" id="form_' . $name . '" type="text" name="' . $name . '" value="' . htmlspecialchars($value) . '" placeholder="' . $placeholder . '" ' . $disabled . '/>');
 }
 
 /**
@@ -209,7 +218,11 @@ function form_text_placeholder($name, $placeholder, $value, $disabled = false)
 function form_email($name, $label, $value, $disabled = false)
 {
     $disabled = $disabled ? ' disabled="disabled"' : '';
-    return form_element($label, '<input class="form-control" id="form_' . $name . '" type="email" name="' . $name . '" value="' . htmlspecialchars($value) . '" ' . $disabled . '/>', 'form_' . $name);
+    return form_element(
+        $label,
+        '<input class="form-control" id="form_' . $name . '" type="email" name="' . $name . '" value="' . htmlspecialchars($value) . '" ' . $disabled . '/>',
+        'form_' . $name
+    );
 }
 
 /**
@@ -226,7 +239,11 @@ function form_file($name, $label)
 function form_password($name, $label, $disabled = false)
 {
     $disabled = $disabled ? ' disabled="disabled"' : '';
-    return form_element($label, '<input class="form-control" id="form_' . $name . '" type="password" name="' . $name . '" value="" ' . $disabled . '/>', 'form_' . $name);
+    return form_element(
+        $label,
+        '<input class="form-control" id="form_' . $name . '" type="password" name="' . $name . '" value="" ' . $disabled . '/>',
+        'form_' . $name
+    );
 }
 
 /**
@@ -235,7 +252,11 @@ function form_password($name, $label, $disabled = false)
 function form_password_placeholder($name, $placeholder, $disabled = false)
 {
     $disabled = $disabled ? ' disabled="disabled"' : '';
-    return form_element('', '<input class="form-control" id="form_' . $name . '" type="password" name="' . $name . '" value="" placeholder="' . $placeholder . '" ' . $disabled . '/>', 'form_' . $name);
+    return form_element(
+        '',
+        '<input class="form-control" id="form_' . $name . '" type="password" name="' . $name . '" value="" placeholder="' . $placeholder . '" ' . $disabled . '/>',
+        'form_' . $name
+    );
 }
 
 /**
@@ -244,7 +265,11 @@ function form_password_placeholder($name, $placeholder, $disabled = false)
 function form_textarea($name, $label, $value, $disabled = false)
 {
     $disabled = $disabled ? ' disabled="disabled"' : '';
-    return form_element($label, '<textarea rows="5" class="form-control" id="form_' . $name . '" type="text" name="' . $name . '" ' . $disabled . '>' . $value . '</textarea>', 'form_' . $name);
+    return form_element(
+        $label,
+        '<textarea rows="5" class="form-control" id="form_' . $name . '" type="text" name="' . $name . '" ' . $disabled . '>' . $value . '</textarea>',
+        'form_' . $name
+    );
 }
 
 /**

includes/sys_log.php

@@ -28,12 +28,12 @@ function debug_string_backtrace()
     $trace = ob_get_contents();
     ob_end_clean();
 
-  // Remove first item from backtrace as it's this function which
+    // Remove first item from backtrace as it's this function which
-  // is redundant.
+    // is redundant.
-  $trace = preg_replace('/^#0\s+' . __FUNCTION__ . "[^\n]*\n/", '', $trace, 1);
+    $trace = preg_replace('/^#0\s+' . __FUNCTION__ . "[^\n]*\n/", '', $trace, 1);
 
-  // Renumber backtrace items.
+    // Renumber backtrace items.
-  // $trace = preg_replace('/^#(\d+)/me', '\'#\' . ($1 - 1)', $trace);
+    // $trace = preg_replace('/^#(\d+)/me', '\'#\' . ($1 - 1)', $trace);
 
-  return $trace;
+    return $trace;
 }

includes/sys_menu.php

@@ -11,7 +11,10 @@ function page_link_to($page = "")
 
 function page_link_to_absolute($page)
 {
-    return (isset($_SERVER['HTTPS']) ? 'https' : 'http') . '://' . $_SERVER['HTTP_HOST'] . preg_replace("/\?.*$/", '', $_SERVER['REQUEST_URI']) . page_link_to($page);
+    return (isset($_SERVER['HTTPS']) ? 'https' : 'http') . '://'
+        . $_SERVER['HTTP_HOST']
+        . preg_replace("/\?.*$/", '', $_SERVER['REQUEST_URI'])
+        . page_link_to($page);
 }
 
 /**
@@ -29,8 +32,8 @@ function header_render_hints()
         $hints_renderer->addHint(render_user_departure_date_hint());
         $hints_renderer->addHint(user_driver_license_required_hint());
 
-    // Important hints:
+        // Important hints:
-    $hints_renderer->addHint(render_user_freeloader_hint(), true);
+        $hints_renderer->addHint(render_user_freeloader_hint(), true);
         $hints_renderer->addHint(render_user_arrived_hint(), true);
         $hints_renderer->addHint(render_user_tshirt_hint(), true);
         $hints_renderer->addHint(render_user_dect_hint(), true);
@@ -49,10 +52,14 @@ function header_toolbar()
     $toolbar_items = [];
 
     if (isset($user)) {
-        $toolbar_items[] = toolbar_item_link(page_link_to('shifts') . '&action=next', 'time', User_shift_state_render($user));
+        $toolbar_items[] = toolbar_item_link(
+            page_link_to('shifts') . '&action=next',
+            'time',
+            User_shift_state_render($user)
+        );
     }
 
-    if (! isset($user) && in_array('register', $privileges)) {
+    if (!isset($user) && in_array('register', $privileges)) {
         $toolbar_items[] = toolbar_item_link(page_link_to('register'), 'plus', register_title(), $page == 'register');
     }
 
@@ -66,7 +73,12 @@ function header_toolbar()
 
     $toolbar_items[] = header_render_hints();
     if (in_array('user_myshifts', $privileges)) {
-        $toolbar_items[] = toolbar_item_link(page_link_to('users') . '&action=view', ' icon-icon_angel', $user['Nick'], $page == 'users');
+        $toolbar_items[] = toolbar_item_link(
+            page_link_to('users') . '&action=view',
+            ' icon-icon_angel',
+            $user['Nick'],
+            $page == 'users'
+        );
     }
 
     $user_submenu = make_user_submenu();
@@ -88,7 +100,12 @@ function make_user_submenu()
     }
 
     if (in_array('user_settings', $privileges)) {
-        $user_submenu[] = toolbar_item_link(page_link_to('user_settings'), 'list-alt', settings_title(), $page == 'user_settings');
+        $user_submenu[] = toolbar_item_link(
+            page_link_to('user_settings'),
+            'list-alt',
+            settings_title(),
+            $page == 'user_settings'
+        );
     }
 
     if (in_array('logout', $privileges)) {
@@ -104,12 +121,12 @@ function make_navigation()
 
     $menu = [];
     $pages = [
-      "news" => news_title(),
+        "news"           => news_title(),
-      "user_meetings" => meetings_title(),
+        "user_meetings"  => meetings_title(),
-      "user_shifts" => shifts_title(),
+        "user_shifts"    => shifts_title(),
-      "angeltypes" => angeltypes_title(),
+        "angeltypes"     => angeltypes_title(),
-      "user_questions" => questions_title()
+        "user_questions" => questions_title()
-  ];
+    ];
 
     foreach ($pages as $menu_page => $title) {
         if (in_array($menu_page, $privileges)) {
@@ -121,19 +138,19 @@ function make_navigation()
 
     $admin_menu = [];
     $admin_pages = [
-      "admin_arrive" => admin_arrive_title(),
+        "admin_arrive"       => admin_arrive_title(),
-      "admin_active" => admin_active_title(),
+        "admin_active"       => admin_active_title(),
-      "admin_user" => admin_user_title(),
+        "admin_user"         => admin_user_title(),
-      "admin_free" => admin_free_title(),
+        "admin_free"         => admin_free_title(),
-      "admin_questions" => admin_questions_title(),
+        "admin_questions"    => admin_questions_title(),
-      "shifttypes" => shifttypes_title(),
+        "shifttypes"         => shifttypes_title(),
-      "admin_shifts" => admin_shifts_title(),
+        "admin_shifts"       => admin_shifts_title(),
-      "admin_rooms" => admin_rooms_title(),
+        "admin_rooms"        => admin_rooms_title(),
-      "admin_groups" => admin_groups_title(),
+        "admin_groups"       => admin_groups_title(),
-      "admin_import" => admin_import_title(),
+        "admin_import"       => admin_import_title(),
-      "admin_log" => admin_log_title(),
+        "admin_log"          => admin_log_title(),
-      "admin_event_config" => event_config_title()
+        "admin_event_config" => event_config_title()
-  ];
+    ];
 
     foreach ($admin_pages as $menu_page => $title) {
         if (in_array($menu_page, $privileges)) {
@@ -158,7 +175,7 @@ function make_room_navigation($menu)
 {
     global $privileges;
 
-    if (! in_array('view_rooms', $privileges)) {
+    if (!in_array('view_rooms', $privileges)) {
         return $menu;
     }
 

includes/sys_page.php

@@ -8,13 +8,13 @@ use Engelsystem\ValidationResult;
 /**
  * Parse a date from da day and a time textfield.
  *
- * @param string $date_name
+ * @param string   $date_name
  *          Name of the textfield containing the day (format Y-m-d)
- * @param string $time_name
+ * @param string   $time_name
  *          Name of the textfield containing the time (format H:i)
  * @param string[] $allowed_days
  *          List of allowed days in format Y-m-d
- * @param int $default_value
+ * @param int      $default_value
  *          Default value unix timestamp
  */
 function check_request_datetime($date_name, $time_name, $allowed_days, $default_value)
@@ -74,7 +74,7 @@ function raw_output($output)
 /**
  * Helper function for transforming list of entities into array for select boxes.
  *
- * @param array $data
+ * @param array  $data
  *          The data array
  * @param string $key_name
  *          name of the column to use as id/key
@@ -94,9 +94,9 @@ function select_array($data, $key_name, $value_name)
  * Returns an int[] from given request param name.
  *
  * @param String $name
- *          Name of the request param
+ *                     Name of the request param
- * @param array<int> $default
+ * @param        array <int> $default
- *          Default return value, if param is not set
+ *                     Default return value, if param is not set
  */
 function check_request_int_array($name, $default = [])
 {
@@ -110,9 +110,9 @@ function check_request_int_array($name, $default = [])
  * Checks if given request item (name) can be parsed to a date.
  * If not parsable, given error message is put into msg() and null is returned.
  *
- * @param string $input
+ * @param string  $input
  *          String to be parsed into a date.
- * @param string $error_message
+ * @param string  $error_message
  *          the error message displayed if $input is not parsable
  * @param boolean $null_allowed
  *          is a null value allowed?
@@ -120,7 +120,7 @@ function check_request_int_array($name, $default = [])
  */
 function check_request_date($name, $error_message = null, $null_allowed = false)
 {
-    if (! isset($_REQUEST[$name])) {
+    if (!isset($_REQUEST[$name])) {
         return new ValidationResult($null_allowed, null);
     }
     return check_date($_REQUEST[$name], $error_message, $null_allowed);
@@ -130,9 +130,9 @@ function check_request_date($name, $error_message = null, $null_allowed = false)
  * Checks if given string can be parsed to a date.
  * If not parsable, given error message is put into msg() and null is returned.
  *
- * @param string $input
+ * @param string  $input
  *          String to be parsed into a date.
- * @param string $error_message
+ * @param string  $error_message
  *          the error message displayed if $input is not parsable
  * @param boolean $null_allowed
  *          is a null value allowed?
@@ -198,5 +198,5 @@ function strip_item($item)
  */
 function check_email($email)
 {
-    return (bool) filter_var($email, FILTER_VALIDATE_EMAIL);
+    return (bool)filter_var($email, FILTER_VALIDATE_EMAIL);
 }

includes/sys_template.php

@@ -95,7 +95,7 @@ function toolbar_pills($items)
  * @param string $href
  * @param string $glyphicon
  * @param string $label
- * @param bool $selected
+ * @param bool   $selected
  * @return string
  */
 function toolbar_item_link($href, $glyphicon, $label, $selected = false)
@@ -158,17 +158,17 @@ function page_with_title($title, $elements)
 function table($columns, $rows_raw, $data = true)
 {
     // If only one column is given
-  if (! is_array($columns)) {
+    if (!is_array($columns)) {
-      $rows = [];
+        $rows = [];
-      foreach ($rows_raw as $row) {
+        foreach ($rows_raw as $row) {
-          $rows[] = [
+            $rows[] = [
-          'col' => $row
+                'col' => $row
-      ];
+            ];
-      }
+        }
-      return render_table([
+        return render_table([
-        'col' => $columns
+            'col' => $columns
-    ], $rows, $data);
+        ], $rows, $data);
-  }
+    }
 
     return render_table($columns, $rows_raw, $data);
 }
@@ -255,7 +255,9 @@ function shorten($str, $length = 50)
     if (strlen($str) < $length) {
         return $str;
     }
-    return '<span title="' . htmlentities($str, ENT_COMPAT, 'UTF-8') . '">' . substr($str, 0, $length - 3) . '...</span>';
+    return '<span title="' . htmlentities($str, ENT_COMPAT, 'UTF-8') . '">'
+        . substr($str, 0, $length - 3)
+        . '...</span>';
 }
 
 function table_body($array)

includes/view/AngelTypes_view.php

@@ -42,12 +42,16 @@ function AngelType_render_membership($user_angeltype)
 function AngelType_delete_view($angeltype)
 {
     return page_with_title(sprintf(_("Delete angeltype %s"), $angeltype['name']), [
-      info(sprintf(_("Do you want to delete angeltype %s?"), $angeltype['name']), true),
+        info(sprintf(_("Do you want to delete angeltype %s?"), $angeltype['name']), true),
-      buttons([
+        buttons([
-          button(page_link_to('angeltypes'), _("cancel"), 'cancel'),
+            button(page_link_to('angeltypes'), _("cancel"), 'cancel'),
-          button(page_link_to('angeltypes') . '&action=delete&angeltype_id=' . $angeltype['id'] . '&confirmed', _("delete"), 'ok')
+            button(
-      ])
+                page_link_to('angeltypes') . '&action=delete&angeltype_id=' . $angeltype['id'] . '&confirmed',
-  ]);
+                _("delete"),
+                'ok'
+            )
+        ])
+    ]);
 }
 
 /**
@@ -55,31 +59,46 @@ function AngelType_delete_view($angeltype)
  *
  * @param Angeltype $angeltype
  *          The angeltype to edit
- * @param boolean $supporter_mode
+ * @param boolean   $supporter_mode
  *          Is the user a supporter of this angeltype?
  */
 function AngelType_edit_view($angeltype, $supporter_mode)
 {
     $contact_info = AngelType_contact_info($angeltype);
     return page_with_title(sprintf(_("Edit %s"), $angeltype['name']), [
-      buttons([
+        buttons([
-          button(page_link_to('angeltypes'), _("Angeltypes"), 'back')
+            button(page_link_to('angeltypes'), _("Angeltypes"), 'back')
-      ]),
+        ]),
-      msg(),
+        msg(),
-      form([
+        form([
-          $supporter_mode ? form_info(_("Name"), $angeltype['name']) : form_text('name', _("Name"), $angeltype['name']),
+            $supporter_mode
-          $supporter_mode ? form_info(_("Restricted"), $angeltype['restricted'] ? _("Yes") : _("No")) : form_checkbox('restricted', _("Restricted"), $angeltype['restricted']),
+                ? form_info(_("Name"), $angeltype['name'])
-          $supporter_mode ? form_info(_("No Self Sign Up"), $angeltype['no_self_signup'] ? _("Yes") : _("No")) : form_checkbox('no_self_signup', _("No Self Sign Up"), $angeltype['no_self_signup']),
+                : form_text('name', _("Name"), $angeltype['name']),
-          $supporter_mode ? form_info(_("Requires driver license"), $angeltype['requires_driver_license'] ? _("Yes") : _("No")) : form_checkbox('requires_driver_license', _("Requires driver license"), $angeltype['requires_driver_license']),
+            $supporter_mode
-          //form_text('contact_name', _("Name"), $angeltype['contact_name']),
+                ? form_info(_("Restricted"), $angeltype['restricted'] ? _("Yes") : _("No"))
-          //form_text('contact_dect', _("DECT"), $angeltype['contact_dect']),
+                : form_checkbox('restricted', _("Restricted"), $angeltype['restricted']),
-          //form_text('contact_email', _("E-Mail"), $angeltype['contact_email']),
+            $supporter_mode
-          form_info("", _("Restricted angel types can only be used by an angel if enabled by a supporter (double opt-in).")),
+                ? form_info(_("No Self Sign Up"), $angeltype['no_self_signup'] ? _("Yes") : _("No"))
-          form_textarea('description', _("Description"), $angeltype['description']),
+                : form_checkbox('no_self_signup', _("No Self Sign Up"), $angeltype['no_self_signup']),
-          form_info("", _("Please use markdown for the description.")),
+            $supporter_mode
-          form_submit('submit', _("Save"))
+                ? form_info(_("Requires driver license"), $angeltype['requires_driver_license'] ? _("Yes") : _("No"))
-      ])
+                : form_checkbox(
-  ]);
+                'requires_driver_license',
+                _("Requires driver license"),
+                $angeltype['requires_driver_license']
+            ),
+            //form_text('contact_name', _("Name"), $angeltype['contact_name']),
+            //form_text('contact_dect', _("DECT"), $angeltype['contact_dect']),
+            //form_text('contact_email', _("E-Mail"), $angeltype['contact_email']),
+            form_info(
+                "",
+                _("Restricted angel types can only be used by an angel if enabled by a supporter (double opt-in).")
+            ),
+            form_textarea('description', _("Description"), $angeltype['description']),
+            form_info("", _("Please use markdown for the description.")),
+            form_submit('submit', _("Save"))
+        ])
+    ]);
 }
 
 /**
@@ -88,31 +107,47 @@ function AngelType_edit_view($angeltype, $supporter_mode)
 function AngelType_view_buttons($angeltype, $user_angeltype, $admin_angeltypes, $supporter, $user_driver_license, $user)
 {
     $buttons = [
-      button(page_link_to('angeltypes'), _("Angeltypes"), 'back')
+        button(page_link_to('angeltypes'), _("Angeltypes"), 'back')
-  ];
+    ];
 
     if ($angeltype['requires_driver_license']) {
         $buttons[] = button(user_driver_license_edit_link($user), glyph("road") . _("my driving license"));
     }
 
     if ($user_angeltype == null) {
-        $buttons[] = button(page_link_to('user_angeltypes') . '&action=add&angeltype_id=' . $angeltype['id'], _("join"), 'add');
+        $buttons[] = button(
+            page_link_to('user_angeltypes') . '&action=add&angeltype_id=' . $angeltype['id'],
+            _("join"),
+            'add'
+        );
     } else {
         if ($angeltype['requires_driver_license'] && $user_driver_license == null) {
             error(_("This angeltype requires a driver license. Please enter your driver license information!"));
         }
 
         if ($angeltype['restricted'] && $user_angeltype['confirm_user_id'] == null) {
-            error(sprintf(_("You are unconfirmed for this angeltype. Please go to the introduction for %s to get confirmed."), $angeltype['name']));
+            error(sprintf(
+                _("You are unconfirmed for this angeltype. Please go to the introduction for %s to get confirmed."),
+                $angeltype['name']
+            ));
         }
-        $buttons[] = button(page_link_to('user_angeltypes') . '&action=delete&user_angeltype_id=' . $user_angeltype['id'], _("leave"), 'cancel');
+        $buttons[] = button(page_link_to('user_angeltypes') . '&action=delete&user_angeltype_id=' . $user_angeltype['id'],
+            _("leave"), 'cancel');
     }
 
     if ($admin_angeltypes || $supporter) {
-        $buttons[] = button(page_link_to('angeltypes') . '&action=edit&angeltype_id=' . $angeltype['id'], _("edit"), 'edit');
+        $buttons[] = button(
+            page_link_to('angeltypes') . '&action=edit&angeltype_id=' . $angeltype['id'],
+            _("edit"),
+            'edit'
+        );
     }
     if ($admin_angeltypes) {
-        $buttons[] = button(page_link_to('angeltypes') . '&action=delete&angeltype_id=' . $angeltype['id'], _("delete"), 'delete');
+        $buttons[] = button(
+            page_link_to('angeltypes') . '&action=delete&angeltype_id=' . $angeltype['id'],
+            _("delete"),
+            'delete'
+        );
     }
 
     return buttons($buttons);
@@ -143,15 +178,27 @@ function AngelType_view_members($angeltype, $members, $admin_user_angeltypes, $a
 
         if ($angeltype['restricted'] && $member['confirm_user_id'] == null) {
             $member['actions'] = table_buttons([
-          button(page_link_to('user_angeltypes') . '&action=confirm&user_angeltype_id=' . $member['user_angeltype_id'], _("confirm"), 'btn-xs'),
+                button(
-          button(page_link_to('user_angeltypes') . '&action=delete&user_angeltype_id=' . $member['user_angeltype_id'], _("deny"), 'btn-xs')
+                    page_link_to('user_angeltypes') . '&action=confirm&user_angeltype_id=' . $member['user_angeltype_id'],
-      ]);
+                    _("confirm"),
+                    'btn-xs'
+                ),
+                button(
+                    page_link_to('user_angeltypes') . '&action=delete&user_angeltype_id=' . $member['user_angeltype_id'],
+                    _("deny"),
+                    'btn-xs'
+                )
+            ]);
             $members_unconfirmed[] = $member;
         } elseif ($member['supporter']) {
             if ($admin_angeltypes) {
                 $member['actions'] = table_buttons([
-            button(page_link_to('user_angeltypes') . '&action=update&user_angeltype_id=' . $member['user_angeltype_id'] . '&supporter=0', _("Remove supporter rights"), 'btn-xs')
+                    button(
-        ]);
+                        page_link_to('user_angeltypes') . '&action=update&user_angeltype_id=' . $member['user_angeltype_id'] . '&supporter=0',
+                        _("Remove supporter rights"),
+                        'btn-xs'
+                    )
+                ]);
             } else {
                 $member['actions'] = '';
             }
@@ -159,19 +206,26 @@ function AngelType_view_members($angeltype, $members, $admin_user_angeltypes, $a
         } else {
             if ($admin_user_angeltypes) {
                 $member['actions'] = table_buttons([
-            $admin_angeltypes ? button(page_link_to('user_angeltypes') . '&action=update&user_angeltype_id=' . $member['user_angeltype_id'] . '&supporter=1', _("Add supporter rights"), 'btn-xs') : '',
+                    $admin_angeltypes
-            button(page_link_to('user_angeltypes') . '&action=delete&user_angeltype_id=' . $member['user_angeltype_id'], _("remove"), 'btn-xs')
+                        ? button(page_link_to('user_angeltypes') . '&action=update&user_angeltype_id=' . $member['user_angeltype_id'] . '&supporter=1',
-        ]);
+                        _("Add supporter rights"), 'btn-xs')
+                        : '',
+                    button(
+                        page_link_to('user_angeltypes') . '&action=delete&user_angeltype_id=' . $member['user_angeltype_id'],
+                        _("remove"),
+                        'btn-xs'
+                    )
+                ]);
             }
             $members_confirmed[] = $member;
         }
     }
 
     return [
-      $supporters,
+        $supporters,
-      $members_confirmed,
+        $members_confirmed,
-      $members_unconfirmed
+        $members_unconfirmed
-  ];
+    ];
 }
 
 /**
@@ -181,34 +235,42 @@ function AngelType_view_table_headers($angeltype, $supporter, $admin_angeltypes)
 {
     if ($angeltype['requires_driver_license'] && ($supporter || $admin_angeltypes)) {
         return [
-        'Nick' => _("Nick"),
+            'Nick'                         => _("Nick"),
-        'DECT' => _("DECT"),
+            'DECT'                         => _("DECT"),
-        'wants_to_drive' => _("Driver"),
+            'wants_to_drive'               => _("Driver"),
-        'has_car' => _("Has car"),
+            'has_car'                      => _("Has car"),
-        'has_license_car' => _("Car"),
+            'has_license_car'              => _("Car"),
-        'has_license_3_5t_transporter' => _("3,5t Transporter"),
+            'has_license_3_5t_transporter' => _("3,5t Transporter"),
-        'has_license_7_5t_truck' => _("7,5t Truck"),
+            'has_license_7_5t_truck'       => _("7,5t Truck"),
-        'has_license_12_5t_truck' => _("12,5t Truck"),
+            'has_license_12_5t_truck'      => _("12,5t Truck"),
-        'has_license_forklift' => _("Forklift"),
+            'has_license_forklift'         => _("Forklift"),
-        'actions' => ''
+            'actions'                      => ''
-    ];
+        ];
     }
     return [
-      'Nick' => _("Nick"),
+        'Nick'    => _("Nick"),
-      'DECT' => _("DECT"),
+        'DECT'    => _("DECT"),
-      'actions' => ''
+        'actions' => ''
-  ];
+    ];
 }
 
 /**
  * Render an angeltype page containing the member lists.
  */
-function AngelType_view($angeltype, $members, $user_angeltype, $admin_user_angeltypes, $admin_angeltypes, $supporter, $user_driver_license, $user)
+function AngelType_view(
-{
+    $angeltype,
+    $members,
+    $user_angeltype,
+    $admin_user_angeltypes,
+    $admin_angeltypes,
+    $supporter,
+    $user_driver_license,
+    $user
+) {
     $page = [
-      AngelType_view_buttons($angeltype, $user_angeltype, $admin_angeltypes, $supporter, $user_driver_license, $user),
+        AngelType_view_buttons($angeltype, $user_angeltype, $admin_angeltypes, $supporter, $user_driver_license, $user),
-      msg()
+        msg()
-  ];
+    ];
 
     $page[] = '<h3>' . _("Description") . '</h3>';
     $parsedown = new Parsedown();
@@ -216,7 +278,12 @@ function AngelType_view($angeltype, $members, $user_angeltype, $admin_user_angel
         $page[] = '<div class="well">' . $parsedown->parse($angeltype['description']) . '</div>';
     }
 
-    list($supporters, $members_confirmed, $members_unconfirmed) = AngelType_view_members($angeltype, $members, $admin_user_angeltypes, $admin_angeltypes);
+    list($supporters, $members_confirmed, $members_unconfirmed) = AngelType_view_members(
+        $angeltype,
+        $members,
+        $admin_user_angeltypes,
+        $admin_angeltypes
+    );
     $table_headers = AngelType_view_table_headers($angeltype, $supporter, $admin_angeltypes);
 
     if (count($supporters) > 0) {
@@ -226,34 +293,42 @@ function AngelType_view($angeltype, $members, $user_angeltype, $admin_user_angel
 
     if (count($members_confirmed) > 0) {
         $members_confirmed[] = [
-        'Nick' => _('Sum'),
+            'Nick'    => _('Sum'),
-        'DECT' => count($members_confirmed),
+            'DECT'    => count($members_confirmed),
-        'actions' => ''
+            'actions' => ''
-    ];
+        ];
     }
 
     if (count($members_unconfirmed) > 0) {
         $members_unconfirmed[] = [
-        'Nick' => _('Sum'),
+            'Nick'    => _('Sum'),
-        'DECT' => count($members_unconfirmed),
+            'DECT'    => count($members_unconfirmed),
-        'actions' => ''
+            'actions' => ''
-    ];
+        ];
     }
 
     $page[] = '<h3>' . _("Members") . '</h3>';
     if ($admin_user_angeltypes) {
         $page[] = buttons([
-        button(page_link_to('user_angeltypes') . '&action=add&angeltype_id=' . $angeltype['id'], _("Add"), 'add')
+            button(page_link_to('user_angeltypes') . '&action=add&angeltype_id=' . $angeltype['id'], _("Add"), 'add')
-    ]);
+        ]);
     }
     $page[] = table($table_headers, $members_confirmed);
 
     if ($admin_user_angeltypes && $angeltype['restricted'] && count($members_unconfirmed) > 0) {
         $page[] = '<h3>' . _("Unconfirmed") . '</h3>';
         $page[] = buttons([
-        button(page_link_to('user_angeltypes') . '&action=confirm_all&angeltype_id=' . $angeltype['id'], _("confirm all"), 'ok'),
+            button(
-        button(page_link_to('user_angeltypes') . '&action=delete_all&angeltype_id=' . $angeltype['id'], _("deny all"), 'cancel')
+                page_link_to('user_angeltypes') . '&action=confirm_all&angeltype_id=' . $angeltype['id'],
-    ]);
+                _("confirm all"),
+                'ok'
+            ),
+            button(
+                page_link_to('user_angeltypes') . '&action=delete_all&angeltype_id=' . $angeltype['id'],
+                _("deny all"),
+                'cancel'
+            )
+        ]);
         $page[] = table($table_headers, $members_unconfirmed);
     }
 
@@ -268,19 +343,19 @@ function AngelType_view($angeltype, $members, $user_angeltype, $admin_user_angel
 function AngelTypes_list_view($angeltypes, $admin_angeltypes)
 {
     return page_with_title(angeltypes_title(), [
-      msg(),
+        msg(),
-      buttons([
+        buttons([
-          $admin_angeltypes ? button(page_link_to('angeltypes') . '&action=edit', _("New angeltype"), 'add') : '',
+            $admin_angeltypes ? button(page_link_to('angeltypes') . '&action=edit', _("New angeltype"), 'add') : '',
-          button(page_link_to('angeltypes') . '&action=about', _("Teams/Job description"))
+            button(page_link_to('angeltypes') . '&action=about', _("Teams/Job description"))
-      ]),
+        ]),
-      table([
+        table([
-          'name' => _("Name"),
+            'name'           => _("Name"),
-          'restricted' => glyph('lock') . _("Restricted"),
+            'restricted'     => glyph('lock') . _("Restricted"),
-          'no_self_signup' => glyph('share') . _("Self Sign Up Allowed"),
+            'no_self_signup' => glyph('share') . _("Self Sign Up Allowed"),
-          'membership' => _("Membership"),
+            'membership'     => _("Membership"),
-          'actions' => ""
+            'actions'        => ""
-      ], $angeltypes)
+        ], $angeltypes)
-  ]);
+    ]);
 }
 
 /**
@@ -295,15 +370,26 @@ function AngelTypes_about_view_angeltype($angeltype)
     if (isset($angeltype['user_angeltype_id'])) {
         $buttons = [];
         if ($angeltype['user_angeltype_id'] != null) {
-            $buttons[] = button(page_link_to('user_angeltypes') . '&action=delete&user_angeltype_id=' . $angeltype['user_angeltype_id'], _("leave"), 'cancel');
+            $buttons[] = button(
+                page_link_to('user_angeltypes') . '&action=delete&user_angeltype_id=' . $angeltype['user_angeltype_id'],
+                _("leave"),
+                'cancel'
+            );
         } else {
-            $buttons[] = button(page_link_to('user_angeltypes') . '&action=add&angeltype_id=' . $angeltype['id'], _("join"), 'add');
+            $buttons[] = button(
+                page_link_to('user_angeltypes') . '&action=add&angeltype_id=' . $angeltype['id'],
+                _("join"),
+                'add'
+            );
         }
         $html .= buttons($buttons);
     }
 
     if ($angeltype['restricted']) {
-        $html .= info(_("This angeltype is restricted by double-opt-in by a team supporter. Please show up at the according introduction meetings."), true);
+        $html .= info(
+            _("This angeltype is restricted by double-opt-in by a team supporter. Please show up at the according introduction meetings."),
+            true
+        );
     }
     if ($angeltype['description'] != "") {
         $html .= '<div class="well">' . $parsedown->parse($angeltype['description']) . '</div>';
@@ -321,15 +407,15 @@ function AngelTypes_about_view($angeltypes, $user_logged_in)
     global $faq_url;
 
     $content = [
-      buttons([
+        buttons([
-          ! $user_logged_in ? button(page_link_to('register'), register_title()) : '',
+            !$user_logged_in ? button(page_link_to('register'), register_title()) : '',
-          ! $user_logged_in ? button(page_link_to('login'), login_title()) : '',
+            !$user_logged_in ? button(page_link_to('login'), login_title()) : '',
-          $user_logged_in ? button(page_link_to('angeltypes'), angeltypes_title(), 'back') : '',
+            $user_logged_in ? button(page_link_to('angeltypes'), angeltypes_title(), 'back') : '',
-          button($faq_url, _("FAQ"), "btn-primary")
+            button($faq_url, _("FAQ"), "btn-primary")
-      ]),
+        ]),
-      '<p>' . _("Here is the list of teams and their tasks. If you have questions, read the FAQ.") . '</p>',
+        '<p>' . _("Here is the list of teams and their tasks. If you have questions, read the FAQ.") . '</p>',
-      '<hr />'
+        '<hr />'
-  ];
+    ];
     foreach ($angeltypes as $angeltype) {
         $content[] = AngelTypes_about_view_angeltype($angeltype);
     }

includes/view/EventConfig_view.php

@@ -2,54 +2,58 @@
 
 /**
  * Shows basic event infos and countdowns.
+ *
  * @param EventConfig $event_config The event configuration
  */
 function EventConfig_countdown_page($event_config)
 {
     if ($event_config == null) {
         return div('col-md-12 text-center', [
-        heading(sprintf(_("Welcome to the %s!"), '<span class="icon-icon_angel"></span> ENGELSYSTEM'), 2)
+            heading(sprintf(_("Welcome to the %s!"), '<span class="icon-icon_angel"></span> ENGELSYSTEM'), 2)
-    ]);
+        ]);
     }
 
     $elements = [];
 
     if ($event_config['event_name'] != null) {
         $elements[] = div('col-sm-12 text-center', [
-        heading(sprintf(_("Welcome to the %s!"), $event_config['event_name'] . ' <span class="icon-icon_angel"></span> ENGELSYSTEM'), 2)
+            heading(sprintf(
-    ]);
+                _("Welcome to the %s!"),
+                $event_config['event_name'] . ' <span class="icon-icon_angel"></span> ENGELSYSTEM'
+            ), 2)
+        ]);
     }
 
     if ($event_config['buildup_start_date'] != null && time() < $event_config['buildup_start_date']) {
         $elements[] = div('col-sm-3 text-center hidden-xs', [
-        heading(_("Buildup starts"), 4),
+            heading(_("Buildup starts"), 4),
-        '<span class="moment-countdown text-big" data-timestamp="' . $event_config['buildup_start_date'] . '">%c</span>',
+            '<span class="moment-countdown text-big" data-timestamp="' . $event_config['buildup_start_date'] . '">%c</span>',
-        '<small>' . date(_("Y-m-d"), $event_config['buildup_start_date']) . '</small>'
+            '<small>' . date(_("Y-m-d"), $event_config['buildup_start_date']) . '</small>'
-    ]);
+        ]);
     }
 
     if ($event_config['event_start_date'] != null && time() < $event_config['event_start_date']) {
         $elements[] = div('col-sm-3 text-center hidden-xs', [
-        heading(_("Event starts"), 4),
+            heading(_("Event starts"), 4),
-        '<span class="moment-countdown text-big" data-timestamp="' . $event_config['event_start_date'] . '">%c</span>',
+            '<span class="moment-countdown text-big" data-timestamp="' . $event_config['event_start_date'] . '">%c</span>',
-        '<small>' . date(_("Y-m-d"), $event_config['event_start_date']) . '</small>'
+            '<small>' . date(_("Y-m-d"), $event_config['event_start_date']) . '</small>'
-    ]);
+        ]);
     }
 
     if ($event_config['event_end_date'] != null && time() < $event_config['event_end_date']) {
         $elements[] = div('col-sm-3 text-center hidden-xs', [
-        heading(_("Event ends"), 4),
+            heading(_("Event ends"), 4),
-        '<span class="moment-countdown text-big" data-timestamp="' . $event_config['event_end_date'] . '">%c</span>',
+            '<span class="moment-countdown text-big" data-timestamp="' . $event_config['event_end_date'] . '">%c</span>',
-        '<small>' . date(_("Y-m-d"), $event_config['event_end_date']) . '</small>'
+            '<small>' . date(_("Y-m-d"), $event_config['event_end_date']) . '</small>'
-    ]);
+        ]);
     }
 
     if ($event_config['teardown_end_date'] != null && time() < $event_config['teardown_end_date']) {
         $elements[] = div('col-sm-3 text-center hidden-xs', [
-        heading(_("Teardown ends"), 4),
+            heading(_("Teardown ends"), 4),
-        '<span class="moment-countdown text-big" data-timestamp="' . $event_config['teardown_end_date'] . '">%c</span>',
+            '<span class="moment-countdown text-big" data-timestamp="' . $event_config['teardown_end_date'] . '">%c</span>',
-        '<small>' . date(_("Y-m-d"), $event_config['teardown_end_date']) . '</small>'
+            '<small>' . date(_("Y-m-d"), $event_config['teardown_end_date']) . '</small>'
-    ]);
+        ]);
     }
 
     return join("", $elements);
@@ -64,25 +68,37 @@ function EventConfig_info($event_config)
         return "";
     }
 
-  // Event name, start+end date are set
+    // Event name, start+end date are set
-  if ($event_config['event_name'] != null && $event_config['event_start_date'] != null && $event_config['event_end_date'] != null) {
+    if ($event_config['event_name'] != null && $event_config['event_start_date'] != null && $event_config['event_end_date'] != null) {
-      return sprintf(_("%s, from %s to %s"), $event_config['event_name'], date(_("Y-m-d"), $event_config['event_start_date']), date(_("Y-m-d"), $event_config['event_end_date']));
+        return sprintf(
-  }
+            _("%s, from %s to %s"),
+            $event_config['event_name'],
+            date(_("Y-m-d"), $event_config['event_start_date']),
+            date(_("Y-m-d"), $event_config['event_end_date'])
+        );
+    }
 
-  // Event name, start date are set
+    // Event name, start date are set
-  if ($event_config['event_name'] != null && $event_config['event_start_date'] != null) {
+    if ($event_config['event_name'] != null && $event_config['event_start_date'] != null) {
-      return sprintf(_("%s, starting %s"), $event_config['event_name'], date(_("Y-m-d"), $event_config['event_start_date']));
+        return sprintf(
-  }
+            _("%s, starting %s"), $event_config['event_name'],
+            date(_("Y-m-d"), $event_config['event_start_date'])
+        );
+    }
 
-  // Event start+end date are set
+    // Event start+end date are set
-  if ($event_config['event_start_date'] != null && $event_config['event_end_date'] != null) {
+    if ($event_config['event_start_date'] != null && $event_config['event_end_date'] != null) {
-      return sprintf(_("Event from %s to %s"), date(_("Y-m-d"), $event_config['event_start_date']), date(_("Y-m-d"), $event_config['event_end_date']));
+        return sprintf(
-  }
+            _("Event from %s to %s"),
+            date(_("Y-m-d"), $event_config['event_start_date']),
+            date(_("Y-m-d"), $event_config['event_end_date'])
+        );
+    }
 
-  // Only event name is set
+    // Only event name is set
-  if ($event_config['event_name'] != null) {
+    if ($event_config['event_name'] != null) {
-      return sprintf($event_config['event_name']);
+        return sprintf($event_config['event_name']);
-  }
+    }
 
     return "";
 }
@@ -94,37 +110,43 @@ function EventConfig_info($event_config)
  *          The event name
  * @param string $event_welcome_msg
  *          The welcome message
- * @param date $buildup_start_date
+ * @param date   $buildup_start_date
- * @param date $event_start_date
+ * @param date   $event_start_date
- * @param date $event_end_date
+ * @param date   $event_end_date
- * @param date $teardown_end_date
+ * @param date   $teardown_end_date
  */
-function EventConfig_edit_view($event_name, $event_welcome_msg, $buildup_start_date, $event_start_date, $event_end_date, $teardown_end_date)
+function EventConfig_edit_view(
-{
+    $event_name,
+    $event_welcome_msg,
+    $buildup_start_date,
+    $event_start_date,
+    $event_end_date,
+    $teardown_end_date
+) {
     return page_with_title(event_config_title(), [
-      msg(),
+        msg(),
-      form([
+        form([
-          div('row', [
+            div('row', [
-              div('col-md-6', [
+                div('col-md-6', [
-                  form_text('event_name', _("Event Name"), $event_name),
+                    form_text('event_name', _("Event Name"), $event_name),
-                  form_info('', _("Event Name is shown on the start page.")),
+                    form_info('', _("Event Name is shown on the start page.")),
-                  form_textarea('event_welcome_msg', _("Event Welcome Message"), $event_welcome_msg),
+                    form_textarea('event_welcome_msg', _("Event Welcome Message"), $event_welcome_msg),
-                  form_info('', _("Welcome message is shown after successful registration. You can use markdown."))
+                    form_info('', _("Welcome message is shown after successful registration. You can use markdown."))
-              ]),
+                ]),
-              div('col-md-3 col-xs-6', [
+                div('col-md-3 col-xs-6', [
-                  form_date('buildup_start_date', _("Buildup date"), $buildup_start_date),
+                    form_date('buildup_start_date', _("Buildup date"), $buildup_start_date),
-                  form_date('event_start_date', _("Event start date"), $event_start_date)
+                    form_date('event_start_date', _("Event start date"), $event_start_date)
-              ]),
+                ]),
-              div('col-md-3 col-xs-6', [
+                div('col-md-3 col-xs-6', [
-                  form_date('teardown_end_date', _("Teardown end date"), $teardown_end_date),
+                    form_date('teardown_end_date', _("Teardown end date"), $teardown_end_date),
-                  form_date('event_end_date', _("Event end date"), $event_end_date)
+                    form_date('event_end_date', _("Event end date"), $event_end_date)
-              ])
+                ])
-          ]),
+            ]),
-          div('row', [
+            div('row', [
-              div('col-md-6', [
+                div('col-md-6', [
-                  form_submit('submit', _("Save"))
+                    form_submit('submit', _("Save"))
-              ])
+                ])
-          ])
+            ])
-      ])
+        ])
-  ]);
+    ]);
 }

includes/view/Questions_view.php

@@ -14,23 +14,23 @@ function Questions_view($open_questions, $answered_questions, $ask_action)
     }
 
     return page_with_title(questions_title(), [
-      msg(),
+        msg(),
-      heading(_("Open questions"), 2),
+        heading(_("Open questions"), 2),
-      table([
+        table([
-          'Question' => _("Question"),
+            'Question' => _("Question"),
-          'actions' => ""
+            'actions'  => ""
-      ], $open_questions),
+        ], $open_questions),
-      heading(_("Answered questions"), 2),
+        heading(_("Answered questions"), 2),
-      table([
+        table([
-          'Question' => _("Question"),
+            'Question'    => _("Question"),
-          'answer_user' => _("Answered by"),
+            'answer_user' => _("Answered by"),
-          'Answer' => _("Answer"),
+            'Answer'      => _("Answer"),
-          'actions' => ""
+            'actions'     => ""
-      ], $answered_questions),
+        ], $answered_questions),
-      heading(_("Ask the Heaven"), 2),
+        heading(_("Ask the Heaven"), 2),
-      form([
+        form([
-          form_textarea('question', _("Your Question:"), ""),
+            form_textarea('question', _("Your Question:"), ""),
-          form_submit('submit', _("Save"))
+            form_submit('submit', _("Save"))
-      ], $ask_action)
+        ], $ask_action)
-  ]);
+    ]);
 }

includes/view/Rooms_view.php

@@ -1,13 +1,13 @@
 <?php
-use Engelsystem\ShiftsFilterRenderer;
 use Engelsystem\ShiftCalendarRenderer;
+use Engelsystem\ShiftsFilterRenderer;
 
 function Room_view($room, ShiftsFilterRenderer $shiftsFilterRenderer, ShiftCalendarRenderer $shiftCalendarRenderer)
 {
     return page_with_title(glyph('map-marker') . $room['Name'], [
-      $shiftsFilterRenderer->render(room_link($room)) ,
+        $shiftsFilterRenderer->render(room_link($room)),
-      $shiftCalendarRenderer->render()
+        $shiftCalendarRenderer->render()
-  ]);
+    ]);
 }
 
 function Room_name_render($room)

includes/view/ShiftCalendarLane.php

@@ -22,38 +22,38 @@ class ShiftCalendarLane
         $this->blockCount = $blockCount;
     }
 
-  /**
+    /**
-   * Adds a shift to the lane, but only if it fits.
+     * Adds a shift to the lane, but only if it fits.
-   * Returns true on success.
+     * Returns true on success.
-   *
+     *
-   * @param Shift $shift
+     * @param Shift $shift
-   *          The shift to add
+     *          The shift to add
-   * @return boolean true on success
+     * @return boolean true on success
-   */
+     */
-  public function addShift($shift)
+    public function addShift($shift)
-  {
+    {
-      if ($this->shiftFits($shift)) {
+        if ($this->shiftFits($shift)) {
-          $this->shifts[] = $shift;
+            $this->shifts[] = $shift;
-          return true;
+            return true;
-      }
+        }
-      return false;
+        return false;
-  }
+    }
 
-  /**
+    /**
-   * Returns true if given shift fits into this lane.
+     * Returns true if given shift fits into this lane.
-   *
+     *
-   * @param Shift $shift
+     * @param Shift $shift
-   *          The shift to fit into this lane
+     *          The shift to fit into this lane
-   */
+     */
-  public function shiftFits($newShift)
+    public function shiftFits($newShift)
-  {
+    {
-      foreach ($this->shifts as $laneShift) {
+        foreach ($this->shifts as $laneShift) {
-          if (! ($newShift['start'] >= $laneShift['end'] || $newShift['end'] <= $laneShift['start'])) {
+            if (!($newShift['start'] >= $laneShift['end'] || $newShift['end'] <= $laneShift['start'])) {
-              return false;
+                return false;
-          }
+            }
-      }
+        }
-      return true;
+        return true;
-  }
+    }
 
     public function getHeader()
     {

includes/view/ShiftCalendarRenderer.php

@@ -5,26 +5,26 @@ namespace Engelsystem;
 class ShiftCalendarRenderer
 {
 
-  /**
+    /**
-   * 15m * 60s/m = 900s
+     * 15m * 60s/m = 900s
-   */
+     */
-  const SECONDS_PER_ROW = 900;
+    const SECONDS_PER_ROW = 900;
-
+
-  /**
+    /**
-   * Height of a block in pixel.
+     * Height of a block in pixel.
-   * Do not change - corresponds with theme/css
+     * Do not change - corresponds with theme/css
-   */
+     */
-  const BLOCK_HEIGHT = 30;
+    const BLOCK_HEIGHT = 30;
-
+
-  /**
+    /**
-   * Distance between two shifts in pixels
+     * Distance between two shifts in pixels
-   */
+     */
-  const MARGIN = 5;
+    const MARGIN = 5;
-
+
-  /**
+    /**
-   * Seconds added to the start and end time
+     * Seconds added to the start and end time
-   */
+     */
-  const TIME_MARGIN = 1800;
+    const TIME_MARGIN = 1800;
 
     private $lanes;
 
@@ -50,51 +50,51 @@ class ShiftCalendarRenderer
         $this->shift_entries = $shift_entries;
     }
 
-  /**
+    /**
-   * Assigns the shifts to different lanes per room if they collide
+     * Assigns the shifts to different lanes per room if they collide
-   *
+     *
-   * @param Shift[] $shifts
+     * @param Shift[] $shifts
-   *          The shifts to assign
+     *          The shifts to assign
-   *
+     *
-   * @return Returns an array that assigns a room_id to an array of ShiftCalendarLane containing the shifts
+     * @return Returns an array that assigns a room_id to an array of ShiftCalendarLane containing the shifts
-   */
+     */
-  private function assignShiftsToLanes($shifts)
+    private function assignShiftsToLanes($shifts)
-  {
+    {
-      // array that assigns a room id to a list of lanes (per room)
+        // array that assigns a room id to a list of lanes (per room)
-    $lanes = [];
+        $lanes = [];
-    
+
-      foreach ($shifts as $shift) {
+        foreach ($shifts as $shift) {
-          $room_id = $shift['RID'];
+            $room_id = $shift['RID'];
-          $header = Room_name_render([
+            $header = Room_name_render([
-          'RID' => $room_id,
+                'RID'  => $room_id,
-          'Name' => $shift['room_name']
+                'Name' => $shift['room_name']
-      ]);
+            ]);
-          if (! isset($lanes[$room_id])) {
+            if (!isset($lanes[$room_id])) {
-              // initialize room with one lane
+                // initialize room with one lane
-        $lanes[$room_id] = [
+                $lanes[$room_id] = [
-            new ShiftCalendarLane($header, $this->getFirstBlockStartTime(), $this->getBlocksPerSlot())
+                    new ShiftCalendarLane($header, $this->getFirstBlockStartTime(), $this->getBlocksPerSlot())
-        ];
+                ];
-          }
+            }
-      // Try to add the shift to the existing lanes for this room
+            // Try to add the shift to the existing lanes for this room
-      $shift_added = false;
+            $shift_added = false;
-          foreach ($lanes[$room_id] as $lane) {
+            foreach ($lanes[$room_id] as $lane) {
-              $shift_added = $lane->addShift($shift);
+                $shift_added = $lane->addShift($shift);
-              if ($shift_added == true) {
+                if ($shift_added == true) {
-                  break;
+                    break;
-              }
+                }
-          }
+            }
-      // If all lanes for this room are busy, create a new lane and add shift to it
+            // If all lanes for this room are busy, create a new lane and add shift to it
-      if ($shift_added == false) {
+            if ($shift_added == false) {
-          $newLane = new ShiftCalendarLane($header, $this->getFirstBlockStartTime(), $this->getBlocksPerSlot());
+                $newLane = new ShiftCalendarLane($header, $this->getFirstBlockStartTime(), $this->getBlocksPerSlot());
-          if (! $newLane->addShift($shift)) {
+                if (!$newLane->addShift($shift)) {
-              engelsystem_error("Unable to add shift to new lane.");
+                    engelsystem_error("Unable to add shift to new lane.");
-          }
+                }
-          $lanes[$room_id][] = $newLane;
+                $lanes[$room_id][] = $newLane;
-      }
+            }
-      }
+        }
-    
+
-      return $lanes;
+        return $lanes;
-  }
+    }
 
     public function getFirstBlockStartTime()
     {
@@ -114,118 +114,119 @@ class ShiftCalendarRenderer
         return $this->blocksPerSlot;
     }
 
-  /**
+    /**
-   * Renders the whole calendar
+     * Renders the whole calendar
-   *
+     *
-   * @return the generated html
+     * @return the generated html
-   */
+     */
-  public function render()
+    public function render()
-  {
+    {
-      if (count($this->lanes) == 0) {
+        if (count($this->lanes) == 0) {
-          return '';
+            return '';
-      }
+        }
-      return div('shift-calendar', [
+        return div('shift-calendar', [
-        $this->renderTimeLane(),
+                $this->renderTimeLane(),
-        $this->renderShiftLanes()
+                $this->renderShiftLanes()
-    ]) . $this->renderLegend();
+            ]) . $this->renderLegend();
-  }
+    }
-
+
-  /**
+    /**
-   * Renders the lanes containing the shifts
+     * Renders the lanes containing the shifts
-   */
+     */
-  private function renderShiftLanes()
+    private function renderShiftLanes()
-  {
+    {
-      $html = "";
+        $html = "";
-      foreach ($this->lanes as $room_lanes) {
+        foreach ($this->lanes as $room_lanes) {
-          foreach ($room_lanes as $lane) {
+            foreach ($room_lanes as $lane) {
-              $html .= $this->renderLane($lane);
+                $html .= $this->renderLane($lane);
-          }
+            }
-      }
+        }
-    
+
-      return $html;
+        return $html;
-  }
+    }
-
+
-  /**
+    /**
-   * Renders a single lane
+     * Renders a single lane
-   *
+     *
-   * @param ShiftCalendarLane $lane
+     * @param ShiftCalendarLane $lane
-   *          The lane to render
+     *          The lane to render
-   */
+     */
-  private function renderLane(ShiftCalendarLane $lane)
+    private function renderLane(ShiftCalendarLane $lane)
-  {
+    {
-      global $user;
+        global $user;
-    
+
-      $shift_renderer = new ShiftCalendarShiftRenderer();
+        $shift_renderer = new ShiftCalendarShiftRenderer();
-      $html = "";
+        $html = "";
-      $rendered_until = $this->getFirstBlockStartTime();
+        $rendered_until = $this->getFirstBlockStartTime();
-    
+
-      foreach ($lane->getShifts() as $shift) {
+        foreach ($lane->getShifts() as $shift) {
-          while ($rendered_until + ShiftCalendarRenderer::SECONDS_PER_ROW <= $shift['start']) {
+            while ($rendered_until + ShiftCalendarRenderer::SECONDS_PER_ROW <= $shift['start']) {
-              $html .= $this->renderTick($rendered_until);
+                $html .= $this->renderTick($rendered_until);
-              $rendered_until += ShiftCalendarRenderer::SECONDS_PER_ROW;
+                $rendered_until += ShiftCalendarRenderer::SECONDS_PER_ROW;
-          }
+            }
-      
+
-          list($shift_height, $shift_html) = $shift_renderer->render($shift, $this->needed_angeltypes[$shift['SID']], $this->shift_entries[$shift['SID']], $user);
+            list($shift_height, $shift_html) = $shift_renderer->render($shift, $this->needed_angeltypes[$shift['SID']],
-          $html .= $shift_html;
+                $this->shift_entries[$shift['SID']], $user);
-          $rendered_until += $shift_height * ShiftCalendarRenderer::SECONDS_PER_ROW;
+            $html .= $shift_html;
-      }
+            $rendered_until += $shift_height * ShiftCalendarRenderer::SECONDS_PER_ROW;
-    
+        }
-      while ($rendered_until < $this->getLastBlockEndTime()) {
+
-          $html .= $this->renderTick($rendered_until);
+        while ($rendered_until < $this->getLastBlockEndTime()) {
-          $rendered_until += ShiftCalendarRenderer::SECONDS_PER_ROW;
+            $html .= $this->renderTick($rendered_until);
-      }
+            $rendered_until += ShiftCalendarRenderer::SECONDS_PER_ROW;
-    
+        }
-      return div('lane', [
+
-        div('header', $lane->getHeader()),
+        return div('lane', [
-        $html
+            div('header', $lane->getHeader()),
-    ]);
+            $html
-  }
+        ]);
-
+    }
-  /**
+
-   * Renders a tick/block for given time
+    /**
-   *
+     * Renders a tick/block for given time
-   * @param int $time
+     *
-   *          unix timestamp
+     * @param int     $time
-   * @param boolean $label
+     *          unix timestamp
-   *          Should time labels be generated?
+     * @param boolean $label
-   * @return rendered tick html
+     *          Should time labels be generated?
-   */
+     * @return rendered tick html
-  private function renderTick($time, $label = false)
+     */
-  {
+    private function renderTick($time, $label = false)
-      if ($time % (24 * 60 * 60) == 23 * 60 * 60) {
+    {
-          if (! $label) {
+        if ($time % (24 * 60 * 60) == 23 * 60 * 60) {
-              return div('tick day');
+            if (!$label) {
-          }
+                return div('tick day');
-          return div('tick day', [
+            }
-          date('m-d<b\r />H:i', $time)
+            return div('tick day', [
-      ]);
+                date('m-d<b\r />H:i', $time)
-      } elseif ($time % (60 * 60) == 0) {
+            ]);
-          if (! $label) {
+        } elseif ($time % (60 * 60) == 0) {
-              return div('tick hour');
+            if (!$label) {
-          }
+                return div('tick hour');
-          return div('tick hour', [
+            }
-          date('m-d<b\r />H:i', $time)
+            return div('tick hour', [
-      ]);
+                date('m-d<b\r />H:i', $time)
-      }
+            ]);
-      return div('tick');
+        }
-  }
+        return div('tick');
-
+    }
-  /**
+
-   * Renders the left time lane including hour/day ticks
+    /**
-   */
+     * Renders the left time lane including hour/day ticks
-  private function renderTimeLane()
+     */
-  {
+    private function renderTimeLane()
-      $time_slot = [
+    {
-        div('header', [
+        $time_slot = [
-            _("Time")
+            div('header', [
-        ])
+                _("Time")
-    ];
+            ])
-      for ($block = 0; $block < $this->getBlocksPerSlot(); $block ++) {
+        ];
-          $thistime = $this->getFirstBlockStartTime() + ($block * ShiftCalendarRenderer::SECONDS_PER_ROW);
+        for ($block = 0; $block < $this->getBlocksPerSlot(); $block++) {
-          $time_slot[] = $this->renderTick($thistime, true);
+            $thistime = $this->getFirstBlockStartTime() + ($block * ShiftCalendarRenderer::SECONDS_PER_ROW);
-      }
+            $time_slot[] = $this->renderTick($thistime, true);
-      return div('lane time', $time_slot);
+        }
-  }
+        return div('lane time', $time_slot);
+    }
 
     private function calcFirstBlockStartTime($shifts)
     {
@@ -254,17 +255,17 @@ class ShiftCalendarRenderer
         return ceil(($this->getLastBlockEndTime() - $this->getFirstBlockStartTime()) / ShiftCalendarRenderer::SECONDS_PER_ROW);
     }
 
-  /**
+    /**
-   * Renders a legend explaining the shift coloring
+     * Renders a legend explaining the shift coloring
-   */
+     */
-  private function renderLegend()
+    private function renderLegend()
-  {
+    {
-      return div('legend', [
+        return div('legend', [
-        label(_('Your shift'), 'primary'),
+            label(_('Your shift'), 'primary'),
-        label(_('Help needed'), 'danger'),
+            label(_('Help needed'), 'danger'),
-        label(_('Other angeltype needed / collides with my shifts'), 'warning'),
+            label(_('Other angeltype needed / collides with my shifts'), 'warning'),
-        label(_('Shift is full'), 'success'),
+            label(_('Shift is full'), 'success'),
-        label(_('Shift running/ended'), 'default')
+            label(_('Shift running/ended'), 'default')
-    ]);
+        ]);
-  }
+    }
 }

includes/view/ShiftCalendarShiftRenderer.php

@@ -8,63 +8,71 @@ namespace Engelsystem;
 class ShiftCalendarShiftRenderer
 {
 
-  /**
+    /**
-   * Renders a shift
+     * Renders a shift
-   *
+     *
-   * @param Shift $shift
+     * @param Shift $shift
-   *          The shift to render
+     *          The shift to render
-   * @param User $user
+     * @param User  $user
-   *          The user who is viewing the shift calendar
+     *          The user who is viewing the shift calendar
-   */
+     */
-  public function render($shift, $needed_angeltypes, $shift_entries, $user)
+    public function render($shift, $needed_angeltypes, $shift_entries, $user)
-  {
+    {
-      $info_text = "";
+        $info_text = "";
-      if ($shift['title'] != '') {
+        if ($shift['title'] != '') {
-          $info_text = glyph('info-sign') . $shift['title'] . '<br>';
+            $info_text = glyph('info-sign') . $shift['title'] . '<br>';
-      }
+        }
-      list($shift_signup_state, $shifts_row) = $this->renderShiftNeededAngeltypes($shift, $needed_angeltypes, $shift_entries, $user);
+        list($shift_signup_state, $shifts_row) = $this->renderShiftNeededAngeltypes(
-    
+            $shift,
-      $class = $this->classForSignupState($shift_signup_state);
+            $needed_angeltypes,
-    
+            $shift_entries,
-      $blocks = ceil(($shift["end"] - $shift["start"]) / ShiftCalendarRenderer::SECONDS_PER_ROW);
+            $user
-      $blocks = max(1, $blocks);
+        );
-      return [
+
-        $blocks,
+        $class = $this->classForSignupState($shift_signup_state);
-        div('shift panel panel-' . $class . '" style="height: ' . ($blocks * ShiftCalendarRenderer::BLOCK_HEIGHT - ShiftCalendarRenderer::MARGIN) . 'px"', [
+
-            $this->renderShiftHead($shift),
+        $blocks = ceil(($shift["end"] - $shift["start"]) / ShiftCalendarRenderer::SECONDS_PER_ROW);
-            div('panel-body', [
+        $blocks = max(1, $blocks);
-                $info_text,
+        return [
-                Room_name_render([
+            $blocks,
-                    'RID' => $shift['RID'],
+            div(
-                    'Name' => $shift['room_name']
+                'shift panel panel-' . $class . '" style="height: ' . ($blocks * ShiftCalendarRenderer::BLOCK_HEIGHT - ShiftCalendarRenderer::MARGIN) . 'px"',
-                ])
+                [
-            ]),
+                    $this->renderShiftHead($shift),
-            $shifts_row,
+                    div('panel-body', [
-            div('shift-spacer')
+                        $info_text,
-        ])
+                        Room_name_render([
-    ];
+                            'RID'  => $shift['RID'],
-  }
+                            'Name' => $shift['room_name']
+                        ])
+                    ]),
+                    $shifts_row,
+                    div('shift-spacer')
+                ]
+            )
+        ];
+    }
 
     private function classForSignupState(ShiftSignupState $shiftSignupState)
     {
         switch ($shiftSignupState->getState()) {
-      case ShiftSignupState::ADMIN:
+            case ShiftSignupState::ADMIN:
-      case ShiftSignupState::OCCUPIED:
+            case ShiftSignupState::OCCUPIED:
-        return 'success';
+                return 'success';
 
-      case ShiftSignupState::SIGNED_UP:
+            case ShiftSignupState::SIGNED_UP:
-        return 'primary';
+                return 'primary';
 
-      case ShiftSignupState::SHIFT_ENDED:
+            case ShiftSignupState::SHIFT_ENDED:
-        return 'default';
+                return 'default';
 
-      case ShiftSignupState::ANGELTYPE:
+            case ShiftSignupState::ANGELTYPE:
-      case ShiftSignupState::COLLIDES:
+            case ShiftSignupState::COLLIDES:
-        return 'warning';
+                return 'warning';
 
-      case ShiftSignupState::FREE:
+            case ShiftSignupState::FREE:
-        return 'danger';
+                return 'danger';
-    }
+        }
     }
 
     private function renderShiftNeededAngeltypes($shift, $needed_angeltypes, $shift_entries, $user)
@@ -83,7 +91,12 @@ class ShiftCalendarShiftRenderer
         $shift_signup_state = null;
         foreach ($needed_angeltypes as $angeltype) {
             if ($angeltype['count'] > 0 || count($shift_entries_filtered[$angeltype['id']]) > 0) {
-                list($angeltype_signup_state, $angeltype_html) = $this->renderShiftNeededAngeltype($shift, $shift_entries_filtered[$angeltype['id']], $angeltype, $user);
+                list($angeltype_signup_state, $angeltype_html) = $this->renderShiftNeededAngeltype(
+                    $shift,
+                    $shift_entries_filtered[$angeltype['id']],
+                    $angeltype,
+                    $user
+                );
                 if ($shift_signup_state == null) {
                     $shift_signup_state = $angeltype_signup_state;
                 } else {
@@ -97,103 +110,123 @@ class ShiftCalendarShiftRenderer
         }
 
         if (in_array('user_shifts_admin', $privileges)) {
-            $html .= '<li class="list-group-item">' . button(page_link_to('user_shifts') . '&amp;shift_id=' . $shift['SID'], _("Add more angels"), 'btn-xs') . '</li>';
+            $html .= '<li class="list-group-item">' . button(
+                    page_link_to('user_shifts') . '&amp;shift_id=' . $shift['SID'],
+                    _("Add more angels"),
+                    'btn-xs'
+                ) . '</li>';
         }
         if ($html != '') {
             return [
-          $shift_signup_state,
+                $shift_signup_state,
-          '<ul class="list-group">' . $html . '</ul>'
+                '<ul class="list-group">' . $html . '</ul>'
-      ];
+            ];
         }
         return [
-        $shift_signup_state,
+            $shift_signup_state,
-        ""
+            ""
-    ];
+        ];
     }
 
-  /**
+    /**
-   * Renders a list entry containing the needed angels for an angeltype
+     * Renders a list entry containing the needed angels for an angeltype
-   *
+     *
-   * @param Shift $shift
+     * @param Shift     $shift
-   *          The shift which is rendered
+     *          The shift which is rendered
-   * @param Angeltype $angeltype
+     * @param Angeltype $angeltype
-   *          The angeltype, containing informations about needed angeltypes and already signed up angels
+     *          The angeltype, containing informations about needed angeltypes and already signed up angels
-   * @param User $user
+     * @param User      $user
-   *          The user who is viewing the shift calendar
+     *          The user who is viewing the shift calendar
-   */
+     */
-  private function renderShiftNeededAngeltype($shift, $shift_entries, $angeltype, $user)
+    private function renderShiftNeededAngeltype($shift, $shift_entries, $angeltype, $user)
-  {
+    {
-      $entry_list = [];
+        $entry_list = [];
-      foreach ($shift_entries as $entry) {
+        foreach ($shift_entries as $entry) {
-          $style = $entry['freeloaded'] ? " text-decoration: line-through;" : '';
+            $style = $entry['freeloaded'] ? " text-decoration: line-through;" : '';
-          $entry_list[] = "<span style=\"$style\">" . User_Nick_render($entry) . "</span>";
+            $entry_list[] = "<span style=\"$style\">" . User_Nick_render($entry) . "</span>";
-      }
-      $shift_signup_state = Shift_signup_allowed($user, $shift, $angeltype, null, null, $angeltype, $shift_entries);
-      $inner_text = sprintf(ngettext("%d helper needed", "%d helpers needed", $shift_signup_state->getFreeEntries()), $shift_signup_state->getFreeEntries());
-      switch ($shift_signup_state->getState()) {
-      case ShiftSignupState::ADMIN:
-      case ShiftSignupState::FREE:
-        // When admin or free display a link + button for sign up
-        $entry_list[] = '<a href="' . page_link_to('user_shifts') . '&amp;shift_id=' . $shift['SID'] . '&amp;type_id=' . $angeltype['id'] . '">' . $inner_text . '</a> ' . button(page_link_to('user_shifts') . '&amp;shift_id=' . $shift['SID'] . '&amp;type_id=' . $angeltype['id'], _('Sign up'), 'btn-xs btn-primary');
-        break;
-      
-      case ShiftSignupState::SHIFT_ENDED:
-        // No link and add a text hint, when the shift ended
-        $entry_list[] = $inner_text . ' (' . _('ended') . ')';
-        break;
-      
-      case ShiftSignupState::ANGELTYPE:
-        if ($angeltype['restricted'] == 1) {
-            // User has to be confirmed on the angeltype first
-          $entry_list[] = $inner_text . glyph('lock');
-        } else {
-            // Add link to join the angeltype first
-          $entry_list[] = $inner_text . '<br />' . button(page_link_to('user_angeltypes') . '&action=add&angeltype_id=' . $angeltype['id'], sprintf(_('Become %s'), $angeltype['name']), 'btn-xs');
         }
-        break;
+        $shift_signup_state = Shift_signup_allowed($user, $shift, $angeltype, null, null, $angeltype, $shift_entries);
+        $inner_text = sprintf(
+            ngettext("%d helper needed", "%d helpers needed", $shift_signup_state->getFreeEntries()),
+            $shift_signup_state->getFreeEntries()
+        );
+        switch ($shift_signup_state->getState()) {
+            case ShiftSignupState::ADMIN:
+            case ShiftSignupState::FREE:
+                // When admin or free display a link + button for sign up
+                $entry_list[] = '<a href="' . page_link_to('user_shifts') . '&amp;shift_id=' . $shift['SID'] . '&amp;type_id=' . $angeltype['id'] . '">'
+                    . $inner_text
+                    . '</a> '
+                    . button(
+                        page_link_to('user_shifts') . '&amp;shift_id=' . $shift['SID'] . '&amp;type_id=' . $angeltype['id'],
+                        _('Sign up'), 'btn-xs btn-primary'
+                    );
+                break;
+
+            case ShiftSignupState::SHIFT_ENDED:
+                // No link and add a text hint, when the shift ended
+                $entry_list[] = $inner_text . ' (' . _('ended') . ')';
+                break;
+
+            case ShiftSignupState::ANGELTYPE:
+                if ($angeltype['restricted'] == 1) {
+                    // User has to be confirmed on the angeltype first
+                    $entry_list[] = $inner_text . glyph('lock');
+                } else {
+                    // Add link to join the angeltype first
+                    $entry_list[] = $inner_text . '<br />'
+                        . button(
+                            page_link_to('user_angeltypes') . '&action=add&angeltype_id=' . $angeltype['id'],
+                            sprintf(_('Become %s'), $angeltype['name']),
+                            'btn-xs'
+                        );
+                }
+                break;
+
+            case ShiftSignupState::COLLIDES:
+            case ShiftSignupState::SIGNED_UP:
+                // Shift collides or user is already signed up: No signup allowed
+                $entry_list[] = $inner_text;
+                break;
 
-      case ShiftSignupState::COLLIDES:
+            case ShiftSignupState::OCCUPIED:
-      case ShiftSignupState::SIGNED_UP:
+                // Shift is full
-        // Shift collides or user is already signed up: No signup allowed
+                break;
-        $entry_list[] = $inner_text;
+        }
-        break;
 
-      case ShiftSignupState::OCCUPIED:
+        $shifts_row = '<li class="list-group-item">';
-        // Shift is full
+        $shifts_row .= '<strong>' . AngelType_name_render($angeltype) . ':</strong> ';
-        break;
+        $shifts_row .= join(", ", $entry_list);
+        $shifts_row .= '</li>';
+        return [
+            $shift_signup_state,
+            $shifts_row
+        ];
     }
 
-      $shifts_row = '<li class="list-group-item">';
+    /**
-      $shifts_row .= '<strong>' . AngelType_name_render($angeltype) . ':</strong> ';
+     * Renders the shift header
-      $shifts_row .= join(", ", $entry_list);
+     *
-      $shifts_row .= '</li>';
+     * @param Shift $shift
-      return [
+     *          The shift
-        $shift_signup_state,
+     */
-        $shifts_row
+    private function renderShiftHead($shift)
-    ];
+    {
-  }
+        global $privileges;
-
+
-  /**
+        $header_buttons = "";
-   * Renders the shift header
+        if (in_array('admin_shifts', $privileges)) {
-   *
+            $header_buttons = '<div class="pull-right">' . table_buttons([
-   * @param Shift $shift
+                    button(page_link_to('user_shifts') . '&edit_shift=' . $shift['SID'], glyph('edit'), 'btn-xs'),
-   *          The shift
+                    button(page_link_to('user_shifts') . '&delete_shift=' . $shift['SID'], glyph('trash'), 'btn-xs')
-   */
+                ]) . '</div>';
-  private function renderShiftHead($shift)
+        }
-  {
+        $shift_heading = date('H:i', $shift['start']) . ' &dash; '
-      global $privileges;
+            . date('H:i', $shift['end']) . ' &mdash; '
-    
+            . $shift['name'];
-      $header_buttons = "";
+        return div('panel-heading', [
-      if (in_array('admin_shifts', $privileges)) {
+            '<a href="' . shift_link($shift) . '">' . $shift_heading . '</a>',
-          $header_buttons = '<div class="pull-right">' . table_buttons([
+            $header_buttons
-          button(page_link_to('user_shifts') . '&edit_shift=' . $shift['SID'], glyph('edit'), 'btn-xs'),
+        ]);
-          button(page_link_to('user_shifts') . '&delete_shift=' . $shift['SID'], glyph('trash'), 'btn-xs')
+    }
-      ]) . '</div>';
-      }
-      $shift_heading = date('H:i', $shift['start']) . ' &dash; ' . date('H:i', $shift['end']) . ' &mdash; ' . $shift['name'];
-      return div('panel-heading', [
-        '<a href="' . shift_link($shift) . '">' . $shift_heading . '</a>',
-        $header_buttons
-    ]);
-  }
 }

includes/view/ShiftEntry_view.php

@@ -2,6 +2,7 @@
 
 /**
  * Display form for adding/editing a shift entry.
+ *
  * @param string $angel
  * @param string $date
  * @param string $location
@@ -11,26 +12,35 @@
  *
  * @return string
  */
-function ShiftEntry_edit_view($angel, $date, $location, $title, $type, $comment, $freeloaded, $freeload_comment, $user_admin_shifts = false)
+function ShiftEntry_edit_view(
-{
+    $angel,
+    $date,
+    $location,
+    $title,
+    $type,
+    $comment,
+    $freeloaded,
+    $freeload_comment,
+    $user_admin_shifts = false
+) {
     $freeload_form = [];
     if ($user_admin_shifts) {
         $freeload_form = [
-        form_checkbox('freeloaded', _("Freeloaded"), $freeloaded),
+            form_checkbox('freeloaded', _("Freeloaded"), $freeloaded),
-        form_textarea('freeload_comment', _("Freeload comment (Only for shift coordination):"), $freeload_comment)
+            form_textarea('freeload_comment', _("Freeload comment (Only for shift coordination):"), $freeload_comment)
-    ];
+        ];
     }
     return page_with_title(_("Edit shift entry"), [
-      msg(),
+        msg(),
-      form([
+        form([
-          form_info(_("Angel:"), $angel),
+            form_info(_("Angel:"), $angel),
-          form_info(_("Date, Duration:"), $date),
+            form_info(_("Date, Duration:"), $date),
-          form_info(_("Location:"), $location),
+            form_info(_("Location:"), $location),
-          form_info(_("Title:"), $title),
+            form_info(_("Title:"), $title),
-          form_info(_("Type:"), $type),
+            form_info(_("Type:"), $type),
-          form_textarea('comment', _("Comment (for your eyes only):"), $comment),
+            form_textarea('comment', _("Comment (for your eyes only):"), $comment),
-          join("", $freeload_form),
+            join("", $freeload_form),
-          form_submit('submit', _("Save"))
+            form_submit('submit', _("Save"))
-      ])
+        ])
-  ]);
+    ]);
 }

includes/view/ShiftTypes_view.php

@@ -12,36 +12,40 @@ function ShiftType_name_render($shifttype)
 function ShiftType_delete_view($shifttype)
 {
     return page_with_title(sprintf(_("Delete shifttype %s"), $shifttype['name']), [
-      info(sprintf(_("Do you want to delete shifttype %s?"), $shifttype['name']), true),
+        info(sprintf(_("Do you want to delete shifttype %s?"), $shifttype['name']), true),
-      buttons([
+        buttons([
-          button(page_link_to('shifttypes'), _("cancel"), 'cancel'),
+            button(page_link_to('shifttypes'), _("cancel"), 'cancel'),
-          button(page_link_to('shifttypes') . '&action=delete&shifttype_id=' . $shifttype['id'] . '&confirmed', _("delete"), 'ok')
+            button(
-      ])
+                page_link_to('shifttypes') . '&action=delete&shifttype_id=' . $shifttype['id'] . '&confirmed',
-  ]);
+                _("delete"),
+                'ok'
+            )
+        ])
+    ]);
 }
 
 function ShiftType_edit_view($name, $angeltype_id, $angeltypes, $description, $shifttype_id)
 {
     $angeltypes_select = [
-      '' => _('All')
+        '' => _('All')
-  ];
+    ];
     foreach ($angeltypes as $angeltype) {
         $angeltypes_select[$angeltype['id']] = $angeltype['name'];
     }
 
     return page_with_title($shifttype_id ? _('Edit shifttype') : _('Create shifttype'), [
-      msg(),
+        msg(),
-      buttons([
+        buttons([
-          button(page_link_to('shifttypes'), shifttypes_title(), 'back')
+            button(page_link_to('shifttypes'), shifttypes_title(), 'back')
-      ]),
+        ]),
-      form([
+        form([
-          form_text('name', _('Name'), $name),
+            form_text('name', _('Name'), $name),
-          form_select('angeltype_id', _('Angeltype'), $angeltypes_select, $angeltype_id),
+            form_select('angeltype_id', _('Angeltype'), $angeltypes_select, $angeltype_id),
-          form_textarea('description', _('Description'), $description),
+            form_textarea('description', _('Description'), $description),
-          form_info('', _('Please use markdown for the description.')),
+            form_info('', _('Please use markdown for the description.')),
-          form_submit('submit', _('Save'))
+            form_submit('submit', _('Save'))
-      ])
+        ])
-  ]);
+    ]);
 }
 
 function ShiftType_view($shifttype, $angeltype)
@@ -52,16 +56,23 @@ function ShiftType_view($shifttype, $angeltype)
         $title .= ' <small>' . sprintf(_('for team %s'), $angeltype['name']) . '</small>';
     }
     return page_with_title($title, [
-      msg(),
+        msg(),
-      buttons([
+        buttons([
-          button(page_link_to('shifttypes'), shifttypes_title(), 'back'),
+            button(page_link_to('shifttypes'), shifttypes_title(), 'back'),
-          $angeltype ? button(page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id'], $angeltype['name']) : '',
+            $angeltype ? button(
-          button(page_link_to('shifttypes') . '&action=edit&shifttype_id=' . $shifttype['id'], _('edit'), 'edit'),
+                page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id'],
-          button(page_link_to('shifttypes') . '&action=delete&shifttype_id=' . $shifttype['id'], _('delete'), 'delete')
+                $angeltype['name']
-      ]),
+            ) : '',
-      heading(_("Description"), 2),
+            button(page_link_to('shifttypes') . '&action=edit&shifttype_id=' . $shifttype['id'], _('edit'), 'edit'),
-      $parsedown->parse($shifttype['description'])
+            button(
-  ]);
+                page_link_to('shifttypes') . '&action=delete&shifttype_id=' . $shifttype['id'],
+                _('delete'),
+                'delete'
+            )
+        ]),
+        heading(_("Description"), 2),
+        $parsedown->parse($shifttype['description'])
+    ]);
 }
 
 function ShiftTypes_list_view($shifttypes)
@@ -69,19 +80,23 @@ function ShiftTypes_list_view($shifttypes)
     foreach ($shifttypes as &$shifttype) {
         $shifttype['name'] = '<a href="' . page_link_to('shifttypes') . '&action=view&shifttype_id=' . $shifttype['id'] . '">' . $shifttype['name'] . '</a>';
         $shifttype['actions'] = table_buttons([
-        button(page_link_to('shifttypes') . '&action=edit&shifttype_id=' . $shifttype['id'], _('edit'), 'btn-xs'),
+            button(page_link_to('shifttypes') . '&action=edit&shifttype_id=' . $shifttype['id'], _('edit'), 'btn-xs'),
-        button(page_link_to('shifttypes') . '&action=delete&shifttype_id=' . $shifttype['id'], _('delete'), 'btn-xs')
+            button(
-    ]);
+                page_link_to('shifttypes') . '&action=delete&shifttype_id=' . $shifttype['id'],
+                _('delete'),
+                'btn-xs'
+            )
+        ]);
     }
 
     return page_with_title(shifttypes_title(), [
-      msg(),
+        msg(),
-      buttons([
+        buttons([
-          button(page_link_to('shifttypes') . '&action=edit', _('New shifttype'), 'add')
+            button(page_link_to('shifttypes') . '&action=edit', _('New shifttype'), 'add')
-      ]),
+        ]),
-      table([
+        table([
-          'name' => _('Name'),
+            'name'    => _('Name'),
-          'actions' => ''
+            'actions' => ''
-      ], $shifttypes)
+        ], $shifttypes)
-  ]);
+    ]);
 }

includes/view/ShiftsFilterRenderer.php

@@ -5,68 +5,68 @@ namespace Engelsystem;
 class ShiftsFilterRenderer
 {
 
-  /**
+    /**
-   * The shiftFilter to render.
+     * The shiftFilter to render.
-   *
+     *
-   * @var ShiftsFilter
+     * @var ShiftsFilter
-   */
+     */
-  private $shiftsFilter;
+    private $shiftsFilter;
 
-  /**
+    /**
-   * Should the filter display a day selection.
+     * Should the filter display a day selection.
-   *
+     *
-   * @var boolean
+     * @var boolean
-   */
+     */
-  private $daySelectionEnabled = false;
+    private $daySelectionEnabled = false;
 
-  /**
+    /**
-   * Days that can be selected.
+     * Days that can be selected.
-   * Format Y-m-d
+     * Format Y-m-d
-   *
+     *
-   * @var string[]
+     * @var string[]
-   */
+     */
-  private $days = [];
+    private $days = [];
 
     public function __construct(ShiftsFilter $shiftsFilter)
     {
         $this->shiftsFilter = $shiftsFilter;
     }
 
-  /**
+    /**
-   * Renders the filter.
+     * Renders the filter.
-   *
+     *
-   * @return Generated HTML
+     * @return Generated HTML
-   */
+     */
-  public function render($link_base)
+    public function render($link_base)
-  {
+    {
-      $toolbar = [];
+        $toolbar = [];
-      if ($this->daySelectionEnabled && ! empty($this->days)) {
+        if ($this->daySelectionEnabled && !empty($this->days)) {
-          $selected_day = date("Y-m-d", $this->shiftsFilter->getStartTime());
+            $selected_day = date("Y-m-d", $this->shiftsFilter->getStartTime());
-          $day_dropdown_items = [];
+            $day_dropdown_items = [];
-          foreach ($this->days as $day) {
+            foreach ($this->days as $day) {
-              $day_dropdown_items[] = toolbar_item_link($link_base . '&shifts_filter_day=' . $day, '', $day);
+                $day_dropdown_items[] = toolbar_item_link($link_base . '&shifts_filter_day=' . $day, '', $day);
-          }
+            }
-          $toolbar[] = toolbar_dropdown('', $selected_day, $day_dropdown_items, 'active');
+            $toolbar[] = toolbar_dropdown('', $selected_day, $day_dropdown_items, 'active');
-      }
+        }
-      return div('form-group', [
+        return div('form-group', [
-        toolbar_pills($toolbar)
+            toolbar_pills($toolbar)
-    ]);
+        ]);
-  }
+    }
 
-  /**
+    /**
-   * Should the filter display a day selection.
+     * Should the filter display a day selection.
-   */
+     */
-  public function enableDaySelection($days)
+    public function enableDaySelection($days)
-  {
+    {
-      $this->daySelectionEnabled = true;
+        $this->daySelectionEnabled = true;
-      $this->days = $days;
+        $this->days = $days;
-  }
+    }
 
-  /**
+    /**
-   * Should the filter display a day selection.
+     * Should the filter display a day selection.
-   */
+     */
-  public function isDaySelectionEnabled()
+    public function isDaySelectionEnabled()
-  {
+    {
-      return $this->daySelectionEnabled;
+        return $this->daySelectionEnabled;
-  }
+    }
 }

includes/view/Shifts_view.php

@@ -5,10 +5,18 @@ function Shift_editor_info_render($shift)
 {
     $info = [];
     if ($shift['created_by_user_id'] != null) {
-        $info[] = sprintf(glyph('plus') . _("created at %s by %s"), date('Y-m-d H:i', $shift['created_at_timestamp']), User_Nick_render(User($shift['created_by_user_id'])));
+        $info[] = sprintf(
+            glyph('plus') . _("created at %s by %s"),
+            date('Y-m-d H:i', $shift['created_at_timestamp']),
+            User_Nick_render(User($shift['created_by_user_id']))
+        );
     }
     if ($shift['edited_by_user_id'] != null) {
-        $info[] = sprintf(glyph('pencil') . _("edited at %s by %s"), date('Y-m-d H:i', $shift['edited_at_timestamp']), User_Nick_render(User($shift['edited_by_user_id'])));
+        $info[] = sprintf(
+            glyph('pencil') . _("edited at %s by %s"),
+            date('Y-m-d H:i', $shift['edited_at_timestamp']),
+            User_Nick_render(User($shift['edited_by_user_id']))
+        );
     }
     return join('<br />', $info);
 }
@@ -22,9 +30,16 @@ function Shift_signup_button_render($shift, $angeltype, $user_angeltype = null)
     }
 
     if ($angeltype['shift_signup_state']->isSignupAllowed()) {
-        return button(page_link_to('user_shifts') . '&shift_id=' . $shift['SID'] . '&type_id=' . $angeltype['id'], _('Sign up'));
+        return button(
+            page_link_to('user_shifts') . '&shift_id=' . $shift['SID'] . '&type_id=' . $angeltype['id'],
+            _('Sign up')
+        );
     } elseif ($user_angeltype == null) {
-        return button(page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id'], sprintf(_('Become %s'), $angeltype['name']));
+        return button(
+            page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id'],
+            sprintf(_('Become %s'),
+                $angeltype['name'])
+        );
     }
     return '';
 }
@@ -50,54 +65,61 @@ function Shift_view($shift, $shifttype, $room, $angeltypes_source, ShiftSignupSt
         $needed_angels .= Shift_view_render_needed_angeltype($needed_angeltype, $angeltypes, $shift, $user_shift_admin);
     }
 
-    return page_with_title($shift['name'] . ' <small class="moment-countdown" data-timestamp="' . $shift['start'] . '">%c</small>', [
+    return page_with_title(
-      msg(),
+        $shift['name'] . ' <small class="moment-countdown" data-timestamp="' . $shift['start'] . '">%c</small>',
-      $shift_signup_state->getState() == ShiftSignupState::COLLIDES ? info(_('This shift collides with one of your shifts.'), true) : '',
+        [
-      $shift_signup_state->getState() == ShiftSignupState::SIGNED_UP ? info(_('You are signed up for this shift.'), true) : '',
+            msg(),
-      ($shift_admin || $admin_shifttypes || $admin_rooms) ? buttons([
+            $shift_signup_state->getState() == ShiftSignupState::COLLIDES
-          $shift_admin ? button(shift_edit_link($shift), glyph('pencil') . _('edit')) : '',
+                ? info(_('This shift collides with one of your shifts.'), true)
-          $shift_admin ? button(shift_delete_link($shift), glyph('trash') . _('delete')) : '',
+                : '',
-          $admin_shifttypes ? button(shifttype_link($shifttype), $shifttype['name']) : '',
+            $shift_signup_state->getState() == ShiftSignupState::SIGNED_UP
-          $admin_rooms ? button(room_link($room), glyph('map-marker') . $room['Name']) : ''
+                ? info(_('You are signed up for this shift.'), true)
-      ]) : '',
+                : '',
-      div('row', [
+            ($shift_admin || $admin_shifttypes || $admin_rooms) ? buttons([
-          div('col-sm-3 col-xs-6', [
+                $shift_admin ? button(shift_edit_link($shift), glyph('pencil') . _('edit')) : '',
-              '<h4>' . _('Title') . '</h4>',
+                $shift_admin ? button(shift_delete_link($shift), glyph('trash') . _('delete')) : '',
-              '<p class="lead">' . ($shift['URL'] != '' ? '<a href="' . $shift['URL'] . '">' . $shift['title'] . '</a>' : $shift['title']) . '</p>'
+                $admin_shifttypes ? button(shifttype_link($shifttype), $shifttype['name']) : '',
-          ]),
+                $admin_rooms ? button(room_link($room), glyph('map-marker') . $room['Name']) : ''
-          div('col-sm-3 col-xs-6', [
+            ]) : '',
-              '<h4>' . _('Start') . '</h4>',
+            div('row', [
-              '<p class="lead' . (time() >= $shift['start'] ? ' text-success' : '') . '">',
+                div('col-sm-3 col-xs-6', [
-              glyph('calendar') . date(_('Y-m-d'), $shift['start']),
+                    '<h4>' . _('Title') . '</h4>',
-              '<br />',
+                    '<p class="lead">' . ($shift['URL'] != '' ? '<a href="' . $shift['URL'] . '">' . $shift['title'] . '</a>' : $shift['title']) . '</p>'
-              glyph('time') . date('H:i', $shift['start']),
+                ]),
-              '</p>'
+                div('col-sm-3 col-xs-6', [
-          ]),
+                    '<h4>' . _('Start') . '</h4>',
-          div('col-sm-3 col-xs-6', [
+                    '<p class="lead' . (time() >= $shift['start'] ? ' text-success' : '') . '">',
-              '<h4>' . _('End') . '</h4>',
+                    glyph('calendar') . date(_('Y-m-d'), $shift['start']),
-              '<p class="lead' . (time() >= $shift['end'] ? ' text-success' : '') . '">',
+                    '<br />',
-              glyph('calendar') . date(_('Y-m-d'), $shift['end']),
+                    glyph('time') . date('H:i', $shift['start']),
-              '<br />',
+                    '</p>'
-              glyph('time') . date('H:i', $shift['end']),
+                ]),
-              '</p>'
+                div('col-sm-3 col-xs-6', [
-          ]),
+                    '<h4>' . _('End') . '</h4>',
-          div('col-sm-3 col-xs-6', [
+                    '<p class="lead' . (time() >= $shift['end'] ? ' text-success' : '') . '">',
-              '<h4>' . _('Location') . '</h4>',
+                    glyph('calendar') . date(_('Y-m-d'), $shift['end']),
-              '<p class="lead">' . Room_name_render($room) . '</p>'
+                    '<br />',
-          ])
+                    glyph('time') . date('H:i', $shift['end']),
-      ]),
+                    '</p>'
-      div('row', [
+                ]),
-          div('col-sm-6', [
+                div('col-sm-3 col-xs-6', [
-              '<h2>' . _('Needed angels') . '</h2>',
+                    '<h4>' . _('Location') . '</h4>',
-              '<div class="list-group">' . $needed_angels . '</div>'
+                    '<p class="lead">' . Room_name_render($room) . '</p>'
-          ]),
+                ])
-          div('col-sm-6', [
+            ]),
-              '<h2>' . _('Description') . '</h2>',
+            div('row', [
-              $parsedown->parse($shifttype['description'])
+                div('col-sm-6', [
-          ])
+                    '<h2>' . _('Needed angels') . '</h2>',
-      ]),
+                    '<div class="list-group">' . $needed_angels . '</div>'
-      $shift_admin ? Shift_editor_info_render($shift) : ''
+                ]),
-  ]);
+                div('col-sm-6', [
+                    '<h2>' . _('Description') . '</h2>',
+                    $parsedown->parse($shifttype['description'])
+                ])
+            ]),
+            $shift_admin ? Shift_editor_info_render($shift) : ''
+        ]
+    );
 }
 
 function Shift_view_render_needed_angeltype($needed_angeltype, $angeltypes, $shift, $user_shift_admin)
@@ -123,7 +145,13 @@ function Shift_view_render_needed_angeltype($needed_angeltype, $angeltypes, $shi
     $needed_angels .= '<h3>' . AngelType_name_render($angeltype) . '</h3>';
     $bar_max = max($needed_angeltype['count'] * 10, $needed_angeltype['taken'] * 10, 10);
     $bar_value = max(1, $needed_angeltype['taken'] * 10);
-    $needed_angels .= progress_bar(0, $bar_max, $bar_value, $class, $needed_angeltype['taken'] . ' / ' . $needed_angeltype['count']);
+    $needed_angels .= progress_bar(
+        0,
+        $bar_max,
+        $bar_value,
+        $class,
+        $needed_angeltype['taken'] . ' / ' . $needed_angeltype['count']
+    );
 
     $angels = [];
     foreach ($shift['ShiftEntry'] as $shift_entry) {
@@ -147,7 +175,11 @@ function Shift_view_render_shift_entry($shift_entry, $user_shift_admin, $angelty
     if ($user_shift_admin || $angeltype_supporter) {
         $entry .= ' <div class="btn-group">';
         if ($user_shift_admin) {
-            $entry .= button_glyph(page_link_to('user_myshifts') . '&edit=' . $shift_entry['id'] . '&id=' . $shift_entry['UID'], 'pencil', 'btn-xs');
+            $entry .= button_glyph(
+                page_link_to('user_myshifts') . '&edit=' . $shift_entry['id'] . '&id=' . $shift_entry['UID'],
+                'pencil',
+                'btn-xs'
+            );
         }
         $entry .= button_glyph(page_link_to('user_shifts') . '&entry_id=' . $shift_entry['id'], 'trash', 'btn-xs');
         $entry .= '</div>';

includes/view/UserAngelTypes_view.php

@@ -3,61 +3,90 @@
 function UserAngelType_update_view($user_angeltype, $user, $angeltype, $supporter)
 {
     return page_with_title($supporter ? _("Add supporter rights") : _("Remove supporter rights"), [
-      msg(),
+        msg(),
-      info(sprintf($supporter ? _("Do you really want to add supporter rights for %s to %s?") : _("Do you really want to remove supporter rights for %s from %s?"), $angeltype['name'], User_Nick_render($user)), true),
+        info(sprintf(
-      buttons([
+            $supporter
-          button(page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id'], _("cancel"), 'cancel'),
+                ? _("Do you really want to add supporter rights for %s to %s?")
-          button(page_link_to('user_angeltypes') . '&action=update&user_angeltype_id=' . $user_angeltype['id'] . '&supporter=' . ($supporter ? '1' : '0') . '&confirmed', _("yes"), 'ok')
+                : _("Do you really want to remove supporter rights for %s from %s?"),
-      ])
+            $angeltype['name'],
-  ]);
+            User_Nick_render($user)
+        ), true),
+        buttons([
+            button(page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id'], _("cancel"), 'cancel'),
+            button(
+                page_link_to('user_angeltypes')
+                . '&action=update&user_angeltype_id=' . $user_angeltype['id']
+                . '&supporter=' . ($supporter ? '1' : '0')
+                . '&confirmed',
+                _("yes"),
+                'ok'
+            )
+        ])
+    ]);
 }
 
 function UserAngelTypes_delete_all_view($angeltype)
 {
     return page_with_title(_("Deny all users"), [
-      msg(),
+        msg(),
-      info(sprintf(_("Do you really want to deny all users for %s?"), $angeltype['name']), true),
+        info(sprintf(_("Do you really want to deny all users for %s?"), $angeltype['name']), true),
-      buttons([
+        buttons([
-          button(page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id'], _("cancel"), 'cancel'),
+            button(page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id'], _("cancel"), 'cancel'),
-          button(page_link_to('user_angeltypes') . '&action=delete_all&angeltype_id=' . $angeltype['id'] . '&confirmed', _("yes"), 'ok')
+            button(
-      ])
+                page_link_to('user_angeltypes') . '&action=delete_all&angeltype_id=' . $angeltype['id'] . '&confirmed',
-  ]);
+                _("yes"),
+                'ok'
+            )
+        ])
+    ]);
 }
 
 function UserAngelTypes_confirm_all_view($angeltype)
 {
     return page_with_title(_("Confirm all users"), [
-      msg(),
+        msg(),
-      info(sprintf(_("Do you really want to confirm all users for %s?"), $angeltype['name']), true),
+        info(sprintf(_("Do you really want to confirm all users for %s?"), $angeltype['name']), true),
-      buttons([
+        buttons([
-          button(page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id'], _("cancel"), 'cancel'),
+            button(page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id'], _("cancel"), 'cancel'),
-          button(page_link_to('user_angeltypes') . '&action=confirm_all&angeltype_id=' . $angeltype['id'] . '&confirmed', _("yes"), 'ok')
+            button(
-      ])
+                page_link_to('user_angeltypes') . '&action=confirm_all&angeltype_id=' . $angeltype['id'] . '&confirmed',
-  ]);
+                _("yes"),
+                'ok'
+            )
+        ])
+    ]);
 }
 
 function UserAngelType_confirm_view($user_angeltype, $user, $angeltype)
 {
     return page_with_title(_("Confirm angeltype for user"), [
-      msg(),
+        msg(),
-      info(sprintf(_("Do you really want to confirm %s for %s?"), User_Nick_render($user), $angeltype['name']), true),
+        info(sprintf(_("Do you really want to confirm %s for %s?"), User_Nick_render($user), $angeltype['name']), true),
-      buttons([
+        buttons([
-          button(page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id'], _("cancel"), 'cancel'),
+            button(page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id'], _("cancel"), 'cancel'),
-          button(page_link_to('user_angeltypes') . '&action=confirm&user_angeltype_id=' . $user_angeltype['id'] . '&confirmed', _("yes"), 'ok')
+            button(
-      ])
+                page_link_to('user_angeltypes') . '&action=confirm&user_angeltype_id=' . $user_angeltype['id'] . '&confirmed',
-  ]);
+                _("yes"),
+                'ok'
+            )
+        ])
+    ]);
 }
 
 function UserAngelType_delete_view($user_angeltype, $user, $angeltype)
 {
     return page_with_title(_("Remove angeltype"), [
-      msg(),
+        msg(),
-      info(sprintf(_("Do you really want to delete %s from %s?"), User_Nick_render($user), $angeltype['name']), true),
+        info(sprintf(_("Do you really want to delete %s from %s?"), User_Nick_render($user), $angeltype['name']), true),
-      buttons([
+        buttons([
-          button(page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id'], _("cancel"), 'cancel'),
+            button(page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id'], _("cancel"), 'cancel'),
-          button(page_link_to('user_angeltypes') . '&action=delete&user_angeltype_id=' . $user_angeltype['id'] . '&confirmed', _("yes"), 'ok')
+            button(
-      ])
+                page_link_to('user_angeltypes') . '&action=delete&user_angeltype_id=' . $user_angeltype['id'] . '&confirmed',
-  ]);
+                _("yes"),
+                'ok'
+            )
+        ])
+    ]);
 }
 
 function UserAngelType_add_view($angeltype, $users_source, $user_id)
@@ -68,26 +97,30 @@ function UserAngelType_add_view($angeltype, $users_source, $user_id)
     }
 
     return page_with_title(_("Add user to angeltype"), [
-      msg(),
+        msg(),
-      buttons([
+        buttons([
-          button(page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id'], _("back"), 'back')
+            button(page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id'], _("back"), 'back')
-      ]),
+        ]),
-      form([
+        form([
-          form_info(_("Angeltype"), $angeltype['name']),
+            form_info(_("Angeltype"), $angeltype['name']),
-          form_select('user_id', _("User"), $users, $user_id),
+            form_select('user_id', _("User"), $users, $user_id),
-          form_submit('submit', _("Add"))
+            form_submit('submit', _("Add"))
-      ])
+        ])
-  ]);
+    ]);
 }
 
 function UserAngelType_join_view($user, $angeltype)
 {
     return page_with_title(sprintf(_("Become a %s"), $angeltype['name']), [
-      msg(),
+        msg(),
-      info(sprintf(_("Do you really want to add %s to %s?"), User_Nick_render($user), $angeltype['name']), true),
+        info(sprintf(_("Do you really want to add %s to %s?"), User_Nick_render($user), $angeltype['name']), true),
-      buttons([
+        buttons([
-          button(page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id'], _("cancel"), 'cancel'),
+            button(page_link_to('angeltypes') . '&action=view&angeltype_id=' . $angeltype['id'], _("cancel"), 'cancel'),
-          button(page_link_to('user_angeltypes') . '&action=add&angeltype_id=' . $angeltype['id'] . '&user_id=' . $user['UID'] . '&confirmed', _("save"), 'ok')
+            button(
-      ])
+                page_link_to('user_angeltypes') . '&action=add&angeltype_id=' . $angeltype['id'] . '&user_id=' . $user['UID'] . '&confirmed',
-  ]);
+                _("save"),
+                'ok'
+            )
+        ])
+    ]);
 }

includes/view/UserDriverLicenses_view.php

@@ -3,9 +3,9 @@
 /**
  * Edit a user's driving license information.
  *
- * @param User $user_source
+ * @param User              $user_source
  *          The user
- * @param bool $wants_to_drive
+ * @param bool              $wants_to_drive
  *          true, if the user wants to drive
  * @param UserDriverLicense $user_driver_license
  *          The user driver license
@@ -14,27 +14,43 @@
 function UserDriverLicense_edit_view($user_source, $wants_to_drive, $user_driver_license)
 {
     return page_with_title(sprintf(_("Edit %s driving license information"), User_Nick_render($user_source)), [
-      buttons([
+        buttons([
-          button(user_link($user_source), _("Back to profile"), 'back')
+            button(user_link($user_source), _("Back to profile"), 'back')
-      ]),
+        ]),
-      msg(),
+        msg(),
-      form([
+        form([
-          form_info(_("Privacy"), _("Your driving license information is only visible for supporters and admins.")),
+            form_info(_("Privacy"), _("Your driving license information is only visible for supporters and admins.")),
-          form_checkbox('wants_to_drive', _("I am willing to operate cars for the PL"), $wants_to_drive),
+            form_checkbox('wants_to_drive', _("I am willing to operate cars for the PL"), $wants_to_drive),
-          div('panel panel-default', [
+            div('panel panel-default', [
-              div('panel-body', [
+                div('panel-body', [
-                  form_checkbox('has_car', _("I have my own car with me and am willing to use it for the PL (You'll get reimbursed for fuel)"), $user_driver_license['has_car']),
+                    form_checkbox(
-                  heading(_("Driver license"), 3),
+                        'has_car',
-                  form_checkbox('has_license_car', _("Car"), $user_driver_license['has_license_car']),
+                        _("I have my own car with me and am willing to use it for the PL (You'll get reimbursed for fuel)"),
-                  form_checkbox('has_license_3_5t_transporter', _("Transporter 3,5t"), $user_driver_license['has_license_3_5t_transporter']),
+                        $user_driver_license['has_car']
-                  form_checkbox('has_license_7_5t_truck', _("Truck 7,5t"), $user_driver_license['has_license_7_5t_truck']),
+                    ),
-                  form_checkbox('has_license_12_5t_truck', _("Truck 12,5t"), $user_driver_license['has_license_12_5t_truck']),
+                    heading(_("Driver license"), 3),
-                  form_checkbox('has_license_forklift', _("Forklift"), $user_driver_license['has_license_forklift'])
+                    form_checkbox('has_license_car', _("Car"), $user_driver_license['has_license_car']),
-              ])
+                    form_checkbox(
-          ], 'driving_license'),
+                        'has_license_3_5t_transporter',
-          form_submit('submit', _("Save"))
+                        _("Transporter 3,5t"),
-      ]),
+                        $user_driver_license['has_license_3_5t_transporter']
-      '<script type="text/javascript">
+                    ),
+                    form_checkbox(
+                        'has_license_7_5t_truck',
+                        _("Truck 7,5t"),
+                        $user_driver_license['has_license_7_5t_truck']
+                    ),
+                    form_checkbox(
+                        'has_license_12_5t_truck',
+                        _("Truck 12,5t"),
+                        $user_driver_license['has_license_12_5t_truck']
+                    ),
+                    form_checkbox('has_license_forklift', _("Forklift"), $user_driver_license['has_license_forklift'])
+                ])
+            ], 'driving_license'),
+            form_submit('submit', _("Save"))
+        ]),
+        '<script type="text/javascript">
         $(function() {
           if($("#wants_to_drive").is(":checked"))
             $("#driving_license").show();
@@ -51,5 +67,5 @@ function UserDriverLicense_edit_view($user_source, $wants_to_drive, $user_driver
           );
         });
       </script>'
-  ]);
+    ]);
 }

includes/view/UserHintsRenderer.php

@@ -8,54 +8,54 @@ class UserHintsRenderer
 
     private $important = false;
 
-  /**
+    /**
-   * Render the added hints to a popover for the toolbar.
+     * Render the added hints to a popover for the toolbar.
-   */
+     */
-  public function render()
+    public function render()
-  {
+    {
-      if (count($this->hints) > 0) {
+        if (count($this->hints) > 0) {
-          $hint_class = $this->important ? 'danger' : 'info';
+            $hint_class = $this->important ? 'danger' : 'info';
-          $glyphicon = $this->important ? 'warning-sign' : 'info-sign';
+            $glyphicon = $this->important ? 'warning-sign' : 'info-sign';
-      
+
-          return toolbar_popover($glyphicon . ' text-' . $hint_class, '', $this->hints, 'bg-' . $hint_class);
+            return toolbar_popover($glyphicon . ' text-' . $hint_class, '', $this->hints, 'bg-' . $hint_class);
-      }
+        }
-    
+
-      return '';
+        return '';
-  }
+    }
-
+
-  /**
+    /**
-   * Add a hint to the list, if its not null and a not empty string.
+     * Add a hint to the list, if its not null and a not empty string.
-   *
+     *
-   * @param string $hint
+     * @param string  $hint
-   *          The hint
+     *          The hint
-   * @param boolean $important
+     * @param boolean $important
-   *          Is the hint important?
+     *          Is the hint important?
-   */
+     */
-  public function addHint($hint, $important = false)
+    public function addHint($hint, $important = false)
-  {
+    {
-      if ($hint != null && $hint != '') {
+        if ($hint != null && $hint != '') {
-          if ($important) {
+            if ($important) {
-              $this->important = true;
+                $this->important = true;
-              $this->hints[] = error($hint, true);
+                $this->hints[] = error($hint, true);
-          } else {
+            } else {
-              $this->hints[] = info($hint, true);
+                $this->hints[] = info($hint, true);
-          }
+            }
-      }
+        }
-  }
+    }
-
+
-  /**
+    /**
-   * Get all hints.
+     * Get all hints.
-   */
+     */
-  public function getHints()
+    public function getHints()
-  {
+    {
-      return $this->hints;
+        return $this->hints;
-  }
+    }
-
+
-  /**
+    /**
-   * Are there important hints? This leads to a more intensive icon.
+     * Are there important hints? This leads to a more intensive icon.
-   */
+     */
-  public function isImportant()
+    public function isImportant()
-  {
+    {
-      return $this->important;
+        return $this->important;
-  }
+    }
 }

includes/view/User_view.php

@@ -4,18 +4,18 @@
  * Available T-Shirt sizes
  */
 $tshirt_sizes = [
-    '' => _("Please select..."),
+    ''     => _("Please select..."),
-    'S' => "S",
+    'S'    => "S",
-    'M' => "M",
+    'M'    => "M",
-    'L' => "L",
+    'L'    => "L",
-    'XL' => "XL",
+    'XL'   => "XL",
-    '2XL' => "2XL",
+    '2XL'  => "2XL",
-    '3XL' => "3XL",
+    '3XL'  => "3XL",
-    '4XL' => "4XL",
+    '4XL'  => "4XL",
-    '5XL' => "5XL",
+    '5XL'  => "5XL",
-    'S-G' => "S Girl",
+    'S-G'  => "S Girl",
-    'M-G' => "M Girl",
+    'M-G'  => "M Girl",
-    'L-G' => "L Girl",
+    'L-G'  => "L Girl",
     'XL-G' => "XL Girl"
 ];
 
@@ -23,61 +23,92 @@ $tshirt_sizes = [
  * Renders user settings page
  *
  * @param User $user_source
- *          The user
+ *                   The user
- * @param array<String> $locales
+ * @param      array <String> $locales
- *          Available languages
+ *                   Available languages
- * @param array<String> $themes
+ * @param      array <String> $themes
- *          Available themes
+ *                   Available themes
  */
-function User_settings_view($user_source, $locales, $themes, $buildup_start_date, $teardown_end_date, $enable_tshirt_size, $tshirt_sizes)
+function User_settings_view(
-{
+    $user_source,
+    $locales,
+    $themes,
+    $buildup_start_date,
+    $teardown_end_date,
+    $enable_tshirt_size,
+    $tshirt_sizes
+) {
     return page_with_title(settings_title(), [
-      msg(),
+        msg(),
-      div('row', [
+        div('row', [
-          div('col-md-6', [
+            div('col-md-6', [
-              form([
+                form([
-                  form_info('', _("Here you can change your user details.")),
+                    form_info('', _("Here you can change your user details.")),
-                  form_info(entry_required() . ' = ' . _("Entry required!")),
+                    form_info(entry_required() . ' = ' . _("Entry required!")),
-                  form_text('nick', _("Nick"), $user_source['Nick'], true),
+                    form_text('nick', _("Nick"), $user_source['Nick'], true),
-                  form_text('lastname', _("Last name"), $user_source['Name']),
+                    form_text('lastname', _("Last name"), $user_source['Name']),
-                  form_text('prename', _("First name"), $user_source['Vorname']),
+                    form_text('prename', _("First name"), $user_source['Vorname']),
-                  form_date('planned_arrival_date', _("Planned date of arrival") . ' ' . entry_required(), $user_source['planned_arrival_date'], $buildup_start_date, $teardown_end_date),
+                    form_date(
-                  form_date('planned_departure_date', _("Planned date of departure"), $user_source['planned_departure_date'], $buildup_start_date, $teardown_end_date),
+                        'planned_arrival_date',
-                  form_text('age', _("Age"), $user_source['Alter']),
+                        _("Planned date of arrival") . ' ' . entry_required(),
-                  form_text('tel', _("Phone"), $user_source['Telefon']),
+                        $user_source['planned_arrival_date'],
-                  form_text('dect', _("DECT"), $user_source['DECT']),
+                        $buildup_start_date, $teardown_end_date
-                  form_text('mobile', _("Mobile"), $user_source['Handy']),
+                    ),
-                  form_text('mail', _("E-Mail") . ' ' . entry_required(), $user_source['email']),
+                    form_date(
-                  form_checkbox('email_shiftinfo', _("The engelsystem is allowed to send me an email (e.g. when my shifts change)"), $user_source['email_shiftinfo']),
+                        'planned_departure_date',
-                  form_checkbox('email_by_human_allowed', _("Humans are allowed to send me an email (e.g. for ticket vouchers)"), $user_source['email_by_human_allowed']),
+                        _("Planned date of departure"),
-                  form_text('jabber', _("Jabber"), $user_source['jabber']),
+                        $user_source['planned_departure_date'],
-                  form_text('hometown', _("Hometown"), $user_source['Hometown']),
+                        $buildup_start_date,
-                  $enable_tshirt_size ? form_select('tshirt_size', _("Shirt size"), $tshirt_sizes, $user_source['Size']) : '',
+                        $teardown_end_date
-                  form_info('', _('Please visit the angeltypes page to manage your angeltypes.')),
+                    ),
-                  form_submit('submit', _("Save"))
+                    form_text('age', _("Age"), $user_source['Alter']),
-              ])
+                    form_text('tel', _("Phone"), $user_source['Telefon']),
-          ]),
+                    form_text('dect', _("DECT"), $user_source['DECT']),
-          div('col-md-6', [
+                    form_text('mobile', _("Mobile"), $user_source['Handy']),
-              form([
+                    form_text('mail', _("E-Mail") . ' ' . entry_required(), $user_source['email']),
-                  form_info(_("Here you can change your password.")),
+                    form_checkbox(
-                  form_password('password', _("Old password:")),
+                        'email_shiftinfo',
-                  form_password('new_password', _("New password:")),
+                        _("The engelsystem is allowed to send me an email (e.g. when my shifts change)"),
-                  form_password('new_password2', _("Password confirmation:")),
+                        $user_source['email_shiftinfo']
-                  form_submit('submit_password', _("Save"))
+                    ),
-              ]),
+                    form_checkbox(
-              form([
+                        'email_by_human_allowed',
-                  form_info(_("Here you can choose your color settings:")),
+                        _("Humans are allowed to send me an email (e.g. for ticket vouchers)"),
-                  form_select('theme', _("Color settings:"), $themes, $user_source['color']),
+                        $user_source['email_by_human_allowed']
-                  form_submit('submit_theme', _("Save"))
+                    ),
-              ]),
+                    form_text('jabber', _("Jabber"), $user_source['jabber']),
-              form([
+                    form_text('hometown', _("Hometown"), $user_source['Hometown']),
-                  form_info(_("Here you can choose your language:")),
+                    $enable_tshirt_size ? form_select(
-                  form_select('language', _("Language:"), $locales, $user_source['Sprache']),
+                        'tshirt_size',
-                  form_submit('submit_language', _("Save"))
+                        _("Shirt size"),
-              ])
+                        $tshirt_sizes,
-          ])
+                        $user_source['Size']
-      ])
+                    ) : '',
-  ]);
+                    form_info('', _('Please visit the angeltypes page to manage your angeltypes.')),
+                    form_submit('submit', _("Save"))
+                ])
+            ]),
+            div('col-md-6', [
+                form([
+                    form_info(_("Here you can change your password.")),
+                    form_password('password', _("Old password:")),
+                    form_password('new_password', _("New password:")),
+                    form_password('new_password2', _("Password confirmation:")),
+                    form_submit('submit_password', _("Save"))
+                ]),
+                form([
+                    form_info(_("Here you can choose your color settings:")),
+                    form_select('theme', _("Color settings:"), $themes, $user_source['color']),
+                    form_submit('submit_theme', _("Save"))
+                ]),
+                form([
+                    form_info(_("Here you can choose your language:")),
+                    form_select('language', _("Language:"), $locales, $user_source['Sprache']),
+                    form_submit('submit_language', _("Save"))
+                ])
+            ])
+        ])
+    ]);
 }
 
 /**
@@ -88,32 +119,32 @@ function User_registration_success_view($event_welcome_message)
     $parsedown = new Parsedown();
     $event_welcome_message = $parsedown->text($event_welcome_message);
     return page_with_title(_("Registration successful"), [
-      msg(),
+        msg(),
-      div('row', [
+        div('row', [
-          div('col-md-4', [
+            div('col-md-4', [
-              $event_welcome_message
+                $event_welcome_message
-          ]),
+            ]),
-          div('col-md-4', [
+            div('col-md-4', [
-              '<h2>' . _("Login") . '</h2>',
+                '<h2>' . _("Login") . '</h2>',
-              form([
+                form([
-                  form_text('nick', _("Nick"), ""),
+                    form_text('nick', _("Nick"), ""),
-                  form_password('password', _("Password")),
+                    form_password('password', _("Password")),
-                  form_submit('submit', _("Login")),
+                    form_submit('submit', _("Login")),
-                  buttons([
+                    buttons([
-                      button(page_link_to('user_password_recovery'), _("I forgot my password"))
+                        button(page_link_to('user_password_recovery'), _("I forgot my password"))
-                  ]),
+                    ]),
-                  info(_("Please note: You have to activate cookies!"), true)
+                    info(_("Please note: You have to activate cookies!"), true)
-              ], page_link_to('login'))
+                ], page_link_to('login'))
-          ]),
+            ]),
-          div('col-md-4', [
+            div('col-md-4', [
-              '<h2>' . _("What can I do?") . '</h2>',
+                '<h2>' . _("What can I do?") . '</h2>',
-              '<p>' . _("Please read about the jobs you can do to help us.") . '</p>',
+                '<p>' . _("Please read about the jobs you can do to help us.") . '</p>',
-              buttons([
+                buttons([
-                  button(page_link_to('angeltypes') . '&action=about', _("Teams/Job description") . ' &raquo;')
+                    button(page_link_to('angeltypes') . '&action=about', _("Teams/Job description") . ' &raquo;')
-              ])
+                ])
-          ])
+            ])
-      ])
+        ])
-  ]);
+    ]);
 }
 
 /**
@@ -122,16 +153,19 @@ function User_registration_success_view($event_welcome_message)
 function User_delete_view($user)
 {
     return page_with_title(sprintf(_("Delete %s"), User_Nick_render($user)), [
-      msg(),
+        msg(),
-      buttons([
+        buttons([
-          button(user_edit_link($user), glyph('chevron-left') . _("back"))
+            button(user_edit_link($user), glyph('chevron-left') . _("back"))
-      ]),
+        ]),
-      error(_("Do you really want to delete the user including all his shifts and every other piece of his data?"), true),
+        error(
-      form([
+            _("Do you really want to delete the user including all his shifts and every other piece of his data?"),
-          form_password('password', _("Your password")),
+            true
-          form_submit('submit', _("Delete"))
+        ),
-      ])
+        form([
-  ]);
+            form_password('password', _("Your password")),
+            form_submit('submit', _("Delete"))
+        ])
+    ]);
 }
 
 /**
@@ -140,20 +174,28 @@ function User_delete_view($user)
 function User_edit_vouchers_view($user)
 {
     return page_with_title(sprintf(_("%s's vouchers"), User_Nick_render($user)), [
-      msg(),
+        msg(),
-      buttons([
+        buttons([
-          button(user_link($user), glyph('chevron-left') . _("back"))
+            button(user_link($user), glyph('chevron-left') . _("back"))
-      ]),
+        ]),
-      info(sprintf(_("Angel should receive at least  %d vouchers."), User_get_eligable_voucher_count($user)), true),
+        info(sprintf(_("Angel should receive at least  %d vouchers."), User_get_eligable_voucher_count($user)), true),
-      form([
+        form([
-          form_spinner('vouchers', _("Number of vouchers given out"), $user['got_voucher']),
+            form_spinner('vouchers', _("Number of vouchers given out"), $user['got_voucher']),
-          form_submit('submit', _("Save"))
+            form_submit('submit', _("Save"))
-      ], page_link_to('users') . '&action=edit_vouchers&user_id=' . $user['UID'])
+        ], page_link_to('users') . '&action=edit_vouchers&user_id=' . $user['UID'])
-  ]);
+    ]);
 }
 
-function Users_view($users, $order_by, $arrived_count, $active_count, $force_active_count, $freeloads_count, $tshirts_count, $voucher_count)
+function Users_view(
-{
+    $users,
+    $order_by,
+    $arrived_count,
+    $active_count,
+    $force_active_count,
+    $freeloads_count,
+    $tshirts_count,
+    $voucher_count
+) {
     foreach ($users as &$user) {
         $user['Nick'] = User_Nick_render($user);
         $user['Gekommen'] = glyph_bool($user['Gekommen']);
@@ -163,41 +205,41 @@ function Users_view($users, $order_by, $arrived_count, $active_count, $force_act
         $user['Tshirt'] = glyph_bool($user['Tshirt']);
         $user['lastLogIn'] = date(_('m/d/Y h:i a'), $user['lastLogIn']);
         $user['actions'] = table_buttons([
-        button_glyph(page_link_to('admin_user') . '&id=' . $user['UID'], 'edit', 'btn-xs')
+            button_glyph(page_link_to('admin_user') . '&id=' . $user['UID'], 'edit', 'btn-xs')
-    ]);
+        ]);
     }
     $users[] = [
-      'Nick' => '<strong>' . _('Sum') . '</strong>',
+        'Nick'         => '<strong>' . _('Sum') . '</strong>',
-      'Gekommen' => $arrived_count,
+        'Gekommen'     => $arrived_count,
-      'got_voucher' => $voucher_count,
+        'got_voucher'  => $voucher_count,
-      'Aktiv' => $active_count,
+        'Aktiv'        => $active_count,
-      'force_active' => $force_active_count,
+        'force_active' => $force_active_count,
-      'freeloads' => $freeloads_count,
+        'freeloads'    => $freeloads_count,
-      'Tshirt' => $tshirts_count,
+        'Tshirt'       => $tshirts_count,
-      'actions' => '<strong>' . count($users) . '</strong>'
+        'actions'      => '<strong>' . count($users) . '</strong>'
-  ];
+    ];
 
     return page_with_title(_("All users"), [
-      msg(),
+        msg(),
-      buttons([
+        buttons([
-          button(page_link_to('register'), glyph('plus') . _("New user"))
+            button(page_link_to('register'), glyph('plus') . _("New user"))
-      ]),
+        ]),
-      table([
+        table([
-          'Nick' => Users_table_header_link('Nick', _("Nick"), $order_by),
+            'Nick'         => Users_table_header_link('Nick', _("Nick"), $order_by),
-          'Vorname' => Users_table_header_link('Vorname', _("Prename"), $order_by),
+            'Vorname'      => Users_table_header_link('Vorname', _("Prename"), $order_by),
-          'Name' => Users_table_header_link('Name', _("Name"), $order_by),
+            'Name'         => Users_table_header_link('Name', _("Name"), $order_by),
-          'DECT' => Users_table_header_link('DECT', _("DECT"), $order_by),
+            'DECT'         => Users_table_header_link('DECT', _("DECT"), $order_by),
-          'Gekommen' => Users_table_header_link('Gekommen', _("Arrived"), $order_by),
+            'Gekommen'     => Users_table_header_link('Gekommen', _("Arrived"), $order_by),
-          'got_voucher' => Users_table_header_link('got_voucher', _("Voucher"), $order_by),
+            'got_voucher'  => Users_table_header_link('got_voucher', _("Voucher"), $order_by),
-          'freeloads' => _('Freeloads'),
+            'freeloads'    => _('Freeloads'),
-          'Aktiv' => Users_table_header_link('Aktiv', _("Active"), $order_by),
+            'Aktiv'        => Users_table_header_link('Aktiv', _("Active"), $order_by),
-          'force_active' => Users_table_header_link('force_active', _("Forced"), $order_by),
+            'force_active' => Users_table_header_link('force_active', _("Forced"), $order_by),
-          'Tshirt' => Users_table_header_link('Tshirt', _("T-Shirt"), $order_by),
+            'Tshirt'       => Users_table_header_link('Tshirt', _("T-Shirt"), $order_by),
-          'Size' => Users_table_header_link('Size', _("Size"), $order_by),
+            'Size'         => Users_table_header_link('Size', _("Size"), $order_by),
-          'lastLogIn' => Users_table_header_link('lastLogIn', _("Last login"), $order_by),
+            'lastLogIn'    => Users_table_header_link('lastLogIn', _("Last login"), $order_by),
-          'actions' => ''
+            'actions'      => ''
-      ], $users)
+        ], $users)
-  ]);
+    ]);
 }
 
 function Users_table_header_link($column, $label, $order_by)
@@ -264,12 +306,12 @@ function User_view_myshift($shift, $user_source, $its_me)
     }
 
     $myshift = [
-      'date' => date("Y-m-d", $shift['start']),
+        'date'       => date("Y-m-d", $shift['start']),
-      'time' => date("H:i", $shift['start']) . ' - ' . date("H:i", $shift['end']),
+        'time'       => date("H:i", $shift['start']) . ' - ' . date("H:i", $shift['end']),
-      'room' => $shift['Name'],
+        'room'       => $shift['Name'],
-      'shift_info' => $shift_info,
+        'shift_info' => $shift_info,
-      'comment' => $shift['Comment']
+        'comment'    => $shift['Comment']
-  ];
+    ];
 
     if ($shift['freeloaded']) {
         if (in_array("user_shifts_admin", $privileges)) {
@@ -280,13 +322,21 @@ function User_view_myshift($shift, $user_source, $its_me)
     }
 
     $myshift['actions'] = [
-      button(shift_link($shift), glyph('eye-open') . _('view'), 'btn-xs')
+        button(shift_link($shift), glyph('eye-open') . _('view'), 'btn-xs')
-  ];
+    ];
     if ($its_me || in_array('user_shifts_admin', $privileges)) {
-        $myshift['actions'][] = button(page_link_to('user_myshifts') . '&edit=' . $shift['id'] . '&id=' . $user_source['UID'], glyph('edit') . _('edit'), 'btn-xs');
+        $myshift['actions'][] = button(
+            page_link_to('user_myshifts') . '&edit=' . $shift['id'] . '&id=' . $user_source['UID'],
+            glyph('edit') . _('edit'),
+            'btn-xs'
+        );
     }
     if (($shift['start'] > time() + $LETZTES_AUSTRAGEN * 3600) || in_array('user_shifts_admin', $privileges)) {
-        $myshift['actions'][] = button(page_link_to('user_myshifts') . ((! $its_me) ? '&id=' . $user_source['UID'] : '') . '&cancel=' . $shift['id'], glyph('trash') . _('sign off'), 'btn-xs');
+        $myshift['actions'][] = button(
+            page_link_to('user_myshifts') . ((!$its_me) ? '&id=' . $user_source['UID'] : '') . '&cancel=' . $shift['id'],
+            glyph('trash') . _('sign off'),
+            'btn-xs'
+        );
     }
     $myshift['actions'] = table_buttons($myshift['actions']);
 
@@ -304,7 +354,7 @@ function User_view_myshifts($shifts, $user_source, $its_me)
         $myshifts_table[] = User_view_myshift($shift, $user_source, $its_me);
 
         if ($shift['freeloaded']) {
-            $timesum += (- 2 * ($shift['end'] - $shift['start']));
+            $timesum += (-2 * ($shift['end'] - $shift['start']));
         } else {
             $timesum += ($shift['end'] - $shift['start']);
         }
@@ -312,13 +362,13 @@ function User_view_myshifts($shifts, $user_source, $its_me)
 
     if (count($myshifts_table) > 0) {
         $myshifts_table[] = [
-        'date' => '<b>' . _("Sum:") . '</b>',
+            'date'       => '<b>' . _("Sum:") . '</b>',
-        'time' => "<b>" . round($timesum / 3600, 1) . " h</b>",
+            'time'       => "<b>" . round($timesum / 3600, 1) . " h</b>",
-        'room' => "",
+            'room'       => "",
-        'shift_info' => "",
+            'shift_info' => "",
-        'comment' => "",
+            'comment'    => "",
-        'actions' => ""
+            'actions'    => ""
-    ];
+        ];
     }
     return $myshifts_table;
 }
@@ -331,59 +381,115 @@ function User_view($user_source, $admin_user_privilege, $freeloader, $user_angel
     $user_name = htmlspecialchars($user_source['Vorname']) . " " . htmlspecialchars($user_source['Name']);
     $myshifts_table = User_view_myshifts($shifts, $user_source, $its_me);
 
-    return page_with_title('<span class="icon-icon_angel"></span> ' . htmlspecialchars($user_source['Nick']) . ' <small>' . $user_name . '</small>', [
+    return page_with_title(
-      msg(),
+        '<span class="icon-icon_angel"></span> ' . htmlspecialchars($user_source['Nick']) . ' <small>' . $user_name . '</small>',
-      div('row space-top', [
+        [
-          div('col-md-12', [
+            msg(),
-              buttons([
+            div('row space-top', [
-                  $admin_user_privilege ? button(page_link_to('admin_user') . '&id=' . $user_source['UID'], glyph("edit") . _("edit")) : '',
+                div('col-md-12', [
-                  $admin_user_privilege ? button(user_driver_license_edit_link($user_source), glyph("road") . _("driving license")) : '',
+                    buttons([
-                  ($admin_user_privilege && ! $user_source['Gekommen']) ? button(page_link_to('admin_arrive') . '&arrived=' . $user_source['UID'], _("arrived")) : '',
+                        $admin_user_privilege ? button(
-                  $admin_user_privilege ? button(page_link_to('users') . '&action=edit_vouchers&user_id=' . $user_source['UID'], glyph('cutlery') . _('Edit vouchers')) : '',
+                            page_link_to('admin_user') . '&id=' . $user_source['UID'],
-                  $its_me ? button(page_link_to('user_settings'), glyph('list-alt') . _("Settings")) : '',
+                            glyph("edit") . _("edit")
-                  $its_me ? button(page_link_to('ical') . '&key=' . $user_source['api_key'], glyph('calendar') . _("iCal Export")) : '',
+                        ) : '',
-                  $its_me ? button(page_link_to('shifts_json_export') . '&key=' . $user_source['api_key'], glyph('export') . _("JSON Export")) : '',
+                        $admin_user_privilege ? button(
-                  $its_me ? button(page_link_to('user_myshifts') . '&reset', glyph('repeat') . _('Reset API key')) : ''
+                            user_driver_license_edit_link($user_source),
-              ])
+                            glyph("road") . _("driving license")
-          ])
+                        ) : '',
-      ]),
+                        ($admin_user_privilege && !$user_source['Gekommen']) ? button(
-      div('row', [
+                            page_link_to('admin_arrive') . '&arrived=' . $user_source['UID'],
-          div('col-md-3', [
+                            _("arrived")
-              '<h1>',
+                        ) : '',
-              '<span class="glyphicon glyphicon-phone"></span>',
+                        $admin_user_privilege ? button(
-              $user_source['DECT'],
+                            page_link_to('users') . '&action=edit_vouchers&user_id=' . $user_source['UID'],
-              '</h1>'
+                            glyph('cutlery') . _('Edit vouchers')
-          ]),
+                        ) : '',
-          div('col-md-3', [
+                        $its_me ? button(page_link_to('user_settings'), glyph('list-alt') . _("Settings")) : '',
-              '<h4>' . _("User state") . '</h4>',
+                        $its_me ? button(
-              ($admin_user_privilege && $freeloader) ? '<span class="text-danger"><span class="glyphicon glyphicon-exclamation-sign"></span> ' . _("Freeloader") . '</span><br />' : '',
+                            page_link_to('ical') . '&key=' . $user_source['api_key'],
-              $user_source['Gekommen'] ? User_shift_state_render($user_source) . '<br />' : '',
+                            glyph('calendar') . _("iCal Export")
-              $admin_user_privilege || $its_me ? ($user_source['Gekommen'] ? '<span class="text-success"><span class="glyphicon glyphicon-home"></span> ' . sprintf(_("Arrived at %s"), date('Y-m-d', $user_source['arrival_date'])) . '</span>' : '<span class="text-danger">' . sprintf(_("Not arrived (Planned: %s)"), date('Y-m-d', $user_source['planned_arrival_date'])) . '</span>') : ($user_source['Gekommen'] ? '<span class="text-success"><span class="glyphicon glyphicon-home"></span> ' . _("Arrived") . '</span>' : '<span class="text-danger">' . _("Not arrived") . '</span>'),
+                        ) : '',
-              $admin_user_privilege ? ($user_source['got_voucher'] > 0 ? '<br /><span class="text-success">' . glyph('cutlery') . sprintf(ngettext("Got %s voucher", "Got %s vouchers", $user_source['got_voucher']), $user_source['got_voucher']) . '</span><br />' : '<br /><span class="text-danger">' . _("Got no vouchers") . '</span><br />') : '',
+                        $its_me ? button(
-              ($user_source['Gekommen'] && $admin_user_privilege && $user_source['Aktiv']) ? ' <span class="text-success">' . _("Active") . '</span>' : '',
+                            page_link_to('shifts_json_export') . '&key=' . $user_source['api_key'],
-              ($user_source['Gekommen'] && $admin_user_privilege && $user_source['Tshirt']) ? ' <span class="text-success">' . _("T-Shirt") . '</span>' : ''
+                            glyph('export') . _("JSON Export")
-          ]),
+                        ) : '',
-          div('col-md-3', [
+                        $its_me ? button(
-              '<h4>' . _("Angeltypes") . '</h4>',
+                            page_link_to('user_myshifts') . '&reset',
-              User_angeltypes_render($user_angeltypes)
+                            glyph('repeat') . _('Reset API key')
-          ]),
+                        ) : ''
-          div('col-md-3', [
+                    ])
-              '<h4>' . _("Rights") . '</h4>',
+                ])
-              User_groups_render($user_groups)
+            ]),
-          ])
+            div('row', [
-      ]),
+                div('col-md-3', [
-      ($its_me || $admin_user_privilege) ? '<h2>' . _("Shifts") . '</h2>' : '',
+                    '<h1>',
-      ($its_me || $admin_user_privilege) ? table([
+                    '<span class="glyphicon glyphicon-phone"></span>',
-          'date' => _("Day"),
+                    $user_source['DECT'],
-          'time' => _("Time"),
+                    '</h1>'
-          'room' => _("Location"),
+                ]),
-          'shift_info' => _("Name &amp; workmates"),
+                div('col-md-3', [
-          'comment' => _("Comment"),
+                    '<h4>' . _("User state") . '</h4>',
-          'actions' => _("Action")
+                    ($admin_user_privilege && $freeloader)
-      ], $myshifts_table) : '',
+                        ? '<span class="text-danger"><span class="glyphicon glyphicon-exclamation-sign"></span> ' . _("Freeloader") . '</span><br />'
-      $its_me ? info(glyph('info-sign') . _("Your night shifts between 2 and 8 am count twice."), true) : '',
+                        : '',
-      $its_me && count($shifts) == 0 ? error(sprintf(_("Go to the <a href=\"%s\">shifts table</a> to sign yourself up for some shifts."), page_link_to('user_shifts')), true) : ''
+                    $user_source['Gekommen']
-  ]);
+                        ? User_shift_state_render($user_source) . '<br />'
+                        : '',
+                    $admin_user_privilege || $its_me
+                        ? (
+                    $user_source['Gekommen']
+                        ? '<span class="text-success"><span class="glyphicon glyphicon-home"></span> '
+                        . sprintf(_("Arrived at %s"), date('Y-m-d', $user_source['arrival_date']))
+                        . '</span>'
+                        : '<span class="text-danger">'
+                        . sprintf(_("Not arrived (Planned: %s)"), date('Y-m-d', $user_source['planned_arrival_date']))
+                        . '</span>'
+                    )
+                        : (
+                    $user_source['Gekommen']
+                        ? '<span class="text-success"><span class="glyphicon glyphicon-home"></span> ' . _("Arrived") . '</span>'
+                        : '<span class="text-danger">' . _("Not arrived") . '</span>'),
+                    $admin_user_privilege
+                        ? (
+                    $user_source['got_voucher'] > 0
+                        ? '<br /><span class="text-success">'
+                        . glyph('cutlery')
+                        . sprintf(
+                            ngettext("Got %s voucher", "Got %s vouchers", $user_source['got_voucher']),
+                            $user_source['got_voucher']
+                        )
+                        . '</span><br />'
+                        : '<br /><span class="text-danger">' . _("Got no vouchers") . '</span><br />')
+                        : '',
+                    ($user_source['Gekommen'] && $admin_user_privilege && $user_source['Aktiv']) ? ' <span class="text-success">' . _("Active") . '</span>' : '',
+                    ($user_source['Gekommen'] && $admin_user_privilege && $user_source['Tshirt']) ? ' <span class="text-success">' . _("T-Shirt") . '</span>' : ''
+                ]),
+                div('col-md-3', [
+                    '<h4>' . _("Angeltypes") . '</h4>',
+                    User_angeltypes_render($user_angeltypes)
+                ]),
+                div('col-md-3', [
+                    '<h4>' . _("Rights") . '</h4>',
+                    User_groups_render($user_groups)
+                ])
+            ]),
+            ($its_me || $admin_user_privilege) ? '<h2>' . _("Shifts") . '</h2>' : '',
+            ($its_me || $admin_user_privilege) ? table([
+                'date'       => _("Day"),
+                'time'       => _("Time"),
+                'room'       => _("Location"),
+                'shift_info' => _("Name &amp; workmates"),
+                'comment'    => _("Comment"),
+                'actions'    => _("Action")
+            ], $myshifts_table) : '',
+            $its_me ? info(glyph('info-sign') . _("Your night shifts between 2 and 8 am count twice."), true) : '',
+            $its_me && count($shifts) == 0
+                ? error(sprintf(
+                _("Go to the <a href=\"%s\">shifts table</a> to sign yourself up for some shifts."),
+                page_link_to('user_shifts')
+            ), true)
+                : ''
+        ]);
 }
 
 /**
@@ -392,13 +498,13 @@ function User_view($user_source, $admin_user_privilege, $freeloader, $user_angel
 function User_password_recovery_view()
 {
     return page_with_title(user_password_recovery_title(), [
-      msg(),
+        msg(),
-      _("We will send you an e-mail with a password recovery link. Please use the email address you used for registration."),
+        _("We will send you an e-mail with a password recovery link. Please use the email address you used for registration."),
-      form([
+        form([
-          form_text('email', _("E-Mail"), ""),
+            form_text('email', _("E-Mail"), ""),
-          form_submit('submit', _("Recover"))
+            form_submit('submit', _("Recover"))
-      ])
+        ])
-  ]);
+    ]);
 }
 
 /**
@@ -407,14 +513,14 @@ function User_password_recovery_view()
 function User_password_set_view()
 {
     return page_with_title(user_password_recovery_title(), [
-      msg(),
+        msg(),
-      _("Please enter a new password."),
+        _("Please enter a new password."),
-      form([
+        form([
-          form_password('password', _("Password")),
+            form_password('password', _("Password")),
-          form_password('password2', _("Confirm password")),
+            form_password('password2', _("Confirm password")),
-          form_submit('submit', _("Save"))
+            form_submit('submit', _("Save"))
-      ])
+        ])
-  ]);
+    ]);
 }
 
 function User_angeltypes_render($user_angeltypes)
@@ -460,7 +566,7 @@ function render_user_departure_date_hint()
 {
     global $user;
 
-    if (! isset($user['planned_departure_date']) || $user['planned_departure_date'] == null) {
+    if (!isset($user['planned_departure_date']) || $user['planned_departure_date'] == null) {
         return _("Please enter your planned date of departure on your settings page to give us a feeling for teardown capacities.");
     }
 
@@ -472,7 +578,10 @@ function render_user_freeloader_hint()
     global $user, $max_freeloadable_shifts;
 
     if (User_is_freeloader($user)) {
-        return sprintf(_("You freeloaded at least %s shifts. Shift signup is locked. Please go to heavens desk to be unlocked again."), $max_freeloadable_shifts);
+        return sprintf(
+            _("You freeloaded at least %s shifts. Shift signup is locked. Please go to heavens desk to be unlocked again."),
+            $max_freeloadable_shifts
+        );
     }
 
     return null;

phpunit.xml

@@ -1,24 +1,24 @@
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-	xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/4.5/phpunit.xsd"
+         xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/4.5/phpunit.xsd"
-	backupGlobals="false"
+         backupGlobals="false"
-	bootstrap="./includes/engelsystem_provider.php"
+         bootstrap="./includes/engelsystem_provider.php"
-	colors="true"
+         colors="true"
-	convertErrorsToExceptions="true" 
+         convertErrorsToExceptions="true"
-	convertNoticesToExceptions="true"
+         convertNoticesToExceptions="true"
-	convertWarningsToExceptions="true"
+         convertWarningsToExceptions="true"
-	processIsolation="false">
+         processIsolation="false">
-	<testsuites>
+    <testsuites>
-		<testsuite name="Models">
+        <testsuite name="Models">
-			<directory>./test/model/</directory>
+            <directory>./test/model/</directory>
-		</testsuite>
+        </testsuite>
-	</testsuites>
+    </testsuites>
-	<filter>
+    <filter>
-		<whitelist>
+        <whitelist>
-			<directory>./include/</directory>
+            <directory>./include/</directory>
-			<directory>./public/</directory>
+            <directory>./public/</directory>
-		</whitelist>
+        </whitelist>
-	</filter>
+    </filter>
-	<php>
+    <php>
-		<const name="PHPUNIT_TESTSUITE" value="true" />
+        <const name="PHPUNIT_TESTSUITE" value="true"/>
-	</php>
+    </php>
 </phpunit>

public/index.php

@@ -21,11 +21,18 @@ $free_pages = [
 
 // Gewünschte Seite/Funktion
 $page = "";
-if (! isset($_REQUEST['p'])) {
+if (!isset($_REQUEST['p'])) {
     $_REQUEST['p'] = isset($user) ? "news" : "login";
 }
 
-if (isset($_REQUEST['p']) && preg_match("/^[a-z0-9_]*$/i", $_REQUEST['p']) && (in_array($_REQUEST['p'], $free_pages) || in_array($_REQUEST['p'], $privileges))) {
+if (
+    isset($_REQUEST['p'])
+    && preg_match("/^[a-z0-9_]*$/i", $_REQUEST['p'])
+    && (
+        in_array($_REQUEST['p'], $free_pages)
+        || in_array($_REQUEST['p'], $privileges)
+    )
+) {
     $page = $_REQUEST['p'];
 
     $title = $page;
@@ -151,26 +158,26 @@ if (isset($_REQUEST['p']) && preg_match("/^[a-z0-9_]*$/i", $_REQUEST['p']) && (i
     }
 } else {
     // Wenn schon eingeloggt, keine-Berechtigung-Seite anzeigen
-  if (isset($user)) {
+    if (isset($user)) {
-      $title = _("No Access");
+        $title = _("No Access");
-      $content = _("You don't have permission to view this page. You probably have to sign in or register in order to gain access!");
+        $content = _("You don't have permission to view this page. You probably have to sign in or register in order to gain access!");
-  } else {
+    } else {
-      // Sonst zur Loginseite leiten
+        // Sonst zur Loginseite leiten
-    redirect(page_link_to("login"));
+        redirect(page_link_to("login"));
-  }
+    }
 }
 
 $event_config = EventConfig();
 
 echo template_render(__DIR__ . '/../templates/layout.html', [
-    'theme' => isset($user) ? $user['color'] : $default_theme,
+    'theme'          => isset($user) ? $user['color'] : $default_theme,
-    'title' => $title,
+    'title'          => $title,
-    'atom_link' => ($page == 'news' || $page == 'user_meetings') ? '<link href="' . page_link_to('atom') . (($page == 'user_meetings') ? '&amp;meetings=1' : '') . '&amp;key=' . $user['api_key'] . '" type="application/atom+xml" rel="alternate" title="Atom Feed">' : '',
+    'atom_link'      => ($page == 'news' || $page == 'user_meetings') ? '<link href="' . page_link_to('atom') . (($page == 'user_meetings') ? '&amp;meetings=1' : '') . '&amp;key=' . $user['api_key'] . '" type="application/atom+xml" rel="alternate" title="Atom Feed">' : '',
-    'menu' => make_menu(),
+    'menu'           => make_menu(),
-    'content' => msg() . $content,
+    'content'        => msg() . $content,
     'header_toolbar' => header_toolbar(),
-    'faq_url' => $faq_url,
+    'faq_url'        => $faq_url,
-    'contact_email' => $contact_email,
+    'contact_email'  => $contact_email,
-    'locale' => locale(),
+    'locale'         => locale(),
-    'event_info' => EventConfig_info($event_config) . '<br />'
+    'event_info'     => EventConfig_info($event_config) . '<br />'
 ]);

public/js/forms.js

@@ -8,21 +8,21 @@
  *            checked True if the checkboxes should be checked
  */
 function checkAll(id, checked) {
-	var obj = document.getElementById(id);
+    var obj = document.getElementById(id);
-	var boxes = obj.getElementsByTagName("input");
+    var boxes = obj.getElementsByTagName("input");
-	for (var i = 0; i < boxes.length; i++) {
+    for (var i = 0; i < boxes.length; i++) {
-		if (boxes[i].type === "checkbox" && !boxes[i].disabled) {
+        if (boxes[i].type === "checkbox" && !boxes[i].disabled) {
-			boxes[i].checked = checked;
+            boxes[i].checked = checked;
-		}
+        }
-	}
+    }
 }
 
-$(function() {
+$(function () {
-	/**
+    /**
-	 * Disable every submit button after clicking (to prevent double-clicking)
+     * Disable every submit button after clicking (to prevent double-clicking)
-	 */
+     */
-	$("form").submit(function(ev) {
+    $("form").submit(function (ev) {
-		$("input[type='submit']").prop("readonly", true).addClass("disabled");
+        $("input[type='submit']").prop("readonly", true).addClass("disabled");
-		return true;
+        return true;
-	});
+    });
 });

public/js/moment-countdown.js

@@ -3,17 +3,17 @@
  * class "moment-countdown" and the attribute "data-timestamp" which defines the
  * countdown's time goal.
  */
-$(document).ready(function() {
+$(document).ready(function () {
-  if (typeof moment !== "undefined") {
+    if (typeof moment !== "undefined") {
-    $.each($(".moment-countdown"), function(i, e) {
+        $.each($(".moment-countdown"), function (i, e) {
-      var span = $(e);
+            var span = $(e);
-      var text = span.html();
+            var text = span.html();
-      /* global moment */
+            /* global moment */
-      var timestamp = moment(parseInt(span.attr("data-timestamp") * 1000));
+            var timestamp = moment(parseInt(span.attr("data-timestamp") * 1000));
-      span.html(text.replace("%c", timestamp.fromNow()));
+            span.html(text.replace("%c", timestamp.fromNow()));
-      setInterval(function() {
+            setInterval(function () {
-        span.html(text.replace("%c", timestamp.fromNow()));
+                span.html(text.replace("%c", timestamp.fromNow()));
-      }, 1000);
+            }, 1000);
-    });
+        });
-  }
+    }
 });

public/js/sticky-headers.js

@@ -1,32 +1,31 @@
 /**
  * Enables the fixed headers and time lane for the shift-calendar and datatables
  */
-$(document).ready(
+$(document).ready(function () {
-    function() {
+    if ($(".shift-calendar").length) {
-      if ($(".shift-calendar").length) {
         var timeLanes = $(".shift-calendar .time");
         var headers = $(".shift-calendar .header");
         var topReference = $(".container-fluid .row");
         var top = headers.offset().top;
         var left = 15;
         timeLanes.css({
-          "position" : "relative",
+            "position": "relative",
-          "z-index" : 999
+            "z-index": 999
         });
         headers.css({
-          "position" : "relative",
+            "position": "relative",
-          "z-index" : 900
+            "z-index": 900
         });
         $(window).scroll(
-            function() {
+            function () {
-              timeLanes.css({
+                timeLanes.css({
-                "left" : Math.max(0, $(window).scrollLeft() - left) + "px"
+                    "left": Math.max(0, $(window).scrollLeft() - left) + "px"
-              });
+                });
-              headers.css({
+                headers.css({
-                "top" : Math.max(0, $(window).scrollTop() - top
+                    "top": Math.max(0, $(window).scrollTop() - top
-                    + topReference.offset().top)
+                        + topReference.offset().top)
                     + "px"
-              });
+                });
             });
-      }
+    }
-    });
+});

public/maintenance.html

@@ -1,72 +1,86 @@
 <!DOCTYPE html>
 <html>
 <head>
-<title>Maintenance - Engelsystem</title>
+    <title>Maintenance - Engelsystem</title>
-<meta charset="UTF-8" />
+    <meta charset="UTF-8"/>
-<meta name="viewport" content="width=device-width, initial-scale=1">
+    <meta name="viewport" content="width=device-width, initial-scale=1">
-<link rel="stylesheet" type="text/css" href="css/theme0.css" />
+    <link rel="stylesheet" type="text/css" href="css/theme0.css"/>
-<link rel="stylesheet" type="text/css" href="vendor/icomoon/style.css" />
+    <link rel="stylesheet" type="text/css" href="vendor/icomoon/style.css"/>
-<link rel="stylesheet" type="text/css" href="vendor/bootstrap-datepicker-1.4.0/css/bootstrap-datepicker3.min.css" />
+    <link rel="stylesheet" type="text/css" href="vendor/bootstrap-datepicker-1.4.0/css/bootstrap-datepicker3.min.css"/>
-<script type="text/javascript" src="vendor/jquery-2.1.1.min.js"></script>
+    <script type="text/javascript" src="vendor/jquery-2.1.1.min.js"></script>
-<script type="text/javascript" src="vendor/jquery-ui.min.js"></script>
+    <script type="text/javascript" src="vendor/jquery-ui.min.js"></script>
 </head>
 <body>
-  <div class="navbar navbar-default navbar-fixed-top">
+<div class="navbar navbar-default navbar-fixed-top">
     <div class="container-fluid">
-      <div class="navbar-header">
+        <div class="navbar-header">
-        <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#navbar-collapse-1">
+            <button type="button" class="navbar-toggle collapsed"
-          <span class="sr-only">Toggle navigation</span> <span class="icon-bar"></span> <span class="icon-bar"></span> <span class="icon-bar"></span>
+                    data-toggle="collapse" data-target="#navbar-collapse-1">
-        </button>
+                <span class="sr-only">Toggle navigation</span>
-        <a class="navbar-brand" href="?"><span class="icon-icon_angel"></span> <strong class="visible-lg-inline">ENGELSYSTEM</strong></a>
+                <span class="icon-bar"></span>
-      </div>
+                <span class="icon-bar"></span>
-      <div class="collapse navbar-collapse" id="navbar-collapse-1">
+                <span class="icon-bar"></span>
-        <ul class="nav navbar-nav"></ul>
+            </button>
-        <ul class="nav navbar-nav navbar-right">
+            <a class="navbar-brand" href="?">
-        </ul>
+                <span class="icon-icon_angel"></span> <strong class="visible-lg-inline">ENGELSYSTEM</strong>
-      </div>
+            </a>
+        </div>
+        <div class="collapse navbar-collapse" id="navbar-collapse-1">
+            <ul class="nav navbar-nav"></ul>
+            <ul class="nav navbar-nav navbar-right">
+            </ul>
+        </div>
     </div>
-  </div>
+</div>
-  <div class="container-fluid">
+<div class="container-fluid">
     <div class="row">
-      <div class="jumbotron">
+        <div class="jumbotron">
-        <div class="container text-center">
+            <div class="container text-center">
-          <h1>
+                <h1>
-            <span class="glyphicon glyphicon-scissors"></span> <span class="glyphicon glyphicon-wrench"></span> <span class="glyphicon glyphicon-fire"></span>
+                    <span class="glyphicon glyphicon-scissors"></span>
-          </h1>
+                    <span class="glyphicon glyphicon-wrench"></span>
-          <div class="col-md-6">
+                    <span class="glyphicon glyphicon-fire"></span>
-            <h2>
+                </h1>
-              The <span class="icon-icon_angel"></span> <strong>ENGELSYSTEM</strong> is in maintenance mode.
+                <div class="col-md-6">
-            </h2>
+                    <h2>
-            <p>This may be due to...</p>
+                        The <span class="icon-icon_angel"></span> <strong>ENGELSYSTEM</strong> is in maintenance mode.
-            <p>
+                    </h2>
-              ...archangels closing the gates of heaven. <br>...somebody's stolen the power chord and now the battery is empty. <br>...DHCP decided to give me another ip address.
+                    <p>This may be due to...</p>
-            </p>
+                    <p>
-          </div>
+                        ...archangels closing the gates of heaven. <br>
-          <div class="col-md-6">
+                        ...somebody's stolen the power chord and now the battery is empty. <br>
-            <iframe width="560" height="315" src="https://www.youtube.com/embed/0aV_vHcunSQ?rel=0" frameborder="0" allowfullscreen></iframe>
+                        ...DHCP decided to give me another ip address.
-          </div>
+                    </p>
+                </div>
+                <div class="col-md-6">
+                    <iframe width="560" height="315"
+                            src="https://www.youtube.com/embed/0aV_vHcunSQ?rel=0"
+                            frameborder="0" allowfullscreen>
+                    </iframe>
+                </div>
+            </div>
         </div>
-      </div>
     </div>
     <div class="row">
-      <div class="col-md-12">
+        <div class="col-md-12">
-        <div class="text-center footer">
+            <div class="text-center footer">
-          <a href="https://github.com/engelsystem/engelsystem/issues">Bugs / Features</a> · <a href="https://github.com/engelsystem/engelsystem/">Development Platform</a>
+                <a href="https://github.com/engelsystem/engelsystem/issues">Bugs / Features</a>
+                · <a href="https://github.com/engelsystem/engelsystem/">Development Platform</a>
+            </div>
         </div>
-      </div>
     </div>
-  </div>
+</div>
-  <script type="text/javascript" src="vendor/bootstrap/js/bootstrap.min.js"></script>
+<script type="text/javascript" src="vendor/bootstrap/js/bootstrap.min.js"></script>
-  <script type="text/javascript" src="vendor/bootstrap-datepicker-1.4.0/js/bootstrap-datepicker.min.js"></script>
+<script type="text/javascript" src="vendor/bootstrap-datepicker-1.4.0/js/bootstrap-datepicker.min.js"></script>
-  <script type="text/javascript" src="vendor/bootstrap-datepicker-1.4.0/locales/bootstrap-datepicker.de.min.js"></script>
+<script type="text/javascript" src="vendor/bootstrap-datepicker-1.4.0/locales/bootstrap-datepicker.de.min.js"></script>
-  <script type="text/javascript" src="vendor/Chart.min.js"></script>
+<script type="text/javascript" src="vendor/Chart.min.js"></script>
-  <script type="text/javascript" src="js/forms.js"></script>
+<script type="text/javascript" src="js/forms.js"></script>
-  <script type="text/javascript" src="vendor/moment-with-locales.min.js"></script>
+<script type="text/javascript" src="vendor/moment-with-locales.min.js"></script>
-  <script type="text/javascript">
+<script type="text/javascript">
-			$(function() {
+    $(function () {
-				moment.locale("en_US.UTF-8");
+        moment.locale("en_US.UTF-8");
-			});
+    });
-		</script>
+</script>
-  <script type="text/javascript" src="js/moment-countdown.js"></script>
+<script type="text/javascript" src="js/moment-countdown.js"></script>
 </body>
 </html>

public/overwhelmed.html

@@ -1,57 +1,77 @@
 <!DOCTYPE html>
 <html>
 <head>
-<title>Engelsystem</title>
+    <title>Engelsystem</title>
-<meta charset="UTF-8" />
+    <meta charset="UTF-8"/>
-<meta name="viewport" content="width=device-width, initial-scale=1">
+    <meta name="viewport" content="width=device-width, initial-scale=1">
-<link rel="stylesheet" type="text/css" href="css/theme0.css" />
+    <link rel="stylesheet" type="text/css" href="css/theme0.css"/>
-<link rel="stylesheet" type="text/css" href="vendor/icomoon/style.css" />
+    <link rel="stylesheet" type="text/css" href="vendor/icomoon/style.css"/>
-<link rel="stylesheet" type="text/css" href="vendor/bootstrap-datepicker-1.4.0/css/bootstrap-datepicker3.min.css" />
+    <link rel="stylesheet" type="text/css" href="vendor/bootstrap-datepicker-1.4.0/css/bootstrap-datepicker3.min.css"/>
-<script type="text/javascript" src="vendor/jquery-2.1.1.min.js"></script>
+    <script type="text/javascript" src="vendor/jquery-2.1.1.min.js"></script>
-<script type="text/javascript" src="vendor/jquery-ui.min.js"></script>
+    <script type="text/javascript" src="vendor/jquery-ui.min.js"></script>
 </head>
 <body>
-  <div class="navbar navbar-default navbar-fixed-top">
+<div class="navbar navbar-default navbar-fixed-top">
     <div class="container-fluid">
-      <div class="navbar-header">
+        <div class="navbar-header">
-        <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#navbar-collapse-1">
+            <button type="button" class="navbar-toggle collapsed"
-          <span class="sr-only">Toggle navigation</span> <span class="icon-bar"></span> <span class="icon-bar"></span> <span class="icon-bar"></span>
+                    data-toggle="collapse" data-target="#navbar-collapse-1">
-        </button>
+                <span class="sr-only">Toggle navigation</span>
-        <a class="navbar-brand" href="https://engelsystem.de"><span class="icon-icon_angel"></span> <strong class="visible-lg-inline">ENGELSYSTEM</strong></a>
+                <span class="icon-bar"></span>
-      </div>
+                <span class="icon-bar"></span>
-      <div class="collapse navbar-collapse" id="navbar-collapse-1">
+                <span class="icon-bar"></span>
-        <ul class="nav navbar-nav"></ul>
+            </button>
-        <ul class="nav navbar-nav navbar-right">
+            <a class="navbar-brand" href="https://engelsystem.de"><span class="icon-icon_angel"></span> <strong
-        </ul>
+                    class="visible-lg-inline">ENGELSYSTEM</strong></a>
-      </div>
+        </div>
+        <div class="collapse navbar-collapse" id="navbar-collapse-1">
+            <ul class="nav navbar-nav"></ul>
+            <ul class="nav navbar-nav navbar-right"></ul>
+        </div>
     </div>
-  </div>
+</div>
-  <div class="container-fluid">
+<div class="container-fluid">
     <div class="row">
-      <div class="jumbotron">
+        <div class="jumbotron">
-        <div class="container text-center">
+            <div class="container text-center">
-          <div class="col-md-6 col-md-offset-3">
+                <div class="col-md-6 col-md-offset-3">
-            <h2>Dear Angels,</h2>
+                    <h2>Dear Angels,</h2>
-            <p>The great interest in becoming an angel and participating at 33C3 is is something we are grateful for every time. There is a record number of angels and helping volunteers this year.</p>
+                    <p>
-            <p>We did anticipate a great number but we are overwhelmed by this endless wave of support. We do want to enable each and every one of you to be an angel at the congress, but sadly our resources and capacities at Heaven are limited. The amount of angels at this point is beyond our
+                        The great interest in becoming an angel and participating at 33C3 is is something we are
-              planing and to ensure we can support the angels already checked in. We did make a choice never thought possible on a chaos event:</p>
+                        grateful for every time. There is a record number of angels and helping volunteers this year.
-            <p>We closed the registration in the Engelsystem and at Heaven Desk at 19:00 27. Dec. 2016.</p>
+                    </p>
-            <p>Everyone of us works for you to support you in being an angel, but the Heaven Desk and the Kitchen among others are limited and so we decided to focus our effort to support those of you already arrived to the best of our abilities.</p>
+                    <p>
-            <p>
+                        We did anticipate a great number but we are overwhelmed by this endless wave of support. We do
-              For the Heaven Team<br /> Agnes, Jen, LLF and Knuth
+                        want to enable each and every one of you to be an angel at the congress, but sadly our resources
-            </p>
+                        and capacities at Heaven are limited. The amount of angels at this point is beyond our
-          </div>
+                        planing and to ensure we can support the angels already checked in. We did make a choice never
+                        thought possible on a chaos event:
+                    </p>
+                    <p>
+                        We closed the registration in the Engelsystem and at Heaven Desk at 19:00 27. Dec. 2016.
+                    </p>
+                    <p>
+                        Everyone of us works for you to support you in being an angel, but the Heaven Desk and the
+                        Kitchen among others are limited and so we decided to focus our effort to support those of you
+                        already arrived to the best of our abilities.
+                    </p>
+                    <p>
+                        For the Heaven Team<br/>
+                        Agnes, Jen, LLF and Knuth
+                    </p>
+                </div>
+            </div>
         </div>
-      </div>
     </div>
     <div class="row">
-      <div class="col-md-12">
+        <div class="col-md-12">
-        <div class="text-center footer">
+            <div class="text-center footer">
-          <a href="https://github.com/engelsystem/engelsystem/issues">Bugs / Features</a> · <a href="https://github.com/engelsystem/engelsystem/">Development Platform</a>
+                <a href="https://github.com/engelsystem/engelsystem/issues">Bugs / Features</a>
+                · <a href="https://github.com/engelsystem/engelsystem/">Development Platform</a>
+            </div>
         </div>
-      </div>
     </div>
-  </div>
+</div>
-  <script type="text/javascript" src="vendor/bootstrap/js/bootstrap.min.js"></script>
+<script type="text/javascript" src="vendor/bootstrap/js/bootstrap.min.js"></script>
 </body>
 </html>

shift_markup.html

@@ -1,86 +1,105 @@
 <!DOCTYPE html>
 <html>
 <head>
-<meta charset="UTF-8" />
+    <meta charset="UTF-8"/>
-<link rel="stylesheet" type="text/css" href="public/css/theme3.css" />
+    <link rel="stylesheet" type="text/css" href="public/css/theme3.css"/>
-<style>
+    <style>
-</style>
+    </style>
 </head>
 <body>
-  <div class="shift-calendar">
+<div class="shift-calendar">
     <div class="lane time">
-      <div class="header">Time</div>
+        <div class="header">Time</div>
-      <div class="tick day">2016-12-27 00:00</div>
+        <div class="tick day">2016-12-27 00:00</div>
-      <div class="tick"></div>
+        <div class="tick"></div>
-      <div class="tick"></div>
+        <div class="tick"></div>
-      <div class="tick"></div>
+        <div class="tick"></div>
-      <div class="tick hour">11:00</div>
+        <div class="tick hour">11:00</div>
-      <div class="tick"></div>
+        <div class="tick"></div>
-      <div class="tick"></div>
+        <div class="tick"></div>
-      <div class="tick"></div>
+        <div class="tick"></div>
-      <div class="tick hour">12:00</div>
+        <div class="tick hour">12:00</div>
-      <div class="tick"></div>
+        <div class="tick"></div>
-      <div class="tick"></div>
+        <div class="tick"></div>
-      <div class="tick"></div>
+        <div class="tick"></div>
-      <div class="tick hour">13:00</div>
+        <div class="tick hour">13:00</div>
-      <div class="tick"></div>
+        <div class="tick"></div>
-      <div class="tick"></div>
+        <div class="tick"></div>
-      <div class="tick"></div>
+        <div class="tick"></div>
     </div>
     <div class="lane">
-      <div class="header">
+        <div class="header">
-        <span class="glyphicon glyphicon-map-marker"></span> Bottle Sorting (Hall H)
+            <span class="glyphicon glyphicon-map-marker"></span> Bottle Sorting (Hall H)
-      </div>
-      <div class="tick day"></div>
-      <div class="tick"></div>
-      <div class="tick"></div>
-      <div class="tick"></div>
-      <div class="shift panel panel-success" style="height: 160px;">
-        <div class="panel-heading">
-          <a href="?p=shifts&amp;action=view&amp;shift_id=2696">00:00 ‐ 02:00 — Bottle Collection</a>
-          <div class="pull-right">
-            <div class="btn-group">
-              <a href="?p=user_shifts&amp;edit_shift=2696" class="btn btn-default btn-xs"> <span class="glyphicon glyphicon-edit"></span>
-              </a> <a href="?p=user_shifts&amp;delete_shift=2696" class="btn btn-default btn-xs"> <span class="glyphicon glyphicon-trash"></span>
-              </a>
-            </div>
-          </div>
         </div>
-        <div class="panel-body">
+        <div class="tick day"></div>
-          <span class="glyphicon glyphicon-info-sign"></span> Bottle Collection Quick Response Team<br> <a href="?p=rooms&amp;action=view&amp;room_id=42"> <span class="glyphicon glyphicon-map-marker"></span> Bottle Sorting (Hall H)
+        <div class="tick"></div>
-          </a>
+        <div class="tick"></div>
+        <div class="tick"></div>
+        <div class="shift panel panel-success" style="height: 160px;">
+            <div class="panel-heading">
+                <a href="?p=shifts&amp;action=view&amp;shift_id=2696">00:00 ‐ 02:00 — Bottle Collection</a>
+                <div class="pull-right">
+                    <div class="btn-group">
+                        <a href="?p=user_shifts&amp;edit_shift=2696" class="btn btn-default btn-xs">
+                            <span class="glyphicon glyphicon-edit"></span>
+                        </a>
+                        <a href="?p=user_shifts&amp;delete_shift=2696" class="btn btn-default btn-xs">
+                            <span class="glyphicon glyphicon-trash"></span>
+                        </a>
+                    </div>
+                </div>
+            </div>
+            <div class="panel-body">
+                <span class="glyphicon glyphicon-info-sign"></span> Bottle Collection Quick Response Team<br>
+                <a href="?p=rooms&amp;action=view&amp;room_id=42">
+                    <span class="glyphicon glyphicon-map-marker"></span> Bottle Sorting (Hall H)
+                </a>
+            </div>
+            <ul class="list-group">
+                <li class="list-group-item"><strong><a href="?p=angeltypes&amp;action=view&amp;angeltype_id=104575">Angel</a>:</strong>
+                    <span style="">
+                        <a class="" href="?p=users&amp;action=view&amp;user_id=1755">
+                            <span class="icon-icon_angel"></span> Pantomime
+                        </a>
+                    </span>,
+                    <span style="">
+                        <a class="" href="?p=users&amp;action=view&amp;user_id=50">
+                            <span class="icon-icon_angel"></span> sandzwerg
+                        </a>
+                    </span>
+                </li>
+                <li class="list-group-item">
+                    <a href="?p=user_shifts&amp;shift_id=2696&amp;type_id=104575" class="btn btn-default btn-xs">
+                        Neue Engel hinzufügen
+                    </a>
+                </li>
+            </ul>
+            <div class="shift-spacer"></div>
         </div>
-        <ul class="list-group">
+        <div class="tick hour"></div>
-          <li class="list-group-item"><strong><a href="?p=angeltypes&amp;action=view&amp;angeltype_id=104575">Angel</a>:</strong> <span style=""><a class="" href="?p=users&amp;action=view&amp;user_id=1755"><span class="icon-icon_angel"></span> Pantomime</a></span>, <span style=""><a
+        <div class="tick"></div>
-              class="" href="?p=users&amp;action=view&amp;user_id=50"><span class="icon-icon_angel"></span> sandzwerg</a></span></li>
+        <div class="tick"></div>
-          <li class="list-group-item"><a href="?p=user_shifts&amp;shift_id=2696&amp;type_id=104575" class="btn btn-default btn-xs">Neue Engel hinzufügen</a></li>
+        <div class="tick"></div>
-        </ul>
-        <div class="shift-spacer"></div>
-      </div>
-      <div class="tick hour"></div>
-      <div class="tick"></div>
-      <div class="tick"></div>
-      <div class="tick"></div>
     </div>
     <div class="lane">
-      <div class="header"></div>
+        <div class="header"></div>
-      <div class="tick day"></div>
+        <div class="tick day"></div>
-      <div class="tick"></div>
+        <div class="tick"></div>
-      <div class="tick"></div>
+        <div class="tick"></div>
-      <div class="tick"></div>
+        <div class="tick"></div>
-      <div class="tick hour"></div>
+        <div class="tick hour"></div>
-      <div class="tick"></div>
+        <div class="tick"></div>
-      <div class="tick"></div>
+        <div class="tick"></div>
-      <div class="tick"></div>
+        <div class="tick"></div>
-      <div class="tick hour"></div>
+        <div class="tick hour"></div>
-      <div class="tick"></div>
+        <div class="tick"></div>
-      <div class="tick"></div>
+        <div class="tick"></div>
-      <div class="tick"></div>
+        <div class="tick"></div>
-      <div class="tick hour"></div>
+        <div class="tick hour"></div>
-      <div class="tick"></div>
+        <div class="tick"></div>
-      <div class="tick"></div>
+        <div class="tick"></div>
-      <div class="tick"></div>
+        <div class="tick"></div>
     </div>
-  </div>
+</div>
 </body>
 </html>

templates/guest_credits.html

@@ -1,27 +1,35 @@
 <div class="container">
-<h1>Credits</h1>
+    <h1>Credits</h1>
-  <div class="row">
+    <div class="row">
-    <div class="col-md-4">
+        <div class="col-md-4">
-      <h2>Source code</h2>
+            <h2>Source code</h2>
-      <p>
+            <p>
-        The original system was written by <a href="https://github.com/cookieBerlin/engelsystem">cookie</a>. It was then completely rewritten and greatly enhanced by <a href="http://notrademark.de/">msquare</a> and <a href="http://mortzu.de/">mortzu</a> of <a href="http://planetcyborg.de">planet
+                The original system was written by <a href="https://github.com/cookieBerlin/engelsystem">cookie</a>.
-          cyborg</a>, <a href="http://jplitza.de/">jplitza</a> and gnomus.
+                It was then completely rewritten and greatly enhanced by <a href="http://notrademark.de/">msquare</a>
-      </p>
+                and <a href="http://myigel.name/">MyIgel</a>,
-      <p>
+                <a href="http://mortzu.de/">mortzu</a> of <a href="http://planetcyborg.de">planet cyborg</a>,
-        Please look at the <a href="https://github.com/engelsystem/engelsystem/graphs/contributors">contributor list on github</a> for a more complete version.
+                <a href="http://jplitza.de/">jplitza</a> and gnomus.
-      </p>
+            </p>
+            <p>
+                Please look at the <a href="https://github.com/engelsystem/engelsystem/graphs/contributors">contributor
+                list on github</a> for a more complete version.
+            </p>
+        </div>
+        <div class="col-md-4">
+            <h2>Hosting</h2>
+            <p>
+                Webspace, development platform and domain is currently provided by
+                <a href="https://www.wybt.net/">would you buy this?</a> (ichdasich)<br/>
+                and adminstrated by <a href="http://mortzu.de/">mortzu</a>,
+                <a href="http://derf.homelinux.org/">derf</a>
+                and ichdasich.
+            </p>
+        </div>
+        <div class="col-md-4">
+            <h2>Translation</h2>
+            <p>
+                Many thanks for the german translation: <a href="http://e7p.de">e7p</a>
+            </p>
+        </div>
     </div>
-    <div class="col-md-4">
-      <h2>Hosting</h2>
-      <p>
-        Webspace, development platform and domain is currently provided by <a href="https://www.wybt.net/">would you buy this?</a> (ichdasich)<br /> and adminstrated by <a href="http://mortzu.de/">mortzu</a>, <a href="http://derf.homelinux.org/">derf</a> and ichdasich.
-      </p>
-    </div>
-    <div class="col-md-4">
-      <h2>Translation</h2>
-      <p>
-        Many thanks for the german translation: <a href="http://e7p.de">e7p</a>
-      </p>
-    </div>
-  </div>
 </div>

templates/layout.html

@@ -1,53 +1,60 @@
 <!DOCTYPE html>
 <html>
 <head>
-<title>%title% - Engelsystem</title>
+    <title>%title% - Engelsystem</title>
-<meta charset="UTF-8" />
+    <meta charset="UTF-8"/>
-<meta name="viewport" content="width=device-width, initial-scale=1">
+    <meta name="viewport" content="width=device-width, initial-scale=1">
-<link rel="stylesheet" type="text/css" href="css/theme%theme%.css" />
+    <link rel="stylesheet" type="text/css" href="css/theme%theme%.css"/>
-<link rel="stylesheet" type="text/css" href="vendor/icomoon/style.css" />
+    <link rel="stylesheet" type="text/css" href="vendor/icomoon/style.css"/>
-<link rel="stylesheet" type="text/css" href="vendor/bootstrap-datepicker-1.4.0/css/bootstrap-datepicker3.min.css" />
+    <link rel="stylesheet" type="text/css" href="vendor/bootstrap-datepicker-1.4.0/css/bootstrap-datepicker3.min.css"/>
-<script type="text/javascript" src="vendor/jquery-2.1.1.min.js"></script>
+    <script type="text/javascript" src="vendor/jquery-2.1.1.min.js"></script>
-<script type="text/javascript" src="vendor/jquery-ui.min.js"></script>
+    <script type="text/javascript" src="vendor/jquery-ui.min.js"></script>
-%atom_link%
+    %atom_link%
 </head>
 <body>
-  <div class="navbar navbar-default navbar-fixed-top">
+<div class="navbar navbar-default navbar-fixed-top">
     <div class="container-fluid">
-      <div class="navbar-header">
+        <div class="navbar-header">
-        <button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#navbar-collapse-1">
+            <button type="button" class="navbar-toggle collapsed"
-          <span class="sr-only">Toggle navigation</span> <span class="icon-bar"></span> <span class="icon-bar"></span> <span class="icon-bar"></span>
+                    data-toggle="collapse" data-target="#navbar-collapse-1">
-        </button>
+                <span class="sr-only">Toggle navigation</span>
-        <a class="navbar-brand" href="?"><span class="icon-icon_angel"></span> <strong class="visible-lg-inline">ENGELSYSTEM</strong></a>
+                <span class="icon-bar"></span>
-      </div>
+                <span class="icon-bar"></span>
-      <div class="collapse navbar-collapse" id="navbar-collapse-1">%menu% %header_toolbar%</div>
+                <span class="icon-bar"></span>
+            </button>
+            <a class="navbar-brand" href="?"><span class="icon-icon_angel"></span> <strong class="visible-lg-inline">ENGELSYSTEM</strong></a>
+        </div>
+        <div class="collapse navbar-collapse" id="navbar-collapse-1">%menu% %header_toolbar%</div>
     </div>
-  </div>
+</div>
-  <div class="container-fluid">
+<div class="container-fluid">
     <div class="row">%content%</div>
     <div class="row">
-      <div class="col-md-12">
+        <div class="col-md-12">
-        <hr />
+            <hr/>
-        <div class="text-center footer" style="margin-bottom: 10px;">
+            <div class="text-center footer" style="margin-bottom: 10px;">
-          %event_info%
+                %event_info%
-          <a href="%faq_url%">FAQ</a> · <a href="%contact_email%"><span class="glyphicon glyphicon-envelope"></span> Contact</a> · <a href="https://github.com/engelsystem/engelsystem/issues">Bugs / Features</a> · <a href="https://github.com/engelsystem/engelsystem/">Development
+                <a href="%faq_url%">FAQ</a>
-            Platform</a> · <a href="?p=credits">Credits</a>
+                · <a href="%contact_email%"><span class="glyphicon glyphicon-envelope"></span> Contact</a>
+                · <a href="https://github.com/engelsystem/engelsystem/issues">Bugs / Features</a>
+                · <a href="https://github.com/engelsystem/engelsystem/">Development Platform</a>
+                · <a href="?p=credits">Credits</a>
+            </div>
         </div>
-      </div>
     </div>
-  </div>
+</div>
-  <script type="text/javascript" src="vendor/bootstrap/js/bootstrap.min.js"></script>
+<script type="text/javascript" src="vendor/bootstrap/js/bootstrap.min.js"></script>
-  <script type="text/javascript" src="vendor/bootstrap-datepicker-1.4.0/js/bootstrap-datepicker.min.js"></script>
+<script type="text/javascript" src="vendor/bootstrap-datepicker-1.4.0/js/bootstrap-datepicker.min.js"></script>
-  <script type="text/javascript" src="vendor/bootstrap-datepicker-1.4.0/locales/bootstrap-datepicker.de.min.js"></script>
+<script type="text/javascript" src="vendor/bootstrap-datepicker-1.4.0/locales/bootstrap-datepicker.de.min.js"></script>
-  <script type="text/javascript" src="vendor/Chart.min.js"></script>
+<script type="text/javascript" src="vendor/Chart.min.js"></script>
-  <script type="text/javascript" src="js/forms.js"></script>
+<script type="text/javascript" src="js/forms.js"></script>
-  <script type="text/javascript" src="vendor/moment-with-locales.min.js"></script>
+<script type="text/javascript" src="vendor/moment-with-locales.min.js"></script>
-  <script type="text/javascript">
+<script type="text/javascript">
-			$(function() {
+    $(function () {
-				moment.locale("%locale%");
+        moment.locale("%locale%");
-			});
+    });
-		</script>
+</script>
-  <script type="text/javascript" src="js/moment-countdown.js"></script>
+<script type="text/javascript" src="js/moment-countdown.js"></script>
-  <script type="text/javascript" src="js/sticky-headers.js"></script>
+<script type="text/javascript" src="js/sticky-headers.js"></script>
 </body>
 </html>

templates/user_shifts.html

@@ -1,52 +1,54 @@
 <script type="text/javascript">
-	function set_to_now(id) {
+    function set_to_now(id) {
-		document.getElementById(id + '_time').value = moment().format('HH:mm');
+        document.getElementById(id + '_time').value = moment().format('HH:mm');
-		var days = document.getElementById(id + '_day').getElementsByTagName(
+        var days = document.getElementById(id + '_day').getElementsByTagName(
-				'option');
+            'option');
-		for ( var i = 0; i < days.length; i++) {
+        for (var i = 0; i < days.length; i++) {
-			if (days[i].value == moment().format('YYYY-MM-DD'))
+            if (days[i].value == moment().format('YYYY-MM-DD'))
-				days[i].selected = true;
+                days[i].selected = true;
-		}
+        }
-	}
+    }
 </script>
 <form class="form-inline" action="" method="get">
-  <input type="hidden" name="p" value="user_shifts">
+    <input type="hidden" name="p" value="user_shifts">
-  <div class="row">
+    <div class="row">
-    <div class="col-md-6">
+        <div class="col-md-6">
-      <h1>%title%</h1>
+            <h1>%title%</h1>
-      <div class="form-group">%start_select%</div>
+            <div class="form-group">%start_select%</div>
-      <div class="form-group">
+            <div class="form-group">
-        <div class="input-group">
+                <div class="input-group">
-          <input class="form-control" type="text" id="start_time" name="start_time" size="5" pattern="^\d{1,2}:\d{2}$" placeholder="HH:MM" maxlength="5" value="%start_time%">
+                    <input class="form-control" type="text" id="start_time" name="start_time" size="5"
-          <div class="input-group-btn">
+                           pattern="^\d{1,2}:\d{2}$" placeholder="HH:MM" maxlength="5" value="%start_time%">
-            <button class="btn btn-default" title="Now" type="button" onclick="set_to_now('start');">
+                    <div class="input-group-btn">
-              <span class="glyphicon glyphicon-time"></span>
+                        <button class="btn btn-default" title="Now" type="button" onclick="set_to_now('start');">
-            </button>
+                            <span class="glyphicon glyphicon-time"></span>
-          </div>
+                        </button>
+                    </div>
+                </div>
+            </div>
+            &#8211;
+            <div class="form-group">%end_select%</div>
+            <div class="form-group">
+                <div class="input-group">
+                    <input class="form-control" type="text" id="end_time" name="end_time" size="5"
+                           pattern="^\d{1,2}:\d{2}$" placeholder="HH:MM" maxlength="5" value="%end_time%">
+                    <div class="input-group-btn">
+                        <button class="btn btn-default" title="Now" type="button" onclick="set_to_now('end');">
+                            <span class="glyphicon glyphicon-time"></span>
+                        </button>
+                    </div>
+                </div>
+            </div>
         </div>
-      </div>
+        <div class="col-md-2">%room_select%</div>
-      &#8211;
+        <div class="col-md-2">%type_select%</div>
-      <div class="form-group">%end_select%</div>
+        <div class="col-md-2">%filled_select%</div>
-      <div class="form-group">
+    </div>
-        <div class="input-group">
+    <div class="row">
-          <input class="form-control" type="text" id="end_time" name="end_time" size="5" pattern="^\d{1,2}:\d{2}$" placeholder="HH:MM" maxlength="5" value="%end_time%">
+        <div class="col-md-6">
-          <div class="input-group-btn">
+            <div>%task_notice%</div>
-            <button class="btn btn-default" title="Now" type="button" onclick="set_to_now('end');">
+            <input class="btn btn-primary" type="submit" style="width: 75%; margin-bottom: 20px" value="%filter%">
-              <span class="glyphicon glyphicon-time"></span>
-            </button>
-          </div>
         </div>
-      </div>
     </div>
-    <div class="col-md-2">%room_select%</div>
-    <div class="col-md-2">%type_select%</div>
-    <div class="col-md-2">%filled_select%</div>
-  </div>
-	<div class="row">
-		<div class="col-md-6">
-  		<div>%task_notice%</div>
-  		<input class="btn btn-primary" type="submit" style="width: 75%; margin-bottom: 20px" value="%filter%">
-		</div>
-	</div>
 </form>
 %shifts_table% %ical_text%

test/model/LogEntriesModelTest.php

@@ -14,8 +14,8 @@ class LogEntriesModelTest extends \PHPUnit_Framework_TestCase
         $count = count(LogEntries());
         $this->assertNotFalse(LogEntry_create('test', 'test_LogEntry_create'));
 
-    // There should be one more log entry now
+        // There should be one more log entry now
-    $this->assertEquals(count(LogEntries()), $count + 1);
+        $this->assertEquals(count(LogEntries()), $count + 1);
     }
 
     public function test_LogEntries_clear_all()
@@ -26,11 +26,11 @@ class LogEntriesModelTest extends \PHPUnit_Framework_TestCase
         $this->assertEquals(count(LogEntries()), 0);
     }
 
-  /**
+    /**
-   * @after
+     * @after
-   */
+     */
-  public function teardown()
+    public function teardown()
-  {
+    {
-      LogEntries_clear_all();
+        LogEntries_clear_all();
-  }
+    }
 }

test/model/RoomModelTest.php

@@ -21,16 +21,16 @@ class RoomModelTest extends \PHPUnit_Framework_TestCase
         $this->assertNotNull($room);
         $this->assertEquals($room['Name'], 'test');
 
-        $this->assertNull(Room(- 1));
+        $this->assertNull(Room(-1));
     }
 
-  /**
+    /**
-   * @after
+     * @after
-   */
+     */
-  public function teardown()
+    public function teardown()
-  {
+    {
-      if ($this->room_id != null) {
+        if ($this->room_id != null) {
-          Room_delete($this->room_id);
+            Room_delete($this->room_id);
-      }
+        }
-  }
+    }
 }

themes/base.less

@@ -11,14 +11,14 @@ body {
 }
 
 .first {
-	margin-top: 30px;
+  margin-top: 30px;
 }
 
 .text-big {
-	display: block;
+  display: block;
-	font-size: 30px;
+  font-size: 30px;
-	line-height: 30px;
+  line-height: 30px;
-	margin: 0px;
+  margin: 0px;
 }
 
 .panel-primary .panel-heading a {
@@ -52,24 +52,24 @@ body {
   align-itmes: stretch;
   width: 100%;
 
-	.lane {
+  .lane {
-	  background: @table-bg-accent;
+    background: @table-bg-accent;
-	  flex-grow: 1;
+    flex-grow: 1;
-	  min-width: 280px;
+    min-width: 280px;
-	  width: 280px;
+    width: 280px;
-	  flex-shrink: 1;
+    flex-shrink: 1;
-	  
+
-		.header {
+    .header {
-		  background: @panel-bg;
+      background: @panel-bg;
-		  border-bottom: 1px solid @table-border-color;
+      border-bottom: 1px solid @table-border-color;
-		  height: 30px;
+      height: 30px;
-		  padding: 5px 5px 5px 16px;
+      padding: 5px 5px 5px 16px;
-		}
+    }
-  
+
-	  .tick {
+    .tick {
-	    height: 30px;
+      height: 30px;
-	    border-top: 1px solid darken(@table-bg-accent, 2%);
+      border-top: 1px solid darken(@table-bg-accent, 2%);
-	  }
+    }
 
     .tick.hour {
       border-top: 2px solid @table-border-color;
@@ -82,20 +82,20 @@ body {
       font-size: 0.9em;
       padding-left: 5px;
     }
-	}
+  }
 
-	.lane.time {
+  .lane.time {
-	  border-right: 1px solid @table-border-color;
+    border-right: 1px solid @table-border-color;
-	  flex-grow: 0;
+    flex-grow: 0;
-	  min-width: 50px;
+    min-width: 50px;
-	  width: 50px;
+    width: 50px;
-	  flex-shrink: 0;
+    flex-shrink: 0;
-	}
+  }
 
-	.shift {
+  .shift {
-	  margin: 0 5px 5px 0;
+    margin: 0 5px 5px 0;
-	  overflow: hidden;
+    overflow: hidden;
-	}
+  }
 }
 
 .space-top {
@@ -119,22 +119,22 @@ body {
 
 @keyframes pulse {
   0% {
-     transform: rotate(0deg);
+    transform: rotate(0deg);
   }
   10% {
-     transform: rotate(5deg) translateY(-2px);
+    transform: rotate(5deg) translateY(-2px);
   }
   20% {
-     transform: rotate(-5deg);
+    transform: rotate(-5deg);
   }
-    30% {
+  30% {
-     transform: rotate(5deg) translateY(-2px);;
+    transform: rotate(5deg) translateY(-2px);;
   }
-    40% {
+  40% {
-     transform: rotate(-5deg);
+    transform: rotate(-5deg);
   }
-    50% {
+  50% {
-     transform: rotate(0deg) translateY(-2px);
+    transform: rotate(0deg) translateY(-2px);
   }
   75% {
     transform: rotate(0deg) translateY(0px);
@@ -143,22 +143,22 @@ body {
 
 @-webkit-keyframes pulse {
   0% {
-     transform: rotate(0deg);
+    transform: rotate(0deg);
   }
   10% {
-     transform: rotate(5deg) translateY(-2px);
+    transform: rotate(5deg) translateY(-2px);
   }
   20% {
-     transform: rotate(-5deg);
+    transform: rotate(-5deg);
   }
-    30% {
+  30% {
-     transform: rotate(5deg) translateY(-2px);
+    transform: rotate(5deg) translateY(-2px);
   }
-    40% {
+  40% {
-     transform: rotate(-5deg);
+    transform: rotate(-5deg);
   }
-    50% {
+  50% {
-     transform: rotate(0deg) translateY(-2px);
+    transform: rotate(0deg) translateY(-2px);
   }
   75% {
     transform: rotate(0deg) translateY(0px);
@@ -167,22 +167,22 @@ body {
 
 @-moz-keyframes pulse {
   0% {
-     transform: rotate(0deg);
+    transform: rotate(0deg);
   }
   10% {
-     transform: rotate(5deg) translateY(-2px);
+    transform: rotate(5deg) translateY(-2px);
   }
   20% {
-     transform: rotate(-5deg);
+    transform: rotate(-5deg);
   }
-    30% {
+  30% {
-     transform: rotate(5deg) translateY(-2px);
+    transform: rotate(5deg) translateY(-2px);
   }
-    40% {
+  40% {
-     transform: rotate(-5deg);
+    transform: rotate(-5deg);
   }
-    50% {
+  50% {
-     transform: rotate(0deg) translateY(-2px);
+    transform: rotate(0deg) translateY(-2px);
   }
   75% {
     transform: rotate(0deg) translateY(0px);